[08:36] some more words to make the people merge page a bit less scary (to me at least): https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382274 [08:40] tomwardill: LGTM, couple of additional suggestions [08:40] ah, ta [08:40] * tomwardill fixes [08:44] changed and landing [12:46] pappacena: http://lpbuildbot.canonical.com/builders/lp-devel-xenial/builds/1183/steps/shell_9/logs/summary (skipping the transient failure) is yours I think [13:20] tomwardill: There may actually be zero test fallout from fixing getUniqueURL to use .test or similar. None of the matches for domain.com look like they were generated by it [13:20] cjwatson: excellent, I'll do that after I've done this credentials work then [13:21] tomwardill: https://tools.ietf.org/html/rfc2606.html is the canonical reference for this kind of thing if you don't have it already [13:35] cjwatson: how do I create a new distribution in my test instance? [13:45] ah, no matter, did it [13:45] ( /distros/+add for future travellers ) [13:45] Didn't know offhand anyway :) [13:55] tomwardill: Could you request a new build of https://dogfood.paddev.net/~twom/ubuntu/+oci/test-oci-project-1/+recipe/test-oci-recipe-2, and tell me when you've done so so that I can get in quickly and strace it? [13:56] Not sure if this will work but let's see [13:56] on it now [13:56] cjwatson: requested [13:58] Bother, too slow [13:58] I'll make my own version :) [13:58] Better than bothering you all the time [14:00] righto :) [14:01] I think only the API exists on that version to create an OCI Project [14:03] I used the same project [14:03] same OCI project rather [14:03] ah, of course [14:04] * tomwardill tries to work out how to create a DAS for a new distribution [14:11] tomwardill: +addseries, then +addport on that [14:12] wgrant: hmm, that gets me a series/distro page that looks right, but no architectures selectable when I try and create a build from my recipe [14:15] tomwardill: Ah, you might need to set supports_virtualized on the Processor (needs DB hackery), or unset require_virtualized on the recipe [14:15] It's also possible we check presence of a chroot to create the checkboxes, but I forget. [14:19] tomwardill: Well, it's definitely sending correct-looking proxy basic auth. Will need to dig through the proxy rules [14:25] Ah, I think this is just that the staging proxy was out of date with the spec [14:33] tomwardill: https://dogfood.paddev.net/~cjwatson/ubuntu/+oci/test-oci-project-1/+recipe/test-oci-recipe-1/+build/5 [14:34] Worked fine once I upgraded the staging proxy to have https://bazaar.launchpad.net/~canonical-launchpad-branches/canonical-mojo-specs/trunk/revision/284. Production was done a while ago (https://portal.admin.canonical.com/C122738/) [14:43] wwooo! [14:51] well, that's quite exciting [16:01] pappacena: Did you see my message earlier about the buildbot failure? [16:01] uhm, I think I missed it. I'll check buildbot [16:05] Probably a one-liner :) [16:06] It seems so. :-) [16:06] I'll open a MP [16:08] Quick review? https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/382316 [16:11] Well, since it's simple test change, I'll self-approve it. The test is running find on my machine now. [16:12] hah, I was just looking at it pappacena :) [16:13] Sorry, was reviewing another thing of yours :-) [16:13] my laptop is not the fastest to load a page atm [16:13] Self-approving trivial test fixes like that is fine [16:13] tomwardill, cjwatson. Thanks :-) [16:21] cjwatson: bit lost in the ObjectModifiedEvent change, what would be the changed fields on a build for a create() method? [16:39] oh, wait, there's an ObjectCreatedEvent, that seems more like what I'd be after [16:40] or could do ObjectModifiedEvent with field of status [16:40] which hooks better into the rest of the lifecycle [16:41] tomwardill: create should use ObjectCreatedEvent, yes [16:41] Assuming the notified object is the object being created [16:43] cjwatson: as in 'the object that we are notifying a subscriber about'? [16:43] I can't quite parse that sentence [16:58] okay, think I got it [17:02] Right, if you're doing notify(SomeEvent(obj)) and the notification is to the effect that obj was just created, then ObjectCreatedEvent is right [17:05] yeah, that makes sense