| tomwardill | cjwatson: if you get 5 mionutes, can you have a look at https://git.launchpad.net/~twom/launchpad/commit/?id=8215dfdeeafb07ed27722bcf51b93450df6bbd92 and check I've not done a silly before I merge it | 08:29 |
|---|---|---|
| cjwatson | tomwardill: looks exactly right | 09:13 |
| tomwardill | cool, landing that then, the RT for the DB users went in over night | 09:13 |
| tomwardill | s/went in/completed | 09:13 |
| cjwatson | Could anyone review https://code.launchpad.net/~cjwatson/lp-signing/+git/lp-signing/+merge/382413 for me please? | 09:38 |
| cjwatson | Maybe wgrant actually, since it is crypto | 09:38 |
| cjwatson | crypto *and* a cheaty DB change | 09:38 |
| SpecialK|Canon | heh | 09:40 |
| wgrant | I already judged you for the sneaky DB change this morning, don't worry | 09:40 |
| wgrant | I'll look in a bit | 09:41 |
| cjwatson | Thanks | 09:41 |
| tomwardill | landing the push credentials branch | 10:44 |
| tomwardill | and with that, modulo some api/ui bits, we should be able to end-to-end an OCI image into ROCKS | 10:44 |
| * tomwardill finds the rum | 10:45 | |
| cjwatson | \o/ | 10:47 |
| cjwatson | Mainly just Ioana's push rule UI stuff at this point, right? | 10:47 |
| tomwardill | yep, think so | 10:47 |
| tomwardill | I'll start on the API side of that this afternoon/monday | 10:48 |
| tomwardill | okay, with some buildbot poking, both of those branches should be landed | 12:20 |
| pappacena | Anyone available for a quick review to fix a broken test? It's just one line affecting 4 small test cases, but I would like more eyes on it, to make sure I didn't miss anything: https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/382506 | 15:50 |
| tomwardill | pappacena: I'm not familiar with the code, but would altering the factory method to set the BugAttachement owner to be the given bug's owner also work? | 15:53 |
| cjwatson | I'm a bit suspicious of a requirement for the bug attachment owner to be the bug reporter | 15:53 |
| cjwatson | It doesn't seem to totally make sense | 15:53 |
| cjwatson | So I don't think that would be a good factory default | 15:54 |
| cjwatson | Let me look at the test failures ... | 15:54 |
| pappacena | It's failing because it tries to change attachment's title with another user (it used to be allowed, and now it's not)... | 15:55 |
| pappacena | I can just change that specific test to login with bug attachment's owner, I think... | 15:55 |
| cjwatson | pappacena: Instead of this, try changing login_person(self.bug_owner) on line 43 to login_person(self.bug_attachment.owner) | 15:55 |
| cjwatson | I think that would be cleaner | 15:55 |
| cjwatson | pappacena: Oh and also on line 63 | 15:56 |
| pappacena | Yes, that was my second option... :) | 15:56 |
| pappacena | Let me do it | 15:56 |
| cjwatson | (It is unfortunate that the bug reporter is called "owner") | 15:57 |
| pappacena | uhm... actually, changing line 63 doesn't seem to be needed... the test passes today oO | 15:57 |
| cjwatson | Yeah, I'm not sure why | 15:58 |
| cjwatson | Might be worth a brief bit of debugging | 15:58 |
| cjwatson | Oh, I see | 16:01 |
| cjwatson | createToken is on View, not Edit, so ViewBugAttachment applies | 16:01 |
| cjwatson | And the bug "owner" is currently always allowed to view attachments | 16:01 |
| cjwatson | So yeah, I think it's OK to leave 63 alone | 16:01 |
| pappacena | Good. Let me just fix the line 43, them | 16:01 |
| pappacena | n | 16:02 |
| pappacena | Done: https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/382506 | 16:04 |
| cjwatson | r=me | 16:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!