| Chipaca | ₘₒᵢₙ ₘₒᵢₙ | 08:17 |
|---|---|---|
| niemeyer | o/ | 08:18 |
| * Chipaca doing dispatch like https://boingboing.net/2020/04/16/watch-a-plane-gracefully-land.html | 09:03 | |
| Chipaca | grah, fake_script_* depends on $0 being the script and not a symlink to it | 09:19 |
| niemeyer | Symlinks don't work very well on windows | 09:19 |
| niemeyer | With Python, specifically | 09:19 |
| niemeyer | There's code in the interpreter that hides away the symlink name | 09:20 |
| Chipaca | i think windows doesn't have symlinks of non-directories, but i might be wrong | 09:22 |
| Chipaca | need to improve the test suite so it supports non-symlink things | 10:38 |
| Chipaca | but that can be a followup | 10:38 |
| * Chipaca ⇝ runch | 10:59 | |
| niemeyer | Good idea | 10:59 |
| facubatista | Muy buenos días a todos! | 11:17 |
| facubatista | Chipaca, I'm not sure if #221 is ready to review or wip (does github have a way to signal this?) | 11:59 |
| mup_ | PR #221: ops/main.py: support dispatch <Created by chipaca> <https://github.com/canonical/operator/pull/221> | 11:59 |
| facubatista | oh, I've found a "Still in progress? Convert to draft" thing | 12:03 |
| * facubatista -> errands, will be back for the standup | 12:50 | |
| Chipaca | niemeyer: to start using spread, should i reuse the snapd credentials? | 13:08 |
| niemeyer | Chipaca: To play with it you can set it up with your own credentials as you did in snapd.. once this is ready for merging we'll need to set up the repository as well | 13:09 |
| Chipaca | ok | 13:09 |
| * facubatista is back | 13:32 | |
| niemeyer | facubatista, Chipaca: I'll need a few more minutes.. | 14:58 |
| Chipaca | ooh, #232 is nice | 15:36 |
| mup_ | PR #232: ops.testing.Harness actions metadata support. (#231) <Created by Vultaire> <https://github.com/canonical/operator/pull/232> | 15:36 |
| Chipaca | might need changes but as a followup | 15:36 |
| * facubatista -> lunch | 15:37 | |
| niemeyer | Chipaca: Indeed | 15:47 |
| Chipaca | niemeyer: ah, missed your comment, i could fix that as well :) | 15:47 |
| * Chipaca does so | 15:47 | |
| niemeyer | Thanks! | 15:48 |
| Chipaca | bah | 15:49 |
| Chipaca | niemeyer: all the assertEqual in that file seem to be (expected, got) | 15:49 |
| Chipaca | boo | 15:49 |
| Chipaca | no, i lie | 15:49 |
| Chipaca | half of them? | 15:49 |
| Chipaca | grmbl | 15:49 |
| Chipaca | the ones in the odd-numbered tests | 15:50 |
| niemeyer | Chipaca: :P | 15:50 |
| Chipaca | definitely not something to burden this pr with | 15:50 |
| niemeyer | Chipaca: Agreed, as mentioned there | 15:50 |
| Chipaca | niemeyer: yeah, i thought it was just one test or two to change, related to the pr... but no | 15:50 |
| niemeyer | Chipaca: I know for sure that the original tests had expected on right hand side, consistently | 15:50 |
| niemeyer | Chipaca: (because I wrote them.. ;) | 15:51 |
| niemeyer | Debating about the right way would be harder, though :) | 15:51 |
| Chipaca | :-D | 15:51 |
| Chipaca | the docs are very unhelpful | 15:51 |
| Chipaca | assertEqual(first, second) | 15:52 |
| Chipaca | psh | 15:52 |
| Chipaca | anyhoo, i'm going to go buy bread | 15:52 |
| niemeyer | Yeah.. let's just keep expected on right hand side.. | 15:52 |
| niemeyer | I think this is the most common convention for tests in general | 15:52 |
| niemeyer | Including if statements | 15:52 |
| niemeyer | There are certainly variations, but I think it's fair to say the constant tends to be after the variable more often than not | 15:52 |
| * Chipaca nods | 15:53 | |
| Chipaca | i might make a pass to do that change later, if i need the distraction | 15:54 |
| Chipaca | (ie if dispatch gets too gnarly) | 15:54 |
| Chipaca | ok now yes i go out for a bit | 16:02 |
| facubatista | Chipaca, we need to create the project in GH... `charm`? `charm-tool`? | 18:08 |
| facubatista | `charm-cli`? | 18:08 |
| niemeyer | charm-tool sounds like the better of these.. not sure if there's a better option | 19:58 |
| facubatista | niemeyer, I wonder how this collides with *the current* charm tool | 20:03 |
| niemeyer | facubatista: This is the next version of the current tool | 20:03 |
| facubatista | niemeyer, yeap, but where is the old one hosted? shall we have a big sign in the README saying "don't confuse this `charm` with the other `charm`", etc | 20:04 |
| facubatista | I mean, I expect some confusion about both, like I have a bug will not know in which project to open the issue, that kind of detail | 20:06 |
| mup_ | Issue operator#234 opened: Debugger "at" reserved words <Created by facundobatista> <https://github.com/canonical/operator/issues/234> | 20:11 |
| * facubatista eods | 20:31 | |
| facubatista | see you all on Monday | 20:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!