/srv/irclogs.ubuntu.com/2020/04/17/#snappy.txt

mupPR snapd#8513 opened: snap-bootstrap: lock access to sealed keys <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8513>00:06
zygaGood morning05:19
* zyga is tired after working past midnight05:19
mborzeckimorning05:51
zygaHey05:52
zygaMade some more progress last night05:57
zygaBut tired now05:57
zygaI’ll start at around 905:57
mborzeckimvo: zyga: hey06:14
mvomborzecki: good morning06:20
zygaHey mvo06:24
mvohey zyga06:25
zygaHow is bit cacher?06:25
mvozyga: seems to be working, running a real spread run this morning to see if it behaves06:25
zygaCool06:26
zygaI guess we could then return to phased testing, with one build of snapd deb/snap06:26
mvozyga: yes, I think those can be distributed via artifcats06:27
zygaThat would be superb.06:28
mupPR snapd#8510 closed: boot/bootstate20: small changes to bootloaderKernelState20 <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8510>06:32
mupPR snapd#8507 closed: packaging: fix build on Centos8 to support BUILDTAGS <Created by mvo5> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8507>06:40
mborzeckimvo: i'm going to file a bug in rhel about the build tags macro06:50
mborzeckijust upadting my rhel8 vm06:50
mvomborzecki: nice, thank you! fwiw, the git report referenced in the code has what we need06:53
pstolowskimorning07:01
* zyga starts the day07:07
mupPR snapcraft#3047 closed: repos: fix returned strings for install_stage_packages() <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3047>07:13
mborzeckipstolowski: hey07:20
zygamy dbus test passes without hanging for the first time08:08
zygalet me clean it up a little and propose :)08:08
pstolowskimvo: can you grant me edit rights to the doc?08:28
mvopstolowski: please reload, you should have it08:28
mupPR snapd#8514 opened: Extend openvswitch interface to support ovs-appctl <Created by dosaboy> <https://github.com/snapcore/snapd/pull/8514>08:31
pstolowskimvo: ty08:32
mvomborzecki: hey, just fyi - ondra shared some fun initrd building snippet https://git.launchpad.net/~ondrak/ondras-snaps/+git/linux-kernel/tree/snapcraft.yaml?h=ubuntu-focal-qcomlt-uc20#n5008:35
mborzeckimvo: mhm, right, that's what we do too08:36
mvomborzecki: aha, ok08:36
mborzeckiotherwise it's lots of pain08:37
pstolowskipedronis: hey, not sure if you saw my yesterday's finding (pastebin from the evening)? mvo figured out the reason (it's due to how writable is handled) and proposed how to handle it; we discussed it in a HO this morning. i'm sharing this notes with you and we can discuss when you have a moment today08:39
pedronispstolowski: mvo: did you discuss what to do about /etc/cloud, it has the same problem?08:40
mvopedronis: the soution outlined in the gdoc (number c) should apply to all of them equally08:47
pstolowskipedronis: it's defined as synced per https://github.com/snapcore/core18/blob/master/static/etc/system-image/writable-paths#L5408:47
pedronismvo: ok, I'll wait for the doc to be finished08:49
mvopedronis: it's finished, (d) is really a bit of a distraction08:51
mvopedronis: it's super interessting but I'm not sure if it's worth it given that we also need to support uc16/uc1808:51
pedronismvo: c for 16/18 needs initramfs changes there, right?08:52
mvopedronis: correct08:52
mborzeckihuh, whole session froze08:52
pedronismvo: maybe if we need to do changes, we should do the same thing as uc20 and call a hook inside the bases?08:52
pedronisbut upgrades08:53
pedronisthere's probably a way to do that though08:53
pedronisreexec like08:54
mvopedronis: that's a very interessting idea, let me look at the old initramfs code08:54
mvopedronis: I like this, should be totally doable (also in a backward compat way). it's a bit risky as it involves initrd changes but would be nice and clean and more uniform08:55
pedronismvo: notice though that we can't probably remove any synced from core18 writable-paths08:56
pedronisbecause we don't know what people did with ubuntu-image hooks08:57
pedroniswe can/should remove them from core20 though08:57
mvopedronis: +108:58
pedronismvo: there is probably some other wrinkle as well, related to prepare-image08:59
pedronisI'll write some notes in the doc, when I have a moment. Finishing something else atm09:00
mvopedronis: thanks! adding some notes myself too09:00
pedronismvo: ok, yes, one point I wanted to make was indeed iv09:04
pedronismvo: pstolowski: made a couple of comments09:07
mvopedronis: thanks for adding the comment about the fallback!09:07
pstolowskithanks09:08
mupPR snapd#8515 opened: testutil: add NewDBusTestConn <Created by zyga> <https://github.com/snapcore/snapd/pull/8515>09:16
zygaI pushed the test helper alone here09:21
zygaand the tests are in https://github.com/snapcore/snapd/pull/782509:21
mupPR #7825: many: use transient scope for tracking apps and hooks <Security-High> <Created by zyga> <https://github.com/snapcore/snapd/pull/7825>09:21
pstolowskimborzecki: hey, what's the plan with #7414?09:24
mupPR #7414: tests: keep track of installed packages and restore the state after the test <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/7414>09:24
zygaI will write a few more tests to exercise all the interactions09:24
mborzeckipstolowski: probably needs a merge from master and making sure it still works09:24
zygabut now I need a break, my back is killing me09:24
mborzeckineed to run an errand, back in 1.5-2h, hopefully sooner09:26
mupPR snapcraft#3048 opened: V2 dump plugin <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3048>09:38
* zyga is pissed off at go fmt10:24
zygacan we move to non-ancient go fmt10:24
zygait doesn't matter for compiling10:24
zygais anyone in the team still using "go fmt" from 1.6 because they cannot use newer go?10:24
zygaI have to fight my editor to hand-craft restore some alignment10:25
pedronisI made an alias go-fmt that calls the old go fmt from a snap installation fwiw, I'm also happy to discuss how to switch to something newer, but probably after the beta at this point10:30
mupPR snapd#8516 opened: github: format with modern go <Created by zyga> <https://github.com/snapcore/snapd/pull/8516>10:37
mupPR snapd#8516 closed: github: format with modern go <Created by zyga> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8516>10:42
zygapedronis: huh10:43
pedroniszyga: what part of until beta you didn't get?10:43
zygapedronis: I just read you writing that10:43
zygapedronis: and you could have just marked it as blocked or something10:43
zygapedronis: not nice10:43
pedroniszyga: if we don't land it, it will need tending, so I don't see how marking it blocked helps10:47
pedroniszyga: I don't know what people workflows are like, I don't think I want to even discuss that before beta10:47
pstolowskiit seems that jenkins deb is not authenticated in special-home-can-run-classic-snaps, despite adding the key in the test? i saw this test failing on some PRs11:12
mborzeckire11:13
mupPR core-build#59 opened: initramfs: add new handle_writable_defaults() <Created by mvo5> <https://github.com/snapcore/core-build/pull/59>11:19
mvopstolowski: ^- that is probably all we need, the interessting part if of course the next step where we test this :)11:20
mvopstolowski: we can look into this after the standup11:20
mvozyga: fwiw 8508 works, thanks again for your help with that11:21
pstolowskimvo: oh thank you, i didn't expect you to take this! thanks!11:21
mvopstolowski: no worries, it's just a tiny step11:22
* mvo gets some lunch11:22
mvomborzecki: (8505 - your caching idea ftw!)11:22
* mvo really gets lunch11:22
mupPR snapd#8517 opened: tests: temporarily allow unauthenticated jenkins deb <Created by stolowski> <https://github.com/snapcore/snapd/pull/8517>11:47
pstolowski^ a bit scary, perhaps we should disable the test for now..11:48
pedronisso much weirdness12:00
pedronispstolowski: we probably need mvo input on that one12:04
mborzeckicmatsuoka: hi, i seem to be getting a differnt output from lsblk --fs --json than the tests expect12:25
cmatsuokamborzecki: that sounds bad, what test?12:26
mborzeckicmatsuoka: here's the test data vs what i get from the tool https://paste.ubuntu.com/p/qSCBCC44zF/12:27
mborzeckicmatsuoka: the parsing only handles blockdevice.[i] elements, does not descend into blockdevice.[i].children[j]12:28
cmatsuokamborzecki: I think the test output is simulating the output when lsblk is called directly on the partition and not the disk12:28
mborzeckiaah w812:28
mborzeckiright12:28
cmatsuokadoes it make sense?12:29
mborzeckiyeah, it does now12:29
mborzeckimeh, more mocking in tests :/12:29
cmatsuokaah ok good12:29
ijohnsonmorning folks12:53
cachiopstolowski, hei, there is a beg assigned to you, lp:187211512:54
cachiopstolowski, did you see that? is there a priority for that?12:55
cmatsuokahey ijohnson12:57
ijohnsonhey cmatsuoka o/12:57
cmatsuokacachio: I had problems with the tpm branches yesterday, will try the sb test again after the SU12:59
cachiocmatsuoka, sure12:59
pstolowskicachio: no, i didn't see that, thanks. i guess zyga assigned it to me because of my other rsyslog work, need to check12:59
cachiocmatsuoka, ping me if you need any help12:59
ijohnson ugggh pulseaudio13:01
mupBug #1873452 opened: 'snap install' | "INFO Waiting for restart..." <Snappy:New> <https://launchpad.net/bugs/1873452>13:01
roadmrhi diddledan are you around?13:24
diddledanello13:24
roadmrdiddledan: I got a request from the mycroft devs to have the snap transferred to them. Are you OK with that?13:25
diddledanyup13:25
roadmrsweet, ok thanks, all I needed was confirmation :) I'll take it from here13:25
roadmrhappy Friday13:25
diddledancoolbeans :-)13:25
mupPR snapd#8517 closed: tests: temporarily allow unauthenticated jenkins deb <Created by stolowski> <Closed by stolowski> <https://github.com/snapcore/snapd/pull/8517>13:28
mupPR snapd#8518 opened: tests: disable special-home-can-run-classic-snaps due to jenkins repo issue <Created by stolowski> <https://github.com/snapcore/snapd/pull/8518>13:31
mupPR snapcraft#3046 closed: plugins: introduce v2.GoPlugin <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3046>13:41
pedronisijohnson: to be clear I'm not sure if there are different scenarios were we need that divergent snap, we don't with the current tests14:01
ijohnsonI don't think we will need it, I'm not sure what scenarios we could end up with that, where the kernel the bootloader boots is not the one we want as the "normal" kernel on the bootloader after MarkSuccessful runs14:02
pedronisijohnson: that sounds right14:03
pedroniswe still want to check before and after though14:03
pedronisjust for the same value, to be clear14:03
ijohnsonwhat do you mean check before and after?14:03
ijohnsonbefore and after the MarkSuccessful ?14:03
pedronisyes14:04
pedronisI suppose14:04
ijohnsonhmm ok I can make that work14:04
pedronisijohnson: I thougth, it's an easy change, we are probably talk cross-purpose14:05
mupPR snapcraft#3049 opened: build providers: rename default sources <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3049>14:11
roadmrjdstrand: hi, are you around?14:26
ackkhi, I'm having an issue. my lxd snap suddenly broke, looking at /snap/lxd there's no snap dir there, just a broken "current" link14:46
jdstrandroadmr: I'm here today but stepping away for a little bit. please ask and I'll answer when I get back14:49
ackkand no lxd snap file in /var/lib/snapd/snaps14:49
roadmrjdstrand: remember https://dashboard.snapcraft.io/snaps/inkscape/feedback/ timing out? it's because the page lists thousands of items. Are you OK with paginating that by e.g. 100 items at a time?14:50
mupPR snapcraft#3050 opened: meta: split up package repository sanity checks <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3050>14:50
jdstrandroadmr: I can answer that now14:51
jdstrandroadmr: yes. please yes14:51
jdstrand:)14:51
roadmr\o/ hehe ok jdstrand we'll do it that way then14:51
jdstrandzyga: you have mail :)14:52
* jdstrand steps away14:52
ackkis there a way I can make snapd happy and mount the lxd snap again?14:54
popeyerror: cannot communicate with server: timeout exceeded while waiting for response15:00
popeyMy machine ^. Can't install or update anything.15:01
mupPR snapcraft#3051 opened: project: introduce 'keys' for project assets <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3051>15:12
pstolowskipopey: journalctl -u snapd15:15
pstolowski?15:15
mborzeckiijohnson: pushed the changes to https://github.com/snapcore/snapd/pull/8487 and marked it as ready for review15:16
mupPR #8487: [RFC] gadget, cmd/snap-bootstrap: hack some things into place to get rpi4 semi-working <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8487>15:16
popeyhttps://paste.ubuntu.com/p/mDrRqBJNrZ/  pstolowski15:16
ijohnsonthanks mborzecki15:16
ijohnsonI'll give it a try on my pi today15:16
ijohnsonpopey: can you still run snaps?15:17
pstolowskipopey: ok, not much interesting there, anything else in the logs?15:18
popeyyes, i can run snaps15:18
popeyi just can't refresh, or it does, but i get that error15:19
pstolowskiapparently deamon is not running15:20
stgrabermvo, zyga: https://discuss.linuxcontainers.org/t/unable-to-start-snap-lxd-on-debian-10/7456/17?u=stgraber15:20
stgraberthis feels like pretty crap experience :)15:20
mvostgraber: in a meeting right now, but I though we did test lxd on debian :(15:20
zygamvo: reexec15:21
zygamvo: backports15:21
zygastgraber: can you add assumes to lxd?15:21
zygastgraber: and at least put a FAQ that you need to snap install core15:21
zygait will break in a nicer way IMO15:21
zygaunless we update backports we have few optiosn15:22
zyga*options15:22
zygastgraber: I totally agree about the UX15:22
pstolowskipopey: 'snap changes' fails the same I presume?15:22
mvoyeah, assumes should fix things15:22
stgraberzyga: where is the doc on assumes?15:22
popeypstolowski snap changes returns immediately15:22
zygahttps://snapcraft.io/docs/snapcraft-top-level-metadata#heading--assumes15:23
zygastgraber: ^ add the assumess snapdX.YY version that meets your expectations15:23
stgraberah yeah, just found it too15:23
stgraberzyga: so what's the minimum version that's known to behave?15:23
zygastgraber: perhaps we could patch snapd in debian 10 to say something like15:24
mupPR snapcraft#3049 closed: build providers: rename default sources <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3049>15:24
zygastgraber: anyone that you pick as right for you15:24
zygastgraber: it depends on a snap15:24
stgraberzyga: well, in this case the issue is apparently the snapd didn't connect any of the interfaces, so I have no idea when you fixed that :)15:24
pstolowskipopey: anything else in the logs? a crash/panic?15:24
zygastgraber: perhaps we could patch debian 10 snapd to say "you need snapd X.YY, you may try to get it from backports <URL> or by installing core"15:24
stgraberzyga: we purposefuly don't use anything new/fancy in the snap15:24
popeypstolowski not that I have seen :(15:24
zygastgraber: put a version that you tested as ok and that's enough15:25
zygastgraber: it's fine to depend on new snapd15:25
pstolowskipopey: and what does 'systemctl status snapd.service snapd.socket' say?15:25
zygapstolowski, popey: this is assertion check being >> than snap client timeout15:25
zygaIIRC we ran into it before and debugged it to that15:25
zygabut I could be wrong15:25
stgraberzyga: looks like 2.39 and higher based on the versions our CI sees on the distros we test15:29
popeypstolowski https://paste.ubuntu.com/p/zPcXzjtpNJ/15:31
pstolowskizyga: can you elaborate on the assertion check, what do you mean?15:34
zygapstolowski: that's for stgraber15:34
zygapstolowski: it's unrelated to the issue you are looking at for popey15:34
zygaI can explain if you want to, just wanted to make this clear15:34
pstolowskiack15:35
pstolowskipopey: and 'snap --version' ?15:35
popeyhttps://paste.ubuntu.com/p/zNtPDNF8ns/15:35
zygapstolowski: to reproduce install 300 snaps15:36
zygaand refresh15:36
popeyI have 113 installed15:36
zygapstolowski: if I'm correct your work on assertion refreshes will help immensly15:36
zygapstolowski: but would be good to undestand this in depth, perhaps there are other inefficiences15:36
zyga(each from the store, not local)15:37
zygahmm, we could actually use15:37
pstolowskizyga: i'm not working on assertion refreshes afaik ;)15:37
zygatest-snapd-manysnap-$(seq...)15:37
zygain the store15:37
zygapstolowski: oh, sorry, I though that was in the new store API work15:37
zygaanyway15:37
pstolowskino i was new search v2 api15:37
pstolowski*it*15:38
zygaI see15:38
mupPR snapcraft#3052 opened: build providers: wait for systemd and better nameserver setup on LXD <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3052>15:39
ijohnsonzyga: I thought pedronis was working on bulk assertion refreshes15:39
pstolowskiyes15:40
zygaijohnson: yeah, I must have confused the store work with "anything related to store"15:40
ijohnsonis this issue related to the internet? must be the store15:40
ijohnsonand that folks is how you do investigative work15:40
zygaijohnson: IIRC just that we cannot grab the lock15:41
zygaijohnson: needed to produce most "snap foo" responses15:41
* ijohnson was joking15:41
zygaah :)15:41
zygasorry15:41
ijohnsonI have no idea honestly what this issue is15:41
* zyga should really EOD15:41
zygaI've reviewed half of James' user session services PR15:42
zygayeah, let's rest15:42
mupPR snapd#8518 closed: tests: disable special-home-can-run-classic-snaps due to jenkins repo issue <Simple 😃> <⚠ Critical> <Created by stolowski> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8518>15:42
ijohnsonalright master should be at least not red due to jenkins again15:42
ijohnsonpstolowski: you wanna quick open up the PR re-enabling the jenkins test?15:43
ijohnsonif you want I can do it too15:43
pstolowskipopey: does ps aux|grep apparmor show anything?15:43
popeyno15:44
pstolowskiijohnson: please do, thanks, trying to figure out popey's issue15:44
ijohnsonack15:44
pstolowskipopey: how about 'sudo snap debug state /var/lib/snapd/state.json' ?15:48
popey(that looks like snap changes)?15:48
popeyhttps://paste.ubuntu.com/p/wHXFrdQhJ2/15:48
pstolowskipopey: yes, but it doesn't talk to the daemon15:49
popeyahh15:50
pstolowskipopey: does 'snap list' work?15:54
popeyyes15:55
pstolowskipopey: ah, so snapd does respond, i got confused by that first communication error. perhaps store is acting up? how about 'snap find ...'?15:58
popeysnap find works15:58
popeybah, now I'm not getting the error when I refresh!15:58
zygapstolowski: my theory is wrong, based on the debug output15:58
pstolowskipopey: i bet that was a store problem, maybe of limited scope (i was testing with same snapd as you have without issues)16:00
pstolowskipopey: there was no sign of snapd errors/malfunction in the info you got me so far16:01
ijohnsonpopey: how performant is this machine with 116 snaps? and also what kind of disk is it on?16:01
ijohnsonpopey: given that it keeps finding bugs, maybe turning on debug logging for snapd would be a good idea, even maybe http debug logging too16:02
popeyit's an ThinkPad T450, i7, 32GB RAM16:02
popeybrb, meeting16:02
ijohnsonpedronis: if you have time yet today, 8511 is updated with your comments16:02
ijohnsonah actually I forgot one thing, let me push that quickly16:03
pstolowskieow, cu all!16:10
mupPR snapd#8409 closed: snap-bootstrap: seal and unseal encryption key using tpm <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8409>16:15
cmatsuoka\o/16:16
pedronisijohnson: yes, I'll try to wrap up a couple of things and some reviews after dinner16:17
ijohnsonthanks pedronis16:17
ijohnsoncongrats cmatsuoka !16:17
cmatsuokaijohnson: many fixes still to come16:17
pedroniscmatsuoka: can you merge master into your locking keys PRs now16:18
cmatsuokapedronis: doing that right now16:19
pedronisthx16:19
cmatsuokacachio: ok, ready to run the sb/tpm tests16:34
cachionice16:34
cmatsuokacachio: I'm using your spread, which back-end should I use?16:34
mupPR snapcraft#3051 closed: project: introduce 'keys' for project assets <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3051>16:36
cmatsuokacachio: and should I run on master or tests-extend-uc20-nested-suite?16:36
cachiocmatsuoka, you should use the google-tpm I sent yesterday16:37
cachiowhich test do you want to run?16:38
cmatsuokauc20-create-partitions-encrypted16:38
cachioyou should add this new tpm backend to the spread.yaml16:38
cmatsuokaah yes, I remember now, let's do this16:38
cachioand run spread -debug google-tpm:ubuntu-20.04-64:tests/main/uc20-create-partitions-encrypted16:39
cachiocmatsuoka, when you run this please tell me so I can monitor the vm16:39
mupPR snapcraft#3050 closed: meta: split up package repository sanity checks <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3050>16:48
mupPR snapcraft#3053 opened: snap_packaging: quote final LD_LIBRARY_PATH <Created by Saviq> <https://github.com/snapcore/snapcraft/pull/3053>16:57
mupPR snapcraft#3054 opened: Add note about docker snap <Created by sixcorners> <https://github.com/snapcore/snapcraft/pull/3054>17:03
mupPR snapcraft#3048 closed: V2 dump plugin <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3048>17:06
mupPR snapcraft#3052 closed: build providers: wait for systemd and better nameserver setup on LXD <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3052>17:27
mupPR snapcraft#3055 opened: repo: add identifiers for gpg keys and sources <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3055>17:39
bdxhello18:31
bdxI'm trying to release a snap that uses classic confinement, and need an approval to release it to the snap store. I have started a discourse post here https://forum.snapcraft.io/t/classic-confinement-request-for-nhc-snap18:32
bdxis there someone from the reviewers team available to possibly give some feedback ^?18:33
bdxthanks!18:33
mupPR snapcraft#3056 opened: remote-build: package up local sources with source-type 'git' <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3056>18:39
mupPR snapd#8325 closed: snap-bootstrap: copy auth data from real ubuntu-data in recovery mode <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8325>18:41
mupPR snapd#8514 closed: interfaces/openvswitch: support use of ovs-appctl <Created by dosaboy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8514>18:42
mupPR snapcraft#3057 opened: repo: format $SNAPCRAFT_APT_RELEASE instead of ${release} for suites <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3057>18:42
mupPR snapcraft#3055 closed: repo: add identifiers for gpg keys and sources <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3055>19:00
pedronisijohnson: I reviewed #851119:24
mupPR #8511: tests/boot: refactor to make it easier for new bootloaderKernelState20 impl <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8511>19:24
ijohnsonthanks pedronis19:31
ijohnsonHave a good weekend!19:31
* ijohnson continues fighting the pi 19:32
=== Wouter01005 is now known as Wouter0100
mborzeckiijohnson: hey, saw your comment, pushed a patch19:48
ijohnsonhey mborzecki thanks let me look now19:48
ijohnsonI locally had a simple patch to work around it, but didn't push anything cause I wasn't sure what the right way to do it is19:49
mborzeckiijohnson: missed that ensure layout compatiblity check, but it shoudl be ok now19:49
ijohnsonah yeah I think your check is better, I forgot that the gadgetLayout has Schema on it to check that it's mbr19:49
mborzeckiijohnson: i mean, there's nothign we can check there if there's no way store the name on disk :P so well19:50
ijohnsontrue19:50
mborzeckias long as we don't erase ubuntu-seed things should be ok xD19:51
mborzeckiwhat reminds me i need to discuss gadget updates in uc20 on monday19:51
mborzeckiijohnson: anyways, thanks for catching that! hope it works now19:53
mupPR snapd#8511 closed: tests/boot: refactor to make it easier for new bootloaderKernelState20 impl <Test Robustness> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8511>19:54
mupPR snapcraft#3058 opened: package-repositories: make 'name' optional <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3058>19:54
mupPR snapd#8423 closed: tests: uc20 nested suite part II <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8423>20:30
mupPR pc-amd64-gadget#42 closed: Hide menu by default <Created by xnox> <Merged by xnox> <https://github.com/snapcore/pc-amd64-gadget/pull/42>21:29
mupIssue pc-amd64-gadget#41 closed: Hide the menu by default <Created by xnox> <Closed by xnox> <https://github.com/snapcore/pc-amd64-gadget/issue/41>21:38
mupPR pc-amd64-gadget#37 closed: Drop duplicate grub.cfg-* <Created by xnox> <Merged by xnox> <https://github.com/snapcore/pc-amd64-gadget/pull/37>21:38
mupPR core20#43 opened: extra-packages: add dbus-user-session for user-session dbus <Created by xnox> <https://github.com/snapcore/core20/pull/43>21:45
mupPR snapd#8519 opened: tests/special-home-can-run-classic-snaps: re-enable <Test Robustness> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8519>22:09
mupPR core20#44 opened: travis: use bionic <Created by xnox> <https://github.com/snapcore/core20/pull/44>22:27
mupPR core20#44 closed: travis: use bionic <Created by xnox> <Merged by xnox> <https://github.com/snapcore/core20/pull/44>22:31
mupPR core20#45 opened: Add arches <Created by xnox> <https://github.com/snapcore/core20/pull/45>22:33

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!