| tomwardill | first attempt at API for OCI Registry Credentials: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382651 | 08:45 |
|---|---|---|
| SpecialK|Canon | cjwatson pappacena: Nice work both; very much agree on holding off going live unti lpost-release! | 08:47 |
| * SpecialK|Canon moves that l a bit to the left | 08:47 | |
| cjwatson | https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/382484 quick trivial UI fix? | 09:25 |
| tomwardill | +1 | 09:28 |
| cjwatson | And https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/381912 is a simple code tidy-up | 09:29 |
| cjwatson | Thanks | 09:29 |
| tomwardill | also +1 | 09:30 |
| tomwardill | I did get very confused by the title of the first one | 09:32 |
| tomwardill | 'but why are we building images again?' | 09:32 |
| cjwatson | ah, sorry :) | 09:32 |
| cjwatson | tomwardill: and thanks, I'll look over oci-registry-credentials-api | 09:52 |
| tomwardill | ta | 09:52 |
| * tomwardill -> lunch | 11:01 | |
| cjwatson | tomwardill: All right, you have a pile of comments on https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382651 now | 11:29 |
| cjwatson | ilasc: ^- You probably want to look over those as well, since they have some bearing on your UI work | 11:29 |
| cjwatson | And this reminds me that I need to get the production config ticket in to generate a registry credential storage key pair | 11:30 |
| tomwardill | sigh, that thing where pass-by-reference catches you out, again | 13:04 |
| tomwardill | cjwatson, ilasc: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382674 | 13:35 |
| ilasc | thanks tomwardill | 13:35 |
| ilasc | looking now | 13:35 |
| tomwardill | now without me copying and pasting cjwatson's comment into the middle of it :) | 13:35 |
| tomwardill | if this push ever succeeds | 13:36 |
| ilasc | :) | 13:45 |
| ilasc | +1 | 13:45 |
| cjwatson | tomwardill: r=me with a few comments | 14:12 |
| tomwardill | ta | 14:13 |
| tomwardill | after a brief fight with tests, landing that branch | 14:54 |
| cjwatson | Good stuff | 14:58 |
| cjwatson | Could anyone have a look over https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/381234 (built-using-model)? It's had an overall direction review from William, but it needs more detailed code review. You may need to look further up the stack (anything on https://code.launchpad.net/~cjwatson/launchpad/+activereviews that mentions "built-using") for context. | 15:00 |
| cjwatson | I'm still working on the top couple of layers of that, but I think the lowest-level model branch and probably also built-using-ui is pretty solid now. | 15:01 |
| * tomwardill will have a look in a mo | 15:06 | |
| tomwardill | cjwatson: having now implemented that branch, I'm unsure how it helps... as `getCredentials` will still attempt a decrypt, so it doesn't help in the OCIPushRule API | 16:10 |
| tomwardill | other than accessing _credentials directly | 16:10 |
| cjwatson | tomwardill: Well, we don't need to export getCredentials. We could have a username accessor property that just looks at the unencrypted bit | 16:11 |
| tomwardill | ah, yes, that makes sense | 16:12 |
| * tomwardill goes back to arguing with interface declarations | 16:12 | |
| tomwardill | cjwatson: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382651 is up again | 16:46 |
| cjwatson | Ack | 16:47 |
| cjwatson | tomwardill: r=me with a few tweaks | 17:01 |
| tomwardill | ta, looking now | 17:02 |
| tomwardill | fixed, landing | 17:11 |
| * tomwardill -> EOD, I'll pop back to poke buildbot if required | 17:16 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!