[08:45] first attempt at API for OCI Registry Credentials: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382651 [08:47] cjwatson pappacena: Nice work both; very much agree on holding off going live unti lpost-release! [08:47] * SpecialK|Canon moves that l a bit to the left [09:25] https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/382484 quick trivial UI fix? [09:28] +1 [09:29] And https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/381912 is a simple code tidy-up [09:29] Thanks [09:30] also +1 [09:32] I did get very confused by the title of the first one [09:32] 'but why are we building images again?' [09:32] ah, sorry :) [09:52] tomwardill: and thanks, I'll look over oci-registry-credentials-api [09:52] ta [11:01] * tomwardill -> lunch [11:29] tomwardill: All right, you have a pile of comments on https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382651 now [11:29] ilasc: ^- You probably want to look over those as well, since they have some bearing on your UI work [11:30] And this reminds me that I need to get the production config ticket in to generate a registry credential storage key pair [13:04] sigh, that thing where pass-by-reference catches you out, again [13:35] cjwatson, ilasc: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382674 [13:35] thanks tomwardill [13:35] looking now [13:35] now without me copying and pasting cjwatson's comment into the middle of it :) [13:36] if this push ever succeeds [13:45] :) [13:45] +1 [14:12] tomwardill: r=me with a few comments [14:13] ta [14:54] after a brief fight with tests, landing that branch [14:58] Good stuff [15:00] Could anyone have a look over https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/381234 (built-using-model)? It's had an overall direction review from William, but it needs more detailed code review. You may need to look further up the stack (anything on https://code.launchpad.net/~cjwatson/launchpad/+activereviews that mentions "built-using") for context. [15:01] I'm still working on the top couple of layers of that, but I think the lowest-level model branch and probably also built-using-ui is pretty solid now. [15:06] * tomwardill will have a look in a mo [16:10] cjwatson: having now implemented that branch, I'm unsure how it helps... as `getCredentials` will still attempt a decrypt, so it doesn't help in the OCIPushRule API [16:10] other than accessing _credentials directly [16:11] tomwardill: Well, we don't need to export getCredentials. We could have a username accessor property that just looks at the unencrypted bit [16:12] ah, yes, that makes sense [16:12] * tomwardill goes back to arguing with interface declarations [16:46] cjwatson: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/382651 is up again [16:47] Ack [17:01] tomwardill: r=me with a few tweaks [17:02] ta, looking now [17:11] fixed, landing [17:16] * tomwardill -> EOD, I'll pop back to poke buildbot if required