/srv/irclogs.ubuntu.com/2020/04/22/#snappy.txt

mupPR snapd#8539 opened: tests: update encrypted partition creation test <UC20> <ā›” Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8539>00:17
=== diddledan9 is now known as diddledan
mborzeckimorning05:52
zygaGood morning06:10
zygaChilly morning06:11
mborzeckizyga: hey, yeah only 6C here06:14
zygaCurrently outside in shorts06:14
mborzeckihahah06:16
zygaIs everything red today?06:18
mborzeckizyga: idk, looking at uc20 prs only atm06:22
mborzeckithose are red more often ;) so nothing out of the ordinary06:23
zygaIā€™m feeling pretty bad today06:37
zygaHad some heart issue all evening06:37
zygaHope it passes :/06:37
mvozyga: hey, good morning!06:39
zygaGood morning06:39
zyga(It passed... away, said the narrator)06:39
zygaThere are git CVEs06:43
zygaUpdate your systems!06:43
zygaOur cloud stuff is up to date06:44
mupPR snapd#8538 closed: overlord: have a variant of Mock that can take a state.State <Simple šŸ˜ƒ> <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8538>06:44
mupPR snapd#8535 closed: daemon: fix error message from `snap remove-user foo` on classic <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8535>06:46
mupPR snapd#8512 closed: boot/bootstate20: add EnvRefExtractedKernelBootloader bootstate20 implementation <UC20> <āš  Critical> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8512>06:56
pstolowskimorning06:59
mvogood morning pstolowski07:01
mborzeckipstolowski: mvo: hey07:02
mvomborzecki: it looks like you are almost happy with 7825? I'm inclinded to merge, the remaining issues looks like cosmetics, or am I missing something in the 4323431 comments in there :) ?07:02
mvomborzecki: and good morning!07:05
mborzeckimvo: left some questions for zyga there07:10
pstolowskimvo: one last remark about initramfs PR and +107:10
pedronismborzecki: hi, now that the initramfs changes were incorporated should we try #8464 again?07:16
mupPR #8464: cmd/snap-boostrap, boot: use /run/mnt/data instead of ubuntu-data <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8464>07:16
mborzeckipedronis: yes07:16
mborzeckipedronis: i'm fixinig one more thing in #8530, installbootConfig for uboot does not look at options07:17
mupPR #8530:  boot: enable makeBootable20RunMode for EnvRefExtractedKernel bootloaders <UC20> <āš  Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8530>07:17
mborzeckiand a missing test probably too07:17
pedronisah07:17
pedronismborzecki: maybe makebootable tests should check for that too07:21
mborzeckipedronis: heh, so there's a unit test, but checks the wrong location, looking at ian's plan the agreement was to have $systemseedrootdir/uboot.env07:27
pedronisyes07:28
pedronismborzecki: we have code in grub, I suppose uboot needs similar07:29
mborzeckipedronis: fixed that already, pushing in a bit07:29
pedronismaybe we can reorg a bit the code, not sure, maybe later07:30
zygamborzecki, mvo: yeah, iterating07:41
mvopstolowski: woah, your hunch was right, one more bug found and tests improved, shell is hard07:44
pstolowskimvo: oh wow, i didn't expect a bug...07:44
pstolowskishell is terrible07:44
mvopstolowski: [ -e ... ] will break on broken symlinks :)07:44
mvopstolowski: or your idea of adding a broken symlink uncovred it07:45
mvopstolowski: I doubt it would actually have hit us for real as the broken-symlink would have to be in the toplevel dir but a bug is a bug07:45
* mvo hugs pstolowski 07:45
mborzeckimvo: we should write in tcl instead :P07:50
mborzeckipedronis: pushed a fix to #853007:51
mupPR #8530:  boot: enable makeBootable20RunMode for EnvRefExtractedKernel bootloaders <UC20> <āš  Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8530>07:52
pedronismborzecki: looks good to me07:55
pstolowskimvo: right, -e, drat07:56
mvomborzecki: *cough* tcl *cough*07:58
pstolowskimvo: i reckon it just became harder to convince you to do initrd version check in shell vs go :}07:59
mvopstolowski: lol08:01
zygajust use C, at least you will get *excellent* reviews from jamie :)08:02
zygamvo: one of the workers in canonistack was lost due to btrfs corruption due to disk space exhaustion, remaining workers are moved to a new volume that has more space09:18
mborzeckizyga: haha it's still a thing?09:21
mvozyga: in a meeting, will get back to you09:21
mborzeckithought this was fixed in btrfs a while ago09:22
mborzeckibrb, quick errand09:22
mborzeckire09:41
mupPR snapd#8530 closed:  boot: enable makeBootable20RunMode for EnvRefExtractedKernel bootloaders <UC20> <āš  Critical> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8530>10:03
mupPR snapd#8540 opened: o/snapstate: tweak "waiting for restart" message <Simple šŸ˜ƒ> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8540>10:16
zygamborzecki: eh, go-dbus spawns dbus-launch and leaves it running10:43
zygamborzecki: and they pile up10:43
mborzeckiomg10:43
zygamborzecki: what a terrible idea10:43
zygamborzecki: :|10:43
zygamborzecki: anyway, those -failure tests are sure fun10:43
zygamborzecki: I found one more funny bugg10:43
zygamborzecki: but more in how we use it10:43
mupPR snapd#8541 opened: devicestate: add support for cloufg.cfg.d config from the gadget <Created by mvo5> <https://github.com/snapcore/snapd/pull/8541>11:02
zygaok, I have a good understanding of what I need to write for the test11:37
zygaI'll take a break to stretch and think about how to write that in one nice test11:37
zygamborzecki: I still have to tackle the leaking dbus-launch, it's such a shame go-dbus doesn't allow one to configure this11:38
mborzeckizyga: there's Connect where you can pass address11:39
mborzeckizyga: so we could inspect the relevant env/files ourselves11:39
zygamborzecki: yes I know11:39
zygathat's unavoidable11:39
mborzeckizyga: that's probably all we can do :/11:39
zygajust look at the amount of code that is behind SessionBus()11:39
zygauntil Connect11:39
zygabut yeah, I know11:39
mupPR snapd#8542 opened: boot: store model model and grade information in modeenv <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8542>11:41
mupPR snapd#8543 opened: overlord/devicestate: preserve the current model inside ubuntu-boot <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8543>11:43
mborzeckipedronis_: ^^11:44
=== pedronis_ is now known as pedronis
pedronismborzecki: reviewed11:46
pedronismborzecki: unit test failure though11:48
mborzeckihmmm11:48
mborzeckiheh, yeah, splitting patches is fun11:49
mborzeckiw8, actually, there's patches in master that broke the unit tests /o\11:53
pedronismborzecki: can you remind me what mounts boot data etc at install time?11:55
mborzeckipedronis: we ask snap-bootstrap to do it by passing --mount11:55
mborzecki(along with the rest of create-partitions parameters)11:56
pedronisah, I was looked at the wrong point11:56
mborzeckipedronis: partitions are mounted at /run/mnt/<fs-label>11:56
pedronismborzecki: that's interesting, so we override the original tmpfs ubuntu-data ?12:13
pedronismborzecki: we probably really need your PR (for sanity)12:13
mupPR snapcraft#3075 opened: Edge staged <do-not-merge> <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3075>12:18
=== Eighth_Doctor is now known as Conan_Kudo
=== Conan_Kudo is now known as Eighth_Doctor
=== Eighth_Doctor is now known as Conan_Kudo
=== Conan_Kudo is now known as Eighth_Doctor
=== Eighth_Doctor is now known as Conan_Kudo
pedronismborzecki: some comment son #954312:30
=== Conan_Kudo is now known as Eighth_Doctor
pedronisheh, #854312:30
mupPR #8543: overlord/devicestate: preserve the current model inside ubuntu-boot <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8543>12:30
jdstrandxnox: hey, I'm trying to use http://cdimage.ubuntu.com/ubuntu-core/20/edge/20200421/ubuntu-core-20-amd64.img.xz in a vm ,13:14
jdstrandxnox: but it isn't working right. 'invalid signature'. is there documenation on how to use it?13:14
jdstrandmvo: ^ (I'm trying to do this to test the firewall-control interface (it needs some updates)13:17
jdstrandmaybe 20200421 was busted13:20
* jdstrand tries 2020042213:20
mvojdstrand: in a meeting right now, can get back to you13:24
jdstrandno, same issue13:25
jdstrandmvo: thanks!13:25
mvojdstrand: kvm -m 1500 -snapshot -bios /usr/share/OVMF/OVMF_CODE.fd -drive if=virtio,file=ubuntu-core-20-amd64.img works for me it seems13:34
jdstrandmvo: ok, it was the OVMF bit I needed. thanks!13:34
jdstrandxnox: nm13:35
cachiomvo, I see this error on sbuild test https://paste.ubuntu.com/p/tKrXvmjQDw/13:38
cachioI remember you tald you were working on that13:38
zygahey jdstrand, good to see you :)13:45
mvocachio: hm, this one is confusing13:48
mvocachio: no error beside E: Build failure (dpkg-buildpackage died)13:49
mvocachio: is there any debug output or anything?13:49
pedronisthere are some UC20 milestone 2.45 PRs that needs 2nd reviews13:51
cachiomvo, yes https://paste.ubuntu.com/p/HprXqxGS56/13:51
cachiomvo, I see similar output13:51
mvocachio: I think we need more + tail -n 100 ./snapd_2.44.3-1_amd64-2020-04-22T13:07:36Z.build13:52
mvocachio: more than 100 lines :(13:52
mvocachio: because the failure is in the unit tests13:53
cachiomvo, ok, I'll do that13:53
cachiothanks13:53
mvocachio: so we should probably grep FAIL /snapd_2.44.3-1_amd64-2020-04-22T13:07:36Z.build13:53
mvocachio: but the full log is probably best13:53
cachioI'll print the full log13:54
mvocachio: thanks13:54
cachiomvo, to you13:54
jdstrandhey zyga :)14:00
zygajdstrand: those tests are useful, I found some interesting bugs in the cases where it fails14:01
zygajdstrand: more later today, I'm still making it readable/pretty14:01
* zyga breaks for lunch now 14:02
zygajdstrand: hey, I have a quick idea I wanted to run by you14:15
zygajdstrand: I was thinking about adding an environment variable that lets an application know snapd is tracking it14:15
zygajdstrand: perhaps something like SNAP_$something=tracked14:16
zygajdstrand: it would help in testing but it also might be useful to allow desktop applications that do their fancy pants custom checks to easily know about this and behave in a special way over time14:17
mupPR snapcraft#3076 opened: remote-build: fix case where build log url is None <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3076>14:21
jdstrandzyga: I'm not opposed to it, but it isn't really needed after it isn't experimental. plus I thought there was going to be an api or something for snaps to query (am I making that up?)14:24
zygajdstrand: there's snapctl based api but not for the sort of thing I'm thinking about14:24
zygajdstrand: it's really mainly for testing14:24
zygajdstrand: right now my test greps for the debug message14:25
jdstrandzyga: I wonder if this could be generalized. eg: SNAP_EXPERIMENTAL_FEATURES=refresh-app-awareness14:25
jdstrandzyga: so we expose via env what experimental features core has enabled14:25
zygathat's interesting but there's a difference, you can have it enabled but it may not really work14:26
jdstrandzyga: I might be missing something. I didn't think you would do SNAP_$something=tracking-broken14:26
zygaI would do the reverse,14:26
zygaSNAP_EXECUTION_ENVIRONMENT=,...,tracked14:27
zyga(the name is entirely arbitrary now)14:27
jdstrandzyga: or are you saying if the stars are aligned, only then you get 'tracked'?14:27
zygacorrect14:27
jdstrandzyga: considerations the limitations of this, that might make sense, sure14:27
zygaI probably won't add it today because I'm kind of set with debug for now but as we go into snapctl territory it might be something that's going to show up in a PR14:28
* jdstrand nods14:29
zyga- Fetch and check assertions for snap "core" (9138) (cannot get device session from store: store server returned status 400 and body "{\"error_list\":[{\"code\":\"invalid-assertion\",\"message\":\"invalid assertion: could not validate model assertion (revision 0 is already the current revision)\"}],\"errors\":[\"invalid assertion: could not validate model assertion (revision 0 is already the current14:38
zygarevision)\"],\"result\":\"error\"}\n")14:38
zygaI haven't seen this kind of error beore14:38
zygapedronis: ^ just a random spin up of a test that is fixed on a git revision from yesterday14:38
pedroniszyga: interesting, that might be a new bug14:40
mupPR snapd#8544 opened: interfaces/firewall-control: allow -legacy and -nft for core20 <Simple šŸ˜ƒ> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8544>14:44
pedroniszyga: thanks for spotting this, is likely a real issue14:45
* cachio afk -> bank14:56
zygapedronis: thank you!15:00
zygaI need a second review for test helper code: https://github.com/snapcore/snapd/pull/851515:05
mupPR #8515: testutil: add NewDBusTestConn <Created by zyga> <https://github.com/snapcore/snapd/pull/8515>15:06
zygajdstrand: nice15:07
zygauh so the assertion issue seems to be more serious15:07
zygaI guess snaps are busted now15:07
pstolowskiyeah15:13
pstolowskiFetch and check assertions for snap "core" (8935) (cannot get device session from store: store server returned status 400 and body.....15:14
om26erhttps://paste.ubuntu.com/p/xcMfkfwNjZ/15:14
om26erI am seeing that inside multipass ^ is that an issue in the backend or my setup ?15:14
Saviqom26er: status.snapcraft.io/15:15
pstolowskiom26er: yeah, store15:15
Saviqhttps://status.snapcraft.io/ even15:15
roadmrgive it a try now folks :)15:16
Saviqyup, works here :)15:16
om26erroadmr, thanks works for me too15:17
roadmrglad to hear, sorry for the inconvenience15:19
zygaroadmr: thank you!15:19
mupPR snapcraft#3077 opened: pluginhandler: skip plugin clean_pull for PluginV2 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3077>15:27
mvohas anyone looked at our tests? it looks like we have a bunch of unhappy runs, is the store a bit unhappy?16:22
pedronismvo: one issue was related to the deploy of the generic serial code, that has been reverted in the store now16:25
pedronisit will be fixed and re-deployed16:26
pedronisthere were more transient store issues as well16:26
mvopedronis: thanks16:28
pedronisI don't know if there are other issues16:31
zygaerror: cannot query the store for updates: got unexpected HTTP status code 503 via POST to "https://api.snapcraft.io/v2/snaps/refresh"16:56
zygaroadmr: ^16:56
zygaroadmr: is that expected?16:56
roadmrzyga: sorry :( we're seeing a lot of load and tweaking things to cope16:57
zygaack, understood16:57
zygaman I really need to start using that proxy16:57
roadmr:)16:57
zygaroadmr: good luck! (to the whole team)16:57
roadmrthanks16:57
mupIssue core20#48 opened: python3 from base causes segfault for confined snaps <Created by sergiusens> <https://github.com/snapcore/core20/issue/48>17:02
zygajdstrand: ^ is interesting17:06
zygajdstrand: did we miss the whole time64 move>17:06
zygaI cannot even think about how many syscalls are involved there :<17:07
ijohnson:-(17:07
=== ijohnson is now known as ijohnson|lunch
zygaI will soft-EOD and go on a bike ride (we can now)17:20
zygain about 30 minutes17:20
mupPR core20#49 opened: fix broken symlinks in /etc/writable <Created by mvo5> <https://github.com/snapcore/core20/pull/49>17:20
mupPR snapcraft#3078 opened: meson v2 plugin: ignore any staged python when installing meson <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3078>17:30
=== ijohnson|lunch is now known as ijohnson
mupPR snapcraft#3077 closed: pluginhandler: skip plugin clean_pull for PluginV2 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3077>18:37
mupPR snapcraft#3079 opened: cli: add plugin help for core20 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3079>18:58
mupPR snapd#8544 closed: interfaces/firewall-control: allow -legacy and -nft for core20 <Simple šŸ˜ƒ> <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8544>19:11
mupPR snapd#8542 closed: boot: store model model and grade information in modeenv <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8542>19:13
mupPR snapd#8540 closed: o/snapstate: tweak "waiting for restart" message <Simple šŸ˜ƒ> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8540>19:14
jdstrandzyga: I'm looking at the seccomp thing. is https://github.com/snapcore/snapd/pull/8496#issuecomment-617993863 something you could do or is that an mvo thing?19:42
mupPR #8496: interfaces/apparmor: use differently templated policy for non-core bases <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8496>19:42
zygajdstrand: checking19:42
zygaonly mvo19:42
zyga:/19:43
jdstrandok19:43
mupPR snapcraft#3080 opened: repo: fix for multi-arch stage-package scenario <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3080>19:46
mupPR snapcraft#3078 closed: meson v2 plugin: ignore any staged python when installing meson <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3078>20:01
mupPR snapd#8545 opened: cmd/snap-bootstrap/initramfs-mounts: mount ubuntu-seed first, other misc changes <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8545>20:07
ijohnsonpedronis: cmatsuoka: opened ^20:07
cmatsuokaijohnson: great, thanks!20:07
mupPR snapcraft#3081 opened: make v2 plugin: also pass make-parameters to install <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3081>20:28
mupPR snapd#8546 opened: seccomp: add get_tls, io_pg* and *time64/*64 variants for existing syscalls <āš  Critical> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8546>20:29
mupPR snapcraft#3079 closed: cli: add plugin help for core20 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3079>20:49
mupPR snapcraft#3082 opened: cli: add list-plugins for core20 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3082>20:52
mupPR snapcraft#3076 closed: remote-build: fix case where build log url is None <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3076>21:28
mupPR snapcraft#3081 closed: make v2 plugin: also pass make-parameters to install <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3081>21:46
mupPR snapd#8545 closed: cmd/snap-bootstrap/initramfs-mounts: mount ubuntu-seed first, other misc changes <UC20> <āš  Critical> <Created by anonymouse64> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/8545>22:32
mupPR snapcraft#3082 closed: cli: add list-plugins for core20 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3082>22:46
mupPR snapcraft#3080 closed: repo: fix for multi-arch stage-package scenario <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3080>23:04
cmatsuokaijohnson: I landed your PR and merged master back to the lock access PR, refactoring some common parts in the process23:08
cmatsuokaijohnson: you may want to verify if it looks correct23:08
cmatsuokaijohnson: will push soon23:08
ijohnsonThanks cmatsuoka I'll take a look in a bit23:09
cmatsuokaijohnson: I'm just creating an image here to make sure it still boots23:11
cmatsuokayep, it does23:14
cmatsuokaoops, some merge errors23:28
mupPR snapcraft#3075 closed: Edge staged <do-not-merge> <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3075>23:29
cmatsuokaijohnson: will be afk for 20min or so, feel free to push to that PR if you feel necessary23:43

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!