[00:17] <mup> PR snapd#8539 opened: tests: update encrypted partition creation test <UC20> <⛔ Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8539>
[05:52] <mborzecki> morning
[06:10] <zyga> Good morning
[06:11] <zyga> Chilly morning
[06:14] <mborzecki> zyga: hey, yeah only 6C here
[06:14] <zyga> Currently outside in shorts
[06:16] <mborzecki> hahah
[06:18] <zyga> Is everything red today?
[06:22] <mborzecki> zyga: idk, looking at uc20 prs only atm
[06:23] <mborzecki> those are red more often ;) so nothing out of the ordinary
[06:37] <zyga> I’m feeling pretty bad today
[06:37] <zyga> Had some heart issue all evening
[06:37] <zyga> Hope it passes :/
[06:39] <mvo> zyga: hey, good morning!
[06:39] <zyga> Good morning
[06:39] <zyga> (It passed... away, said the narrator)
[06:43] <zyga> There are git CVEs
[06:43] <zyga> Update your systems!
[06:44] <zyga> Our cloud stuff is up to date
[06:44] <mup> PR snapd#8538 closed: overlord: have a variant of Mock that can take a state.State <Simple 😃> <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8538>
[06:46] <mup> PR snapd#8535 closed: daemon: fix error message from `snap remove-user foo` on classic <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8535>
[06:56] <mup> PR snapd#8512 closed: boot/bootstate20: add EnvRefExtractedKernelBootloader bootstate20 implementation <UC20> <⚠ Critical> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8512>
[06:59] <pstolowski> morning
[07:01] <mvo> good morning pstolowski
[07:02] <mborzecki> pstolowski: mvo: hey
[07:02] <mvo> mborzecki: it looks like you are almost happy with 7825? I'm inclinded to merge, the remaining issues looks like cosmetics, or am I missing something in the 4323431 comments in there :) ?
[07:05] <mvo> mborzecki: and good morning!
[07:10] <mborzecki> mvo: left some questions for zyga there
[07:10] <pstolowski> mvo: one last remark about initramfs PR and +1
[07:16] <pedronis> mborzecki: hi, now that the initramfs changes were incorporated should we try #8464 again?
[07:16] <mup> PR #8464: cmd/snap-boostrap, boot: use /run/mnt/data instead of ubuntu-data <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8464>
[07:16] <mborzecki> pedronis: yes
[07:17] <mborzecki> pedronis: i'm fixinig one more thing in #8530, installbootConfig for uboot does not look at options
[07:17] <mup> PR #8530:  boot: enable makeBootable20RunMode for EnvRefExtractedKernel bootloaders <UC20> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8530>
[07:17] <mborzecki> and a missing test probably too
[07:17] <pedronis> ah
[07:21] <pedronis> mborzecki: maybe makebootable tests should check for that too
[07:27] <mborzecki> pedronis: heh, so there's a unit test, but checks the wrong location, looking at ian's plan the agreement was to have $systemseedrootdir/uboot.env
[07:28] <pedronis> yes
[07:29] <pedronis> mborzecki: we have code in grub, I suppose uboot needs similar
[07:29] <mborzecki> pedronis: fixed that already, pushing in a bit
[07:30] <pedronis> maybe we can reorg a bit the code, not sure, maybe later
[07:41] <zyga> mborzecki, mvo: yeah, iterating
[07:44] <mvo> pstolowski: woah, your hunch was right, one more bug found and tests improved, shell is hard
[07:44] <pstolowski> mvo: oh wow, i didn't expect a bug...
[07:44] <pstolowski> shell is terrible
[07:44] <mvo> pstolowski: [ -e ... ] will break on broken symlinks :)
[07:45] <mvo> pstolowski: or your idea of adding a broken symlink uncovred it
[07:45] <mvo> pstolowski: I doubt it would actually have hit us for real as the broken-symlink would have to be in the toplevel dir but a bug is a bug
[07:45]  * mvo hugs pstolowski 
[07:50] <mborzecki> mvo: we should write in tcl instead :P
[07:51] <mborzecki> pedronis: pushed a fix to #8530
[07:52] <mup> PR #8530:  boot: enable makeBootable20RunMode for EnvRefExtractedKernel bootloaders <UC20> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8530>
[07:55] <pedronis> mborzecki: looks good to me
[07:56] <pstolowski> mvo: right, -e, drat
[07:58] <mvo> mborzecki: *cough* tcl *cough*
[07:59] <pstolowski> mvo: i reckon it just became harder to convince you to do initrd version check in shell vs go :}
[08:01] <mvo> pstolowski: lol
[08:02] <zyga> just use C, at least you will get *excellent* reviews from jamie :)
[09:18] <zyga> mvo: one of the workers in canonistack was lost due to btrfs corruption due to disk space exhaustion, remaining workers are moved to a new volume that has more space
[09:21] <mborzecki> zyga: haha it's still a thing?
[09:21] <mvo> zyga: in a meeting, will get back to you
[09:22] <mborzecki> thought this was fixed in btrfs a while ago
[09:22] <mborzecki> brb, quick errand
[09:41] <mborzecki> re
[10:03] <mup> PR snapd#8530 closed:  boot: enable makeBootable20RunMode for EnvRefExtractedKernel bootloaders <UC20> <⚠ Critical> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8530>
[10:16] <mup> PR snapd#8540 opened: o/snapstate: tweak "waiting for restart" message <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8540>
[10:43] <zyga> mborzecki: eh, go-dbus spawns dbus-launch and leaves it running
[10:43] <zyga> mborzecki: and they pile up
[10:43] <mborzecki> omg
[10:43] <zyga> mborzecki: what a terrible idea
[10:43] <zyga> mborzecki: :|
[10:43] <zyga> mborzecki: anyway, those -failure tests are sure fun
[10:43] <zyga> mborzecki: I found one more funny bugg
[10:43] <zyga> mborzecki: but more in how we use it
[11:02] <mup> PR snapd#8541 opened: devicestate: add support for cloufg.cfg.d config from the gadget <Created by mvo5> <https://github.com/snapcore/snapd/pull/8541>
[11:37] <zyga> ok, I have a good understanding of what I need to write for the test
[11:37] <zyga> I'll take a break to stretch and think about how to write that in one nice test
[11:38] <zyga> mborzecki: I still have to tackle the leaking dbus-launch, it's such a shame go-dbus doesn't allow one to configure this
[11:39] <mborzecki> zyga: there's Connect where you can pass address
[11:39] <mborzecki> zyga: so we could inspect the relevant env/files ourselves
[11:39] <zyga> mborzecki: yes I know
[11:39] <zyga> that's unavoidable
[11:39] <mborzecki> zyga: that's probably all we can do :/
[11:39] <zyga> just look at the amount of code that is behind SessionBus()
[11:39] <zyga> until Connect
[11:39] <zyga> but yeah, I know
[11:41] <mup> PR snapd#8542 opened: boot: store model model and grade information in modeenv <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8542>
[11:43] <mup> PR snapd#8543 opened: overlord/devicestate: preserve the current model inside ubuntu-boot <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8543>
[11:44] <mborzecki> pedronis_: ^^
[11:46] <pedronis> mborzecki: reviewed
[11:48] <pedronis> mborzecki: unit test failure though
[11:48] <mborzecki> hmmm
[11:49] <mborzecki> heh, yeah, splitting patches is fun
[11:53] <mborzecki> w8, actually, there's patches in master that broke the unit tests /o\
[11:55] <pedronis> mborzecki: can you remind me what mounts boot data etc at install time?
[11:55] <mborzecki> pedronis: we ask snap-bootstrap to do it by passing --mount
[11:56] <mborzecki> (along with the rest of create-partitions parameters)
[11:56] <pedronis> ah, I was looked at the wrong point
[11:56] <mborzecki> pedronis: partitions are mounted at /run/mnt/<fs-label>
[12:13] <pedronis> mborzecki: that's interesting, so we override the original tmpfs ubuntu-data ?
[12:13] <pedronis> mborzecki: we probably really need your PR (for sanity)
[12:18] <mup> PR snapcraft#3075 opened: Edge staged <do-not-merge> <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3075>
[12:30] <pedronis> mborzecki: some comment son #9543
[12:30] <pedronis> heh, #8543
[12:30] <mup> PR #8543: overlord/devicestate: preserve the current model inside ubuntu-boot <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8543>
[13:14] <jdstrand> xnox: hey, I'm trying to use http://cdimage.ubuntu.com/ubuntu-core/20/edge/20200421/ubuntu-core-20-amd64.img.xz in a vm ,
[13:14] <jdstrand> xnox: but it isn't working right. 'invalid signature'. is there documenation on how to use it?
[13:17] <jdstrand> mvo: ^ (I'm trying to do this to test the firewall-control interface (it needs some updates)
[13:20] <jdstrand> maybe 20200421 was busted
[13:20]  * jdstrand tries 20200422
[13:24] <mvo> jdstrand: in a meeting right now, can get back to you
[13:25] <jdstrand> no, same issue
[13:25] <jdstrand> mvo: thanks!
[13:34] <mvo> jdstrand: kvm -m 1500 -snapshot -bios /usr/share/OVMF/OVMF_CODE.fd -drive if=virtio,file=ubuntu-core-20-amd64.img works for me it seems
[13:34] <jdstrand> mvo: ok, it was the OVMF bit I needed. thanks!
[13:35] <jdstrand> xnox: nm
[13:38] <cachio> mvo, I see this error on sbuild test https://paste.ubuntu.com/p/tKrXvmjQDw/
[13:38] <cachio> I remember you tald you were working on that
[13:45] <zyga> hey jdstrand, good to see you :)
[13:48] <mvo> cachio: hm, this one is confusing
[13:49] <mvo> cachio: no error beside E: Build failure (dpkg-buildpackage died)
[13:49] <mvo> cachio: is there any debug output or anything?
[13:51] <pedronis> there are some UC20 milestone 2.45 PRs that needs 2nd reviews
[13:51] <cachio> mvo, yes https://paste.ubuntu.com/p/HprXqxGS56/
[13:51] <cachio> mvo, I see similar output
[13:52] <mvo> cachio: I think we need more + tail -n 100 ./snapd_2.44.3-1_amd64-2020-04-22T13:07:36Z.build
[13:52] <mvo> cachio: more than 100 lines :(
[13:53] <mvo> cachio: because the failure is in the unit tests
[13:53] <cachio> mvo, ok, I'll do that
[13:53] <cachio> thanks
[13:53] <mvo> cachio: so we should probably grep FAIL /snapd_2.44.3-1_amd64-2020-04-22T13:07:36Z.build
[13:53] <mvo> cachio: but the full log is probably best
[13:54] <cachio> I'll print the full log
[13:54] <mvo> cachio: thanks
[13:54] <cachio> mvo, to you
[14:00] <jdstrand> hey zyga :)
[14:01] <zyga> jdstrand: those tests are useful, I found some interesting bugs in the cases where it fails
[14:01] <zyga> jdstrand: more later today, I'm still making it readable/pretty
[14:02]  * zyga breaks for lunch now 
[14:15] <zyga> jdstrand: hey, I have a quick idea I wanted to run by you
[14:15] <zyga> jdstrand: I was thinking about adding an environment variable that lets an application know snapd is tracking it
[14:16] <zyga> jdstrand: perhaps something like SNAP_$something=tracked
[14:17] <zyga> jdstrand: it would help in testing but it also might be useful to allow desktop applications that do their fancy pants custom checks to easily know about this and behave in a special way over time
[14:21] <mup> PR snapcraft#3076 opened: remote-build: fix case where build log url is None <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3076>
[14:24] <jdstrand> zyga: I'm not opposed to it, but it isn't really needed after it isn't experimental. plus I thought there was going to be an api or something for snaps to query (am I making that up?)
[14:24] <zyga> jdstrand: there's snapctl based api but not for the sort of thing I'm thinking about
[14:24] <zyga> jdstrand: it's really mainly for testing
[14:25] <zyga> jdstrand: right now my test greps for the debug message
[14:25] <jdstrand> zyga: I wonder if this could be generalized. eg: SNAP_EXPERIMENTAL_FEATURES=refresh-app-awareness
[14:25] <jdstrand> zyga: so we expose via env what experimental features core has enabled
[14:26] <zyga> that's interesting but there's a difference, you can have it enabled but it may not really work
[14:26] <jdstrand> zyga: I might be missing something. I didn't think you would do SNAP_$something=tracking-broken
[14:26] <zyga> I would do the reverse,
[14:27] <zyga> SNAP_EXECUTION_ENVIRONMENT=,...,tracked
[14:27] <zyga> (the name is entirely arbitrary now)
[14:27] <jdstrand> zyga: or are you saying if the stars are aligned, only then you get 'tracked'?
[14:27] <zyga> correct
[14:27] <jdstrand> zyga: considerations the limitations of this, that might make sense, sure
[14:28] <zyga> I probably won't add it today because I'm kind of set with debug for now but as we go into snapctl territory it might be something that's going to show up in a PR
[14:29]  * jdstrand nods
[14:38] <zyga> - Fetch and check assertions for snap "core" (9138) (cannot get device session from store: store server returned status 400 and body "{\"error_list\":[{\"code\":\"invalid-assertion\",\"message\":\"invalid assertion: could not validate model assertion (revision 0 is already the current revision)\"}],\"errors\":[\"invalid assertion: could not validate model assertion (revision 0 is already the current
[14:38] <zyga> revision)\"],\"result\":\"error\"}\n")
[14:38] <zyga> I haven't seen this kind of error beore
[14:38] <zyga> pedronis: ^ just a random spin up of a test that is fixed on a git revision from yesterday
[14:40] <pedronis> zyga: interesting, that might be a new bug
[14:44] <mup> PR snapd#8544 opened: interfaces/firewall-control: allow -legacy and -nft for core20 <Simple 😃> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8544>
[14:45] <pedronis> zyga: thanks for spotting this, is likely a real issue
[14:56]  * cachio afk -> bank
[15:00] <zyga> pedronis: thank you!
[15:05] <zyga> I need a second review for test helper code: https://github.com/snapcore/snapd/pull/8515
[15:06] <mup> PR #8515: testutil: add NewDBusTestConn <Created by zyga> <https://github.com/snapcore/snapd/pull/8515>
[15:07] <zyga> jdstrand: nice
[15:07] <zyga> uh so the assertion issue seems to be more serious
[15:07] <zyga> I guess snaps are busted now
[15:13] <pstolowski> yeah
[15:14] <pstolowski> Fetch and check assertions for snap "core" (8935) (cannot get device session from store: store server returned status 400 and body.....
[15:14] <om26er> https://paste.ubuntu.com/p/xcMfkfwNjZ/
[15:14] <om26er> I am seeing that inside multipass ^ is that an issue in the backend or my setup ?
[15:15] <Saviq> om26er: status.snapcraft.io/
[15:15] <pstolowski> om26er: yeah, store
[15:15] <Saviq> https://status.snapcraft.io/ even
[15:16] <roadmr> give it a try now folks :)
[15:16] <Saviq> yup, works here :)
[15:17] <om26er> roadmr, thanks works for me too
[15:19] <roadmr> glad to hear, sorry for the inconvenience
[15:19] <zyga> roadmr: thank you!
[15:27] <mup> PR snapcraft#3077 opened: pluginhandler: skip plugin clean_pull for PluginV2 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3077>
[16:22] <mvo> has anyone looked at our tests? it looks like we have a bunch of unhappy runs, is the store a bit unhappy?
[16:25] <pedronis> mvo: one issue was related to the deploy of the generic serial code, that has been reverted in the store now
[16:26] <pedronis> it will be fixed and re-deployed
[16:26] <pedronis> there were more transient store issues as well
[16:28] <mvo> pedronis: thanks
[16:31] <pedronis> I don't know if there are other issues
[16:56] <zyga> error: cannot query the store for updates: got unexpected HTTP status code 503 via POST to "https://api.snapcraft.io/v2/snaps/refresh"
[16:56] <zyga> roadmr: ^
[16:56] <zyga> roadmr: is that expected?
[16:57] <roadmr> zyga: sorry :( we're seeing a lot of load and tweaking things to cope
[16:57] <zyga> ack, understood
[16:57] <zyga> man I really need to start using that proxy
[16:57] <roadmr> :)
[16:57] <zyga> roadmr: good luck! (to the whole team)
[16:57] <roadmr> thanks
[17:02] <mup> Issue core20#48 opened: python3 from base causes segfault for confined snaps <Created by sergiusens> <https://github.com/snapcore/core20/issue/48>
[17:06] <zyga> jdstrand: ^ is interesting
[17:06] <zyga> jdstrand: did we miss the whole time64 move>
[17:07] <zyga> I cannot even think about how many syscalls are involved there :<
[17:07] <ijohnson> :-(
[17:20] <zyga> I will soft-EOD and go on a bike ride (we can now)
[17:20] <zyga> in about 30 minutes
[17:20] <mup> PR core20#49 opened: fix broken symlinks in /etc/writable <Created by mvo5> <https://github.com/snapcore/core20/pull/49>
[17:30] <mup> PR snapcraft#3078 opened: meson v2 plugin: ignore any staged python when installing meson <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3078>
[18:37] <mup> PR snapcraft#3077 closed: pluginhandler: skip plugin clean_pull for PluginV2 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3077>
[18:58] <mup> PR snapcraft#3079 opened: cli: add plugin help for core20 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3079>
[19:11] <mup> PR snapd#8544 closed: interfaces/firewall-control: allow -legacy and -nft for core20 <Simple 😃> <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8544>
[19:13] <mup> PR snapd#8542 closed: boot: store model model and grade information in modeenv <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8542>
[19:14] <mup> PR snapd#8540 closed: o/snapstate: tweak "waiting for restart" message <Simple 😃> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8540>
[19:42] <jdstrand> zyga: I'm looking at the seccomp thing. is https://github.com/snapcore/snapd/pull/8496#issuecomment-617993863 something you could do or is that an mvo thing?
[19:42] <mup> PR #8496: interfaces/apparmor: use differently templated policy for non-core bases <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8496>
[19:42] <zyga> jdstrand: checking
[19:42] <zyga> only mvo
[19:43] <zyga> :/
[19:43] <jdstrand> ok
[19:46] <mup> PR snapcraft#3080 opened: repo: fix for multi-arch stage-package scenario <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3080>
[20:01] <mup> PR snapcraft#3078 closed: meson v2 plugin: ignore any staged python when installing meson <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3078>
[20:07] <mup> PR snapd#8545 opened: cmd/snap-bootstrap/initramfs-mounts: mount ubuntu-seed first, other misc changes <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8545>
[20:07] <ijohnson> pedronis: cmatsuoka: opened ^
[20:07] <cmatsuoka> ijohnson: great, thanks!
[20:28] <mup> PR snapcraft#3081 opened: make v2 plugin: also pass make-parameters to install <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3081>
[20:29] <mup> PR snapd#8546 opened: seccomp: add get_tls, io_pg* and *time64/*64 variants for existing syscalls <⚠ Critical> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8546>
[20:49] <mup> PR snapcraft#3079 closed: cli: add plugin help for core20 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3079>
[20:52] <mup> PR snapcraft#3082 opened: cli: add list-plugins for core20 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3082>
[21:28] <mup> PR snapcraft#3076 closed: remote-build: fix case where build log url is None <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3076>
[21:46] <mup> PR snapcraft#3081 closed: make v2 plugin: also pass make-parameters to install <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3081>
[22:32] <mup> PR snapd#8545 closed: cmd/snap-bootstrap/initramfs-mounts: mount ubuntu-seed first, other misc changes <UC20> <⚠ Critical> <Created by anonymouse64> <Merged by cmatsuoka> <https://github.com/snapcore/snapd/pull/8545>
[22:46] <mup> PR snapcraft#3082 closed: cli: add list-plugins for core20 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3082>
[23:04] <mup> PR snapcraft#3080 closed: repo: fix for multi-arch stage-package scenario <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3080>
[23:08] <cmatsuoka> ijohnson: I landed your PR and merged master back to the lock access PR, refactoring some common parts in the process
[23:08] <cmatsuoka> ijohnson: you may want to verify if it looks correct
[23:08] <cmatsuoka> ijohnson: will push soon
[23:09] <ijohnson> Thanks cmatsuoka I'll take a look in a bit
[23:11] <cmatsuoka> ijohnson: I'm just creating an image here to make sure it still boots
[23:14] <cmatsuoka> yep, it does
[23:28] <cmatsuoka> oops, some merge errors
[23:29] <mup> PR snapcraft#3075 closed: Edge staged <do-not-merge> <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3075>
[23:43] <cmatsuoka> ijohnson: will be afk for 20min or so, feel free to push to that PR if you feel necessary