| seb128 | Laney, k, I give up on that RST translation issue, it's over my debconf/ubiquity understanding | 09:15 |
|---|---|---|
| seb128 | I edited https://git.launchpad.net/ubiquity/tree/ubiquity/plugins/ubi-prepare.py#n147 and do | 09:15 |
| seb128 | syslog;syslog(self.controller.get_string('ubiquity/text/efi_secureboot')) | 09:16 |
| seb128 | syslog.syslog(self.controller.get_string('ubiquity/text/efi_secureboot')) | 09:16 |
| seb128 | -> translated | 09:16 |
| seb128 | syslog.syslog(self.controller.get_string('ubiquity/text/rst_header')) | 09:16 |
| seb128 | -> not translated | 09:16 |
| seb128 | they are defined the same way in the template from what I can tell | 09:16 |
| seb128 | and | 09:17 |
| seb128 | $ gettext -d ubiquity-debconf 'Turn off RST' | 09:17 |
| seb128 | correctly return the french string | 09:17 |
| seb128 | I can't see a difference between that one and others | 09:17 |
| Laney | :/ | 09:17 |
| Laney | we can look more together after this week if you want | 09:18 |
| seb128 | sure | 09:18 |
| Laney | I thought I just copied everything else | 09:18 |
| seb128 | I will try thinking about it but I'm just out of ideas | 09:18 |
| seb128 | I don't get why the get_string works on another string and not this one | 09:18 |
| seb128 | at least it doesn't seem the plumbing around or the page | 09:18 |
| seb128 | if I use 'ubiquity/text/efi_secureboot' it displays also translated on the page | 09:18 |
| seb128 | so it's something about the string | 09:19 |
| seb128 | or debconf, I don't understand how debconf translations work... | 09:19 |
| seb128 | ok | 09:20 |
| seb128 | found a problem now | 09:20 |
| seb128 | sometime summarizing help : | 09:20 |
| seb128 | :p | 09:20 |
| seb128 | /var/cache/debconf/templates.dat doesn't include the translations for those new strings | 09:21 |
| seb128 | Laney, k, got it | 09:27 |
| seb128 | ./debian/imported-po translations need to be updated | 09:28 |
| seb128 | the build does | 09:28 |
| seb128 | 'dh_installdebconf | 09:28 |
| seb128 | echo >> debian/ubiquity/DEBIAN/templates | 09:28 |
| seb128 | po2debconf --podir=debian/imported-po \ | 09:28 |
| seb128 | debian/ubiquity.templates-imported \ | 09:28 |
| seb128 | >> debian/ubiquity/DEBIAN/templates | 09:28 |
| seb128 | echo >> debian/ubiquity/DEBIAN/templates' | 09:28 |
| seb128 | 09:28 | |
| seb128 | I don't understand the difference between debian/real-po and debian/imported-po | 09:29 |
| seb128 | I updated both in the previous export | 09:29 |
| seb128 | Laney, looks like you only updated real-po when you added the strings | 09:30 |
| Laney | ok | 09:30 |
| seb128 | sorry for the channel spamming | 09:30 |
| seb128 | I will do a MP with a new translations import | 09:30 |
| Laney | is there any chance you can add a test to make sure this doesn't happen? | 09:30 |
| Laney | thx for finding it | 09:31 |
| seb128 | I would need to understand why we have those directories split first | 09:31 |
| seb128 | but yeah, I can take an action item to look at that | 09:31 |
| Laney | there are already some tests for untranslatable strings iirc | 09:31 |
| Laney | but sounds like they are missing this | 09:31 |
| Laney | whatever this means, shrug | 09:31 |
| seb128 | the string is translatable correctly | 09:32 |
| seb128 | we just didn't inject back translation work from launchpad | 09:32 |
| Laney | but you said gettext was showing it for you yet the UI wasn't | 09:33 |
| seb128 | yes, because the title is not fetch using gettext | 09:33 |
| seb128 | it's read from debconf | 09:33 |
| Laney | where did that translation come from? | 09:34 |
| seb128 | gettext? from the .mo | 09:34 |
| seb128 | but debconf is looking to /var/cache/debconf/templates.dat | 09:34 |
| Laney | someone did a bad import or what are you saying? | 09:34 |
| seb128 | which has inline translations from the snippet at the package built I copied | 09:34 |
| seb128 | build does | 09:34 |
| seb128 | po2debconf --podir=debian/imported-po \ | 09:34 |
| seb128 | debian/ubiquity.templates-imported \ | 09:34 |
| seb128 | >> debian/ubiquity/DEBIAN/templates | 09:34 |
| seb128 | but import-po didn't get a copy of the new .po exported | 09:35 |
| seb128 | imported-po | 09:35 |
| seb128 | so the strings are missing from the templates file | 09:35 |
| seb128 | real-po has been updated though | 09:35 |
| seb128 | so gettext is fine | 09:35 |
| seb128 | mismatch of dbs | 09:35 |
| seb128 | I don't know why we have 2 sets of .po though, that's confusing :/ | 09:35 |
| Laney | weird | 09:37 |
| Laney | will it automatically get all the translations from launchpad when that is fixed? | 09:38 |
| seb128 | well the fix is to do a launchpad export and copy the updated po to the vcs | 09:39 |
| seb128 | there is no 'automatic', ubiquity doesn't use langpacks for those translations | 09:39 |
| seb128 | need to be manually updated | 09:39 |
| Laney | I know, sorry trying again | 09:42 |
| Laney | I mean: will they have to be re-translated or will the existing translations work, once this is fixed? | 09:42 |
| seb128 | oh, existing translations will work | 09:42 |
| seb128 | sorry :) | 09:42 |
| seb128 | k, I think I got things wrong with imported-po | 09:47 |
| seb128 | but an export/rebuild should fix it, I'm testing that now | 09:48 |
| seb128 | the imported-po are other strings from e.g GTK | 09:49 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!