[09:15] Laney, k, I give up on that RST translation issue, it's over my debconf/ubiquity understanding [09:15] I edited https://git.launchpad.net/ubiquity/tree/ubiquity/plugins/ubi-prepare.py#n147 and do [09:16] syslog;syslog(self.controller.get_string('ubiquity/text/efi_secureboot')) [09:16] syslog.syslog(self.controller.get_string('ubiquity/text/efi_secureboot')) [09:16] -> translated [09:16] syslog.syslog(self.controller.get_string('ubiquity/text/rst_header')) [09:16] -> not translated [09:16] they are defined the same way in the template from what I can tell [09:17] and [09:17] $ gettext -d ubiquity-debconf 'Turn off RST' [09:17] correctly return the french string [09:17] I can't see a difference between that one and others [09:17] :/ [09:18] we can look more together after this week if you want [09:18] sure [09:18] I thought I just copied everything else [09:18] I will try thinking about it but I'm just out of ideas [09:18] I don't get why the get_string works on another string and not this one [09:18] at least it doesn't seem the plumbing around or the page [09:18] if I use 'ubiquity/text/efi_secureboot' it displays also translated on the page [09:19] so it's something about the string [09:19] or debconf, I don't understand how debconf translations work... [09:20] ok [09:20] found a problem now [09:20] sometime summarizing help : [09:20] :p [09:21] /var/cache/debconf/templates.dat doesn't include the translations for those new strings [09:27] Laney, k, got it [09:28] ./debian/imported-po translations need to be updated [09:28] the build does [09:28] 'dh_installdebconf [09:28] echo >> debian/ubiquity/DEBIAN/templates [09:28] po2debconf --podir=debian/imported-po \ [09:28] debian/ubiquity.templates-imported \ [09:28] >> debian/ubiquity/DEBIAN/templates [09:28] echo >> debian/ubiquity/DEBIAN/templates' [09:28] [09:29] I don't understand the difference between debian/real-po and debian/imported-po [09:29] I updated both in the previous export [09:30] Laney, looks like you only updated real-po when you added the strings [09:30] ok [09:30] sorry for the channel spamming [09:30] I will do a MP with a new translations import [09:30] is there any chance you can add a test to make sure this doesn't happen? [09:31] thx for finding it [09:31] I would need to understand why we have those directories split first [09:31] but yeah, I can take an action item to look at that [09:31] there are already some tests for untranslatable strings iirc [09:31] but sounds like they are missing this [09:31] whatever this means, shrug [09:32] the string is translatable correctly [09:32] we just didn't inject back translation work from launchpad [09:33] but you said gettext was showing it for you yet the UI wasn't [09:33] yes, because the title is not fetch using gettext [09:33] it's read from debconf [09:34] where did that translation come from? [09:34] gettext? from the .mo [09:34] but debconf is looking to /var/cache/debconf/templates.dat [09:34] someone did a bad import or what are you saying? [09:34] which has inline translations from the snippet at the package built I copied [09:34] build does [09:34] po2debconf --podir=debian/imported-po \ [09:34] debian/ubiquity.templates-imported \ [09:34] >> debian/ubiquity/DEBIAN/templates [09:35] but import-po didn't get a copy of the new .po exported [09:35] imported-po [09:35] so the strings are missing from the templates file [09:35] real-po has been updated though [09:35] so gettext is fine [09:35] mismatch of dbs [09:35] I don't know why we have 2 sets of .po though, that's confusing :/ [09:37] weird [09:38] will it automatically get all the translations from launchpad when that is fixed? [09:39] well the fix is to do a launchpad export and copy the updated po to the vcs [09:39] there is no 'automatic', ubiquity doesn't use langpacks for those translations [09:39] need to be manually updated [09:42] I know, sorry trying again [09:42] I mean: will they have to be re-translated or will the existing translations work, once this is fixed? [09:42] oh, existing translations will work [09:42] sorry :) [09:47] k, I think I got things wrong with imported-po [09:48] but an export/rebuild should fix it, I'm testing that now [09:49] the imported-po are other strings from e.g GTK