[01:49] babbageclunk: so, when you proposed your recent juju/utils PR, did you see unrelated failures in merge check tests due to focal now being picked up as a series https://github.com/juju/utils/pull/311 [01:50] wallyworld: hmm, trying to remember... [01:50] doesn't sound familiar [01:51] i guess i need to make a drive by change then [01:51] no, I definitely didn't [01:51] maybe distro has been updated on machine [01:52] that was nearly 2 months ago though so I can see a default having changed in the meantime [01:52] acxtually, maybe focal is released now [01:53] was going to be today or thereabouts [01:53] it *is* 20.04 [01:53] yeah that would do that [03:49] wallyworld: can you review this commit https://github.com/juju/juju/pull/11465/commits/2995c2168bdb04d8708dcac06acdbfb9b90ac3a9 [03:52] hpidcock: otp, sec [04:07] hpidcock: yeah, that uniter test is bloody awful. goes back to the very early juju go port from python and never been fixed [04:08] hpidcock: looks like a new conflict to solve in gopkg.lock [04:08] yeah, also still fighting some silly tests [04:08] joy [04:31] I can almost taste go mod [04:34] mmmmmmm [04:38] I want it now hpidcock [04:38] Waiting for ci jobs [04:38] I am cool with untested code [04:39] Oh its already tested. But Jenkins likes to get upset [05:10] wallyworld: https://github.com/juju/juju/pull/11490 got this PR to let webhook name keep no change, +1 plz ty [05:10] sure [05:11] wallyworld: going to grab some food, come back later [05:11] np [05:43] wallyworld: https://github.com/juju/juju/pull/11491 is the logger branch [05:44] wallyworld: it is very mechanical [05:44] sure [05:46] I'm just snap installing microk8s to bootstrap and deploy to ensure all bits are actually hooked up [05:47] this is my first time bootstrapping into k8s, anything I need to know? [05:47] hope not [05:47] and what can I deploy as an "ubuntu-lite" type k8s charm [05:47] i use ~juju/mariadb-k8s [05:47] well, my local copy [05:47] you will need to seed microk8s [05:48] with your locally build juju image [05:48] how? [05:48] make microk8s-operator-update [05:48] in the discourse post :-) [05:48] then just juju bootstrap microk8s tim [05:49] ack [05:49] will try [05:49] still in the middle of bootstrapping lxd for that part of the test [05:49] i hope to hear good news :-) [05:49] oh... [05:49] as noted in the description [05:50] I've actually properly fixed an intermittent test failure in the featuretests package [05:50] yeah, saw that, good [05:52] wallyworld: ah, poo, found another place I've missed since the develop merge [05:52] worker/uniter/actions has a place I need to thread a logger [05:52] np, i'll keep reviewing [05:52] I'll update and push [05:54] thumper: in caasoperator worker, why logger := loggo.GetLogger("juju.worker.uniter.charm") ? and not from config? [05:54] wallyworld: because we don't want the "worker.caasoperator" module [05:55] oh right ok [05:55] maybe pass in as a second logger on the config struct? [05:55] as it's used twice [05:56] well, actuallt no [05:56] slightly different variations [05:56] so maybe not [06:06] wallyworld: some of this will get cleaned up when we have the caas operator using a nested dep engine [06:06] thumper: yeah, true that. lgtm with a suggestion [06:07] * thumper is still testing... [06:07] * wallyworld needs to go to vet [06:07] wallyworld: seems I don't have docker installed [06:07] where do we normally get that from [06:07] ? [06:07] wallyworld, hpidcock: ^^ [06:07] i snap install docker [06:07] thumper: snap is ok [06:07] cheers [06:08] there might be a perms issue with /var/lib/docker something [06:08] why? [06:08] or /var/run/docker. can't recall [06:08] because docker [06:08] or because snap [06:08] I think you just need to add your user to the docker group [06:08] not sure [06:08] ah yeah, that rungs a bell [06:08] been a while [06:09] * thumper hasn't done any of that, just snap installed docker [06:09] may be ok to use it to build images [06:10] but running stuff might complain. but microk8s uses containerd now anyway [06:10] snap might have fixed the issue [06:10] it isn't / hasn't [06:10] hpidcock: good luck with go mod finalisation, i'll see if there's a devel update after vet :-) [06:10] does anyone remember how to add to groups without logging in or out? [06:11] newgrp docker will fork the shell with the new group [06:11] but [06:11] you first need to add yourself to the group [06:11] that [06:11] same as we do for lxd [06:12] usermod -a -G docker thumper [06:12] right, off to vet [06:12] start a new session with su thumper [06:12] should re load all the groups in that terminal [06:13] su - thumper [06:14] hmm... seems like the docker snap doesn't create the docker group [06:14] or at least doesn't put me in it [06:16] * thumper sighs [06:16] seems like the docker daemon isn't running even [06:17] i always install docker from their deb repo [06:17] but thats just me [06:17] snap service docker does show one running [06:17] * thumper sighs [06:17] why is this so hard? [06:19] wallyworld: I changed the annoation to "juju.io/disable-name-prefix" [06:20] hpidcock: any ideas why snap docker wouldn't do its thing? [06:20] i installed docker using apt as well [06:21] `ls -la /var/run/docker.sock` [06:21] is it using the docker group? [06:22] also check `snap services` [06:22] maybe there is a docker service there [06:23] I haven't used the snap in a while [06:23] that's running as root [06:23] /var/run/docker.sock [06:23] should be owned by root but the group should be docker [06:24] it's root root [06:24] eww [06:24] * thumper edits it [06:26] * thumper tries again [06:30] got further, but it still doesn't work [06:32] hpidcock: https://pastebin.ubuntu.com/p/cDnpRHhJ77/ [06:37] thumper: are you part of the microk8s group ? [06:38] ?? [06:38] maybe not [06:38] nope [06:40] see if that works [06:40] * thumper adds himself to the microk8s group and tries again [06:42] yep, that now worked [06:43] \o/ [06:43] * thumper tries to deploy again [06:43] charmstore was still down before [06:44] looks like it still is [06:44] may come back down later [06:44] * thumper is past EOD [06:44] later peeps [06:54] anyone free to take a look this tiny PR plz https://github.com/juju/juju/pull/11492 [07:43] wallyworld: "All checks have passed" [07:50] hpidcock: so merge that mother plucker [07:55] I need popcorn [07:56] UberEats popcorn delivery to the whole team [09:20] anyone around in here? [09:35] manadart, https://github.com/juju/juju/pull/11483 [09:35] babbageclunk, hello [09:37] stickupkid: Tick. [09:38] manadart, Ta [09:38] manadart, tests are fun [11:31] stickupkid: My MicroStack QA worked for https://github.com/juju/juju/pull/11435. [11:32] manadart, was actually just looking at that PR [11:32] stickupkid: Quick HO? [13:54] manadart: if interface info aka network config doesn't have an origin (older api), then it should be a OriginProvider right? [13:56] stickupkid: Hmm, that may get us into trouble. [13:56] manadart, quick ho about it? [20:13] Audio is not working for everyone on youtube you might need to repeate the questions [20:13] whoever is talking now can't be heard