[01:49] <wallyworld> babbageclunk: so, when you proposed your recent juju/utils PR, did you see unrelated failures in merge check tests due to focal now being picked up as a series https://github.com/juju/utils/pull/311
[01:50] <babbageclunk> wallyworld: hmm, trying to remember...
[01:50] <babbageclunk> doesn't sound familiar
[01:51] <wallyworld> i guess i need to make a drive by change then
[01:51] <babbageclunk> no, I definitely didn't
[01:51] <wallyworld> maybe distro has been updated on machine
[01:52] <babbageclunk> that was nearly 2 months ago though so I can see a default having changed in the meantime
[01:52] <wallyworld> acxtually, maybe focal is released now
[01:53] <wallyworld> was going to be today or thereabouts
[01:53] <babbageclunk> it *is* 20.04
[01:53] <babbageclunk> yeah that would do that
[03:49] <hpidcock> wallyworld: can you review this commit https://github.com/juju/juju/pull/11465/commits/2995c2168bdb04d8708dcac06acdbfb9b90ac3a9
[03:52] <wallyworld> hpidcock: otp, sec
[04:07] <wallyworld> hpidcock: yeah, that uniter test is bloody awful. goes back to the very early juju go port from python and never been fixed
[04:08] <wallyworld> hpidcock: looks like a new conflict to solve in gopkg.lock
[04:08] <hpidcock> yeah, also still fighting some silly tests
[04:08] <wallyworld> joy
[04:31] <hpidcock> I can almost taste go mod
[04:34] <wallyworld> mmmmmmm
[04:38] <tlm> I want it now hpidcock
[04:38] <hpidcock> Waiting for ci jobs
[04:38] <tlm> I am cool with untested code
[04:39] <hpidcock> Oh its already tested. But Jenkins likes to get upset
[05:10] <kelvinliu> wallyworld: https://github.com/juju/juju/pull/11490 got this PR to let webhook name keep no change, +1 plz  ty
[05:10] <wallyworld> sure
[05:11] <kelvinliu> wallyworld: going to grab some food, come back later
[05:11] <wallyworld> np
[05:43] <thumper> wallyworld: https://github.com/juju/juju/pull/11491 is the logger branch
[05:44] <thumper> wallyworld: it is very mechanical
[05:44] <wallyworld> sure
[05:46] <thumper> I'm just snap installing microk8s to bootstrap and deploy to ensure all bits are actually hooked up
[05:47] <thumper> this is my first time bootstrapping into k8s, anything I need to know?
[05:47] <wallyworld> hope not
[05:47] <thumper> and what can I deploy as an "ubuntu-lite" type k8s charm
[05:47] <wallyworld> i use ~juju/mariadb-k8s
[05:47] <wallyworld> well, my local copy
[05:47] <wallyworld> you will need to seed microk8s
[05:48] <wallyworld> with your locally build juju image
[05:48] <thumper> how?
[05:48] <wallyworld> make microk8s-operator-update
[05:48] <wallyworld> in the discourse post :-)
[05:48] <wallyworld> then just juju bootstrap microk8s tim
[05:49] <thumper> ack
[05:49] <thumper> will try
[05:49] <thumper> still in the middle of bootstrapping lxd for that part of the test
[05:49] <wallyworld> i hope to hear good news :-)
[05:49] <thumper> oh...
[05:49] <thumper> as noted in the description
[05:50] <thumper> I've actually properly fixed an intermittent test failure in the featuretests package
[05:50] <wallyworld> yeah, saw that, good
[05:52] <thumper> wallyworld: ah, poo, found another place I've missed since the develop merge
[05:52] <thumper> worker/uniter/actions has a place I need to thread a logger
[05:52] <wallyworld> np, i'll keep reviewing
[05:52] <thumper> I'll update and push
[05:54] <wallyworld> thumper: in caasoperator worker, why logger := loggo.GetLogger("juju.worker.uniter.charm") ? and not from config?
[05:54] <thumper> wallyworld: because we don't want the "worker.caasoperator" module
[05:55] <wallyworld> oh right ok
[05:55] <wallyworld> maybe pass in  as a second logger on the config struct?
[05:55] <wallyworld> as it's used twice
[05:56] <wallyworld> well, actuallt no
[05:56] <wallyworld> slightly different variations
[05:56] <wallyworld> so maybe not
[06:06] <thumper> wallyworld: some of this will get cleaned up when we have the caas operator using a nested dep engine
[06:06] <wallyworld> thumper: yeah, true that. lgtm with a suggestion
[06:07]  * thumper is still testing...
[06:07]  * wallyworld needs to go to vet
[06:07] <thumper> wallyworld: seems I don't have docker installed
[06:07] <thumper> where do we normally get that from
[06:07] <thumper> ?
[06:07] <thumper> wallyworld, hpidcock: ^^
[06:07] <wallyworld> i snap install docker
[06:07] <hpidcock> thumper: snap is ok
[06:07] <thumper> cheers
[06:08] <wallyworld> there might be a perms issue with /var/lib/docker something
[06:08] <thumper> why?
[06:08] <wallyworld> or /var/run/docker. can't recall
[06:08] <wallyworld> because docker
[06:08] <wallyworld> or because snap
[06:08] <hpidcock> I think you just need to add your user to the docker group
[06:08] <wallyworld> not sure
[06:08] <wallyworld> ah yeah, that rungs a bell
[06:08] <wallyworld> been a while
[06:09]  * thumper hasn't done any of that, just snap installed docker
[06:09] <wallyworld> may be ok to use it to build images
[06:10] <wallyworld> but running stuff might complain. but microk8s uses containerd now anyway
[06:10] <hpidcock> snap might have fixed the issue
[06:10] <thumper> it isn't / hasn't
[06:10] <wallyworld> hpidcock: good luck with go mod finalisation, i'll see if there's a devel update after vet :-)
[06:10] <thumper> does anyone remember how to add to groups without logging in or out?
[06:11] <hpidcock> newgrp docker will fork the shell with the new group
[06:11] <hpidcock> but
[06:11] <hpidcock> you first need to add yourself to the group
[06:11] <wallyworld> that
[06:11] <wallyworld> same as we do for lxd
[06:12] <hpidcock> usermod -a -G docker thumper
[06:12] <wallyworld> right, off to vet
[06:12] <tlm> start a new session with su thumper
[06:12] <tlm> should re load all the groups in that terminal
[06:13] <tlm> su - thumper
[06:14] <thumper> hmm... seems like the docker snap doesn't create the docker group
[06:14] <thumper> or at least doesn't put me in it
[06:16]  * thumper sighs
[06:16] <thumper> seems like the docker daemon isn't running even
[06:17] <tlm> i always install docker from their deb repo
[06:17] <tlm> but thats just me
[06:17] <thumper> snap service docker does show one running
[06:17]  * thumper sighs
[06:17] <thumper> why is this so hard?
[06:19] <kelvinliu> wallyworld: I changed the annoation to "juju.io/disable-name-prefix"
[06:20] <thumper> hpidcock: any ideas why snap docker wouldn't do its thing?
[06:20] <kelvinliu> i installed docker using apt as well
[06:21] <hpidcock> `ls -la /var/run/docker.sock`
[06:21] <hpidcock> is it using the docker group?
[06:22] <hpidcock> also check `snap services`
[06:22] <hpidcock> maybe there is a docker service there
[06:23] <hpidcock> I haven't used the snap in a while
[06:23] <thumper> that's running as root
[06:23] <thumper> /var/run/docker.sock
[06:23] <hpidcock> should be owned by root but the group should be docker
[06:24] <thumper> it's root root
[06:24] <hpidcock> eww
[06:24]  * thumper edits it
[06:26]  * thumper tries again
[06:30] <thumper> got further, but it still doesn't work
[06:32] <thumper> hpidcock: https://pastebin.ubuntu.com/p/cDnpRHhJ77/
[06:37] <tlm> thumper: are you part of the microk8s group ?
[06:38] <thumper> ??
[06:38] <thumper> maybe not
[06:38] <thumper> nope
[06:40] <tlm> see if that works
[06:40]  * thumper adds himself to the microk8s group and tries again
[06:42] <thumper> yep, that now worked
[06:43] <tlm> \o/
[06:43]  * thumper tries to deploy again
[06:43] <thumper> charmstore was still down before
[06:44] <thumper> looks like it still is
[06:44] <thumper> may come back down later
[06:44]  * thumper is past EOD
[06:44] <thumper> later peeps
[06:54] <kelvinliu> anyone free to take a look this tiny PR plz https://github.com/juju/juju/pull/11492
[07:43] <hpidcock> wallyworld: "All checks have passed"
[07:50] <wallyworld> hpidcock: so merge that mother plucker
[07:55] <hpidcock> I need popcorn
[07:56] <hpidcock> UberEats popcorn delivery to the whole team
[09:20] <babbageclunk> anyone around in here?
[09:35] <stickupkid> manadart, https://github.com/juju/juju/pull/11483
[09:35] <stickupkid> babbageclunk, hello
[09:37] <manadart> stickupkid: Tick.
[09:38] <stickupkid> manadart, Ta
[09:38] <stickupkid> manadart, tests are fun
[11:31] <manadart> stickupkid: My MicroStack QA worked for https://github.com/juju/juju/pull/11435.
[11:32] <stickupkid> manadart, was actually just looking at that PR
[11:32] <manadart> stickupkid: Quick HO?
[13:54] <stickupkid> manadart: if interface info aka network config doesn't have an origin (older api), then it should be a OriginProvider right?
[13:56] <manadart> stickupkid: Hmm, that may get us into trouble.
[13:56] <stickupkid> manadart, quick ho about it?
[20:13] <cmsanders> Audio is not working for everyone on youtube you might need to repeate the questions
[20:13] <cmsanders> whoever is talking now can't be heard