| tomwardill | cjwatson: I've had another look over the Built Using MP. I've left two (small) questions, but otherwise it looks good to me. I think I can follow the implementation and the model for it at least. | 08:34 |
|---|---|---|
| tomwardill | there is possibly/probably detail bits I'm missing, but I can't see anything broadly wrong with it | 08:35 |
| * tomwardill looks at the pile of reviews and suspects cjwatson of not sleeping again :P | 08:38 | |
| * SpecialK|Canon peers | 08:45 | |
| cjwatson | tomwardill: clarified, I hope | 09:35 |
| tomwardill | cjwatson: ah right, I remember you talking about that now | 09:36 |
| tomwardill | okay, +1 then :) | 09:36 |
| cjwatson | Thanks | 09:38 |
| tomwardill | is an exported property on distribution listing the ociprojects desirable? | 10:01 |
| tomwardill | I can't find precedence in source packages or livefs, but it seems like something that would be wanted | 10:02 |
| cjwatson | Properties are probably not great for unordered unbounded collections like that. Maybe a search method instead? | 10:20 |
| cjwatson | We want to be able to navigate down the tree, but maybe not by way of a full list | 10:21 |
| cjwatson | (searchSourcePackages exists, for instance, though it's a very old design and shouldn't necessarily be taken as unqualified precedent) | 10:22 |
| tomwardill | ah, interesting | 10:24 |
| tomwardill | it is really hard to write OCI type documents when you want to use the word 'container' outside of an actual OCI container | 14:12 |
| tomwardill | cjwatson: something that has just occured to me, is there any reason why there can only be one 'official' recipe for a project? | 14:22 |
| tomwardill | for instance, if we had a project that relied on multiple images to be produced, they could be represented as multiple 'official' recipes | 14:23 |
| cjwatson | tomwardill: well, the point of 'official' was to own a default bit of namespace | 14:42 |
| cjwatson | We could consider a different presentational name for that idea | 14:42 |
| tomwardill | ah yeah | 14:43 |
| * cjwatson finally gets built-using-domination back into shape | 16:51 | |
| cjwatson | I think that and the rest of the built-using stack are now worth reviewing again | 16:51 |
| pappacena | I'll land https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/381683, with the permission check for Distribution.oci_project_admin on OCI Project creation. It was approved a couple of days ago, and I forgot to merge it. | 18:41 |
| cjwatson | Yep, go for it. I don't always remember either ... | 19:14 |
| pappacena | Buildbot seems to be failing. Is anyone checking that? | 19:34 |
| cjwatson | pappacena: Ah, built-using-model fallout, I'll look at it, thanks | 19:37 |
| pappacena | Thanks! | 19:38 |
| cjwatson | Looks trivial | 19:38 |
| pappacena | If it's already EOD for you, I can check that | 19:38 |
| cjwatson | It's OK, will take five minutes | 19:38 |
| pappacena | Ok! :) | 19:39 |
| tomwardill | how do I add a new dependency to launchpad? | 19:39 |
| cjwatson | doc/pip.txt | 19:39 |
| tomwardill | aha | 19:40 |
| cjwatson | Some assembly required | 19:40 |
| cjwatson | pappacena: https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/382878 | 19:48 |
| * tomwardill defenestrates python https://github.com/python-poetry/poetry/issues/1975 | 19:49 | |
| * pappacena checking MP | 19:59 | |
| cjwatson | thanks | 20:05 |
| === heroux_ is now known as heroux | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!