| mup | PR snapcraft#3086 opened: repo: restore marked-install strategy for apt-cache <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3086> | 00:26 |
|---|---|---|
| mup | Issue core20#34 closed: please provide dbus-launch <Created by zyga> <Closed by xnox> <https://github.com/snapcore/core20/issue/34> | 00:26 |
| mup | PR core20#43 closed: extra-packages: add dbus-user-session for user-session dbus <Created by xnox> <Merged by xnox> <https://github.com/snapcore/core20/pull/43> | 00:26 |
| mup | PR snapd#8555 opened: bootloader/uboot: use secondary ubootenv file boot.sel for uc20 <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8555> | 03:26 |
| mborzecki | morning | 05:39 |
| mup | PR snapd#8531 closed: secboot,cmd/snap-bootstrap: add model to pcr protection profile <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8531> | 06:16 |
| mborzecki | damn wasps | 06:18 |
| mborzecki | already flying everywhere | 06:18 |
| mborzecki | errand, back in a bit | 06:37 |
| zyga | mborzecki: wasps? | 07:00 |
| zyga | szerszenie? | 07:00 |
| zyga | I wonder if I should merge master to resolve those build failures from yesterday | 07:01 |
| zyga | mborzecki: perhaps we should patch the search test to skip on release weeks? :P | 07:02 |
| mvo | centos-8 is still busted, I had no chance to look at htis yet | 07:03 |
| pstolowski | morning | 07:07 |
| pedronis | mborzecki: mvo: hi, I'm staring at #8552 and thinking what to do there | 07:09 |
| mup | PR #8552: cmd/snap-bootstrap: measure epoch and model before unlocking encrypted data <UC20> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8552> | 07:09 |
| mvo | pedronis: thank you | 07:09 |
| zyga | hey mvo, pedronis, pstolowski | 07:17 |
| mvo | good morning zyga | 07:17 |
| zyga | mvo: should I review the UC20 branches that samuele mentioned yesterday or work on the GUI for refresh? | 07:21 |
| mvo | zyga: what uc20 PR did he ask you about? if he did not ask you specifically I would say GUI is more important | 07:22 |
| pedronis | I think we are ok, most things that could land have landed | 07:22 |
| zyga | no not me | 07:22 |
| zyga | during the standup | 07:22 |
| zyga | ok, I think the gui is within reach today | 07:22 |
| pedronis | what's left atm need a bit more than reviews | 07:22 |
| zyga | assuming we can land things today | 07:23 |
| zyga | ok | 07:23 |
| pedronis | mvo: mborzecki: can we have a quick sync in 10 mins? | 07:23 |
| zyga | I need a review for the GUI front-end https://github.com/snapcore/snapd/pull/7700 | 07:24 |
| mup | PR #7700: many: wait while inhibition file is present <Created by zyga> <https://github.com/snapcore/snapd/pull/7700> | 07:24 |
| zyga | I will work on the glue logic now | 07:24 |
| mvo | pedronis: I don't think mborzecki is around just then | 07:30 |
| mvo | mborzecki: but I can be there if you want | 07:30 |
| pedronis | mvo: ok, let's do one quick and we might need one with him later though. I want to bounce some ideas before I go off on a tangent | 07:32 |
| mvo | pedronis: but I can be there if you want, just need 1min | 07:32 |
| mvo | pedronis: ok, let me just push this one PR and I'm there (1min) | 07:32 |
| zyga | mvo: he said he's out on an errand | 07:32 |
| mup | PR snapd#8556 opened: tests: ensure $cache_dir is actually available <Created by mvo5> <https://github.com/snapcore/snapd/pull/8556> | 07:33 |
| pedronis | mvo: I'm in the standup HO | 07:34 |
| mborzecki | re | 08:39 |
| mborzecki | i'll grab a coffe and back to work | 08:40 |
| zyga | installing windows is slow, snaps are faster ;-) (this is a joke with extra meanings) | 08:40 |
| mborzecki | pedronis: sync in 5-10? | 08:42 |
| pedronis | mborzecki: yes | 08:43 |
| mborzecki | pedronis: mvo: i'm in the standup HO | 08:52 |
| pedronis | omw | 08:52 |
| ijohnson | Good morning folks | 10:06 |
| zyga | hey ian :) | 10:08 |
| ijohnson | Hey zyga | 10:10 |
| pedronis | mvo: btw, the refactoring is goinf well, but we have a ton of those MockOsutilIsMounted | 10:12 |
| mvo | pedronis: could we make it part of the suite setup? | 10:13 |
| pedronis | not really | 10:13 |
| mvo | pedronis: but I'm in a meeting right now so might be a bit slow to reply | 10:13 |
| pedronis | just saying it takes a while to refactor | 10:13 |
| mvo | pedronis: +1 | 10:22 |
| mup | PR snapd#8556 closed: tests: ensure $cache_dir is actually available <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8556> | 10:52 |
| mup | PR snapd#8557 opened: c/snap-bootstrap: have a small struct for checking mount states <Created by pedronis> <https://github.com/snapcore/snapd/pull/8557> | 11:23 |
| pedronis | mvo: mborzecki: done ^ | 11:24 |
| zyga | afk, small child invasion | 11:39 |
| mup | PR snapd#8550 closed: ubootenv, uboot: support new uc20 style text bootenv <UC20> <⛔ Blocked> <Created by anonymouse64> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8550> | 11:41 |
| zyga | mborzecki: now my vendor.json does change | 11:52 |
| zyga | weird | 11:52 |
| mborzecki | zyga: govendor --version? | 11:52 |
| zyga | 1.0.9 | 11:52 |
| zyga | the changes I see are on secboot and sys/unix | 11:53 |
| mborzecki | master was updated with a PR from claudio, and vendor.json changed | 11:53 |
| mborzecki | zyga: checksum? | 11:53 |
| zyga | es | 11:53 |
| zyga | yes | 11:53 |
| mborzecki | hm maybe cmatsuoka had a differetn govendor version? | 11:53 |
| mborzecki | idk, way over my head :P | 11:53 |
| mvo | pedronis: thank you | 11:58 |
| zyga | is master broken, is should I hold with any new PRs/ | 11:58 |
| mborzecki | xerrors.Is() is kinda silly with os.PathError or i'm doing something wrong here | 11:59 |
| mborzecki | cmatsuoka: what's you `govendor --version` ? | 12:00 |
| zyga | mborzecki: what are you doing with path error? | 12:04 |
| zyga | maybe you pass some syscall result? | 12:04 |
| mborzecki | zyga: maybe i'm doing/reading it wrong, but xerrors.Is(err, &PathError{}) compares whether *(err(*os.PathError)) == *(&PathError{}) | 12:11 |
| mborzecki | zyga: while i really want to know wetherh os.PathError is wrapped somewhere in the error stack | 12:11 |
| zyga | hmmm | 12:13 |
| zyga | just looking at it quickly | 12:13 |
| zyga | either err is really PathError | 12:13 |
| zyga | or you need to provide Unwrap | 12:13 |
| pedronis | mborzecki: xerrors cannot really do it's job if the go stdlib isn't collaborating | 12:13 |
| zyga | to look deeper into err | 12:13 |
| pedronis | mborzecki: it gives you some of the future, but if go itself is too old some things won't work | 12:14 |
| pedronis | I think | 12:14 |
| zyga | mborzecki: you could manually repackage an error you get from somewhere | 12:15 |
| zyga | into something that implements the Wrapper interface | 12:15 |
| pedronis | though Chris has given Unwrap to some stuff | 12:15 |
| zyga | then you could have "nice" properties from that point on | 12:15 |
| pedronis | or maybe only something else I need to check | 12:15 |
| zyga | but it's some extra work in a specific ase | 12:15 |
| zyga | *case | 12:15 |
| pedronis | there are different orthogonal things you can provided | 12:15 |
| pedronis | for Is vs As | 12:15 |
| mborzecki | pedronis: yeah, As seems to work for now | 12:16 |
| cmatsuoka | mborzecki: hmm, 1.0.8. Too old? | 12:23 |
| mborzecki | cmatsuoka: looks like it's generating a different checksum that 1.0.9 does | 12:23 |
| * cmatsuoka updates | 12:23 | |
| cmatsuoka | mborzecki: are you using the edge snap? | 12:24 |
| mborzecki | cmatsuoka: the edge snap? | 12:24 |
| mborzecki | of govendor? | 12:24 |
| cmatsuoka | I was using stable, switched to edge now | 12:24 |
| mborzecki | cmatsuoka: idk, i go get'ed it | 12:25 |
| zyga | oh there's a snap for that? | 12:25 |
| cmatsuoka | mborzecki: I don't mind using any version but we should agree on a standard one | 12:25 |
| pedronis | well it's archived | 12:26 |
| pedronis | we should use the latest | 12:26 |
| pedronis | available | 12:26 |
| pedronis | and switch to modules when possible | 12:26 |
| cmatsuoka | ok, I switched to 1.0.9 from the archive | 12:28 |
| mup | PR snapcraft#3087 opened: meta: remove snapd workaround for classic for core20 onwards <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3087> | 12:39 |
| mup | PR snapd#8558 opened: tests: make the nested library usable independently of spread <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8558> | 13:09 |
| ijohnson | mborzecki: so the issue with the /run/mnt/data PR is that it hangs after booting run mode in the initrd? | 13:32 |
| ijohnson | mborzecki: should I just give it a try and see what falls out?> | 13:32 |
| mborzecki | ijohnson: sure, go ahead and play with it | 13:38 |
| mborzecki | ijohnson: i've merged master there this morning, so it shoudl be fairly up to date | 13:38 |
| ijohnson | okay thanks mborzecki I'll let you know how it goes | 13:39 |
| mborzecki | ijohnson: cool, thanks! | 13:40 |
| mup | PR snapd#8424 closed: cmd/snap-bootstrap/initramfs-mounts: cross-check partitions when mounting <UC20> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/8424> | 13:45 |
| mborzecki | hmm looks like there's a problem during reboot with the measurement PR on uc20 | 13:52 |
| mborzecki | but pc-kernel & snapd snaps repacked with snap-bootstrap still work, wth? | 13:55 |
| pedronis | mborzecki: are they using the right version? | 14:04 |
| ijohnson | mborzecki: did it ask you to enter a recovery key ? | 14:05 |
| mborzecki | ijohnson: pstolowski: the nodes hang on reboot for some reason, i'm tying to download the image and check it locally | 14:06 |
| pedronis | we don't have tests that encrypt | 14:07 |
| pedronis | there's might be a tpm though and things explode | 14:07 |
| mborzecki | pedronis: yeah we have /dev/tpm0 in gcp | 14:14 |
| pedronis | mborzecki: maybe write a small bit of code that does the two measurements and see how it fails there | 14:16 |
| mborzecki | hm somewhat unsuprisingly, the image i downloaded works locally | 14:54 |
| pedronis | mborzecki: given the changes in your PR, I expect you need to try the same stuff on gce | 14:55 |
| cmatsuoka | mborzecki: definitely something wrong in the image I created from current 8552, will debug/bisect after lunch to see what's happening | 14:56 |
| mborzecki | cmatsuoka: where does it hang? | 14:56 |
| cmatsuoka | mborzecki: somewhere inside the-tool | 14:57 |
| mborzecki | meh :/ | 14:57 |
| mborzecki | cmatsuoka: is there a write up of what i need to try the emulated tpm with qemu locally? | 14:57 |
| pedronis | mborzecki: the difference with the previous code is that you don't ignore all connect error no? | 14:58 |
| pedronis | mborzecki: maybe you can revert to that but log the error somewhere that stays | 14:59 |
| cmatsuoka | mborzecki: I think we don't have it documented, but this is the script I use: https://pastebin.ubuntu.com/p/Nd9642FkgR/ | 14:59 |
| cmatsuoka | will be back after lunch | 15:00 |
| mborzecki | cmatsuoka: thanks, i'll try that | 15:00 |
| cmatsuoka | mborzecki: you won't need the -serial stdio, I added it to debug things recently but it's not needed anymore | 15:00 |
| pstolowski | fwtw i still have no luck running basic test on master. running for over 25 minutes (a few ssh attempts so far). no sure if this is the same problem? | 15:02 |
| pstolowski | (i mean core20/basic) | 15:03 |
| mborzecki | fwiw the split out bit that measures epoch and model does not return any errors when i run it manually | 15:09 |
| mborzecki | and it's definitely touching /dev/tpm0 | 15:09 |
| pedronis | mborzecki: on gce ? | 15:15 |
| mborzecki | pedronis: yes, i'm calling this basically https://paste.ubuntu.com/p/DWrPSgDqR4/ | 15:15 |
| pedronis | and it makes the stamps? | 15:16 |
| mborzecki | pedronis: yup, i'm looking at strace too, quite some traffic on the fd that /dev/tpm0 was opened with | 15:16 |
| pedronis | ok, so maybe the tpm stuff is not the issue and is some other change? | 15:17 |
| mborzecki | uhh and can't installs swtpm-mvo snap, because the store times out | 15:18 |
| mborzecki | ha ok, i see a bug now | 15:22 |
| mup | PR snapcraft#3088 opened: repo: add interface to get packages from base <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3088> | 15:24 |
| pedronis | I made some comments on the PR, let me know what the bug is | 15:27 |
| ijohnson | mborzecki: do you think you might be able to review #8555 before you EOD? | 15:28 |
| mup | PR #8555: bootloader/uboot: use secondary ubootenv file boot.sel for uc20 <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8555> | 15:28 |
| mborzecki | pedronis: i'm using incorrect path to recovery system model, ubuntu-seed/<label>/model instead of ubuntu-seed/systems/<label>/model | 15:29 |
| pedronis | mborzecki: ah | 15:29 |
| pedronis | mborzecki: you don't need to do that at all | 15:29 |
| pedronis | we have the model | 15:29 |
| pedronis | sorry, I should have spotted this | 15:30 |
| mborzecki | np | 15:30 |
| mborzecki | ah right, we open the seed, but it's a bit later than the measurements are done | 15:31 |
| pedronis | mborzecki: yea, the code optitmized this away | 15:31 |
| pedronis | but we can change it | 15:31 |
| mborzecki | i'll leave a note | 15:32 |
| pedronis | mborzecki: when is your eod? | 15:32 |
| mborzecki | 6-7 probably | 15:32 |
| pedronis | mborzecki: can you try a quick fix? | 15:33 |
| pedronis | then I can take care of fixing the PR | 15:33 |
| mborzecki | pedronis: yeah, i'm working on it right now | 15:33 |
| mborzecki | wow, measuring the model takes a while | 15:40 |
| mvo | cachio: the nightly sbuild test with master should work now | 15:51 |
| mup | PR snapd#8554 closed: packaging: add "$TAGS" to dh_auto_test for debian packaging <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8554> | 15:52 |
| mborzecki | mvo: pedronis: cmatsuoka: i've updated https://github.com/snapcore/snapd/pull/8552 | 15:56 |
| mup | PR #8552: cmd/snap-bootstrap: measure epoch and model before unlocking encrypted data <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8552> | 15:56 |
| mborzecki | need a review from too | 15:56 |
| mborzecki | from chris too ofc | 15:57 |
| mborzecki | gh is down again? | 15:59 |
| ijohnson | mborzecki: not down for me | 15:59 |
| mborzecki | my git push origin was stuck | 15:59 |
| mborzecki | well, C-c and it isn't now :P | 15:59 |
| cachio | mvo, nice, I'll run it again | 16:01 |
| cachio | mvo, thanks!! | 16:01 |
| mvo | mborzecki: thanks for this update | 16:01 |
| cmatsuoka | mborzecki: running a test in the updated branch | 16:01 |
| pedronis | mborzecki: thanks, I will look at it and see if it makes sense to apply other small tweaks but maybe best to land it and do a follow up | 16:02 |
| mborzecki | argghh store hiccups | 16:03 |
| mborzecki | - Download snap "go" (5551) from channel "latest/edge" (received an unexpected http response code (502) when trying to download https://canonical-lcy01.cdn.snapcraft.io/download-origin/canonical-lgw01/Md1HBASHzP4i0bniScAjXGnOII9cEK6e_5551.snap?interactive=1&token=1587758400_1ca872f971102f9a91dd0bf85533f334a428a91a) | 16:03 |
| mborzecki | omg, shellcheck snap install failed too | 16:03 |
| mborzecki | looks like it will be a wasted run :/ | 16:04 |
| pedronis | yes, lots of errors | 16:05 |
| pedronis | I also was running something locally and it died for unexpected store errors | 16:05 |
| mborzecki | https://status.snapcraft.io/ hm refresh endpoint down? | 16:07 |
| cmatsuoka | mborzecki: current 8552 booted correctly to console-conf in run mode | 16:07 |
| mborzecki | cmatsuoka: yup, same here :P | 16:08 |
| mborzecki | cmatsuoka: i guess you ahve the setup for secureboot, can you try and modify the `ubuntu-boot/model` file and reboot? | 16:09 |
| cmatsuoka | mborzecki: sure, trying that | 16:10 |
| cmatsuoka | mborzecki: changing an irrelevant field does nothing as expected, changing a relevant field makes the-tool to fail and the boot process is halted | 16:15 |
| mborzecki | cmatsuoka: cool, thanks for checking! | 16:16 |
| cmatsuoka | mborzecki: should we ask for the recovery key at this point, like we do if other things fail? | 16:16 |
| mborzecki | cmatsuoka: if it's run mode, we should reboot to recovery (?) | 16:17 |
| cmatsuoka | mborzecki: this was the final state: https://pasteboard.co/J5ju6fG.png | 16:18 |
| mvo | pedronis: are you ok with me merging 8414 even though there is a comment from jamie that we may need to address later? | 16:19 |
| cmatsuoka | mborzecki: could be, I think it's only a matter of user experience in case of this kind of failure | 16:19 |
| mborzecki | cmatsuoka: yup, i think we should try to address it for 1.0 somehow | 16:20 |
| pedronis | mvo: yes | 16:20 |
| mvo | pedronis: thanks, will wait for spread and then go ahead | 16:21 |
| pedronis | as I said I have plan if people want really the other behavior | 16:21 |
| mvo | :+1: | 16:21 |
| * mvo breaks while waiting for spread | 16:21 | |
| pedronis | so #8552 is missing some tests, because now we masure things in many more scenarios | 16:25 |
| mup | PR #8552: cmd/snap-bootstrap: measure epoch and model before unlocking encrypted data <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8552> | 16:25 |
| pedronis | not a blocker but I would prefer to add them before we forget | 16:25 |
| cmatsuoka | mborzecki: I regenerated an image and now install mode failed, it might not be completely stable | 16:39 |
| cmatsuoka | mborzecki: again it blocked in the-tool | 16:40 |
| mborzecki | cmatsuoka: got log? | 16:40 |
| mborzecki | pedronis: pushed some unit tests for install/recover mode measurements | 16:40 |
| cmatsuoka | mborzecki: so it spent a lot of time there, and then it continued to install, which is quite odd | 16:40 |
| mborzecki | pedronis: and it caught a typo you noticed | 16:41 |
| pedronis | mborzecki: thanks | 16:41 |
| cmatsuoka | mborzecki: it looks like something in timing out there | 16:41 |
| cmatsuoka | s/in/is/ | 16:41 |
| mborzecki | cmatsuoka: yes, i saw that too, it's like it's stuck for a little while doing measurements or mounts, and then it proceeds just fine | 16:41 |
| cmatsuoka | ah ok | 16:41 |
| pedronis | is opening the tpm slow? | 16:42 |
| pedronis | maybe it needs entropy? | 16:42 |
| pedronis | if it's slow and needs entropy maybe we should try to open it only once | 16:42 |
| pedronis | (just guessing here) | 16:42 |
| pedronis | I suppose somebody should run that script you made on gce and measure where time goes | 16:43 |
| pedronis | and strace | 16:43 |
| cmatsuoka | it's strange because even if it needs entropy qemu is getting it from the host system | 16:44 |
| cmatsuoka | which should have plenty | 16:44 |
| cmatsuoka | so now it opens tpm earlier, but it's only for measurements and then it keeps an external state to do it only once, right? | 16:46 |
| cmatsuoka | because in maciek's original code it also opened tpm for measurements, but I didn't see any timeout in multiple test runs | 16:46 |
| pedronis | it current code opens the tpm multiple times | 16:50 |
| cmatsuoka | ah I see | 16:50 |
| pedronis | that's why it would be interesting to measure where the time goes | 16:50 |
| pedronis | mborzecki played with this earlier: https://paste.ubuntu.com/p/DWrPSgDqR4/ | 16:51 |
| mborzecki | i'm off ot pick up a package, back in 30 or so in case there's anything urgent | 17:01 |
| cmatsuoka | mborzecki: ack | 17:05 |
| mup | PR snapcraft#3087 closed: meta: remove snapd workaround for classic for core20 onwards <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3087> | 17:16 |
| === ijohnson is now known as ijohnson|lunch | ||
| mborzecki | https://status.snapcraft.io/ snap downloads is down :( | 17:40 |
| noise][ | mborzecki: we are fighting to keep up with a massive increase in downloads from the release | 17:43 |
| mborzecki | noise][: thanks for the info, figured as much :) | 17:44 |
| noise][ | 3x normal volume in some cases today, even with some throttling in place :/ | 17:45 |
| mborzecki | does the mouse cursor still look different in certain snaps like chromium? | 18:01 |
| mup | PR pc-amd64-gadget#44 opened: grub-recovery.conf: don't make run mode default just because ubuntu-boot exists <Created by anonymouse64> <https://github.com/snapcore/pc-amd64-gadget/pull/44> | 18:03 |
| === ijohnson|lunch is now known as ijohnson | ||
| mup | PR snapcraft#3088 closed: repo: add interface to get packages from base <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3088> | 19:22 |
| mup | PR snapd#8555 closed: bootloader/uboot: use secondary ubootenv file boot.sel for uc20 <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8555> | 19:32 |
| ijohnson | \o/ | 19:32 |
| mup | PR snapd#8559 opened: boot, bootloader: adjust comments, expand tests <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8559> | 19:54 |
| mup | PR snapd#8560 opened: tests: disable "searching" test <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/8560> | 21:49 |
| zyga | ijohnson: ^ if around | 21:49 |
| zyga | I also CCd jdstrand | 21:50 |
| ijohnson | zyga: looking now | 21:55 |
| zyga | ijohnson: I think we need that to make any progress without mvo's overrides | 22:05 |
| ijohnson | zyga: approved, sorry got distracted reviewing uc20 things | 22:06 |
| ijohnson | zyga: I'll merge later when tests are done and I can open a followup re-enabling it, thanks for this | 22:06 |
| zyga | thanks | 22:11 |
| zyga | eh opensuse needs fixes | 22:19 |
| zyga | pkgconf-pkg-config instead of pkg-config | 22:19 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
