/srv/irclogs.ubuntu.com/2020/04/24/#snappy.txt

mupPR snapcraft#3086 opened: repo: restore marked-install strategy for apt-cache <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3086>00:26
mupIssue core20#34 closed: please provide dbus-launch <Created by zyga> <Closed by xnox> <https://github.com/snapcore/core20/issue/34>00:26
mupPR core20#43 closed: extra-packages: add dbus-user-session for user-session dbus <Created by xnox> <Merged by xnox> <https://github.com/snapcore/core20/pull/43>00:26
mupPR snapd#8555 opened: bootloader/uboot: use secondary ubootenv file boot.sel for uc20 <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8555>03:26
mborzeckimorning05:39
mupPR snapd#8531 closed: secboot,cmd/snap-bootstrap: add model to pcr protection profile <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8531>06:16
mborzeckidamn wasps06:18
mborzeckialready flying everywhere06:18
mborzeckierrand, back in a bit06:37
zygamborzecki: wasps?07:00
zygaszerszenie?07:00
zygaI wonder if I should merge master to resolve those build failures from yesterday07:01
zygamborzecki: perhaps we should patch the search test to skip on release weeks? :P07:02
mvocentos-8 is still busted, I had no chance to look at htis yet07:03
pstolowskimorning07:07
pedronismborzecki: mvo: hi, I'm staring at #8552 and thinking what to do there07:09
mupPR #8552: cmd/snap-bootstrap: measure epoch and model before unlocking encrypted data <UC20> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8552>07:09
mvopedronis: thank you07:09
zygahey mvo, pedronis, pstolowski07:17
mvogood morning zyga07:17
zygamvo: should I review the UC20 branches that samuele mentioned yesterday or work on the GUI for refresh?07:21
mvozyga: what uc20 PR did he ask you about? if he did not ask you specifically I would say GUI is more important07:22
pedronisI think we are ok, most things that could land have landed07:22
zygano not me07:22
zygaduring the standup07:22
zygaok, I think the gui is within reach today07:22
pedroniswhat's left atm need a bit more than reviews07:22
zygaassuming we can land things today07:23
zygaok07:23
pedronismvo: mborzecki: can we have a quick sync in 10 mins?07:23
zygaI need a review for the GUI front-end https://github.com/snapcore/snapd/pull/770007:24
mupPR #7700: many: wait while inhibition file is present <Created by zyga> <https://github.com/snapcore/snapd/pull/7700>07:24
zygaI will work on the glue logic now07:24
mvopedronis: I don't think mborzecki is around just then07:30
mvomborzecki: but I can be there if you want07:30
pedronismvo: ok, let's do one quick and we might need one with him later though. I want to bounce some ideas before I go off on a tangent07:32
mvopedronis:  but I can be there if you want, just need 1min07:32
mvopedronis: ok, let me just push this one PR and I'm there (1min)07:32
zygamvo: he said he's out on an errand07:32
mupPR snapd#8556 opened: tests: ensure $cache_dir is actually available <Created by mvo5> <https://github.com/snapcore/snapd/pull/8556>07:33
pedronismvo: I'm in the standup HO07:34
mborzeckire08:39
mborzeckii'll grab a coffe and back to work08:40
zygainstalling windows is slow, snaps are faster ;-) (this is a joke with extra meanings)08:40
mborzeckipedronis: sync in 5-10?08:42
pedronismborzecki: yes08:43
mborzeckipedronis: mvo: i'm in the standup HO08:52
pedronisomw08:52
ijohnsonGood morning folks10:06
zygahey ian :)10:08
ijohnsonHey zyga10:10
pedronismvo: btw, the refactoring is goinf well, but we have a ton of those MockOsutilIsMounted10:12
mvopedronis: could we make it part of the suite setup?10:13
pedronisnot really10:13
mvopedronis: but I'm in a meeting right now so might be a bit slow to reply10:13
pedronisjust saying it takes a while to refactor10:13
mvopedronis: +110:22
mupPR snapd#8556 closed: tests: ensure $cache_dir is actually available <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8556>10:52
mupPR snapd#8557 opened: c/snap-bootstrap: have a small struct for checking mount states <Created by pedronis> <https://github.com/snapcore/snapd/pull/8557>11:23
pedronismvo: mborzecki: done ^11:24
zygaafk, small child invasion11:39
mupPR snapd#8550 closed: ubootenv, uboot: support new uc20 style text bootenv <UC20> <⛔ Blocked> <Created by anonymouse64> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8550>11:41
zygamborzecki: now my vendor.json does change11:52
zygaweird11:52
mborzeckizyga: govendor --version?11:52
zyga1.0.911:52
zygathe changes I see are on secboot and sys/unix11:53
mborzeckimaster was updated with a PR from claudio, and vendor.json changed11:53
mborzeckizyga: checksum?11:53
zygaes11:53
zygayes11:53
mborzeckihm maybe cmatsuoka had a differetn govendor version?11:53
mborzeckiidk, way over my head :P11:53
mvopedronis: thank you11:58
zygais master broken, is should I hold with any new PRs/11:58
mborzeckixerrors.Is() is kinda silly with os.PathError or i'm doing something wrong here11:59
mborzeckicmatsuoka: what's you `govendor --version` ?12:00
zygamborzecki: what are you doing with path error?12:04
zygamaybe you pass some syscall result?12:04
mborzeckizyga: maybe i'm doing/reading it wrong, but xerrors.Is(err, &PathError{}) compares whether *(err(*os.PathError)) == *(&PathError{})12:11
mborzeckizyga: while i really want to know wetherh os.PathError is wrapped somewhere in the error stack12:11
zygahmmm12:13
zygajust looking at it quickly12:13
zygaeither err is really PathError12:13
zygaor you need to provide Unwrap12:13
pedronismborzecki: xerrors cannot really do it's job if the go stdlib isn't collaborating12:13
zygato look deeper into err12:13
pedronismborzecki: it gives you some of the future, but if go itself is too old some things won't work12:14
pedronisI think12:14
zygamborzecki: you could manually repackage an error you get from somewhere12:15
zygainto something that implements the Wrapper interface12:15
pedronisthough Chris has given Unwrap to some stuff12:15
zygathen you could have "nice" properties from that point on12:15
pedronisor maybe only something else I need to check12:15
zygabut it's some extra work in a specific ase12:15
zyga*case12:15
pedronisthere are different orthogonal things you can provided12:15
pedronisfor Is vs As12:15
mborzeckipedronis: yeah, As seems to work for now12:16
cmatsuokamborzecki: hmm, 1.0.8. Too old?12:23
mborzeckicmatsuoka: looks like it's generating a different checksum that 1.0.9 does12:23
* cmatsuoka updates12:23
cmatsuokamborzecki: are you using the edge snap?12:24
mborzeckicmatsuoka: the edge snap?12:24
mborzeckiof govendor?12:24
cmatsuokaI was using stable, switched to edge now12:24
mborzeckicmatsuoka: idk, i go get'ed it12:25
zygaoh there's a snap for that?12:25
cmatsuokamborzecki: I don't mind using any version but we should agree on a standard one12:25
pedroniswell it's archived12:26
pedroniswe should use the latest12:26
pedronisavailable12:26
pedronisand switch to modules when possible12:26
cmatsuokaok, I switched to 1.0.9 from the archive12:28
mupPR snapcraft#3087 opened: meta: remove snapd workaround for classic for core20 onwards <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3087>12:39
mupPR snapd#8558 opened: tests: make the nested library usable independently of spread <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8558>13:09
ijohnsonmborzecki: so the issue with the /run/mnt/data PR is that it hangs after booting run mode in the initrd?13:32
ijohnsonmborzecki: should I just give it a try and see what falls out?>13:32
mborzeckiijohnson: sure, go ahead and play with it13:38
mborzeckiijohnson: i've merged master there this morning, so it shoudl be fairly up to date13:38
ijohnsonokay thanks mborzecki I'll let you know how it goes13:39
mborzeckiijohnson: cool, thanks!13:40
mupPR snapd#8424 closed: cmd/snap-bootstrap/initramfs-mounts: cross-check partitions when mounting <UC20> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/8424>13:45
mborzeckihmm looks like there's a problem during reboot with the measurement PR on uc2013:52
mborzeckibut pc-kernel & snapd snaps repacked with snap-bootstrap still work, wth?13:55
pedronismborzecki: are they using the right version?14:04
ijohnsonmborzecki: did it ask you to enter a recovery key ?14:05
mborzeckiijohnson: pstolowski: the nodes hang on reboot for some reason, i'm tying to download the image and check it locally14:06
pedroniswe don't have tests that encrypt14:07
pedronisthere's might be a tpm though and things explode14:07
mborzeckipedronis: yeah we have /dev/tpm0 in gcp14:14
pedronismborzecki: maybe write a small bit of code that does the two measurements and see how it fails there14:16
mborzeckihm somewhat unsuprisingly, the image i downloaded works locally14:54
pedronismborzecki: given the changes in your PR, I expect you need to try the same stuff on gce14:55
cmatsuokamborzecki: definitely something wrong in the image I created from current 8552, will debug/bisect after lunch to see what's happening14:56
mborzeckicmatsuoka: where does it hang?14:56
cmatsuokamborzecki: somewhere inside the-tool14:57
mborzeckimeh :/14:57
mborzeckicmatsuoka: is there a write up of what i need to try the emulated tpm with qemu locally?14:57
pedronismborzecki: the difference with the previous code is that you don't ignore all connect error no?14:58
pedronismborzecki: maybe you can revert to that but log the error somewhere that stays14:59
cmatsuokamborzecki: I think we don't have it documented, but this is the script I use: https://pastebin.ubuntu.com/p/Nd9642FkgR/14:59
cmatsuokawill be back after lunch15:00
mborzeckicmatsuoka: thanks, i'll try that15:00
cmatsuokamborzecki: you won't need the -serial stdio, I added it to debug things recently but it's not needed anymore15:00
pstolowskifwtw i still have no luck running basic test on master. running for over 25 minutes (a few ssh attempts so far). no sure if this is the same problem?15:02
pstolowski(i mean core20/basic)15:03
mborzeckifwiw the split out bit that measures epoch and model does not return any errors when i run it manually15:09
mborzeckiand it's definitely touching /dev/tpm015:09
pedronismborzecki: on gce ?15:15
mborzeckipedronis: yes, i'm calling this basically https://paste.ubuntu.com/p/DWrPSgDqR4/15:15
pedronisand it makes the stamps?15:16
mborzeckipedronis: yup, i'm looking at strace too, quite some traffic on the fd that /dev/tpm0 was opened with15:16
pedronisok, so maybe the tpm stuff is not the issue and is some other change?15:17
mborzeckiuhh and can't installs swtpm-mvo snap, because the store times out15:18
mborzeckiha ok, i see a bug now15:22
mupPR snapcraft#3088 opened: repo: add interface to get packages from base <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3088>15:24
pedronisI made some comments on the PR, let me know what the bug is15:27
ijohnsonmborzecki: do you think you might be able to review #8555 before you EOD?15:28
mupPR #8555: bootloader/uboot: use secondary ubootenv file boot.sel for uc20 <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8555>15:28
mborzeckipedronis: i'm using incorrect path to recovery system model, ubuntu-seed/<label>/model instead of ubuntu-seed/systems/<label>/model15:29
pedronismborzecki: ah15:29
pedronismborzecki: you don't need to do that at all15:29
pedroniswe have the model15:29
pedronissorry, I should have spotted this15:30
mborzeckinp15:30
mborzeckiah right, we open the seed, but it's a bit later than the measurements are done15:31
pedronismborzecki: yea, the code optitmized this away15:31
pedronisbut we can change it15:31
mborzeckii'll leave a note15:32
pedronismborzecki: when is your eod?15:32
mborzecki6-7 probably15:32
pedronismborzecki: can you try a quick fix?15:33
pedronisthen I can take care of fixing the PR15:33
mborzeckipedronis: yeah, i'm working on it right now15:33
mborzeckiwow, measuring the model takes a while15:40
mvocachio: the nightly sbuild test with master should work now15:51
mupPR snapd#8554 closed: packaging: add "$TAGS" to dh_auto_test for debian packaging <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8554>15:52
mborzeckimvo: pedronis: cmatsuoka: i've updated https://github.com/snapcore/snapd/pull/855215:56
mupPR #8552: cmd/snap-bootstrap: measure epoch and model before unlocking encrypted data <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8552>15:56
mborzeckineed a review from too15:56
mborzeckifrom chris too ofc15:57
mborzeckigh is down again?15:59
ijohnsonmborzecki: not down for me15:59
mborzeckimy git push origin was stuck15:59
mborzeckiwell, C-c and it isn't now :P15:59
cachiomvo, nice, I'll run it again16:01
cachiomvo, thanks!!16:01
mvomborzecki: thanks for this update16:01
cmatsuokamborzecki: running a test in the updated branch16:01
pedronismborzecki: thanks, I will look at it and see if it makes sense to apply other small tweaks but maybe best to land it and do a follow up16:02
mborzeckiargghh store hiccups16:03
mborzecki- Download snap "go" (5551) from channel "latest/edge" (received an unexpected http response code (502) when trying to download https://canonical-lcy01.cdn.snapcraft.io/download-origin/canonical-lgw01/Md1HBASHzP4i0bniScAjXGnOII9cEK6e_5551.snap?interactive=1&token=1587758400_1ca872f971102f9a91dd0bf85533f334a428a91a)16:03
mborzeckiomg, shellcheck snap install failed too16:03
mborzeckilooks like it will be a wasted run :/16:04
pedronisyes, lots of errors16:05
pedronisI also was running something locally and it died for unexpected store errors16:05
mborzeckihttps://status.snapcraft.io/ hm refresh endpoint down?16:07
cmatsuokamborzecki: current 8552 booted correctly to console-conf in run mode16:07
mborzeckicmatsuoka: yup, same here :P16:08
mborzeckicmatsuoka: i guess you ahve the setup for secureboot, can you try and modify the `ubuntu-boot/model` file and reboot?16:09
cmatsuokamborzecki: sure, trying that16:10
cmatsuokamborzecki: changing an irrelevant field does nothing as expected, changing a relevant field makes the-tool to fail and the boot process is halted16:15
mborzeckicmatsuoka: cool, thanks for checking!16:16
cmatsuokamborzecki: should we ask for the recovery key at this point, like we do if other things fail?16:16
mborzeckicmatsuoka: if it's run mode, we should reboot to recovery (?)16:17
cmatsuokamborzecki: this was the final state: https://pasteboard.co/J5ju6fG.png16:18
mvopedronis: are you ok with me merging 8414 even though there is a comment from jamie that we may need to address later?16:19
cmatsuokamborzecki: could be, I think it's only a matter of user experience in case of this kind of failure16:19
mborzeckicmatsuoka: yup, i think we should try to address it for 1.0 somehow16:20
pedronismvo: yes16:20
mvopedronis: thanks, will wait for spread and then go ahead16:21
pedronisas I said I have plan if people want really the other behavior16:21
mvo:+1:16:21
* mvo breaks while waiting for spread16:21
pedronisso #8552 is missing some tests, because now we masure things in many more scenarios16:25
mupPR #8552: cmd/snap-bootstrap: measure epoch and model before unlocking encrypted data <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8552>16:25
pedronisnot a blocker but I would prefer to add them before we forget16:25
cmatsuokamborzecki: I regenerated an image and now install mode failed, it might not be completely stable16:39
cmatsuokamborzecki: again it blocked in the-tool16:40
mborzeckicmatsuoka: got log?16:40
mborzeckipedronis: pushed some unit tests for install/recover mode measurements16:40
cmatsuokamborzecki: so it spent a lot of time there, and then it continued to install, which is quite odd16:40
mborzeckipedronis: and it caught a typo you noticed16:41
pedronismborzecki: thanks16:41
cmatsuokamborzecki: it looks like something in timing out there16:41
cmatsuokas/in/is/16:41
mborzeckicmatsuoka: yes, i saw that too, it's like it's stuck for a little while doing measurements or mounts, and then it proceeds just fine16:41
cmatsuokaah ok16:41
pedronisis opening the tpm slow?16:42
pedronismaybe it needs entropy?16:42
pedronisif it's slow and needs entropy maybe we should try to open it only once16:42
pedronis(just guessing here)16:42
pedronisI suppose somebody should run that script you made on gce and measure where time goes16:43
pedronisand strace16:43
cmatsuokait's strange because even if it needs entropy qemu is getting it from the host system16:44
cmatsuokawhich should have plenty16:44
cmatsuokaso now it opens tpm earlier, but it's only for measurements and then it keeps an external state to do it only once, right?16:46
cmatsuokabecause in maciek's original code it also opened tpm for measurements, but I didn't see any timeout in multiple test runs16:46
pedronisit current code opens the tpm multiple times16:50
cmatsuokaah I see16:50
pedronisthat's why it would be interesting to measure where the time goes16:50
pedronismborzecki played with this earlier: https://paste.ubuntu.com/p/DWrPSgDqR4/16:51
mborzeckii'm off ot pick up a package, back in 30 or so in case there's anything urgent17:01
cmatsuokamborzecki: ack17:05
mupPR snapcraft#3087 closed: meta: remove snapd workaround for classic for core20 onwards <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3087>17:16
=== ijohnson is now known as ijohnson|lunch
mborzeckihttps://status.snapcraft.io/  snap downloads is down :(17:40
noise][mborzecki: we are fighting to keep up with a massive increase in downloads from the release17:43
mborzeckinoise][: thanks for the info, figured as much :)17:44
noise][3x normal volume in some cases today, even with some throttling in place :/17:45
mborzeckidoes the mouse cursor still look different in certain snaps like chromium?18:01
mupPR pc-amd64-gadget#44 opened: grub-recovery.conf: don't make run mode default just because ubuntu-boot exists <Created by anonymouse64> <https://github.com/snapcore/pc-amd64-gadget/pull/44>18:03
=== ijohnson|lunch is now known as ijohnson
mupPR snapcraft#3088 closed: repo: add interface to get packages from base <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3088>19:22
mupPR snapd#8555 closed: bootloader/uboot: use secondary ubootenv file boot.sel for uc20 <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8555>19:32
ijohnson\o/19:32
mupPR snapd#8559 opened: boot, bootloader: adjust comments, expand tests <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8559>19:54
mupPR snapd#8560 opened: tests: disable "searching" test <⚠ Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/8560>21:49
zygaijohnson: ^ if around21:49
zygaI also CCd jdstrand21:50
ijohnsonzyga: looking now21:55
zygaijohnson: I think we need that to make any progress without mvo's overrides22:05
ijohnsonzyga: approved, sorry got distracted reviewing uc20 things22:06
ijohnsonzyga: I'll merge later when tests are done and I can open a followup re-enabling it, thanks for this22:06
zygathanks22:11
zygaeh opensuse needs fixes22:19
zygapkgconf-pkg-config instead of pkg-config22:19

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!