| cjwatson | Could I have a review of a small build system fix? https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/382990 | 10:36 |
|---|---|---|
| cjwatson | (Might fix CSS on qastaging, not sure if it's the only thing) | 10:41 |
| cjwatson | Not to mention CSS on staging and API on (qa)staging, I think | 10:45 |
| cjwatson | ilasc: ^- maybe? | 10:45 |
| ilasc | cjwatson: looking at it as we speak :) | 10:46 |
| cjwatson | Ta | 10:47 |
| ilasc | cjwatson: looks good to me | 10:48 |
| cjwatson | Thanks | 10:48 |
| ilasc | cjwatson: on the Edit OCI Push Rules screen, looks like with the current approach (replace credentials part of the rule with a link to the appropriate OCIRegistryCredentials:+edit view - screenshot on page 12) if User has no Push Rule defined there is no way for user to edit their Credentials | 10:55 |
| ilasc | might need to do something different than just the link per rule | 10:55 |
| cjwatson | ilasc: Aren't we still planning a tab on the person's index page too? | 10:57 |
| ilasc | yes, that's still there (Display Creds only), allow Edit Creds there was part of the first version, but we said we want to keep Edit Creds with Edit rules. Are you thinking go back to enabling Edit Creds on the Person's index page ? (that's what I'm thinking at the moment) | 11:01 |
| cjwatson | ilasc: I was expecting both | 11:03 |
| cjwatson | credentials views accessible from your index page, and also the ability to edit credentials directly from a push rule if they're linked to one | 11:03 |
| cjwatson | I don't think I intended to say that credentials editing should *only* be accessible from push rules | 11:04 |
| cjwatson | if I implied that, I apologise | 11:04 |
| ilasc | ok, makes sense to do it that way | 11:04 |
| * ilasc implements both | 11:04 | |
| cjwatson | Should just be a matter of the list view having some edit links | 11:05 |
| cjwatson | https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/383000 (Fix determination of bug target roles) | 14:12 |
| pappacena | This is what you were discussing on #launchpad some minutes ago? | 14:13 |
| cjwatson | Yep | 14:13 |
| pappacena | Awesome. Let me review it | 14:14 |
| cjwatson | Thanks | 14:23 |
| cjwatson | And I must owe you at least one review, so let's see | 14:23 |
| pappacena | hahaha! Thanks! :) | 14:25 |
| cjwatson | pappacena: Speaking of which, were you planning on landing https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/382233 ? Looks like it's ready to go | 14:47 |
| pappacena | Is the DB patch applied to production already? | 14:51 |
| cjwatson | It is | 14:51 |
| pappacena | Ok! I'll top-approve it. Thanks | 14:51 |
| cjwatson | pappacena: Conflict again, by the looks of it | 15:05 |
| pappacena | Yep. Merging master into the branch here. | 15:06 |
| SpecialK|Canon | pappacena: (Implicit) question in Freenode/#ubuntu-release ("whoever is accepting NEW packages") - is that something your archive admin audit work should be able to answer, out of interest? | 17:58 |
| pappacena | uhm, I'll join this channel. Anyway, I guess this information is present at the archive admin audit trail, yes. | 17:59 |
| SpecialK|Canon | pappacena: How could I view that for a given package? | 18:02 |
| pappacena | At the publishing history page of that package (like https://launchpad.net/ubuntu/+source/man-db/+publishinghistory) | 18:04 |
| pappacena | At the main page of the package, it shows as "Publishing details" when you click on the arrows at the bottom part too | 18:06 |
| pappacena | like this https://usercontent.irccloud-cdn.com/file/67n2jGD1/image.png | 18:06 |
| SpecialK|Canon | pappacena: Ok thanks will take a look! | 18:11 |
| cjwatson | In this case it would actually be on the queue pages (https://launchpad.net/ubuntu/groovy/+queue) | 19:06 |
| cjwatson | pappacena: FWIW the error on buildbot is easily reproducible locally with bin/test -vvc --layer=AppServerLayer | 19:35 |
| cjwatson | ValueError: In version devel, IOCIRecipeBuildRequestEntry_devel.builds is a collection of IOCIRecipeBuild, but version devel of the web service does not publish IOCIRecipeBuild as an entry. (It may not be published at all.) | 19:35 |
| cjwatson | is the key bit | 19:35 |
| cjwatson | i.e. essentially the problem is that IOCIRecipeBuildRequest.builds is exported but the interface type that it's exporting a collection of isn't | 19:36 |
| pappacena | Ah, got it. I'll take a look in a minute | 19:37 |
| pappacena | Thanks! | 19:37 |
| cjwatson | wgrant: Could you DB-review https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/383021 please? | 19:41 |
| === popey4 is now known as popey | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
