mup_ | PR operator#246 opened: Made breakpoint handling code to use already parsed JUJU_DEBUG_AT, and isolated the message showing logic <Created by facundobatista> <https://github.com/canonical/operator/pull/246> | 08:05 |
---|---|---|
jam | "morning" all | 11:01 |
Chipaca | moin moin | 11:04 |
niemeyer | o/ | 11:04 |
facubatista | Muy buenos días a todos! | 11:34 |
Chipaca | facubatista: heyyy | 11:49 |
facubatista | hola Chipaca | 11:49 |
Chipaca | facubatista: q'acelga caezn | 11:49 |
facubatista | jejej | 11:50 |
jam | morning facubatista and Chipaca | 11:55 |
jam | "morning" :) | 11:55 |
facubatista | hola jam | 11:55 |
facubatista | Chipaca, juju (maybe) never will set JUJU_DISPATCH_PATH as absolute, but a user may; if it's absolute, are we ok with it? | 11:57 |
jam | facubatista, are you sure we don't handle abspath correctly? Because if I do: | 12:24 |
jam | 0 | 12:24 |
jam | https://paste.ubuntu.com/p/7rdWThBDjc/ | 12:24 |
jam | base = Path('/var/run') | 12:25 |
jam | print(base / '/something/else') | 12:25 |
jam | I just get | 12:25 |
jam | '/something/else' | 12:25 |
jam | so self.charm_dir / dispatch_path | 12:25 |
jam | will give an abspath if it is set | 12:25 |
facubatista | jam, it depends on what "correctly" means... if we're ok with using an abspath if it's given, yes, we're handling it correctly, but then it bothers me a previous comment saying that the path "will be relative" | 12:26 |
jam | facubatista, so Juju will always pass a relative path | 12:27 |
facubatista | jam, the user may not | 12:27 |
jam | facubatista, but that is only if someone is intentionally not treating the object as a Juju charm and running something direcly | 12:27 |
facubatista | FTR, I'm +1 to improving the comment | 12:27 |
jam | in which case, they can do what they need to | 12:27 |
facubatista | let's fix the comment so when somebody reads it don't get confused with the code | 12:28 |
* Chipaca updates the comment to say "if the path is not relative, the absolute value of the path's eigenvector is used to compute its state in P-space before proceeding" | 12:31 | |
jam | Chipaca, what about fourier domain ? | 12:36 |
Chipaca | so first fourier transform, *then* get the eigenvector? | 12:36 |
Chipaca | seems reasonable to me | 12:36 |
=== __chip__ is now known as Chipaca | ||
jam | o/ Chipaca | 13:59 |
jam | so chip is chipaca but isn't chip... | 13:59 |
Chipaca | Chipaca, chipakeitor, __chi__, ChipaPhone, and ChipAway are all grouped to me | 14:00 |
jam | "has been a joy to work with" \o/ | 14:50 |
niemeyer | !!! | 14:50 |
* facubatista -> lunch | 15:17 | |
* facubatista -> *really* lunch now | 15:48 | |
=== Dmitrii-Sh0 is now known as Dmitrii-Sh | ||
* facubatista is back | 16:52 | |
* Chipaca goes to have dinner | 17:01 | |
jam | heading out, bbiab | 17:04 |
=== mup__ is now known as mup_ | ||
jam | back | 18:06 |
Chipaca | facubatista: you there? | 18:30 |
facubatista | Chipaca, yes, with my head inside shotcut, but heading to the meeting | 18:30 |
=== Dmitrii-Sh1 is now known as Dmitrii-Sh | ||
Chipaca | woooooooooooo⁰⁰⁰⁰⁰⁰⁰⁰⁰⁰ | 19:18 |
* facubatista eods | 21:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!