| hpidcock | PR please https://github.com/juju/juju/pull/11515 | 01:47 |
|---|---|---|
| babbageclunk | hpidcock: looking | 03:46 |
| babbageclunk | hpidcock: approved | 03:50 |
| hpidcock | babbageclunk: thanks | 03:50 |
| wallyworld_ | babbageclunk: piling on, i have a couple of PRs up if you have a little time to look | 04:48 |
| babbageclunk | wallyworld_: otp with thumper, will look after that | 04:51 |
| wallyworld_ | oh sorry, ty | 04:51 |
| wallyworld_ | stickupkid: hey, so if this gets landed, it will make experiemtng with centos and windows images much easier https://github.com/juju/juju/pull/11513 | 10:54 |
| stickupkid | wallyworld_, nice, let me qa it | 10:54 |
| wallyworld_ | stickupkid: i used it to try centos on aws etc. we still need to teach juju how to inperpret an error saying "no image for you" as something other than a "these creds are broken" error | 10:56 |
| hpidcock | can I get a PR reviewed at some point pls https://github.com/juju/juju/pull/11509 | 11:00 |
| wallyworld_ | hpidcock: lgtm | 11:04 |
| SachinKulkarni | Facing a strange issue while running "juju status". it's failing with an error "ERROR cannot unmarshal accounts: yaml: control characters are not allowed" | 12:37 |
| achilleasa | hml: stickupkid followup fix for the constraints-with-spaces bug; can either of you review? https://github.com/juju/juju/pull/11519 | 15:00 |
| stickupkid | achilleasa, so "a b" will be "a\ \ b" right? | 15:05 |
| achilleasa | stickupkid: yes. Just as you would do in a shell command | 15:06 |
| stickupkid | fair | 15:06 |
| achilleasa | ideally we should also support quoted kv pairs | 15:07 |
| achilleasa | but it's way more effort than this small change (you'd need a tokenizer with depth counters for nested quotes etc.) | 15:07 |
| achilleasa | stickupkid: also, if you take a look at https://bugs.launchpad.net/juju/+bug/1847259, you will see that Pedro tried to slash-escape the spaces | 15:08 |
| mup | Bug #1847259: Juju --constraints "zones=NAME WITH SPACES" fails because of space chars <juju:Triaged> <https://launchpad.net/bugs/1847259> | 15:08 |
| stickupkid | achilleasa, it's actually easier to read | 15:09 |
| stickupkid | achilleasa, I used the prior to the previous commit to compare against | 15:09 |
| achilleasa | hml: can you take a look at https://github.com/juju/juju/pull/11521? | 16:15 |
| hml | achilleasa: looking | 16:15 |
| hml | achilleasa: approved | 16:18 |
| wallyworld_ | stickupkid: last one :-) https://github.com/juju/juju/pull/11522 | 16:25 |
| stickupkid | wallyworld_, looking | 16:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!