[03:33] <mup> Bug #1871827 opened: git ubuntu submit fails on focal <snap> <submit> <Snappy:New> <usd-importer:New> <https://launchpad.net/bugs/1871827>
[05:58] <zyga> https://github.com/snapcore/snapd/pull/8581/checks?check_run_id=631328561 <- persistent journal failed
[05:58] <mup> PR #8581: tests: port pulseaudio test to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8581>
[06:08] <mup> PR snapd#8582 opened: github: register matchers before running spread <Created by zyga> <https://github.com/snapcore/snapd/pull/8582>
[07:09] <pstolowski> morning
[07:24] <mvo> hey pstolowski
[07:24] <pstolowski> mvo: hi! how is the sprint going?
[07:30] <zyga> hey guys
[07:30] <zyga> I'm doing some test fixes
[07:30] <zyga> pstolowski: do you have backscroll?
[07:30] <zyga> pstolowski: can you see my message at 7:58?
[07:31] <pstolowski> zyga: i don't have it
[07:31] <zyga> https://github.com/snapcore/snapd/pull/8581/checks?check_run_id=631328561 <- persistent journal failed
[07:31] <mup> PR #8581: tests: port pulseaudio test to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8581>
[07:31] <zyga> the failure is silly but wonder why
[07:38] <pstolowski> zyga: yeah it consistent with the previous failures, no idea. looks like snapd gets restarted (or crashes) during configure hook. i will think about a debug section for this test. thanks
[07:38] <zyga> is there something in the logs?
[07:42] <pstolowski> zyga: nothing obvious, "Running task 84 on Do: Run configure hook of "core" snap" is the last task run, and snap set fails with 'error: cannot communicate with server: Put http://localhost/v2/snaps/core/conf: EOF'
[07:42] <zyga> hmm
[07:42] <zyga> what ran before?
[07:43] <pstolowski> it's just snap set with true/false in this test
[07:43] <zyga> can you report a bug with the failure fragment, the list of tests that ran before and any additional insight
[07:43] <zyga> I mean tests that ran on this machine before this one
[07:43] <pstolowski> ah, that
[07:43] <pstolowski> yep, good idea
[07:43] <pstolowski> main/cgroup-devices is right before it
[07:45] <zyga> add the complete list
[07:45] <zyga> maybe next time we
[07:45] <zyga> maybe next time we'll know more
[07:46]  * zyga -> breakfast
[07:54] <pstolowski> done, https://bugs.launchpad.net/snapd/+bug/1876053
[07:54] <mup> Bug #1876053: occasional spread test failure on core-persistent-journal <snapd:Confirmed> <https://launchpad.net/bugs/1876053>
[07:54] <zyga> thanks!
[07:55] <zyga> one day we'll learn and understand :)
[07:56] <pstolowski> in the initial version of this code i was restarting journal service which had an undesired effect of restarting snapd during configure hook, but now it's misterious as there is no direct interaction with systemd, just removing/creating journal dir
[07:59] <zyga> do you know why restarting journal restarts snapd?
[07:59] <zyga> is it just snapd that is being restarted in that case?
[08:09] <pstolowski> dunno
[08:11] <zyga> pstolowski: hmm, perhaps we can do a small experiment with a simple service and see what happens
[08:11] <zyga> maybe it's documented
[08:11] <zyga> I think we ought to know, feels wrong to ship this to devices with potential for failure
[08:11] <zyga> offtopic: https://thepihut.com/products/raspberry-pi-high-quality-camera-lens !!! :)
[08:12] <zyga> i'm so getting this
[08:12] <zyga> and setting up a monitoring with a pi :)
[08:12] <zyga> and botland has it
[08:12] <zyga> https://botland.com.pl/pl/szukaj?controller=search&orderby=position&orderway=desc&search_query=Nowa+kamera+do+Raspberry+Pi&submit_search=
[08:20] <mborzecki> morning
[08:23] <zyga> mborzecki: hey
[08:35] <mvo> pstolowski: when you have a couple of minutes, could you please double check trello doing? just making sure it's a bit more up-to-date
[08:35] <pstolowski> mvo: sure
[08:36] <mvo> pstolowski: fwiw, the current trello has a bit too many lanes, this will get cleaned in the following days, so don't worry if it's a bit crowded :)
[09:12] <zyga> I need reviews for https://github.com/snapcore/snapd/pull/7825
[09:12] <mup> PR #7825: many: use transient scope for tracking apps and hooks <Security-High> <Created by zyga> <https://github.com/snapcore/snapd/pull/7825>
[09:12] <zyga> it's super close and I'd love to land it this week
[09:20] <mborzecki> zyga: can yuo remind me whether the session-tool stops the session after the command exits?
[09:21] <zyga> no, because --prepare enables linger and --restore disables linger
[09:21] <zyga> what are you seeing?
[09:22] <mborzecki> so `session-tool -u test --restore` will kill the session then in restore right?
[09:22] <zyga> yes
[09:29] <zyga> it would be good to focus on making master less red
[09:29] <zyga> something broke in debian-sid now, we cannot compile our golang+C tests
[09:29] <zyga> would be worth taking a look,
[09:29] <zyga> I can in ~3-4 hours
[09:29] <zyga> but perhaps someone can fix it faster
[09:30] <mborzecki> zyga: got log?
[09:30] <zyga> mborzecki: plenty, check any of my latest PRs
[09:30] <zyga> mborzecki: asm/geneeric.h is missing or something like that
[09:30] <zyga> mborzecki: it fails each time
[09:30] <zyga> mborzecki: on tests/unit/go
[09:30] <mborzecki> master seems to be green
[09:30] <zyga> mborzecki: nope, it's red red red here :)
[09:30] <zyga> mborzecki: or did it magically go away just as it showed up?
[09:31] <mborzecki> zyga: https://github.com/snapcore/snapd/commits/master looks green
[09:31] <zyga> mborzecki: try debian-sid-64:tests/unit/go
[09:31] <zyga> the tick is confusing
[09:31] <zyga> it's just travis
[09:31] <mborzecki> w8, what's that tick?
[09:31] <zyga> we don't run spread there
[09:31] <mborzecki> pfff
[09:31] <mborzecki> yeah
[09:31] <zyga> yeah
[09:32] <mborzecki> omg
[09:32] <zyga> ?
[09:32] <mborzecki> so, the gh actions only runs on PRs
[09:32] <zyga> yes
[09:32] <zyga> we configured that deliberately
[09:32] <mborzecki> ok, so we do not run spread on master then
[09:32] <zyga> otherwise everything costs x2 more
[09:32] <zyga> we said we should extend that to run on all landings to release branches
[09:33] <zyga> as we land things regularly it's a reasonable tradeoff
[09:33] <mup> PR snapd#8583 opened: tests: add debug to core-persistent-journal test <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8583>
[09:33] <mborzecki> 2020-04-29T17:55:01.8596162Z + su -l -c 'XDG_RUNTIME_DIR="/run/user/12345" DBUS_SESSION_BUS_ADDRESS="" test-snapd-desktop.cmd xdg-open http://www.example.org' test
[09:33] <mborzecki> 2020-04-29T17:55:01.8596782Z user-open error: exec: "dbus-launch": executable file not found in $PATH
[09:33] <mborzecki> heh, on sid
[09:33] <zyga> mborzecki: I really want to burn user.sh and the hacks with fire
[09:33] <zyga> all those XDGD_RUNTIME_DIR=... things are so bogus
[09:33] <zyga> mborzecki: I have a patch that moves one more tests over
[09:34] <zyga> maybe I can remove all of them today
[09:34] <zyga> I'm stuck on "serious" reviews anway
[09:34] <mborzecki> ok, let me see what i can do about that snap-seccomp unit test failing on sid
[09:34] <zyga> thanks!
[09:34] <zyga> one by one
[09:34] <zyga> and we can ask mvo to merge despite other failures
[09:34] <zyga> I'd love to end the week with totally green master
[09:34] <zyga> so that next week is not like a torture :/
[09:38] <mborzecki> zyga: can you take a look at https://github.com/snapcore/snapd/pull/8580 ? or even try it out if you have zsh installed
[09:39] <mup> PR #8580: data/completion: add `snap` command completion for zsh <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8580>
[09:39] <zyga> mborzecki: sure
[09:39] <mborzecki> just dropping _snap file into /usr/share/zsh/vendor-completions/ should do the trick
[09:39] <mborzecki> or site-functions on other non deb distros
[09:40] <mborzecki> now that it works locally i see i've been missing out on some goodies :P
[09:42] <mborzecki> btw the zsh documentation is awful
[09:42] <zyga>   that doesn't seem to work
[09:44] <zyga> I installed that on my system
[09:44] <zyga> invoked zsh
[09:44] <zyga> and nothing
[09:44] <zyga> in comparison other completers work ok
[09:46] <zyga> reviewed
[09:46] <mborzecki> hmmm
[09:47] <zyga> also packaging seems to be broken
[09:47] <zyga> (check the various error logs)
[09:50] <mborzecki> heh, forgot to list the file for opensuse
[09:51] <zyga> check the suse error
[09:52] <zyga> it says something is listed twice
[09:52] <zyga> maybe a drive-by
[09:53] <mborzecki> zyga: https://asciinema.org/a/wXGEu1Ky2To2osTCJ8Wl1rD8b
[09:53] <zyga> weird
[09:53] <zyga> that's not what I'm seeing
[09:54] <zyga> I'll recheck
[09:54] <mborzecki> zyga: on ubuntu you need to move it to /usr/share/zsh/vendor-completins/_snap (with _)
[09:54] <zyga> that's where I put it
[09:55] <zyga> I naively tried to debug it by sourcing
[09:56] <zyga> fyke% source _snap
[09:56] <zyga> _setup:37: compstate: assignment to invalid subscript range
[09:56] <mborzecki> no, it won't work that way :)
[09:59] <zyga> I don't know how to debug it
[10:00] <mborzecki> zyga: that's on opensuse?
[10:00] <zyga> no, focal
[10:00] <zyga> weird, right
[10:01] <zyga> but I didn't set shell to zsh
[10:01] <zyga> just execed zsh
[10:01] <zyga> maybe that's why?
[10:02] <mborzecki> idk, maybe you need to enable completion? try `autoload -Uz compinit ; compinit` ?
[10:02] <zyga> it works for everything else in that directory
[10:02] <zyga> all the other commands generate completios
[10:02] <zyga> *completions
[10:03] <mborzecki> zyga: did you wget/curl the file or pasted it?
[10:03] <zyga> ...
[10:03] <zyga> pasted
[10:03] <zyga> is that relevant?
[10:03] <zyga> Omg :D
[10:04] <mborzecki> check whether the first line is `#compdef snap`
[10:04] <zyga> it is
[10:04] <mborzecki> idk, wget https://raw.githubusercontent.com/snapcore/snapd/060556f7adcf748546cd7c3c97f3254f0bd58644/data/completion/_snap ? :)
[10:05] <zyga> same result
[10:06] <mborzecki> pfff idk then
[10:06] <zyga> can you try?
[10:06] <mborzecki> you could try an wipe ~/.zshrc if you're not to used to it and start over
[10:06] <zyga> I mean, just spawn focal (multipass) and put that file
[10:07] <zyga> mborzecki: my zshrc is empty
[10:07] <mborzecki> zyga: that asciinema is on 20.04
[10:07] <zyga> mborzecki: yes but from spread
[10:07] <zyga> mborzecki: maybe there's a more magic button somewhere
[10:07] <mborzecki> ah, ok
[10:10] <mborzecki> zyga: yup, works
[10:10] <zyga> IDK
[10:10] <zyga> let's ship it then ;D
[10:11] <zyga> I tried setting the GO_... variable for completions and that does print stuff
[10:11] <zyga> did you exec zsh or did you do something more elaborate?
[10:11] <mborzecki> zyga: rm ~/.zshrc and run zsh again, that should suggest using the default config
[10:11] <zyga> tried
[10:12] <zyga> doesn't fix this issue :)
[10:12] <zyga> zyga@fyke ~ % snap inst
[10:12] <zyga> Completing `file' or `corrections'
[10:12] <zyga> I hit <tab> at inst<tab>
[10:14] <mborzecki> zyga: gcc-multilib isn't installed in sid images
[10:14] <mborzecki> zyga: that's why the unit test fails
[10:14] <zyga> cool, ping me for a patch
[10:16] <mborzecki> btw. i don't understand why test/unit build and install the snapd package
[10:17] <zyga> mborzecki: weird
[10:17] <zyga> probably for no reason at all?
[10:17] <mborzecki> that's a huge waste of time
[10:17] <zyga> I also wonder where we waste time
[10:17] <zyga> run 10 tests on a single machine
[10:17] <zyga> with -repeat 10
[10:17] <zyga> that does "true"
[10:17] <mborzecki> also, building the package runs unit tests /o\
[10:17] <zyga> it's incredibly slow
[10:17] <zyga> we are probably wasting loads of time doing something silly somewhere
[10:20] <mborzecki> uff, at least we pass nocheck to deb-bp
[10:20] <mborzecki> dpkg-buildpackage
[10:39] <mup> PR core#113 opened: Makefile: conditionally use the "edge" PPA in live-build <Created by mvo5> <https://github.com/snapcore/core/pull/113>
[10:47] <mborzecki> zyga: https://github.com/snapcore/snapd/pull/8584
[10:48] <mup> PR #8584: packaging/debian-sid: add gcc-multilib to build deps <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8584>
[10:48] <mup> PR snapd#8584 opened: packaging/debian-sid: add gcc-multilib to build deps <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8584>
[10:48] <zyga> mborzecki: are we running tests on debian?
[10:48] <zyga> as in, unit tests while building the debian sid package?
[10:54] <mborzecki> zyga: it was the one that failed in this test
[10:54] <pstolowski> #8537 needs 2nd review
[10:54] <mup> PR #8537: store: handle error-list in fetch-assertions results  <Bulk assert refresh :scroll::scroll::scroll:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8537>
[10:54] <mborzecki> pstolowski: trying to review that since morning
[10:55] <mborzecki> zyga: there's only a bunch of systems we don't run unit tests on: [-ubuntu-core-*, -fedora-*, -opensuse-*, -arch-*, -amazon-*, -centos-*]
[10:55] <zyga> mborzecki: my question was different, we had a missing dependency, how come it didn't come up when building snapd in a pristine environment of a buidd?
[10:55] <zyga> mborzecki: are we running unit tests on package build on debian?
[10:56] <mborzecki> zyga: perhaps gcc-multilib is one of base dependencies already included?
[10:57] <mborzecki> zyga: which test runs buildd? i don't see one
[10:57] <zyga> mborzecki: perhaps :)
[10:57] <zyga> mborzecki: I mean "make check" style
[10:57] <zyga> go test ./...
[10:57] <mup> PR snapd#8585 opened: release: 2.44.5 <Created by mvo5> <https://github.com/snapcore/snapd/pull/8585>
[10:59] <mborzecki> zyga: prepare sets nocheck in DEB_BUILD_OPTIONS, there's a nightly test that runs sbuild, but nobody looks at the result?
[10:59] <zyga> heh
[10:59] <zyga> ok
[10:59] <zyga> thanks for fixing htis
[10:59] <zyga> *this
[11:01] <mborzecki> zyga: where are the nightly test results?
[11:01] <zyga> replied to https://github.com/snapcore/snapd/pull/8581
[11:01] <mup> PR #8581: tests: port pulseaudio test to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8581>
[11:01] <zyga> I have no idea
[11:01] <zyga> probably nowhere
[11:01] <zyga> just read the travis runs
[11:01] <mborzecki> cachio probably knows
[11:08] <mborzecki> zyga: so mvo pointed me to where the nightly tests are and as suspected sbuild test was failing, but even before it reached the package build step /o\
[11:09] <zyga> heh
[11:09] <zyga> where are the results?
[11:18]  * pstolowski lunch + errand
[11:19] <mborzecki> zyga: https://travis-ci.org/github/snapcore/spread-cron/branches and look for nightly
[11:19] <zyga> mmm
[11:19] <zyga> thanks
[11:20] <mborzecki> hm, we don't install sbuild and then run sbuild in the test
[11:20] <mborzecki> perhaps sbuild is no longer in the sid image?
[11:20] <zyga> IIRC we did but perhaps we stopped
[11:20] <zyga> for efficiency?
[11:22] <mborzecki> idk, let me check that test
[11:22] <mborzecki> hm sbuild is installed, wth?
[11:28] <doko> next chromium issue: https://bugs.launchpad.net/snapd/+bug/1876083
[11:28] <mup> Bug #1876083: chromium snap from focal fails DNS lookups, or delays them <snapd:New> <https://launchpad.net/bugs/1876083>
[11:32] <zyga> doko: in your report you said "that is using IPv6 only" - what do you mean by that?
[11:33] <mborzecki> hm idk, looks like sbuild-createchroot is broken
[11:33] <doko> zyga: my provider is doing IPv6 by default
[11:33] <zyga> I see
[11:33] <zyga> doko: what are the consequences of that, that you don't have an ipv4 address? that you cannot resolve ipv4 domains?
[11:34] <doko> no, I have an ipv4 address
[11:37] <zyga> mborzecki: we should nuke fedora 28, 29
[11:37] <zyga> and perhaps 30
[11:37] <zyga> and just have 31 and 32
[11:37] <mborzecki> 30 is eol in a mongth?
[11:37] <zyga> I will look after I wrap up this task
[11:37] <zyga> mborzecki: yeah, they go very quickly
[11:37] <zyga> the nature of fedora community is to move on
[11:37] <mborzecki> zyga: fwiw, the examples in sbuild-createchroot manpage don't work either, pfff
[11:37] <zyga> mborzecki: haha
[11:37] <zyga> I was in that same boat
[11:38] <zyga> mborzecki: with my recent debian maintainer hat
[11:38] <zyga> mborzecki: the wiki is broken
[11:38] <zyga> mborzecki: but also all of the tools behave different if they detect debian vs ubuntu
[11:38] <zyga> which is enormously confusing
[11:39] <mborzecki> eh, a wall of perl code :*
[11:39] <mborzecki> :(
[11:39] <zyga> heh
[11:39] <zyga> if that helps I have a magic line that gives you a working cowbuilder
[11:39] <zyga> it's really really great
[11:39] <zyga> and I use it for git-buildpackage
[11:39] <zyga> but most of the documentation is broken
[11:40] <zyga> and there is some overlap between those tools that doesn't help
[11:40] <zyga> btw, I need to thank stgraber and the team
[11:40] <zyga> lxd is really amazing
[11:40] <zyga> it's revolutionized how I think about systems
[11:40] <zyga> and the container registry is fantastic
[11:41] <zyga> I would love to have a vagrant-like tool for lxd
[11:41] <zyga> that bridges a project directory to the container ootb
[11:56] <cachio> zyga, hey
[11:56] <zyga> hey
[11:56] <cachio> I was trying to merge the no recommends branch
[11:56] <cachio> zyga, but I see these errors https://paste.ubuntu.com/p/BhXjghQ6Nh/
[11:56] <cachio> https://paste.ubuntu.com/p/hNRPxH7n6D/
[11:56] <cachio> both in the same test
[11:57] <cachio> zyga, I already tried with other dependencies
[11:57] <cachio> any idea what could be the cause?
[11:57] <zyga> lack of /lib/systemd/user/dbus.socket
[11:58] <zyga> I rewrote this test (though I haven't pushed it as I'm working on a prerequisite)
[11:58] <zyga> is that the only failure?
[11:58] <cachio> zyga, yes
[11:58] <zyga> do you have a debug shell?
[11:59] <cachio> no, let me create it
[11:59] <zyga> is dbus-user-session installed?
[11:59] <cachio> no
[11:59] <cachio> but it pass in other systems where it is not installed
[12:00] <zyga> ah, I missed that there are two test failures
[12:00] <cachio> zyga, yes, different
[12:00] <zyga> dbus-launch is a separate problem
[12:00] <zyga> the tests are really written in a way that won't work
[12:00] <zyga> I'm working on porting them over
[12:01] <cachio> zyga, I can disable it for those systems
[12:02] <cachio> and then we fix it
[12:02] <cachio> zyga, does it make sense?
[12:02] <zyga> can you add a comment like "TODO:session-tool: port and re-enable"
[12:02] <zyga> yeah
[12:02] <zyga> cachio: do you know if we are using different instances by any chance?
[12:02] <zyga> we've noticed that tests are much slower today
[12:03] <cachio> zyga, no
[12:03] <cachio> same
[12:04] <zyga> ok
[12:05] <cachio> zyga, I'll check
[12:05] <zyga> mborzecki: ^^ what do you think about the comments to disable the two tests sergio mentioned
[12:05] <zyga> cachio: today I'm going through failing tests and porting to session-tool, to unbreak from random annoying failures
[12:05] <zyga> so at some point I'll go through all the user.sh users and make them more robust
[12:06] <cachio> yes
[12:07] <cachio> zyga, it caused several issues already
[12:10] <cachio> zyga, pushed the change nad added the comment in both tests disabled
[12:11] <zyga> thanks
[12:11] <cachio> just disabled the failinf systems
[12:11] <cachio> not the test
[12:11] <zyga> do you need a review for the test changes?
[12:11] <zyga> cachio: uh, that's a bit heavy, I think we should not disable debian-sid
[12:11] <cachio> it is already  apporoved
[12:11] <zyga> 19.10 is a different story and I would not mind dropping it TBH
[12:11] <zyga> cachio: oh? where is it?
[12:12] <cachio> zyga #8468
[12:12] <mup> PR #8468: tests: adding option --no-install-recommends option also when install all the deps <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8468>
[12:13] <zyga> cachio: ah, ok,
[12:13] <zyga> I misunderstood what you said
[12:13] <zyga> mborzecki: https://github.com/snapcore/snapd/pull/8468#pullrequestreview-403460795
[12:14] <mup> PR #8468: tests: adding option --no-install-recommends option also when install all the deps <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8468>
[12:34] <mborzecki> zyga: yay, Chipaca is presenting ;)
[12:35] <zyga> watching :)
[12:35] <mborzecki> zyga: thanks for spotting, i left a comment there
[12:35] <zyga> cool!
[12:37] <doko> jdstrand: thanks, but now I'm facing LP: #1876083
[12:37] <mup> Bug #1876083: chromium snap from focal fails DNS lookups, or delays them <snapd:New> <https://launchpad.net/bugs/1876083>
[12:37] <doko> oops, wrong channel
[12:40] <mborzecki> mvo: can we merge https://github.com/snapcore/snapd/pull/8584 ? we'll need another PR for the xdg-desktop-portal test
[12:40] <mup> PR #8584: packaging/debian-sid: add gcc-multilib to build deps <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8584>
[12:40] <mborzecki> (needs your superpowers)
[12:43] <mvo> sure
[12:43] <mvo> ta
[12:43] <mup> PR snapd#8584 closed: packaging/debian-sid: add gcc-multilib to build deps <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8584>
[12:43] <mborzecki> mvo: thank you!
[13:46] <zyga> small improvement to session-tool, will replace some hand-crafted checks elsewhere: https://github.com/snapcore/snapd/pull/8586
[13:46] <mup> PR #8586: tests: add session-tool --has-systemd-and-dbus <Created by zyga> <https://github.com/snapcore/snapd/pull/8586>
[13:46] <mup> PR snapd#8585 closed: release: 2.44.5 <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8585>
[13:46] <mup> PR snapd#8586 opened: tests: add session-tool --has-systemd-and-dbus <Created by zyga> <https://github.com/snapcore/snapd/pull/8586>
[13:46] <zyga> currently a draft, running one more pass of the full set, will open shortly
[13:47] <mborzecki> google:debian-sid-64:tests/main/xdg-open-portal fails in a weird way
[13:47] <mborzecki> user-open error: exec: "dbus-launch": executable file not found in $PATH
[13:49] <zyga> mborzecki: yeah, we looked at this
[13:49] <zyga> mborzecki: cachio disabled this test, it's on my list to port next
[13:49] <mborzecki> zyga: i replaced some bits with session tool, but i tlooks like the user dbus is not started
[13:49] <zyga> yeah, I know
[13:49] <zyga> my test actually shows that :)
[13:49] <mborzecki> i'm probably doing something wrong here
[13:50] <zyga> dbus-session-bus is not preinstalled
[13:55] <zyga> presumably --no-install-recommends
[13:55] <cachio> cmatsuoka, using new snapd still getting stuck https://paste.ubuntu.com/p/gScx3yH59y/
[13:55] <cachio> cmatsuoka, line 1353
[13:55] <cachio> is the last I see
[13:56] <cmatsuoka> let me see...
[13:56] <cachio> thanks
[13:57] <cmatsuoka> cachio: this is happening in graham's image as well
[13:57] <cachio> cmatsuoka, ahh
[13:58] <cmatsuoka> cachio: did you inject snap-bootstrap into the initramfs?
[13:58] <cachio> cmatsuoka, yes
[13:58] <cmatsuoka> I'm investigating here to see what could be happening
[13:59] <mborzecki> zyga: ok, fixed the portal-open test, but other portal tests need fixing too now
[13:59] <cachio> cmatsuoka, I am running repack_snapd_snap_with_deb_content_and_run_mode_firstboot_tweaks
[13:59] <zyga> mborzecki: ok
[13:59] <cachio> for the image
[14:02] <cmatsuoka> mborzecki: I moved the TPM-related stuff from initramfs-mounts to secboot in PR #8577, could you have a look when you have time? It's trying to not expose TPM to initramfs-mounts so it could work later with a TrustZone-based solution as well
[14:02] <mup> PR #8577: [RFC] secboot,cmd/snap-bootstrap: move initramfs-mounts tpm access to secboot <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8577>
[14:09] <mborzecki> cmatsuoka: sure
[14:09] <mborzecki> zyga: i think i've ported the portal tests now
[14:09] <zyga> mborzecki: to session-tool? :-)
[14:09] <mborzecki> yeah
[14:09] <zyga> \o/
[14:09] <zyga> awesome
[14:09] <zyga> push that!
[14:09] <zyga> I'm looking at the user-env test
[14:10] <zyga> I mean, I ported it but I'm adding some more bits before that can be proposed
[14:10] <zyga> I have a working branch that removes user.sh
[14:10] <zyga> and just fixes stuff that breaks
[14:10] <zyga> mborzecki: did you port all of the portal tests?
[14:11] <mborzecki> zyga: xdg-open-portal and desktop-portal-{filechooser,screenshot,open-file,open-uri}
[14:11] <zyga> awesome
[14:12] <zyga> ijohnson: I pushed to https://github.com/snapcore/snapd/pull/8586 and opened it normally now
[14:13] <mup> PR #8586: tests: add session-tool --has-systemd-and-dbus <Created by zyga> <https://github.com/snapcore/snapd/pull/8586>
[14:13] <zyga> ijohnson: I made a small change to move the test to a new task
[14:13] <zyga> ijohnson: and I highlighted that https://github.com/snapcore/snapd/pull/8586/files#diff-e14795fd89d2bab1c7f6486851d463c0R15 sid has no session support somehow
[14:13] <zyga> this test is nice because it will show us changes in the distros
[14:13] <mborzecki> cmatsuoka: i think you added some standup notes under friday (tomorrow)
[14:13] <ijohnson> that's awesome very nice
[14:13] <zyga> I was thinking to move tumbleweed, sid and arch to unstable
[14:14] <ijohnson> is arch unstable ?
[14:14] <zyga> so that they reflect the unstable nature of the distributions they are
[14:14] <ijohnson> arch seems to be relatively stable for us recently I think
[14:14] <ijohnson> maybe I'm wrong though
[14:14] <zyga> so that we can get a heads up in case it affects the rest of the stack over time
[14:14] <zyga> ijohnson: yeah, it's relatively stable
[14:14] <zyga> but the point is not the measure our feeling about snapd in that distribution
[14:14] <zyga> but to measure the stability of the distribution - in the sense of debian stable
[14:14] <zyga> not sure if this makes sense to you
[14:15] <zyga> since those distributions move rapidly they can change like the wind at a seaside town :)
[14:15] <mup> PR core18#152 opened: Make .disk/info visible on the root partition <Created by sil2100> <https://github.com/snapcore/core18/pull/152>
[14:15] <cmatsuoka> mborzecki: I'm starting my annotations for the next day after the current SU to be in sync with people that have SU at the end of the day
[14:16] <cmatsuoka> (so the activities between SUs can be reviewed in the next SU)
[14:20] <zyga> ijohnson: one more small improvement, https://github.com/snapcore/snapd/pull/8587
[14:20] <mup> PR #8587: tests: session-tool allows preparing/restoring for many users <Created by zyga> <https://github.com/snapcore/snapd/pull/8587>
[14:20] <zyga> this will be used by changed user-env test
[14:20] <mup> PR snapd#8587 opened: tests: session-tool allows preparing/restoring for many users <Created by zyga> <https://github.com/snapcore/snapd/pull/8587>
[14:20] <zyga> that has test and test-zsh users
[14:25] <mup> PR snapd#8588 opened: tests: port portals test to session-tool, fix portal tests on sid <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8588>
[14:25] <mborzecki> zyga: ^^
[14:25] <zyga> looking
[14:26] <zyga> mborzecki: the pkg change is tricky, I would rather depend on it in snapd
[14:26] <zyga> mborzecki: otherwise we are testing something and users are running something else
[14:26] <zyga> mborzecki: wdyt?
[14:26] <mborzecki> zyga: suggests/reccomends?
[14:26] <zyga> yeah
[14:26] <zyga> suggests seems ok
[14:26] <zyga> or recommends
[14:26] <zyga> though we no-install-recommends
[14:26] <zyga> heh :)
[14:26] <zyga> not sure
[14:26] <mborzecki> aren't we suggsting/recommending portals already?
[14:26] <zyga> just don't want to let it slip like that
[14:27] <zyga> if we do we should bundle dbus in the same set
[14:27] <mborzecki> i would expect that to pull in relevant dbus packages
[14:27] <om26er> popey ping! I believe this will need your "blessings" https://forum.snapcraft.io/t/auto-connection-request-for-easy-installer/17063
[14:27] <zyga> the portal teardown should happen beore --restore
[14:27] <zyga> inside the portals you can probably remove loads of redudancy as well
[14:27] <popey> om26er bless you
[14:27] <zyga> it still calls start_user_session
[14:27] <zyga> and uses as_user
[14:28] <zyga> mborzecki: ^ review here :)
[14:28] <cmatsuoka> degville, cachio: something changed between gadget 96 and 98 that's causing the problem
[14:28] <mborzecki> zyga: portals teardown removes files and so on, it should probably be done after we know that session is stopped
[14:29] <zyga> mborzecki: look closer
[14:29] <zyga> it does more
[14:29] <zyga> purge_user_session-data
[14:29] <zyga> and stop_user_session
[14:29] <zyga> I think those two must go
[14:29] <degville> cmatsuoka: ah, thanks for the update.
[14:29] <cmatsuoka> degville: I'll diff them to see what changed
[14:30] <ijohnson> cmatsuoka: could it be https://github.com/snapcore/pc-amd64-gadget/pull/45 ?
[14:30] <mup> PR pc-amd64-gadget#45: Use UC20 signed grub <Created by xnox> <Merged by xnox> <https://github.com/snapcore/pc-amd64-gadget/pull/45>
[14:30] <popey> om26er I'll take a look
[14:31] <cmatsuoka> ijohnson: it looks very suspicious
[14:31] <zyga> mborzecki: reviewed but it's the same as I said here
[14:31] <ijohnson> cmatsuoka: indeed
[14:31] <om26er> popey thanks. I am in touch with the upstream, I was asked to help with snap packaging. After quite a few iterations we came to the point of pushing it to store.
[14:31] <zyga> mborzecki: thank you so much for pushing this :)
[14:33] <mborzecki> zyga: hmm not sure which portal helpers, there's only 2 of those, and they no longer start or stop session
[14:33] <cachio> cmatsuoka, ahhh
[14:33]  * zyga looks
[14:34] <cmatsuoka> ijohnson: this looks suspicious too:
[14:34] <zyga> mborzecki: doh!
[14:34] <zyga> I'm blind
[14:34] <zyga> this is so weird
[14:34] <cmatsuoka> -    - shim-signed=1.41+15+1552672080.a4a1fbe-0ubuntu1
[14:34] <cmatsuoka> -    - shim=15+1552672080.a4a1fbe-0ubuntu1
[14:34] <cmatsuoka> +    - shim-signed=1.40.3+15+1533136590.3beb971-0ubuntu1
[14:34] <cmatsuoka> +    - shim=15+1533136590.3beb971-0ubuntu1
[14:34] <zyga> I didn't see this file before :)
[14:34] <cachio> cmatsuoka, I'll try in that case by using the pc snap from stable
[14:34] <ijohnson> cmatsuoka: so the version of shim was reverted to an older one?
[14:34] <zyga> mborzecki: +1
[14:35] <popey> om26er it's a really nice looking app!
[14:35] <cmatsuoka> ijohnson: it seems so, and if this older one is the one without chris coulson's patches, it would fail like that
[14:35] <zyga> mborzecki: can you remove . user.sh in desktop-portal.sh?
[14:36] <ijohnson> cmatsuoka: yeah makes sense probably needs a comment from Dmitri
[14:38] <cmatsuoka> ijohnson: I pinged him about that
[14:39] <ijohnson> ack
[14:43] <cmatsuoka> degville, cachio: bad shim in recent gadgets, dimitri is fixing it
[14:43] <zyga> mborzecki: superb
[14:43] <zyga> mborzecki: we will have much fewer users of user.sh
[14:44] <cachio> cmatsuoka, awesome
[14:44] <degville> cmatsuoka: thank you!
[14:44] <cachio> cmatsuoka, the fun part is that I tried with older snapd snap, pckernel snap and core20 snap
[14:44] <cachio> cmatsuoka, but didnt try with older pc snap
[14:46] <cmatsuoka> when unlock fails, the prime suspects are the command line and shim, and they're both from gadget
[14:46] <zyga> mborzecki: once your branch lands this will be fixed, right?
[14:46] <zyga> https://github.com/snapcore/snapd/pull/8586/files#diff-e14795fd89d2bab1c7f6486851d463c0R19
[14:46] <mup> PR #8586: tests: add session-tool --has-systemd-and-dbus <Created by zyga> <https://github.com/snapcore/snapd/pull/8586>
[14:46] <zyga> debian-sid-*/test exception will disappear
[14:53] <pstolowski> how do i restart github actions if they seem to be stuck? https://github.com/snapcore/snapd/pull/8583
[14:53] <mup> PR #8583: tests: add debug to core-persistent-journal test <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8583>
[14:57] <zyga> pstolowski: looking
[14:57] <zyga> close and reopen
[14:57] <zyga> I saw that once before
[14:57] <zyga> seems like event got lost
[14:57] <pstolowski> mhm
[14:57] <pstolowski> ok,thanks
[14:57] <zyga> queued :)
[14:58] <zyga> and in progress
[14:59] <zyga> I'll break now
[14:59] <zyga> back hurts
[15:00] <pstolowski> magic
[15:00] <zyga> magic? :)
[15:00] <zyga> could you ask mvo to merge the two session-tool improvements once they are green enough
[15:00] <zyga> I have more follow ups that this enables
[15:10] <zyga> mborzecki: I approved https://github.com/snapcore/snapd/pull/8580#pullrequestreview-403616086
[15:10] <mup> PR #8580: data/completion: add `snap` command completion for zsh <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8580>
[15:10] <zyga> but there's a conflict now
[15:12] <zyga> mborzecki: maybe move pkgver next to pgkname
[15:12] <zyga> so that it conflicts less frequently
[15:17] <zyga> ijohnson: https://github.com/snapcore/snapd/pull/8576#pullrequestreview-403618621
[15:17] <mup> PR #8576: tests/main/lxd: add test for snaps inside nested lxd containers not working <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8576>
[15:18] <pstolowski> anyone up for #8583? needs 2nd review, it's a simple test change
[15:18] <mup> PR #8583: tests: add debug to core-persistent-journal test <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8583>
[15:19] <zyga> pstolowski: perhaps just ask mvo, master is broken now so you will nedd an override anyway
[15:20] <morphis> zyga, mvo: have you guys seen any problems with snapd in lxd with focal images? running into https://pastebin.canonical.com/p/SkdNKHCyNy/
[15:20] <morphis> snapd seems to fail to initialize the system
[15:21] <zyga> morphis: can you do snap tasks 1 or [345]
[15:21] <zyga> I don't think we've seen this
[15:21] <morphis> https://pastebin.canonical.com/p/fwChrpCB49/
[15:21] <morphis> didn't knew `snap tasks` gives you that level of details
[15:22] <morphis> this is a LXD container with: https://pastebin.canonical.com/p/fQJHJq5R6t/
[15:22] <morphis> which works fine for bionic
[15:23] <zyga> morphis: so the preinstall hook fails
[15:23] <zyga> hmmm
[15:23] <zyga> er, install hook
[15:23] <zyga> 2020-04-30T14:58:46Z ERROR run hook "install": cannot perform operation: mount --rbind /var/lib/dhcp /tmp/snap.rootfs_hzQTBP//var/lib/dhcp: Permission denied
[15:23] <zyga> oh
[15:23] <zyga> that's new!
[15:23] <zyga> this is surprising
[15:23] <zyga> morphis: do you have denials?
[15:23] <zyga> on the host container
[15:23] <zyga> container host
[15:24] <zyga> jdstrand: ^ remember this?
[15:24] <zyga> I wonder if there's a regression that the lxd profile doesn't allow snapd to perform this
[15:25] <morphis> zyga: let me check
[15:25] <zyga> morphis: does it go away if you rmdir /var/lib/dhcp in the machine that you "snap install lxd" on?
[15:25] <zyga> we won't try it then
[15:25] <morphis> zyga: https://pastebin.canonical.com/p/NHKWyxpwQj/
[15:26] <morphis> let me check
[15:26] <zyga> [ 1113.914649] audit: type=1400 audit(1588259357.291:359): apparmor="DENIED" operation="mount" info="failed srcname match" error=-13 profile="/usr/lib/snapd/snap-confine" name="/tmp/snap.rootfs_de7sTW/var/lib/dhcp/" pid=61879 comm="snap-confine" srcname="/var/lib/dhcp/" flags="rw, rbind"
[15:26] <morphis> that looks like it
[15:26] <jdstrand> what's up with locking /dev/null?
[15:26] <morphis> but the container has lxc.apparmor.profile=unconfined so I wouldn't expect that
[15:26] <zyga> hmmm
[15:26] <zyga> is that supported for snapd?
[15:27] <zyga> I'm never sure what the various lxd configuration options do
[15:27] <zyga> and which disable nested apparmor
[15:27] <zyga> jdstrand: maybe libc?
[15:27] <morphis> we have a lxd-profile.yaml in our lxd charm which adjusts the container config, k8s does the same AFAIK
[15:28] <morphis> https://github.com/charmed-kubernetes/charm-kubernetes-master/blob/master/lxd-profile.yaml
[15:28] <jdstrand> I've never seen that before
[15:28] <zyga> we have this rule:
[15:28] <zyga>     mount options=(rw rbind) /var/lib/dhcp/ -> /tmp/snap.rootfs_*/var/lib/dhcp/,
[15:28] <zyga>     mount options=(rw rslave) -> /tmp/snap.rootfs_*/var/lib/dhcp/,
[15:28] <zyga> which should cover the dhcp directory you had
[15:28] <zyga> I wonder what's wrong there
[15:29] <zyga> morphis: can you file a bug with repro instructions,
[15:29] <jdstrand> I'm going into a meeting, but if you set lxc.apparmor.profile=unconfined, I'm not sure the profile stacking is going to work correctly
[15:29] <morphis> zyga: rmdir /var/lib/dhcp doesn't seem to help
[15:29] <jdstrand> that is a stgraber question
[15:29] <morphis> now it runs into: 2020-04-30T15:28:45Z ERROR run hook "install": cannot open file /sys/fs/cgroup/freezer/snap.lxd/cgroup.procs: Permission denied
[15:29] <zyga> morphis: it's late today and I wanted to focus on some more bits but I will try to look either later today or on Monday (I'm off tomorrow)
[15:29] <morphis> zyga: sounds good!
[15:29] <zyga> morphis: I'm suspecting this is an unsupported config, please make sure to loop in stgraber
[15:29] <morphis> jdstrand: will check with him later
[15:30] <jdstrand> this is because the policy is shared between the host and the container I think
[15:30] <zyga> and we should document this somehow
[15:30] <jdstrand> because there is no stacking
[15:30] <zyga> yeah, I think jamie is spot on
[15:30] <jdstrand> yikes
[15:30]  * jdstrand -> meeting
[15:30] <morphis> just wondering as this worked well for bionic
[15:31] <jdstrand> yeah, I forget otoh the details of how lxd sets up the profile stacking
[15:31] <jdstrand> but this sounds like what I described
[15:31] <zyga> morphis: some incorrect configurations do seem to work
[15:31] <zyga> morphis: but not by design
[15:31] <zyga> and it depends heavily by what is on the container
[15:32] <pstolowski> zyga: what's broken in master now?
[15:33] <zyga> pstolowski: a few tests
[15:33] <zyga> pstolowski: but those are all with PRs now I think
[15:33] <zyga> pstolowski: your branch will likely fail on them
[15:35] <zyga> pstolowski: watch https://github.com/snapcore/snapd/pull/8588 :)
[15:35] <mup> PR #8588: tests: port portals test to session-tool, fix portal tests on sid <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8588>
[15:35] <zyga> maybe it will be green
[15:35] <zyga> then we can just work normally again
[15:36] <pstolowski> great
[15:36] <pstolowski> ty
[15:36] <cachio> cmatsuoka, I used the pc 93 and I see the same problem
[15:44] <morphis> zyga, jdstrand: dropping "lxc.apparmor.profile=unconfined" fixes it
[15:47] <zyga> great :)
[15:49] <zyga> mvo: could you please override/merge https://github.com/snapcore/snapd/pull/8586
[15:49] <mup> PR #8586: tests: add session-tool --has-systemd-and-dbus <Created by zyga> <https://github.com/snapcore/snapd/pull/8586>
[15:49] <zyga> it's +2 and it fails on a known debian-sid failure maciek has fixed in a separate branch
[15:49] <zyga> thanks!
[15:50] <mup> PR snapd#8586 closed: tests: add session-tool --has-systemd-and-dbus <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8586>
[15:50] <zyga> mborzecki: can you merge master into https://github.com/snapcore/snapd/pull/8588 and remove the debian-sid-*/test exception from tests/main/session-tool-support
[15:50] <mup> PR #8588: tests: port portals test to session-tool, fix portal tests on sid <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8588>
[15:51] <zyga> mborzecki: or I'll just open a follow-up as soon as this lands
[15:51] <zyga> opensuse has fails on degraded systemd unit
[15:51] <zyga> I had a look and it both looks familiar
[15:51] <zyga> and weird
[15:51] <zyga> not sure if we can just disable that service?
[15:51] <zyga> it's something related to tty, let me check...
[15:54] <cmatsuoka> cachio: 96 should work
[15:56] <cachio> cmatsuoka, it is not published anymore right?
[15:57] <cmatsuoka> cachio: no, the current one is 98
[16:01] <mup> PR snapd#8589 opened: tests: port user-session-env to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8589>
[16:02] <zyga> ijohnson: I opened one more https://github.com/snapcore/snapd/pull/8589 <- I'm somewhat worried about 14.04 test coverage thourh, not sure if this is something I should bring back with a separate test that just tests "env"
[16:02] <mup> PR #8589: tests: port user-session-env to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8589>
[16:03] <zyga> ijohnson: actually, the realization that 14.04's systemd build is *not* connected to dbus was my biggest worry/surprise recently
[16:03] <zyga> ijohnson: I don't think we really had this internalized before
[16:03] <jdstrand> morphis: glad to hear
[16:03] <zyga> mborzecki: I think we have only one user of user.sh left
[16:04] <zyga> once that is gone I will update the PR from jamesh
[16:04] <zyga> jamesh: ^ if you are reading backlogs, we are working on removing user.sh hacks
[16:04] <zyga> jamesh: but we don't want to leave you on ice
[16:05] <stgraber> morphis: lxc.apparmor.profile=unconfined will break apparmor, don't do that
[16:05] <stgraber> morphis: and that would indeed cause breakage for the snap
[16:05] <morphis> yeah, makes sense
[16:06] <morphis> something we should fix at https://github.com/charmed-kubernetes/charm-kubernetes-master/blob/master/lxd-profile.yaml#L5 as well unless they use it different
[16:09] <zyga> morphis: imperfect but interesting https://github.com/search?l=&q=lxc.apparmor.profile%3Dunconfined+language%3AYAML&type=Code
[16:09] <zyga> jdstrand: ^ all the unconfined lxds
[16:12] <zyga> stgraber: do you know if there's a way for snapd to detect that it's running in lxd and that lxc.apparmor.profile=unconfined has been set?
[16:29] <stgraber> zyga: it's doable, yeah
[16:31] <mborzecki> zyga: updated #8588
[16:31] <mup> PR #8588: tests: port portals test to session-tool, fix portal tests on sid <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8588>
[16:32] <zyga> looking
[16:32] <mborzecki> and feel a bit dizzy, just traversed through QDesktopServices down to xdgDesktopPortalOpenFile() and omg
[16:33] <zyga> mborzecki: I think you need to drop the sid fragment now
[16:33] <zyga> mborzecki: because your PR adds the dbus-user-session package to sid
[16:33] <zyga> and that will be detected by tests/main/session-tool-support
[16:33] <zyga> mborzecki: what did you find?
[16:36] <stgraber> zyga: if /sys/kernel/security/apparmor/.ns_level doesn't exist or is < 1 + /proc/self/attr/current is unconfined
[16:36] <mborzecki> zyga: i think there's a bug in the portal handler, https://flatpak.github.io/xdg-desktop-portal/portal-docs.html#gdbus-org.freedesktop.portal.OpenURI states that calling that with file:// fails (by design), while the QDesktopServices::openURL() calls that for file://
[16:36] <stgraber> zyga: that should indicate lxc.apparmor.profile=unconfined I think
[16:36] <zyga> stgraber: I'll try that, thanks!
[16:36] <zyga> hmm
[16:36] <zyga> mborzecki: is there any remapping done?
[16:36] <zyga> I didn't check though, perhaps that's a question to jamesh/kenvandine
[16:37] <zyga> mborzecki: we could also ask flatpak developers
[16:37] <mborzecki> zyga: and there's an unhappy user in the forum
[16:37] <mborzecki> zyga: i mean that's the spec, and the portal works according to the spec
[16:37] <zyga> mmmm
[16:38] <mborzecki> zyga: suggested the user to drop file:// from the url, which triggers the path that calls OpenFile()
[16:38] <zyga> mborzecki: ah, I thought the bug is in the app itself
[16:38] <zyga> and it seems you say that the problem is with the usage pattern
[16:38] <mborzecki> but i can understand his frustration, even if he files a bug, and it gets fixed, it's probably not goiung to see the fix for the next 6 months or so
[16:39] <zyga>  /snap/test-snapd-desktop/x1/bin/cmd: 4: exec: sh -c 'echo hello world': not found
[16:39] <zyga> mborzecki: we could fix it in qt
[16:39] <zyga> is the app using a shared qt runtime?
[16:40] <mborzecki> zyga: i could even submit a patch if i got qt building locally and signed cla, but that's like a over-the-weekend recreational activity ;)
[16:41] <zyga> I think the desktop team can help with that
[16:51] <mborzecki> hmm otoh, that app is in qt, i see a segfault starting it on arch
[17:01] <mup> PR snapd#8468 closed: tests: adding option --no-install-recommends option also when install all the deps <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8468>
[17:04] <zyga> cachio: \o/
[17:05] <zyga> cachio, mborzecki: make sure there's a follow-up for https://github.com/snapcore/snapd/pull/8468#discussion_r417975489 please
[17:05] <mup> PR #8468: tests: adding option --no-install-recommends option also when install all the deps <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8468>
[17:05] <zyga> cachio: thank you for pushing this forward :)
[17:07] <cachio> zyga, yaw
[17:07] <zyga> :)
[17:08]  * cachio lunch
[17:08] <cjp256> hello, anyone by chance have thoughts on https://travis-ci.org/github/snapcore/snapcraft/jobs/681562924#L432 ?  this is the first time i've seen snap report that LXD is already installed, but `lxd` not found...
[17:09] <cjp256> fwiw, it happened on the 20.04 image
[17:09] <zyga> cjp256: probably $PATH
[17:09] <zyga> can you debug with echo $PATH
[17:09] <zyga> or you can work around with "snap run ..."
[17:13] <cjp256> zyga: there's a bunch of other tests that ran fine alongside it.   Appears random.  I'll restart it and see if it repros, then I'll print PATH.
[17:13] <zyga> cjp256: you can debug it with things like echo $PATH, snap list, find /snap/bin
[17:14] <cjp256> will do, thanks
[17:15] <zyga> type=AVC msg=audit(04/30/20 17:13:46.842:526) : avc:  denied  { write open } for  pid=27614 comm=systemd-logind path=/var/lib/systemd/linger/test dev="sda1" ino=417790 scontext=system_u:system_r:systemd_logind_t:s0 tcontext=system_u:object_r:init_var_lib_t:s0 tclass=file permissive=1
[17:15] <zyga> but I think that's actually my fault
[17:15] <zyga> :)
[17:15] <zyga> fixing now
[18:08] <mup> PR snapd#8590 opened: tests: port selinux-clean to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8590>
[18:21] <mup> PR snapcraft#3100 opened: Removed ``key`` from ``progressive`` dict following changes in the server API <Created by nessita> <https://github.com/snapcore/snapcraft/pull/3100>
[19:06] <mup> PR snapcraft#3098 closed: build providers: bootstrap with dirmngr <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3098>
[19:14] <zyga> ijohnson: you may want to have a 2nd look at https://github.com/snapcore/snapd/pull/8590
[19:14] <mup> PR #8590: tests: port selinux-clean to session-tool <Created by zyga> <https://github.com/snapcore/snapd/pull/8590>
[19:14] <zyga> I added one more bugfix for session-tool on selinxu
[19:14] <zyga> *selinux
[19:14] <zyga> namely this: https://github.com/snapcore/snapd/pull/8590/files#diff-a8fce2de6a6829d98f798117050b6c93R287
[19:15]  * ijohnson should probably stop reviewing things that are drafts
[19:15] <zyga> haha
[19:15] <zyga> I'm very grateful that you did
[19:15] <zyga> makes fixing those annoying failures gratifying :)
[19:16] <ijohnson> do non selinux systems just ignore The SELinuxContext in the dbus call to StartTansientUnit ?
[19:16] <ijohnson> zyga: ^
[19:16] <zyga> yeah
[19:16] <ijohnson> cool
[19:16] <zyga> session-tool is this little thing that turns out to be a big sprawling mess
[19:16] <zyga> but I think it's better than what we had before :)
[19:18] <ijohnson> it's at least more uniformly a big sprawling mess
[19:18] <ijohnson> and when it's used everywhere it makes it easier for everything to be closer to the right thing
[19:20] <zyga> hopefully very close to having that
[19:20] <zyga> I need to update incoming branches that use user.sh as well
[19:21] <zyga> there's one heavy use in user session services branch
[19:24] <zyga>  I hope we can land all the test fixes
[19:24] <zyga> we have 73 PRs
[19:24] <zyga> but a good chunk of those are recent fixes
[19:27] <zyga> I pushed a small patch to https://github.com/snapcore/snapd/pull/8588 to reflect a new test in master
[19:27] <mup> PR #8588: tests: port portals test to session-tool, fix portal tests on sid <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8588>
[19:28] <zyga> I think I'll EOD now
[19:29] <zyga> it's almost 21:30 here
[19:29] <zyga> mvo: are you going to be around tomorrow?
[19:39] <mvo> zyga: yes
[19:39] <zyga> ok
[19:57] <cachio> cmatsuoka, https://paste.ubuntu.com/p/hxnGhxdH7F/
[19:57] <cachio> works well with the pc 96
[19:57] <cmatsuoka> \o/
[20:13] <cachio> so, I need to wait for the new gadget