MarkMaglana | hi all o/ | 04:50 |
---|---|---|
facubatista | Muy buenos días a todos! | 11:02 |
mup_ | Issue operator#261 opened: Harness should support pod-spec-set <Created by jameinel> <https://github.com/canonical/operator/issues/261> | 12:17 |
mup_ | Issue operator#262 opened: Harness should support resource-get <Created by jameinel> <https://github.com/canonical/operator/issues/262> | 12:17 |
mup_ | Issue operator#263 opened: Harness should support storage-get and storage-add <Created by jameinel> <https://github.com/canonical/operator/issues/263> | 12:18 |
mup_ | PR operator#264 opened: Test harness backend calls <Created by jameinel> <https://github.com/canonical/operator/pull/264> | 12:30 |
* facubatista -> lunch | 15:11 | |
mup_ | Issue operator#265 opened: Auto determining handlers is actually not recommended <Created by jameinel> <https://github.com/canonical/operator/issues/265> | 16:03 |
cmars | hi, what's the best way to ask for a review of an operator charm? is here the right place to ask, or should i start a discourse thread (and if so, how/where/what category)? | 16:21 |
cmars | this is my charm: https://github.com/cloud-green/timescaledb-charm/tree/master/charm/timescaledb. really simple timescaledb subordinate that adds the extension to postgresql | 16:22 |
cmars | want to rid myself of any bad habits before they get too ingrained :) esp as i'm considering some non-trivial ones next... | 16:23 |
mup_ | Issue operator#266 opened: 'smooth' pypi project name <Created by phinate> <https://github.com/canonical/operator/issues/266> | 16:37 |
facubatista | cmars, hello! | 16:46 |
facubatista | cmars, this is the correct place to ask, yes! we don't have a structure to annotate these, I will open an issue in the project so this is not forgotten | 16:48 |
mup_ | Issue operator#267 opened: Review timescaledb-charm <Created by facundobatista> <https://github.com/canonical/operator/issues/267> | 16:50 |
facubatista | cmars, ^ | 16:50 |
cmars | facubatista: thanks! | 16:52 |
mup_ | PR operator#258 closed: docs: first pass at sphinx-built API docs <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/258> | 16:57 |
mup_ | PR operator#268 opened: docs: rtd uses 'sphinx<2', which is slightly different <Created by chipaca> <https://github.com/canonical/operator/pull/268> | 17:17 |
Chipaca | facubatista: if you could once-over this to make sure it's not entirely wrong i'd appreciate it | 17:18 |
facubatista | Chipaca, 268, you say? | 17:18 |
Chipaca | yeh | 17:19 |
Chipaca | facubatista: i thought i'd land the docs one and build rtd, and it failed because they're using 'sphinx<2' | 17:19 |
Chipaca | (in their defense, that's what sphinx calls stable) | 17:19 |
facubatista | Chipaca, you landed already the other branch? | 17:19 |
Chipaca | facubatista: yes | 17:19 |
facubatista | Chipaca, any reason you didn't create the reqs file? what dependency shall I install for this? | 17:22 |
Chipaca | facubatista: eh, i'll add a docs/req | 17:23 |
Chipaca | facubatista: pushed | 17:23 |
Chipaca | facubatista: suspecting we're going to also need to add a requirements.txt with PyYAML in it | 17:24 |
Chipaca | but we'll see | 17:24 |
facubatista | Chipaca, I think we should have a requirements.txt and requirements-dev.txt as most Python projects, and also maybe a docs/requirements.txt for the documentation part alone | 17:30 |
Chipaca | facubatista: i think we're in agreement (modulo the little discussion of whether it was req-dev or dev-req, i think we all agreed) | 17:31 |
Chipaca | facubatista: 268 adds docs/req | 17:32 |
Chipaca | facubatista: and i might push one that adds a /req if needed for the docs, otherwise we can do it next week | 17:32 |
Chipaca | i'm supposed to be off today but wanted to get rtd set up :) | 17:32 |
* Chipaca turns the oven on for pizza time | 17:39 | |
facubatista | Chipaca, I get this | 17:39 |
facubatista | Sphinx error: | 17:39 |
facubatista | master file /home/facundo/canonical/operator/docs/contents.rst not found | 17:39 |
facubatista | Chipaca, note that I did *not* really try IRL the previous branch | 17:39 |
facubatista | (so not sure if this error always was there or it's because current branch) | 17:40 |
Chipaca | facubatista: not sure where you got that error, but that's what you get with sphinx<2 on current master; that's part of what 268 fixes | 21:17 |
facubatista | Chipaca, ah, silly me | 22:14 |
facubatista | Chipaca, +1ed | 22:15 |
facubatista | and with that, /me eods | 22:15 |
facubatista | and eows, see you all on Monday! | 22:15 |
Chipaca | facubatista: o/ thanks! | 22:17 |
Chipaca | facubatista: oohh | 22:18 |
facubatista | Chipaca, uuhh | 22:19 |
facubatista | Chipaca, ? | 22:19 |
Chipaca | facubatista: https://operator-framework.readthedocs.io/en/latest/contents.html | 22:19 |
Chipaca | facubatista: some things still not 'right', and the domain isn't the definitive one, but, getting there | 22:20 |
facubatista | Chipaca, great | 22:20 |
Chipaca | anyway, i'm also EOWing | 22:21 |
facubatista | bye! | 22:21 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!