| hpidcock | wallyworld: just got this bootstrap lxd on 2.8-rc branch | 01:30 |
|---|---|---|
| hpidcock | Unable to fetch Juju GUI info: error fetching simplestreams metadata: cannot unmarshal JSON metadata at URL "https://streams.canonical.com/juju/gui/streams/v1/com.canonical.streams-released-gui.sjson": json: cannot unmarshal string into Go struct field Metadata.juju-version of type int | 01:30 |
| wallyworld | hpidcock: yup, they messed up the metadata | 01:31 |
| wallyworld | a fix is in progress | 01:31 |
| hpidcock | awesome | 01:31 |
| wallyworld | indeed | 01:31 |
| hpidcock | wallyworld: https://github.com/juju/python-libjuju/pull/412 | 02:07 |
| hpidcock | and anyone else interested in python-libjuju | 02:07 |
| wallyworld | looking | 02:07 |
| wallyworld | +43000!!!!!! | 02:08 |
| timClicks | wgrant: appreciate the time taken to write that response, thanks | 02:09 |
| wgrant | timClicks: It's possible that I may have some Opinions :) | 02:09 |
| wgrant | Thanks for starting conversations like this | 02:10 |
| timClicks | wgrant: am glad that thread was started with a warning ;) | 02:10 |
| wgrant | Heh, indeed. | 02:10 |
| wallyworld | hpidcock: ideally we'd use 2.8.0 for the schema not 2.8-rc2 as that reference will be out of date in days. can we add in the remaining schema from the model operator branch and use 2.8.0 | 02:14 |
| hpidcock | wallyworld: rc2 is 2.8.0 at the moment. If stuff hasn't landed in the rc branch it's not 2.8.0 yet | 02:16 |
| wallyworld | sure, but it seems unfortunate to release a new libjuju with will be out of date in terms of that in a matter of days | 02:17 |
| wallyworld | i guess we can do a 2.8.1 after 2.8 ships | 02:17 |
| thumper | hpidcock: reviewed libjuju | 02:29 |
| wallyworld | thumper: i'm still waiting on fixes/changes to the dashboard tarball, but this works with the one that's currently published. i also need to retest upgrades after changes to accommodate the recent tarball revision https://github.com/juju/juju/pull/11562 | 02:41 |
| thumper | wallyworld: ack | 02:48 |
| thumper | wallyworld: did you check that the old gui continued to work after the upgrade? | 02:51 |
| wallyworld | i did | 02:51 |
| wallyworld | will retest everything though after final tweaks for the new new new dashboard | 02:52 |
| wallyworld | thumper: everyone else super busy, so sorry, https://github.com/juju/juju/pull/11565 | 04:01 |
| wallyworld | ah balls, targetted to wrong branch, should be 2.7 | 04:04 |
| thumper | wallyworld: did you want me to retarget? | 04:07 |
| thumper | or do you need to rebase first? | 04:07 |
| wallyworld | thumper: i just rebased and retargetted | 04:07 |
| wallyworld | now i need coffee before i hack on the dashboard stuff again to support the new new format | 04:08 |
| thumper | wallyworld: asked a question... | 04:14 |
| wallyworld | thumper: answered | 04:19 |
| wallyworld | previously the offer stirng was a const | 04:20 |
| wallyworld | now it's built from series, and we also need the sku | 04:20 |
| thumper | wallyworld: right, but the number at the front is something they increment | 04:25 |
| thumper | not a fixed 0001 | 04:25 |
| wallyworld | supposedly | 04:25 |
| wallyworld | it's not something we know ahead of time, it's not something were can query. we could make it a vonfig somewhere but that has its own issues | 04:26 |
| thumper | which is why I asked can we do a substring match on the offer? | 04:26 |
| wallyworld | it's an arbirary decision outside of juju | 04:26 |
| wallyworld | no, becaue it's a param passed to azure | 04:27 |
| wallyworld | we don't match on it | 04:27 |
| wallyworld | we pass it to azure | 04:27 |
| thumper | right | 04:27 |
| thumper | I understand that | 04:28 |
| thumper | can we pass a substring? | 04:28 |
| thumper | is it an exact match? | 04:28 |
| thumper | because we shouldn't be using 0001 | 04:28 |
| wallyworld | it's used to tell azure to pick a particular image by tag, no substring involved, eg | 04:29 |
| wallyworld | return &compute.StorageProfile{ | 04:29 |
| wallyworld | ImageReference: &compute.ImageReference{ | 04:29 |
| wallyworld | Publisher: to.StringPtr(publisher), | 04:29 |
| wallyworld | Offer: to.StringPtr(offer), | 04:29 |
| wallyworld | Sku: to.StringPtr(sku), | 04:29 |
| wallyworld | Version: to.StringPtr(version), | 04:29 |
| wallyworld | }, | 04:29 |
| wallyworld | OsDisk: osDisk, | 04:29 |
| wallyworld | } | 04:29 |
| wallyworld | Offer is a straight out arg to an api call | 04:29 |
| wallyworld | we either have it or we don't | 04:30 |
| thumper | in which case we have a problem | 04:31 |
| wallyworld | if they ever chabge it yes | 04:31 |
| thumper | guarantee that they'll change it | 04:32 |
| kelvinliu | wallyworld: https://github.com/juju/juju/pull/11566 got this pr to move the retry to initialization function to retry the coping charm request only rather than retrying the whole remote init operation | 04:32 |
| wallyworld | we need to tell them not to | 04:32 |
| kelvinliu | could u take a look? | 04:32 |
| wallyworld | sure | 04:32 |
| kelvinliu | ty | 04:32 |
| wallyworld | kelvinliu: lgtm but retarget to 2.8-rc branch | 04:48 |
| kelvinliu | wallyworld: yep, ty | 04:48 |
| thumper | https://github.com/juju/juju/pull/11567 for a fix to the full status query tracker tests | 04:53 |
| wallyworld | hpidcock: kelvinliu: looks like another remote-init issue, bug 1878329 application-mattermost: 15:32:59 ERROR juju.worker.uniter resolver loop error: executing operation "remote init": caas-unit-init for unit "mattermost/0" failed: ERROR failed to remove unit tools dir /var/lib/juju/tools/unit-mattermost-0: unlinkat /var/lib/juju/tools/unit-mattermost-0/goal-state: permission denied | 04:53 |
| mup | Bug #1878329: stuck k8s workload unit following upgrade-charm with new image <juju:New> <https://launchpad.net/bugs/1878329> | 04:53 |
| wallyworld | thumper: looking | 04:53 |
| kelvinliu | that's weird, operator is the root user | 04:55 |
| wallyworld | thumper: just a small suggestion | 04:57 |
| wallyworld | thanks for the libjuju relase hpidcock, you've made several folks very happy, including the osm guys | 04:58 |
| thumper | not to mention solutions qa | 04:59 |
| kelvinliu | wallyworld: https://bugs.launchpad.net/juju/+bug/1877935 we still have this bug, | 04:59 |
| mup | Bug #1877935: operator trys to exec into the workload container but the container is not running yet <juju:New> <https://launchpad.net/bugs/1877935> | 04:59 |
| wallyworld | yeah we do :-( | 05:00 |
| kelvinliu | forgot mention in standup, I think this one and the watcher one should have higher priority than the block storage one? | 05:00 |
| wallyworld | yup | 05:00 |
| wallyworld | the block storage one is more a guard rail | 05:00 |
| kelvinliu | ok, im gonna look on these two first | 05:01 |
| wallyworld | with the init one, maybe we can try looking for the pod a few times, using retry() | 05:01 |
| wallyworld | or at least query the cluster to see if things are stareting up | 05:01 |
| wallyworld | and give them time to get done if they are | 05:02 |
| kelvinliu | i think there might be a upgrade charm flow missing in the init process | 05:03 |
| wallyworld | could be, i'd need to look at the logic again to see what's been implemented | 05:04 |
| kelvinliu | also I guess the watcher bug is related operator rather than the watcher itself. It seems the operator is not responding correctly if any uniter got those errors(like 137, etc). | 05:05 |
| thumper | wallyworld: you think I should just say "FullStatus" without the prefix ? | 05:07 |
| thumper | I think it would probably match too | 05:07 |
| wallyworld | thumper: it's more filtering out other method names that contain the one currently being filtered on | 05:08 |
| thumper | wallyworld: I don't know what you just said | 05:08 |
| wallyworld | so if the tracer has been set up to look for "FullStatus" and the traceback has "FullStatusVerbose", it would match both with the current code | 05:09 |
| thumper | FWIW, tracker := s.State.TrackQueries("FullStatus") works | 05:09 |
| wallyworld | we want to exclude "FullStatusVerbose" | 05:09 |
| thumper | well, then the caller should say "FullStatus(" | 05:09 |
| wallyworld | ok, I wasn't sure if the expectation / desire was for a single method match | 05:10 |
| wallyworld | to avoid ambiguity | 05:10 |
| thumper | it is sufficient for now, but we may need to tweak later, I'll add more of a comment on the TrackQueries method to explain so future people will know | 05:11 |
| wallyworld | sgtm | 05:11 |
| thumper | wallyworld: added more of a comment to explain on the tracker | 05:13 |
| thumper | so it shouldn't be a surprise to any future people using it | 05:13 |
| wallyworld | ty | 05:14 |
| thumper | wallyworld, or anyone: https://github.com/juju/juju/pull/11568 | 05:44 |
| thumper | tlm, hpidcock, kelvinliu: ^^? | 05:48 |
| kelvinliu | looking now? | 05:49 |
| thumper | kelvinliu: thanks | 05:49 |
| thumper | kelvinliu: generally for things we need to wait on, we use testing.LongWait | 05:53 |
| thumper | even if we expect them to happen quickly | 05:53 |
| thumper | there is no real change to the test times for running in that package | 05:53 |
| thumper | with the patch I had 2.2, 3 and 4s for the package on three different runs | 05:54 |
| thumper | before it was 2.7 seconds | 05:54 |
| thumper | so within the realm of ok IMO | 05:54 |
| kelvinliu | thumper: it's weird to see this errors because we mocked anything in caas provider, so no db or any network access, but the fix lgtm. | 05:54 |
| thumper | yeah, I'm betting it is just CPU contention | 05:54 |
| thumper | and the number of concurrent goroutines | 05:55 |
| thumper | yes it shouldn't take long | 05:55 |
| * thumper shrugs | 05:55 | |
| thumper | I'm pretty sure this will make the intermittent issues go away | 05:55 |
| kelvinliu | yeah, thanks for the fix | 05:55 |
| wallyworld | thumper: that PR should land in the 2.8 branch IMO | 06:03 |
| wallyworld | not 2.8-rc but 2.8 | 06:04 |
| wallyworld | tlm: your PR ready for another look? | 06:04 |
| timClicks | an excellent thread has emerged on a charm's error state for anyone who would like a few minutes of procrastination ahead of them https://discourse.juju.is/t/when-to-send-an-application-into-an-error-state/3046 | 07:48 |
| === salmankhan1 is now known as salmankhan | ||
| === salmankhan1 is now known as salmankhan | ||
| manadart | hml: Cherry-pick to the RC branch of Tim's ENI/Netplan patch: https://github.com/juju/juju/pull/11569 | 14:07 |
| hml | manadart: looking | 14:14 |
| hml | manadart: tick | 14:15 |
| manadart | hml: Ta. | 14:15 |
| === cory_fu_ is now known as cory_fu | ||
| manadart | hml: Small utility addition. No hurry; I am EoD: https://github.com/juju/juju/pull/11570 | 15:07 |
| cory_fu | petevg: I have a present for you: https://github.com/juju/python-libjuju/pull/415 There are still failing tests, but you can actually see what they are now and they would have caught the open issues with the 2.8 release. | 19:26 |
| petevg | cory_fu: nice! Thank you :-) | 19:27 |
| cory_fu | petevg: It would also be nice to see all of those "Event loop is closed" errors when a test fails cleaned up to make the results less noisy, but I'll leave that to you. ;) | 19:28 |
| petevg | +1 | 19:29 |
| petevg | :-) | 19:29 |
| cory_fu | petevg: I see that the Juju repo is also using GH Actions now. It would be really interesting if a portion of that PR could be ported over to the Juju repo so that breakages to libjuju are caught immediately rather than depending on a change to land in libjuju to find it. I guess one aspect of that is that you'd need to do the upstream sync as part of the test so that things like facade or definition changes got picked up. That probably worth | 19:55 |
| cory_fu | doing on the edge portion of the libjuju tests as well, TBH. | 19:55 |
| petevg | cory_fu: that makes sense. It'd be nice to catch this stuff right away ... | 19:55 |
| cory_fu | petevg: Downside is the 20+ minute duration of the integration tests, plus the fact that while the change in Juju might lead to a break, it would likely need to be fixed in libjuju rather than the Juju PR. | 19:57 |
| petevg | True. | 19:57 |
| petevg | That would create a chicken and egg issue! | 19:57 |
| cory_fu | I wonder if GitHub Actions could do a daily run with notifications? Or since you have a Jenkins already, adding a daily run to that to watch for libjuju breakage. | 19:57 |
| cory_fu | petevg: I actually thought that last one was planned when the Juju team took over libjuju, but I guess it got dropped. | 19:58 |
| rick_h | cory_fu: petevg one of the issues we had was the whole "land the thing that generates the new schema" and then go update the schema in the library chicken and egg issue | 20:44 |
| rick_h | cory_fu: petevg I think there is a test that's non-gating in jenkins that checks if things are likely to be broken. You can check with stickupkid on those as he's managed most of that to date | 20:44 |
| petevg | rick_h: cory_fu made a pr to make that test gating :-) | 20:45 |
| cory_fu | petevg: Different test | 20:45 |
| petevg | Aha! Got it. | 20:45 |
| cory_fu | rick_h, petevg: Would that be this test? https://jenkins.juju.canonical.com/view/github/job/github-integration-tests-pylibjuju/ | 20:47 |
| cory_fu | Hrm. Maybe this one? https://jenkins.juju.canonical.com/job/github-schema-tests-pylibjuju/ | 20:48 |
| petevg | You're showing me red circles and making me sad, cory_fu :-( | 20:50 |
| cory_fu | petevg: Red circles that haven't been run in months, too | 20:50 |
| cory_fu | petevg: Maybe this one will make you happier? https://jenkins.juju.canonical.com/job/github-check-merge-juju-python-libjuju/147/ | 20:51 |
| cory_fu | That is running the unit tests, at least, but that doesn't help with catching any of the stuff that the integration tests caught. | 20:52 |
| cory_fu | petevg: Thinking about it more, there's a chicken-and-egg issue in the other direction as well. If we make the libjuju edge tests do the upstream sync and it fails, it wouldn't really be relevant to the PR on that side either. | 20:54 |
| cory_fu | petevg: It definitely seems like the right thing is instead something like a daily build that uses master of Juju and master of libjuju, syncs and builds them, then runs the integration tests from libjuju. As long as that actually generated an alert that got paid attention to, it wouldn't block specific PRs but would let you know if there was an issue that would need to be addressed. | 20:55 |
| cory_fu | Plus the 20 or so minute runtime of the integration tests wouldn't be so onerous if only being run once a day. | 20:57 |
| thumper | wallyworld: https://github.com/juju/juju/pull/11571 | 23:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!