/srv/irclogs.ubuntu.com/2020/05/18/#snappy.txt

mupPR snapcraft#3129 opened: schema: add support for the daemon-scope property on apps <Created by jhenstridge> <https://github.com/snapcore/snapcraft/pull/3129>03:43
davido_Does this channel support issues with the snap management tool?03:46
davido_or is it only developer focused?03:46
mupPR snapcraft#3130 opened: build_providers: don't show an error if there are no auto-refresh changes <Created by jhenstridge> <https://github.com/snapcore/snapcraft/pull/3130>03:58
mborzeckimorning06:25
mvohey mborzecki06:28
mborzeckimvo: hey, can you take a look at https://github.com/snapcore/snapd/pull/8604 ?06:29
mupPR #8604: interfaces/builtin/desktop: do not mount fonts cache on distros with quirks <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8604>06:29
mvomborzecki: sure06:30
mborzeckimvo: thanks06:30
mvomborzecki: thanks, done, we should also squash it I think06:31
mborzeckimvo:yeah, easier to cherry pick06:31
mvo+106:33
zygahey06:45
mvogood morning zyga06:45
mborzeckizyga: hey06:48
zygahow was Friday?06:48
mborzeckizyga: that opensuse go thing is weird, looks like there's a parallel install of go1.13 and go1.12, and the packages are conflicgting on who owns /usr/bin/go06:49
zygayeah06:49
zygamaybe it is some kind of vendor change situation06:49
zygabut I really don't know06:49
mborzeckiactually, afaiu both packages ship /usr/bin/go ?06:49
zygaI never experienced this myself06:50
zygayeah06:50
mborzeckizyga: we also ahve `BuildRequires:  go >= 1.9` so go1.13 should be just fine, unless it doesn't provide go?06:51
zygamaybe something else depends06:52
zygaor maybe we just mass-upgrade06:52
zygaI didn't look that deeply06:52
mborzeckimaybe it's confused when we ask for go >= 1.9 :/06:53
mborzeckiit's funny, bc we end up with older go than we had :P06:53
zygammm, as in doesn't understand that dependency is satisfied?06:53
zygaI think that's unlikely06:53
zygabtw, suse does roll back packages normally06:53
zygatheir repo points to the truth06:53
zygaand systems adjust06:54
zygaand it's not unheard of packages going to older releases06:54
zygamaybe that's what going on06:54
pstolowskimorning07:01
zygahey pawel07:01
zygarainy morning07:01
zygaperfect for Monday07:01
mvogood morning pstolowski07:06
pstolowskizyga: same here07:10
mborzeckipstolowski: hey07:29
mborzeckizyga: heh, zypper insists on installing 1.12, however what provides lists many options https://paste.ubuntu.com/p/P8NbcSGpRR/07:30
pstolowskimborzecki: your hunch about selinux denials & go doing enumeration of network interfaces was good.. https://paste.ubuntu.com/p/JQQDrTqsg8/07:47
mborzeckipstolowski: heh, no a question which part of the code does that07:47
mborzeckipstolowski: maybe pulling in net package triggers is07:48
pedronisit's the randutil code07:49
mborzeckiomg, i see now, it's listing interfaces07:50
pstolowskiah07:51
mborzecki/ mix in net interfacles hw addresses (MACs etc)07:51
mborzecki  if ifaces, err := net.Interfaces(); err == nil {07:51
pedronisbut it's inderect07:51
pedronisit you neeed to be using RandDuration07:51
pedronisbut we have a few places that use RandomDuration at the top level07:51
pstolowskiit's only in my PR, apparently indirectly pulled (by configcore?)07:52
pedronishttps://github.com/snapcore/snapd/blob/master/randutil/rand.go#L9307:52
pedronispstolowski: let me think a second, we had something in mind that we might have forgotten07:54
pstolowskipedronis: for clarity, this is now triggered by snap cli, not snapd07:55
pedronispstolowski: yes, we have worked toward a way to build configcore without pulling in the mangers07:55
pedronisbut we haven't finished the work07:55
pedroniswe really don't want the managers in snap07:55
pedronisthis is showing that very indirectly07:55
mvogood morning pedronis !07:56
pedronispstolowski: we need to finish that work07:59
pedronisand it's going to be a of a pain as we learned from nosecboot08:00
mborzeckizyga: addeda  note under https://github.com/snapcore/snapd/pull/8685#issuecomment-630014236 perhaps it's worth checking with go packaging guidelines or in #opensuse about the best solution08:01
mupPR #8685: opensuse: zypper --replacefiles <Created by zyga> <https://github.com/snapcore/snapd/pull/8685>08:01
pstolowskimborzecki: btw i also saw some selinux denials that for some reason were not reported when using --checkpoint ..., only shown with ausearch -i -m AVC. i haven't investigated it and i don't know if it is anyhow related to my branch or also present in master - https://pastebin.ubuntu.com/p/TBRdbCFvkS/08:02
zygamborzecki: 1:108:02
pedronispstolowski: am I making sense?08:03
pstolowskipedronis: yes, i remember the general idea/desire we discussed some time ago. don't know what does this entail yet08:05
pedronispstolowski: mostly usinh build flags, except for some of the distro they don't quite work :/08:05
pstolowskipedronis: in this particular case, is there a concern of entropy? could we land this early-config PR by temporarily relaxing selinux check in these tests?08:06
pedronispstolowski: temporarely for how long?  we really don't want to pull in the managers in snapd08:07
pstolowskipedronis: i can start working on proper fix today, just don't know how annoying/long will it be and for long early config will be blocked because of this08:09
pedronispstolowski: to be clear I'm not too concerned about relaxing the selinux rules otoh is completely not the work we need08:09
mborzeckipstolowski: i saw those only in our tests though, i suspect it's because we repack the core snap and try to prevent the new squashfs from picking up default label (home_t) by passing unlabeled_t epxliciltly, however we also expliclity set the context=.. when mounting the squashfs, but that doesn't stop the denials due to unlabeled_t when running hooks to appear, i suspect there may be some race08:19
mborzeckibetween snapd accessing the contents and desired label set at the fs level08:19
mborzeckipstolowski: iirc if you go an ls -lZ those locations they have snappy_snap_t as expected08:20
mupPR snapd#8676 closed: tests: port interfaces-dbus to session-tool <Test Robustness> <Created by zyga> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8676>08:24
pstolowskimborzecki: ack08:28
zygare08:44
zygamborzecki: looking08:44
zygamborzecki: nice work!08:46
zygabrb, tea and back into the fray :)08:47
pedronispstolowski: are you blocked atm?08:56
pstolowskipedronis: no08:57
zygaand back08:57
pedronispstolowski: we can chat after lunch about what to do, I have a meeting now08:58
pstolowskipedronis: ok, thanks08:58
mupPR snapd#8686 opened: o/devicestate: cleanup system actions supported by recover mode <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8686>09:17
pedronispstolowski: can you setup a meeting before the standup when is convenient for you?10:02
pstolowskipedronis: will do10:03
mupPR snapd#8687 opened: [RFC] overlord: show what manager throws a state ensure error <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8687>10:09
mupPR snapd#8688 opened: [RC] state: log task errors in the journal too <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8688>10:19
mupPR snapd#8689 opened: o/devicestate: raise conflict when requesting system action while seeding <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8689>10:46
mupPR snapd#8690 opened: devicestate: do not report "ErrNoState" for seeded up <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8690>10:48
mborzeckimvo: left a comment under https://github.com/snapcore/snapd/pull/8687#discussion_r42654496111:14
mupPR #8687: [RFC] overlord: show what manager throws a state ensure error <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8687>11:14
mvomborzecki: yeah, saw it, looks interessting. I guess we samuele to decide if we should consider this at all but yeah, if we do maybe doing something smarter would be good.11:15
pedronisyes, I think we touch this, it's better to the work, it shouldn' be too hard to something sensible, it will need more than 1 line though11:16
mvopedronis: shall I close it given that it need to be reworked?11:17
mborzeckibtw. devicemgr seems to dtrt, maybe it's enough we add error wrappers for other managers and still log it in stateengine?11:18
mborzeckixerrors would be nice too11:18
mupPR snapd#8688 closed: [RFC] state: log task errors in the journal too <Needs Samuele review> <Created by mvo5> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8688>11:19
mborzeckiit captures the frame info so we'd have exact line in the manager11:19
mvomborzecki: nice11:19
mupPR snapd#8688 opened: [RFC] state: log task errors in the journal too <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8688>11:20
pedronismborzecki: I'm not sure I want to invest in xerrors atm11:20
pedronisI pressed close by mistake11:21
pedronismvo: you want to land these things in 2.45 I imagine?11:21
mvopedronis: yeah, mostly to give us slightly better error reporting. I know it's not ideal but it seems not like a step backwards and we can always improve it11:22
mvopedronis: I care less about 868711:22
mvopedronis: the other one 8688 is a bit more interessting I feel because I noticed when we ask for logs for install failure we tend to lack information11:23
mvopedronis: anyway, up to you - I totally understand if you prefer something better that is less "ad-hoc"11:23
pedronismvo: I have a old PR to address that, doing the right thing is quite a bit of work11:23
pedronisthough, it's probably time to do it, but not 2.4511:24
* mvo nods11:25
mvopedronis: for which one do you have a PR? or for the stateengine errors one?11:25
mvos/or//11:25
pedronisfor logging task errors11:25
pedronisit's a PR from 2016 to give you a sense of things11:26
mborzecki8688 would be nice, it was super annoying debugging why install failed when running with too small image, there was no other way but to use the debug shell, not sure if even https://github.com/CanonicalLtd/subiquity/pull/771 will be enough11:26
mupPR CanonicalLtd/subiquity#771: console-conf-wrapper: show snapd log during install <Created by mvo5> <https://github.com/CanonicalLtd/subiquity/pull/771>11:26
mvopedronis: woah :) ok11:26
mvomborzecki: 771 will be enough but I still think it would be nice to have task error in our log but again, I will not fight over this11:27
pedronismvo: to be clear, I'm not against the logging, the biggest issue is what to log11:28
pedronissummaries are long, task numbers are not informative11:28
pedronisI'm not sure all summaries are complete enough11:29
pedronisthe latter is less of an issue11:29
mvopedronis: right - I was thinking about this too and it seemed like the summary is usually ok but yeah, it's not ideal in all cases.11:30
mborzeckimvo: i see xnox raised the same issue, i think there's a problem when snap watch/change is called to early11:30
mvopedronis, mborzecki fwiw, I created an image too small to install and tested all my changes against that to see if my changes improve the error/log output11:30
mvomborzecki: yes, I need to look, it did not happen in my testing but I was probably lucky11:31
mvomborzecki: for me it was the other way around actually, usually install-system was already done in the error case by the time this code was reached, but again, I think there is no gurantee :/11:31
mvomborzecki: I need to think11:31
mvopedronis: I think you raise an important point, *if* we log the task error we probably need the id there too for cross reference at least. my pr is not doing this right now11:32
* mvo shuts up for a couple of minutes to give others the chance to talk too :)11:34
pedronismvo: we don't display task numbers though usually11:35
* mvo nods11:35
mupPR snapd#8680 closed: tests: port interfaces-autopilot-introspection to session-tool <Test Robustness> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8680>11:36
zygabrb11:42
mupPR snapd#8684 closed: tests: add a note about broken test sequence <Skip spread> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8684>12:05
mborzeckimvo: in the context of https://bugs.launchpad.net/snapd/+bug/1878943 it'd be nice if we made use of the timinigs we have in the install-system handler12:09
mupBug #1878943: armhf core20 image unusable on rpi2, rpi3 <uc20> <snapd:New> <https://launchpad.net/bugs/1878943>12:09
mborzeckimvo: there's still a question how to show the timings before reboot12:09
pedronismvo: I made a proposal12:14
pedronisin #868812:15
mupPR #8688: [RFC] state: log task errors in the journal too <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8688>12:15
pstolowskipedronis: i'm in the HO12:24
mborzeckimvo: do you think we could cherry pick https://github.com/snapcore/snapd/pull/8580 to 2.45.1?12:51
mupPR #8580: data/completion: add `snap` command completion for zsh <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8580>12:52
mborzeckii'll distro patch it in arch and fedora for now12:52
mborzeckimvo: i can open a PR with relevant patches for 2.45 branch12:52
mupPR snapd#8691 opened: tests/lib/bin: a TODO to improve the naming and uniformatiy of utilities <Created by pedronis> <https://github.com/snapcore/snapd/pull/8691>12:57
mvomborzecki: yeah, let's cherry-pick the zsh12:58
mvomborzecki: let me look12:58
mupPR snapcraft#3130 closed: build providers: don't show an error if there are no auto-refresh changes <bug> <Created by jhenstridge> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3130>13:11
mupPR snapcraft#2843 closed: snap: only ship .pyc files, strip shared objects <Created by om26er> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2843>13:32
mupPR snapd#8690 closed: devicestate: do not report "ErrNoState" for seeded up <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8690>13:40
mborzeckihmm i cannot open files via xdg-desktop-portal anymore in 2.4513:41
mborzeckimaj 18 15:40:27 galeon xdg-desktop-por[466975]: g_desktop_app_info_get_string: assertion 'G_IS_DESKTOP_APP_INFO (info)' failed13:41
mborzeckimaj 18 15:40:27 galeon xdg-desktop-por[466975]: g_app_info_launch_uris: assertion 'G_IS_APP_INFO (appinfo)' failed13:41
ijohnsonoh no13:41
mborzecki(on arch)13:41
mborzeckipff, zip/pdf/directories open fine though13:42
mborzeckigraphical files do not13:42
mborzeckithey do open outside of snap tho13:43
* zyga -> lunch13:52
cachiozyga, we need google-compute-engine  availlable for fedora-32 https://paste.ubuntu.com/p/V58T6xCv3v/14:36
zygacachio: where is that package coming from?14:37
cachioPharaoh_Atem, hey, you are the owner of the google-compute-engine package in fedora right?14:37
zygathat's a copr repo14:37
zygaperhaps we don't need it?14:37
cachiozyga, I think Neal owners it14:38
zygacachio: no, he owns the copr we use to get it from14:38
zygacachio: perhaps we don't need the copr at all?14:38
zygacachio: or perhaps the package in general14:38
cachiozyga, ah, ok, I'll try14:38
zygacachio: does the stock f32 cloud image have this package installed?14:38
cachiozyga, let me check14:39
cachiozyga, seems to be installed14:43
zygagreat, then we don't need anything, just use that14:43
zyga(no need for copr)14:43
cachio zyga, yes, now creating the image again14:46
zygasounds good14:46
pedronismborzecki: in your chain of PRs when did you plan to create systems.go ?15:01
mborzeckipedronis:  it's in this one: https://github.com/snapcore/snapd/pull/868915:01
mupPR #8689: o/devicestate: raise conflict when requesting system action while seeding <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8689>15:01
pedronismborzecki: ok, thx15:02
MattJCurious if there is a reason /snap/bin is added in profile.d only, and therefore isn't added to non-interactive sessions?15:04
MattJe.g. snap install aws on server, then `ssh user@server aws` fails with 'command not found'15:04
pedronismborzecki: I reviewed #8672 and #868615:26
mupPR #8672: o/devicestate: change how current system is reported for different modes <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8672>15:27
mupPR #8686: o/devicestate: cleanup system actions supported by recover mode <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8686>15:27
mupPR snapd#8692 opened: configcore: add nomanagers buildtag for conditional build <Created by stolowski> <https://github.com/snapcore/snapd/pull/8692>15:30
pstolowskipedronis: ^ this seems to be sufficient. i can do ConfGetter change separately, didn't do it in this PR as it would create noise in the diff15:31
pedronispstolowski: as I said it matters less15:31
pedronispstolowski: I will look at it in a bit15:31
mupPR snapcraft#3131 opened: plugin handler: debug build commands if developer debug enabled <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3131>15:38
mborzeckipedronis: thanks!15:49
pedronisijohnson: thanks for setting up a meeting15:49
ijohnsonpedronis: sure let me know if there's anything I can do to help or if we should try and pull in somebody from cloud-init15:49
pedronisijohnson: don't think so, I'll try to prepare a bit in my morning15:51
ijohnsonack15:51
* cachio lunch15:52
pedronisijohnson: I did a pass on #868316:18
mupPR #8683: osutil/disks: support IsDecryptedDevice for mountpoints which are dm devices <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8683>16:18
ijohnsonthank you looking now16:19
zygacachio: hey, can you please update the tw image17:02
zygacachio: a "zypper dup" is enough to resolve our issue17:02
zygacachio: I could bake it into the prepare section but I think this is just better17:03
mupPR snapd#8685 closed: opensuse: zypper --replacefiles <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/8685>17:05
* zyga EODs17:07
ijohnsonpedronis: hmm while looking for documentation on the format of DM_UUID and/or the dm/uuid sysfs value it seems that we may have a slight problem17:07
ijohnsonaccording to some of the back and forth on https://bugzilla.redhat.com/show_bug.cgi?id=1322110, the DM_UUID is meant to be an implementation detail and ought not to be parsed because it could be broken at any time17:07
ijohnsonnow that may be true generally, but I'm wondering if we can rely on it for now because 1) we are in control of the thing creating the volume (snap-bootstrap calling systemd-cryptsetup) , 2) the thing creating the volume is from other software version we kinda control, in that systemd version 245/luks/cryptsetup seems unlikely to bump and change significantly over the lifetime of the core20 snap17:09
ijohnson3) the version of systemd in the initramfs should always match what's in the core20 snap I think(?)17:10
cachiozyga, sure, I am finishing fedora 3217:10
ijohnsonso all the things poking / creating this device mapper volume (which is where the DM_UUID value comes from) should be stable over the lifetime of uc20/core20 I think17:10
ijohnsonif that's not good enough then I will need to seriously think about how we can re-write this code, and moreover why we do not have the additional udev params that we expect in the initrd17:11
cachiozyga, in 10 minutes will be ready17:11
cachioand Ill fix tw17:11
=== ijohnson is now known as ijohnson|lunch
mborzeckizyga: https://github.com/snapcore/snapd/pull/8685#issuecomment-630315807 what do you mean by unlucky snapshot? does it install the latest aviablel go version (eg. go1.14) or rather the `go` package in version 1.12.sth?17:15
mupPR #8685: opensuse: zypper --replacefiles <Created by zyga> <Closed by zyga> <https://github.com/snapcore/snapd/pull/8685>17:15
cachioSaviq, hey, are you using fedora 28 and 29 images for testing?17:40
cachioSaviq, we want to rmemove them17:40
cachioSaviq, is it ok for you?17:40
Saviqcachio: remove away https://github.com/MirServer/mir/blob/master/spread.yaml#L517:40
cachiosergiusens, same question for you17:40
sergiusenscachio: we do not.17:41
cachioSaviq, good, hopefully we will have fedora 32 today17:41
sergiusensfeel free to remove17:41
cachiosergiusens, thanks17:41
=== ijohnson|lunch is now known as ijohnson
mupPR snapd#8672 closed: o/devicestate: change how current system is reported for different modes <UC20> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8672>17:47
pedronisijohnson: well we either parse the uuid, or we call cryptsetup status <device-mapper-name> and parse the output18:14
ijohnsonpedronis: which do you think we should do? As I said it seems unlikely that the dm uuid will change for the lifetime of uc20, but then again it could since upsteam devs don't think it's meant to be inspected18:15
pedronisijohnson: it's probably easier to use cryptsetup status, otoh the output doesn't seem super machine friendly (differently for other tools it doesn't seem a way to control the output format)18:16
ijohnsonlet me boot into the initrd and see how the output looks there18:17
ijohnsonpedronis: let me boot into the initrd to see how it looks there18:18
mupPR snapcraft#3132 opened: go v1 plugin: warn when using go.mod and go < 1.13 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3132>18:51
ijohnsonpedronis: after some other new hurdles I learned about (now I have to always also re-build pc gadget to test initramfs changes), I now find that cryptsetup isn't even in the initramfs19:23
ijohnsonafaict we only have systemd-cryptsetup which doesn't understand the "status" argument19:24
pedronisijohnson: no, it can only setup things, so much fun19:24
ijohnsonyep!19:24
pedronisijohnson: let's pursue the parsing to unblock us, and then reconsider this I suppose19:32
ijohnsonpedronis: ok, I will add a TODO to the code about sorting this out perhaps19:32
mupPR snapd#8693 opened: tests: adding fedora 32 to spread.yaml <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8693>19:49
cachiozyga, ~19:49
cachiotests breacking on fedora 3219:49
cachiozyga, https://paste.ubuntu.com/p/vfQqBG2SCG/19:50
* cachio afk20:10
pedronisijohnson: are you now unblocked on what to do with #8683 ? also if you think is risky keep reading the dm files directly20:22
mupPR #8683: osutil/disks: support IsDecryptedDevice for mountpoints which are dm devices <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8683>20:22
ijohnsonpedronis: yes I'm unblocked I will address your comments20:22
pedronisok, thx, going to call it a day20:23
ijohnsonsounds good, talk to you tomorrow20:23

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!