[08:39] <tomwardill> hah, me and cjwatson collide on a pappacena MP again :)
[08:43] <wgrant> It's always interesting to compare colliding reviews.
[08:48] <tomwardill> in this case, I think it's the result of spending too much time reading the registry api docs
[08:49] <cjwatson> wgrant: Could you have another look over https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/384035 ?  I think I've dealt with your suggestions (aside from the bit I split out to a Trello card)
[08:49] <wgrant> Looking
[08:49] <wgrant> The bulk helper I suppose?
[08:49] <cjwatson> Yeah
[08:50] <cjwatson> I agree it would be a good idea - the current necessary invocation is pretty messy
[08:50] <wgrant> Yeah
[08:50] <wgrant> Was hoping it'd gross you out enough that you'd fix it as a driveby, but it is non-trivial indeed.
[08:56] <wgrant> Thanks for fixing my misguided NewBuildersScanner class.
[08:58] <wgrant> cjwatson: Just a couple of trivial comments. Thanks.
[08:58] <wgrant> Did my review of the followup make sense?
[08:59] <cjwatson> I've only skimmed it so far, but it looked clear enough
[08:59] <cjwatson> Need to QA the DMARC thing and maybe catch up on more reviews, but it's next on the list after that
[10:25] <cjwatson> teward: Could you have a look over http://blog.launchpad.net/?p=4318&preview=true and see if it looks right to you?
[10:31] <cjwatson> teward: (The change isn't on production yet - that post is in draft until it is, hopefully in a few hours)
[12:30] <pappacena> tomwardill, cjwatson thanks for the great review. :-)
[12:30] <tomwardill> heh
[12:49] <teward> cjwatson: 404
[12:52] <teward> Cant see it
[12:57] <teward> Either i need rights on the site, or you will just need to pastebin or email me the contents for review :)
[13:09] <cjwatson> teward: Ugh, sorry.  Plain-text part of it is https://paste.ubuntu.com/p/5RPrCrVKDf/ (some links, but nothing critical for understanding)
[13:13] <teward> looks good to me.  be aware automatic address books and autocomplete in email clients will explode with thisnchange and thats beyond our ability to fix.  But otherwise the post contents look good to me.
[13:18] <cjwatson> Right, although that's already the case for people with hide_email_addresses set
[13:19] <cjwatson> And presumably mangling the real-name part of the address would just result in a vast pile of "Colin Watson via bug #1000", "Colin Watson via bug #1001", etc. junk in people's address books / autocomplete, which doesn't seem like an improvement
[13:19] <mup> Bug #1000: There are too many bug reports in Malone <lp-foundations> <NULL Project:Invalid> <https://launchpad.net/bugs/1000>
[13:19] <mup> Bug #1001: Distribution shouldn't have "Change Members" etc for those who can't <lp-foundations> <Launchpad itself:Fix Released by mpt> <https://launchpad.net/bugs/1001>
[13:25] <teward> True cjwatson
[13:26] <cjwatson> teward: Do you think I should add any explicit text about this, or just leave the "any strange behaviour in your email client" bit to do the work?
[13:26] <teward> Just leave it as is
[13:26] <cjwatson> OK
[13:26] <cjwatson> Thanks
[13:26] <teward> My statement was if people complain about autocomplete in their clients we Invalid and explain thats a problem we cant fix
[13:27] <teward> More for us as a set of triage guidelines for those issues
[13:27] <teward> Because they will crop up so
[13:27] <cjwatson> Right, though it may be worth looking around in case there are some magic client-dependent strategies for avoiding it in certain cases
[13:27] <cjwatson> We'll see
[13:28] <cjwatson> Reminded of http://blog.launchpad.net/notifications/improved-filtering-options-for-gmail-users although the solution to that ended up being almost comically low-tech
[14:43] <cjwatson> teward: https://blog.launchpad.net/notifications/bug-emails-now-use-the-bugs-address-in-the-from-header up now
[14:45] <tomwardill> bug closed and commented: https://bugs.launchpad.net/launchpad/+bug/1589693/comments/27
[14:45] <mup> Bug #1589693: Make Launchpad DMARC Compliant to avoid Launchpad mail considered spam <Launchpad itself:Fix Released by teward> <https://launchpad.net/bugs/1589693>
[16:09] <teward> cjwatson: tomwardill: re 1589693 i edited the title/summary to reference bug mail specifically
[16:09] <teward> i also opened 1879740 for the code notification issues, in the same vein as the other bug.  But with a fairly terse comment since it doesn't need reexplained DMARC importance now.
[16:10] <teward> thank you though, all of you, for allowing me to work with you guys to get the bug notification bits pushed in (and working with me to get a dev environment up and helping me through the initial hurdles of LP dev heh)
[16:11] <teward> and i've already started work on the code notification changes.  but something else broke in the test suite so i'm still digging there.
[16:11] <SpecialK|Canon> teward: Thanks for contributing :)
[16:12] <teward> happy to :)  and happy to continue to contribute at least a little :)
[16:18] <cjwatson> Indeed :)
[16:18] <cjwatson> Hm, I suppose I'd better not leave TestBinaryBuildPackageBehaviourBuildCollection broken overnight, bah
[16:34] <cjwatson> Could I have a quick review of https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/384280 please?
[16:35] <tomwardill> 👀
[16:37] <tomwardill> +1
[16:37] <cjwatson> Ta
[16:58] <teward> cjwatson: i can confirm the mail delivers properly with the new LP from addresses.  My syntax checker is doing a 'Hmmmmm..." because Reply-To and From are the same base address, but that's a tiny minor annoyance and not really breaking email at all
[16:58] <teward> so thanks again for accepting the contribution in :)
[18:34] <pappacena> tomwardill: you probably EODed already, but the MP with bearer token auth is ready to be reviewed. If you have some minutes tomorrow: https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/384192