| === KindTwo is now known as KindOne | ||
| mborzecki | morning | 04:47 |
|---|---|---|
| mup | PR snapd#8712 opened: o/devicestate: typo fix <Simple ๐> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8712> | 04:57 |
| mup | PR snapd#8713 opened: update avahi-daemon labelling to allow simply "avahi-daemon" <Created by jetpackdanger> <https://github.com/snapcore/snapd/pull/8713> | 05:10 |
| mborzecki | mvo: hey | 06:46 |
| mborzecki | mvo: how was the long weekend? | 06:47 |
| mvo | hey mborzecki - it was quite nice, thank you ! how are you? what did I miss? | 06:47 |
| jamesh | hi mvo | 06:48 |
| mvo | hey jamesh ! nice to see you | 06:50 |
| mvo | mborzecki, jamesh looks like 8713 should get cherry-picked back into 2.45 (?) | 06:50 |
| mborzecki | mvo: yes, i think so, from what i can tell by looking at aa versions, bionic is likely the last release that had /usr/bin/avahi-daemon as the label, but i haven't checked the actual profile content | 06:52 |
| mvo | mborzecki: woah, so this went undetected for quite some time | 06:53 |
| mborzecki | mvo: i did not check the actual profile content, maybe it was distro patched to use the old name | 06:53 |
| jamesh | mvo: the profile is shipped separately in the apparmor-profiles package, which we don't install by default. | 06:54 |
| mborzecki | jamesh: so without the profiles package we'd get unconfined, right? that'd explain why it went unnoticed | 06:55 |
| jamesh | mborzecki: yes | 06:55 |
| zyga | good morning | 06:59 |
| zyga | hey jamesh | 07:00 |
| zyga | hey mborzecki | 07:00 |
| zyga | hey mvo :) | 07:00 |
| mborzecki | hey zyga | 07:01 |
| mvo | hey zyga ! good morning - how are you? | 07:01 |
| mvo | zyga: had a good weekend? | 07:01 |
| zyga | mvo: Friday was the best, yeah | 07:01 |
| jamesh | hi zyga | 07:01 |
| zyga | mvo: offtopic: there was a bunch of weird snaps added to the store over weekend | 07:02 |
| zyga | I wonder if we have some sort of store response team to raise those to | 07:02 |
| zyga | or if we have some guidelines on phony/phishy snaps | 07:02 |
| mborzecki | zyga: some typosquatters? | 07:02 |
| zyga | no, they were even kind enough to namespace them all | 07:03 |
| zyga | one moment | 07:03 |
| pstolowski | morning | 07:03 |
| zyga | hey pawel | 07:03 |
| zyga | mvo: snap find mobius | 07:03 |
| zyga | looks like one large cryptoscam | 07:03 |
| mvo | good morning pstolowski | 07:04 |
| mvo | zyga: probably best to reach out to #snapstore | 07:04 |
| zyga | mvo: right, my question was mostly about that, is IRC the go-to method? | 07:04 |
| mborzecki | zyga: hm some forexa apps? that's what it says on their website: ะัะปััะธะฟะปะฐััะพัะผะตะฝะฝัะน ัะตัะผะธะฝะฐะป ะดะปั ัะพัะณะพะฒะปะธ ะฝะฐ ััะฝะบะต Forex | 07:05 |
| mvo | zyga: there is a mailing list iirc | 07:05 |
| zyga | mborzecki: dunno what those are, just looked weird | 07:05 |
| zyga | they all appeared in one day | 07:05 |
| mvo | zyga: but I would start with irc or a bugreport in LP against snapstore, if it looks serious maybe even tagged security | 07:05 |
| zyga | ok | 07:05 |
| mborzecki | there's even a windows app https://mtrader7.com/ru/terminals/windows | 07:05 |
| zyga | thanks! | 07:05 |
| zyga | my primary school days are coming to hount me with cyrlic | 07:06 |
| zyga | terminal dla windows? | 07:06 |
| mborzecki | hahah | 07:06 |
| zyga | and offtopic, to close the weekend | 07:07 |
| zyga | civ6 is free on epic games | 07:07 |
| mborzecki | fwiw, it'd be nice to be able to list the snaps from a given publisher in the snapstore page | 07:07 |
| zyga | if you like civ games that's the ultimate bragin | 07:07 |
| zyga | mborzecki: oh yeah | 07:07 |
| mvo | zyga: woah | 07:08 |
| zyga | mvo: it plays wonderfully (though on windows) | 07:08 |
| zyga | civ has grown quite a bit since my atari ST days | 07:08 |
| zyga | but the mood is really the same | 07:09 |
| mvo | zyga: cool, I have a windows partition somewhere :) | 07:15 |
| mup | PR snapd#8712 closed: o/devicestate: typo fix <Simple ๐> <Skip spread> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8712> | 07:16 |
| zyga | jamesh: hey, while I have you, do you think https://github.com/snapcore/snapd/pull/8708 is sensible? | 07:19 |
| mup | PR #8708: tests: setup portals before starting user session <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8708> | 07:19 |
| zyga | mvo: travis is often stuck on yellow on PRs btw | 07:19 |
| zyga | mvo: usually retriggering the test in travis (which is green on their side) fixes it | 07:19 |
| pedronis | mborzecki: hi, did you want to vote need fixing on #8661 ? | 07:21 |
| mup | PR #8661: configcore: add "service.console-conf.disable" config option <Created by mvo5> <https://github.com/snapcore/snapd/pull/8661> | 07:21 |
| mborzecki | pedronis: hm? | 07:21 |
| mborzecki | ah | 07:21 |
| zyga | hey pedronis | 07:22 |
| mborzecki | pedronis: right, wanted to check in with mvo about this | 07:22 |
| zyga | pedronis: I didn't get to it last week but you can expect first wave of tool patches today | 07:22 |
| zyga | pedronis: I made progress on https://github.com/snapcore/snapd/pull/7825 | 07:23 |
| mup | PR #7825: many: use transient scope for tracking apps and hooks <Security-High> <Created by zyga> <https://github.com/snapcore/snapd/pull/7825> | 07:23 |
| zyga | pedronis: it should be ready for tomorrow, perhaps we could discuss what needs to happen next | 07:23 |
| zyga | hmm, I think cachio may have left the 16.04-32 bit image unupdated | 07:25 |
| pedronis | mvo: hi, shouldn't debian-sid rules rm snap-bootstrap like 14.04 ? | 07:31 |
| mvo | pedronis: I think we don't even build it there, let me doulbe check | 07:31 |
| mvo | pedronis: iirc during the build phase there is a "rm -rf cmd/snap-bootstrap" | 07:31 |
| pedronis | ah, you are right, I'm reading the rm wrong | 07:32 |
| mvo | pedronis: no worries, it would be nice to be more uniform but the dh-golang tool does not respect buildtags accross the board. I filed a debian bugreport a while ago (with patch) but that got no traction | 07:33 |
| pedronis | mvo: unrelated, do you remember why we have a specific ubuntu-17.04 packaging symlink ? | 07:37 |
| mvo | pedronis: historic reasons, we can kill all of that, actually let me do this | 07:46 |
| mup | PR snapd#8714 opened: packaging: remove obsolete 16.10,17.04 symlinks <Simple ๐> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8714> | 07:53 |
| zyga | brb | 07:56 |
| pedronis | pstolowski: mvo: hi, I tried to re-run #8697, there's a lot of weird errors, I don't understand if we broke something on master or if it's related to packaging changes in odd ways | 08:02 |
| mup | PR #8697: packaging: build cmd/snap and cmd/snap-bootstrap with nomanagers tag <Created by stolowski> <https://github.com/snapcore/snapd/pull/8697> | 08:02 |
| pstolowski | pedronis: thanks, i will keep an eye on it; i pushed some changes last friday but only run them on a subset of systems & only with the new spread test, so it is possible it breaks something | 08:07 |
| pedronis | pstolowski: we really need it unblock your config PRs | 08:08 |
| mvo | pedronis: in a meeting but I can check later | 08:09 |
| pedronis | pstolowski: are you working on the feedback to #8304 ? | 08:18 |
| mup | PR #8304: usersession/userd: add zoommtg url support <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8304> | 08:18 |
| pedronis | sorry | 08:18 |
| pedronis | pstolowski: I meant, #8704 | 08:18 |
| mup | PR #8704: cmd/snap-preseed: improve mountpoint checks of the preseeded chroot (1/3) <Preseeding ๐> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8704> | 08:18 |
| pstolowski | pedronis: yes, i'm going to update it today | 08:19 |
| pedronis | ok, thx | 08:20 |
| zyga | small breakfast and back to work | 08:43 |
| zyga | re | 08:56 |
| zyga | mvo: can you please force merge https://github.com/snapcore/snapd/pull/8708 | 09:05 |
| mup | PR #8708: tests: setup portals before starting user session <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8708> | 09:05 |
| zyga | not sure how to unstuck travis there | 09:05 |
| mvo | zyga: sure | 09:12 |
| zyga | thanks! | 09:12 |
| mup | PR snapd#8708 closed: tests: setup portals before starting user session <Test Robustness> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8708> | 09:13 |
| pedronis | mvo: some questions/comments in #8351 | 09:14 |
| mup | PR #8351: config: apply vitality-hint immediately when the config changes <Created by mvo5> <https://github.com/snapcore/snapd/pull/8351> | 09:14 |
| mvo | pedronis: cool, thank you | 09:15 |
| pedronis | pstolowski: I reviewed #8709 | 09:51 |
| mup | PR #8709: cmd/snap-preseed, systemd: fix handling of fuse.squashfuse when preseeding (2/3) <Preseeding ๐> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8709> | 09:51 |
| pstolowski | pedronis: thank you | 09:51 |
| mup | PR snapd#8715 opened: tests: port interfaces-network-status-classic to session-tool <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8715> | 10:11 |
| pedronis | mborzecki: thanks for the review of the Pool stuff | 10:13 |
| zyga | brb | 10:26 |
| zyga | small coffee break | 10:26 |
| zyga | hmmm | 10:26 |
| zyga | 2020-05-25 10:24:19 Cannot allocate google-unstable:opensuse-15.1-64: cannot allocate new Google server for opensuse-15.1-64: invalid value for field 'resource.shieldedInstanceConfig': ''. Shielded VM Config can only be set when using a UEFI-compatible disk | 10:26 |
| zyga | mvo: ^ FYI, this is the outdated image used after deploying the new spread binary | 10:28 |
| zyga | we should discuss spread at the standup | 10:28 |
| mvo | zyga: ok | 10:35 |
| mup | PR snapd#8714 closed: packaging: remove obsolete 16.10,17.04 symlinks <Simple ๐> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8714> | 10:37 |
| === Eleventh_Doctor is now known as Eighth_Doctor | ||
| mup | PR snapd#8716 opened: o/devicestate: refactor current system handling <Simple ๐> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8716> | 10:51 |
| mborzecki | pedronis: ^^ | 10:51 |
| mvo | zyga: I reworked 8508 and it uses outputs now, much nicer indeed | 10:53 |
| zyga | wow :) | 10:53 |
| mvo | zyga: please have another look, I think this is good to go now | 10:53 |
| zyga | looking | 10:53 |
| zyga | it was just a suggestion, I didn't know you'd go all the way :) | 10:53 |
| mvo | zyga: it is much nicer this way | 10:55 |
| zyga | mvo: https://github.com/snapcore/snapd/pull/8508#pullrequestreview-417632557 | 11:00 |
| mup | PR #8508: github: run all spread systems in a single go with cached results <Created by mvo5> <https://github.com/snapcore/snapd/pull/8508> | 11:00 |
| mvo | zyga: thanks! yeah, I think the root-owned one is fixed, I will do a followup one this one is in | 11:01 |
| * mvo didn't want to cram too much into this tiny PR | 11:01 | |
| pedronis | mborzecki: are you (still) working on not accepting mode not to be set in modeenv? | 11:03 |
| mborzecki | pedronis: yes, i'm back at that branch | 11:04 |
| pedronis | mborzecki: thx | 11:04 |
| zyga | mvo: thank you! | 11:04 |
| zyga | pedronis: small step towards what we discussed https://github.com/snapcore/snapd/pull/8717 | 11:10 |
| mup | PR #8717: test: session-tool cli tweaks <Created by zyga> <https://github.com/snapcore/snapd/pull/8717> | 11:10 |
| mup | PR snapd#8717 opened: test: session-tool cli tweaks <Created by zyga> <https://github.com/snapcore/snapd/pull/8717> | 11:10 |
| zyga | I' afraid my dog just told me I should go for a walk :D | 11:12 |
| zyga | brb | 11:12 |
| mup | PR snapd#8718 opened: boot, many: require mode in modeenv <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8718> | 11:37 |
| pstolowski | pedronis: fyi, my packaging change fails because of panic: user: Current not implemented on linux/amd64 | 11:40 |
| pedronis | pstolowski: ? | 11:40 |
| pstolowski | pedronis: something isn't included in the build and snap cli panics in some use cases (login?). i'm unclear, investigating | 11:42 |
| zyga | re | 11:55 |
| zyga | pstolowski: re | 11:55 |
| zyga | pstolowski: when I looked at godbus code there was some interesting difference between how godbus is built | 11:56 |
| zyga | pstolowski: and the code handled variants with cgo, without cgo, on various systems | 11:56 |
| zyga | pstolowski: perhaps we need somiething similar | 11:56 |
| pstolowski | zyga: it was caused by passing CGO_ENABLED=0 | 11:57 |
| zyga | pstolowski: https://github.com/godbus/dbus/blob/master/homedir.go https://github.com/godbus/dbus/blob/master/homedir_dynamic.go and https://github.com/godbus/dbus/blob/master/homedir_static.go | 11:59 |
| zyga | linux sound magic, after unplugging headphones there was no sound for like 30 seconds | 12:00 |
| zyga | anyway | 12:00 |
| zyga | back to work | 12:00 |
| mup | PR snapd#8715 closed: tests: port interfaces-network-status-classic to session-tool <Test Robustness> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8715> | 12:01 |
| mup | PR snapd#8719 opened: tests: remove dbus.sh <Simple ๐> <Created by zyga> <https://github.com/snapcore/snapd/pull/8719> | 12:03 |
| ijohnson | mvo zyga so if I just go to 8508 and try to restart one of the spread jobs there that passed it should be really quick and effectively a no-op right ? | 12:51 |
| zyga | ijohnson: looking | 12:51 |
| zyga | ah | 12:51 |
| * ijohnson is excited to try this | 12:51 | |
| zyga | yes, I think so :) | 12:51 |
| zyga | if not it'd be quite funny | 12:52 |
| zyga | let's try? | 12:52 |
| * ijohnson excitedly clicks buttons | 12:52 | |
| mvo | ijohnson: correct | 12:52 |
| mvo | ijohnson: I guess there are a bunch of people starring at this now :) | 12:53 |
| ijohnson | haha | 12:53 |
| ijohnson | well now it seems the jobs are stuck waiting in the queue because multiple people tried it at once | 12:55 |
| zyga | aka "insert coin" | 12:55 |
| zyga | ijohnson: not as exciting but super simple https://github.com/snapcore/snapd/pull/8719 | 12:56 |
| mup | PR #8719: tests: remove dbus.sh <Simple ๐> <Created by zyga> <https://github.com/snapcore/snapd/pull/8719> | 12:56 |
| ijohnson | Nice I'll take a look after SU | 12:57 |
| zyga | thanks :) | 12:57 |
| zyga | it's just a rm -f | 12:57 |
| ijohnson | indeed it is! In that case here's your +1 | 12:59 |
| zyga | standup :) | 13:00 |
| zyga | mborzecki: https://github.com/snapcore/snapd/pull/8720/files <- any ideas on better "gimme all processes" command? | 13:28 |
| mup | PR #8720: spread.yaml: add ps aux to debug section <Simple ๐> <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8720> | 13:28 |
| mup | PR snapd#8720 opened: spread.yaml: add ps aux to debug section <Simple ๐> <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8720> | 13:28 |
| zyga | at this rate we will have beta and then some more releases till stable | 13:29 |
| mborzecki | zyga: gamma? | 13:42 |
| zyga | mborzecki: like adom version | 13:46 |
| roadmr | hey folks any idea who's a good person to poke about snap-store (the gui client)? kenvandine maybe? (but he's off today) | 13:46 |
| zyga | roadmr: no idea, but probably ken indeed | 13:46 |
| roadmr | thanks zyga :) | 13:48 |
| mup | PR snapd#8721 opened: devicestate, sysconfig: revert support for cloud.cfg.d/ in the gadget <Created by mvo5> <https://github.com/snapcore/snapd/pull/8721> | 13:52 |
| mvo | zyga: do you know if there is something funny going on with our gh action runners? I see that 8508 takes forever to be re-run, any idea? | 13:52 |
| zyga | mvo: looking | 14:01 |
| zyga | lots of busy runners | 14:02 |
| zyga | mvo: queue size ~10 | 14:02 |
| zyga | mvo: it should clear in 30 minutes | 14:02 |
| zyga | looks like we got a number of tests re triggered or started | 14:03 |
| zyga | oddly one stuck at -discard for 2 hours 44 minutes | 14:03 |
| zyga | and one 16.04-64 running for over 3 hours 40 minutes | 14:04 |
| zyga | but most of the queue looks happy | 14:04 |
| zyga | ah, sorry, those are zombies | 14:04 |
| zyga | perhaps actions runnner bug / not collecting zombies | 14:04 |
| zyga | note that https://github.com/snapcore/snapd/actions?query=is%3Ain_progress gives pretty good visibility | 14:05 |
| zyga | remember that each really consumes a number of runners at once | 14:05 |
| === bdx9 is now known as bdx | ||
| mvo | ijohnson: 8508 did successfully run the cached results, I triggered another run to see if restarting twice works too (I see no reason why it would not but I'm paranoid) | 14:29 |
| mvo | ijohnson: but yeah, looks like this is ready | 14:29 |
| * mvo hugs mborzecki for this | 14:29 | |
| zyga | yeah, it will be the best of both worlds | 14:32 |
| mborzecki | yay | 14:32 |
| ijohnson | mvo: great news! | 14:33 |
| ijohnson | thanks mborzecki and mvo this will be super amazing | 14:33 |
| mborzecki | but we fixed the random issues in the tests :P | 14:34 |
| zyga | mborzecki: haha | 14:37 |
| zyga | mborzecki: only some | 14:37 |
| zyga | mborzecki: invariant-tool is amazing because a simple few lines shows you what's left TODO | 14:37 |
| mborzecki | hmm why on earth unsquashfs would read /var/run/systemd/userdb which obviously has systemd_userdbd_runtime_t context | 14:39 |
| mborzecki | unless it's some another pam/nss/systemd thing | 14:39 |
| mvo | I bet it's pam/nss/whatnot | 14:40 |
| mborzecki | heh, man 8 nss-systemd, This module preferably utilizes systemd-userdbd.service(8) for resolving users and groups, but also works without the service running. | 14:41 |
| mvo | squashfs is not getting that many commits these days, I don't think code for that would have made it (but I could be wrong of course) | 14:41 |
| mborzecki | and we call unsquashfs -l during install to check the sanity of a snap | 14:42 |
| mborzecki | it's still the same user tho | 14:43 |
| mborzecki | ah ok, unsquashfs may be calling getpwent() or somesuch to translate uid -> name | 14:43 |
| pedronis | mvo: mborzecki: I commented quickly on #8661 | 14:44 |
| mup | PR #8661: configcore: add "service.console-conf.disable" config option <Created by mvo5> <https://github.com/snapcore/snapd/pull/8661> | 14:44 |
| mborzecki | that hits nss, and eventually may reach nss-systemd which probably reads the db directly for simple queries | 14:44 |
| zyga | mborzecki: must be nss | 14:44 |
| zyga | https://github.com/snapcore/snapd/pull/8717 is simple and needs a 2nd review | 14:46 |
| mup | PR #8717: test: session-tool cli tweaks <Created by zyga> <https://github.com/snapcore/snapd/pull/8717> | 14:46 |
| zyga | gentle rain outside, what a lovely sound | 14:49 |
| mborzecki | pedronis: thanks | 14:51 |
| pedronis | mborzecki: tbc, the main comment was about no restarting things if nothing has changed | 14:53 |
| pedronis | the other one is cosmetics | 14:54 |
| Eighth_Doctor | zyga, mborzecki: hey all | 14:55 |
| zyga | hey | 14:55 |
| zyga | how are you? | 14:55 |
| Eighth_Doctor | ehh, as well as I could be | 14:56 |
| Eighth_Doctor | day one billion of the quarantine | 14:56 |
| Eighth_Doctor | I talk to the napkins now :) | 14:56 |
| zyga | Eighth_Doctor: really? I must go out more | 14:56 |
| roadmr | haha it's been less than 3 months :P | 14:56 |
| roadmr | Schools here closed on March 12th or so | 14:57 |
| Eighth_Doctor | Datto closed on March 13, but I stopped one day early | 14:57 |
| mup | PR snapd#8568 closed: asserts: rest of the Pool API <Bulk assert refresh :scroll::scroll::scroll:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8568> | 14:58 |
| ijohnson | zyga: #8717 has 2 +1's and is almost entirely green | 15:06 |
| zyga | thanks, merging! | 15:06 |
| mup | PR #8717: test: session-tool cli tweaks <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8717> | 15:06 |
| mup | PR snapd#8717 closed: test: session-tool cli tweaks <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8717> | 15:07 |
| mborzecki | afk for some time | 15:07 |
| mup | PR snapd#8722 opened: tests: check that host settings like hostname are settable on core <Created by mvo5> <https://github.com/snapcore/snapd/pull/8722> | 15:10 |
| mvo | cmatsuoka: I pushed a very simple spread test, could you please check that this is essentially what you did with hostname when you tested this manually? | 15:10 |
| * zyga reboots for updates | 15:11 | |
| mup | PR snapd#8508 closed: github: run all spread systems in a single go with cached results <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8508> | 15:12 |
| mup | PR snapd#8723 opened: github: remove workaround for bug 133 in actions/cache <Simple ๐> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8723> | 15:14 |
| pedronis | mvo: I made also this comment: https://github.com/snapcore/snapd/pull/8661#discussion_r429969902 | 15:28 |
| mup | PR #8661: configcore: add "service.console-conf.disable" config option <Created by mvo5> <https://github.com/snapcore/snapd/pull/8661> | 15:28 |
| cmatsuoka | mvo: checking | 15:28 |
| cmatsuoka | mvo: btw uc18 is also slow, but it doesn't have the 14s delay before the ttyS0 initialization | 15:28 |
| pedronis | pstolowski: mborzecki: thanks for the Pool reviews, I landed the bits, now there's the main branch using it, but probably can wait a little bit before reviews, I want to discuss something first | 15:29 |
| pstolowski | pedronis: is it updated with master? | 15:29 |
| pedronis | pstolowski: it is, but as I said can wait a little bit | 15:30 |
| pstolowski | pedronis: ack | 15:30 |
| pedronis | ijohnson: #8718 is probably something you can help reviewing | 15:36 |
| mup | PR #8718: boot, many: require mode in modeenv <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8718> | 15:36 |
| ijohnson | pedronis: sure will take a look today | 15:36 |
| pedronis | thx | 15:37 |
| mup | PR snapd#8720 closed: spread.yaml: add ps aux to debug section <Simple ๐> <Test Robustness> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8720> | 15:49 |
| mup | PR snapd#8704 closed: cmd/snap-preseed: improve mountpoint checks of the preseeded chroot (1/3) <Preseeding ๐> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8704> | 15:50 |
| mup | PR snapd#8724 opened: interfaces/block_devices: add NVMe subsystem devices, support multipath paths <โ Blocked> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8724> | 15:50 |
| mvo | pstolowski: I merged 8704 to unblock you, still one suggestion inline that might be worth looking at in one of the followups | 15:51 |
| pstolowski | mvo: thanks! right, will do | 15:52 |
| zyga | thanks mvo! | 15:52 |
| pedronis | mborzecki: I reviewed #8716 | 15:55 |
| mup | PR #8716: o/devicestate: refactor current system handling <Simple ๐> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8716> | 15:55 |
| pedronis | mvo: did you see my comment about missing newlines? you pushed many times to that PR but not a fix for that | 15:58 |
| mvo | pedronis: aha, sorry, missed it | 16:00 |
| ijohnson | I'm so confused right now | 16:43 |
| ijohnson | somehow a change in github.com/snapcore/snapd/snap dir is making github.com/snapcore/snapd/wrappers/ fail by calling systemctl is-system-running seemingly out of thin air??? | 16:44 |
| pedronis | ijohnson: afaik only snap run is using is-system-running | 16:52 |
| ijohnson | pedronis: yes I figured it out | 16:52 |
| ijohnson | we mock systemctl, then we run shellcheck | 16:52 |
| ijohnson | on my system shellcheck is a snap | 16:52 |
| ijohnson | and it just so happened that I had a system key mismatch, so when `shellcheck` as a snap runs, it tries to check if the system is running using the mocked systemctl | 16:53 |
| ijohnson | very very confusing bug | 16:53 |
| pedronis | interesting combination | 16:53 |
| pedronis | we should probably separate mocking of path vs running shellcheck | 16:53 |
| ijohnson | my fix is just to set PATH _after_ we call shellcheck | 16:55 |
| ijohnson | I had a similar problem with some other unit test a long time ago where some unit test got confused when run by specifically the go snap, which mad some old SNAP_CONFINE var get set and confused the unit test | 16:56 |
| mup | PR snapd#8725 opened: testutil/exec.go: set PATH after running shellcheck <Simple ๐> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8725> | 17:01 |
| ijohnson | pedronis: so to fix 8711, I wanted to add an options struct to Install, but have that struct defined in github.com/snapcore/snapd/snap/container.go | 17:06 |
| ijohnson | but then that leads to an import cycle for github.com/snapcore/snapd/snap/squashfs/squashfs.go to use the struct | 17:06 |
| ijohnson | so I'm disentangling them so that container.go doesn't container a reference to squashfs and snapdir, then have a register format function like we did in dirs | 17:06 |
| ijohnson | does that sound reasonable ? | 17:07 |
| ijohnson | I will propose this in a separate PR from 8711 | 17:07 |
| pedronis | ijohnson: not sure, it changes how you have to import things | 17:07 |
| ijohnson | now with my code snap/container.go doesn't import anything from github.com/snapcore/snapd | 17:08 |
| ijohnson | pedronis: would it be easier if I just propose it so you can quick look at it? | 17:08 |
| pedronis | ijohnson: I mean the issue is that now the other places need to import snapdir and squashfs manually | 17:08 |
| ijohnson | pedronis: how so ? | 17:08 |
| ijohnson | I ran all the unit tests and I didn't need to change anything else | 17:09 |
| pedronis | ijohnson: mmh | 17:09 |
| pedronis | I'm probably missing something but the tests probably have explicit imports for their reasons | 17:09 |
| pedronis | in snaptest | 17:09 |
| pedronis | etc | 17:09 |
| mup | PR snapd#8726 opened: tests: silence stderr from dbus-monitor <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8726> | 17:09 |
| ijohnson | mmm let me quick propose it maybe I'm missing something | 17:09 |
| ijohnson | pedronis: https://github.com/snapcore/snapd/pull/8727 | 17:14 |
| mup | PR #8727: snap/container.go: don't import snapdir, squashfs; use register format w/ init() <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8727> | 17:14 |
| === ijohnson is now known as ijohnson|lunch | ||
| mup | PR snapd#8727 opened: snap/container.go: don't import snapdir, squashfs; use register format w/ init() <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8727> | 17:14 |
| mup | PR snapd#8719 closed: tests: remove dbus.sh <Simple ๐> <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8719> | 17:15 |
| pedronis | ijohnson|lunch: yea, what I suspected happens, we either need to paper it over, or think more | 17:17 |
| pedronis | ijohnson|lunch: https://paste.ubuntu.com/p/JVRZWBHFsm/ | 17:18 |
| ijohnson|lunch | Hmm | 17:19 |
| ijohnson|lunch | I see your point now | 17:20 |
| ijohnson|lunch | But how do we not catch this in any unit tests | 17:20 |
| ijohnson|lunch | ๐ | 17:20 |
| pedronis | ijohnson|lunch: because the unit tests import snapdir and squashfs explicitly in a couple of places | 17:21 |
| pedronis | for their reasons | 17:21 |
| ijohnson|lunch | Right but the snapd daemon level tests should surely check that something happened right? | 17:22 |
| ijohnson|lunch | They should be using snapdir from the snaptest util package iirc | 17:22 |
| ijohnson|lunch | Anyways I need to eat lunch | 17:22 |
| ijohnson|lunch | I will look at this in a little bit | 17:22 |
| pedronis | ijohnson|lunch: well, that's the problem snaptest imports snapdir | 17:22 |
| ijohnson|lunch | Oh I see | 17:22 |
| pedronis | anyway I don't think the paper it over approach is appropriate | 17:22 |
| pedronis | because is fairly annoying for this case | 17:23 |
| pedronis | real fixes are probably bit of a pain though | 17:24 |
| mup | PR snapd#8727 closed: snap/container.go: don't import snapdir, squashfs; use register format w/ init() <Created by anonymouse64> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8727> | 17:34 |
| mup | PR snapd#8728 opened: tests: detect stray dbus-daemon <Test Robustness> <Created by zyga> <https://github.com/snapcore/snapd/pull/8728> | 17:37 |
| pedronis | ijohnson|lunch: ping me on tg when you want to discuss this | 17:40 |
| ijohnson|lunch | pedronis: sure probably 15 minutes | 17:41 |
| ijohnson|lunch | *in 15 minutes | 17:41 |
| === ijohnson|lunch is now known as ijohnson | ||
| pedronis | ijohnson: hi | 18:07 |
| ijohnson | hey | 18:07 |
| ijohnson | I'm back now if you want to discuss | 18:07 |
| ijohnson | pedronis: ^ | 18:07 |
| pedronis | ijohnson: yes | 18:07 |
| * zyga afk | 18:08 | |
| ijohnson | pedronis: SU hangout ? | 18:08 |
| pedronis | ijohnson: ok | 18:08 |
| === KindTwo is now known as KindOne | ||
| mup | PR snapd#8729 opened: snap,many: mv Open to snapfile pkg to support add'l options to Container methods <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8729> | 19:09 |
| pedronis | ijohnson: did a bit of reviewing, I think the not-symlinking PR is too aggressive, will not work well after seeding | 20:42 |
| ijohnson | Hmm | 20:44 |
| ijohnson | pedronis: So you want the if condition in snapstate to be more specific and only to be applied when seeding is unset? | 20:45 |
| pedronis | ijohnson: I think it can defined differently and then it doesn't matter again | 20:46 |
| pedronis | ijohnson: there's a bit of a question what to do about snapdir case, it's really for snap try | 20:46 |
| pedronis | copying is never what you expect there | 20:46 |
| ijohnson | pedronis ok I see your review | 20:46 |
| ijohnson | pedronis we could make snapdir just ignore the flag? | 20:46 |
| pedronis | ijohnson: either that with a TODO, possibly in uc20 we should check that dir(targetPath) and s.path are on the same device | 20:47 |
| pedronis | but is not a blocker atm I think | 20:47 |
| pedronis | ijohnson: also it adds some spread testing, I made a suggestion | 20:51 |
| pedronis | s/adds/needs/ | 20:51 |
| ijohnson | pedronis axk | 20:53 |
| pedronis | ijohnson: to be clear, at it is I think some try tests at least will fail, because they edit things in place | 20:55 |
| pedronis | which witht the copy won't work | 20:55 |
| pedronis | we might have also some spread testing about hardlinking, not sure | 20:55 |
| pedronis | ah, also tests/core/seed-base-symlinks/task.yaml needs to be changed, it has a TODO:UC20 atm, but needs a comment about it never working on UC20 intentionally | 20:59 |
| ijohnson | ok, I'll try to fix that as well, need to step out for a bit but I will try to fix before your AM | 21:01 |
| pedronis | ijohnson: thank you (I got disconnected, so maybe you saw that already) | 21:02 |
| ijohnson | Yes I saw it | 21:03 |
| mup | PR core20#65 opened: Do not attempt signing changes during snap build <Created by xnox> <https://github.com/snapcore/core20/pull/65> | 21:45 |
| mup | PR snapcraft#3144 opened: docker: setup a multiarch build for snapcraft docker images <Created by adferrand> <https://github.com/snapcore/snapcraft/pull/3144> | 23:21 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!