| === tomwardill_ is now known as tomwardill | ||
| tomwardill | sigh, whoopsied and `git clean`ed my wheels directory | 09:11 |
|---|---|---|
| * tomwardill waits for everything to rebuild | 09:12 | |
| cjwatson | pappacena: I updated dogfood and reran your push job. https://pastebin.canonical.com/p/8tW3jn8fBz/ - looks good now I think? | 09:27 |
| tomwardill | "Found node-sass binary" | 09:53 |
| tomwardill | proceeds to rebuild it | 09:53 |
| tomwardill | gaaaah | 09:53 |
| cjwatson | I remember that taking some work to get right on SCA but don't quite remember the details | 09:56 |
| tomwardill | I think I've just run into the same problem as I did there | 09:59 |
| tomwardill | it needs to be an absolute path and only works in the config file | 09:59 |
| tomwardill | might have to copy it to somewhere like /tmp/ and then reference it | 09:59 |
| pappacena | cjwatson: it looks good now! :D | 10:53 |
| pappacena | https://hub.docker.com/repository/docker/pappacena/foo-image | 10:57 |
| pappacena | `docker run -it --rm pappacena/foo-image:edge bash` seems to be fine too :) | 10:58 |
| cjwatson | Excellent. Shall we mark green and deploy then? | 11:00 |
| cjwatson | pappacena: ^- above question was to you BTW :) | 11:58 |
| pappacena | Ah, sorry. I thought I have marked. Just marked it now | 12:20 |
| cjwatson | pappacena: OK - can you work with Tom to sort out a deployment then? I updated the docs this morning so you should only have a single place to look | 12:34 |
| pappacena | Yes, I'm taking a look at the document right now. Maybe we can do it together after the standup, tomwardill ? | 12:34 |
| tomwardill | sure! | 12:34 |
| tomwardill | oookay, closer | 14:36 |
| tomwardill | now just to work out why my Make isn't working | 14:36 |
| tomwardill | cjwatson: any idea why `NODE_ABI = $(call lazy_eval,NODE_ABI,nodejs -p process.versions.modules)` is returning empty if I put it in a LP Makefile? | 14:38 |
| cjwatson | tomwardill: What's lazy_eval defined as? | 14:40 |
| tomwardill | aha! | 14:40 |
| tomwardill | yeah.... | 14:40 |
| cjwatson | I thought that might be it :-) | 14:40 |
| tomwardill | defining it | 14:40 |
| tomwardill | that's a thing | 14:40 |
| * tomwardill might try that | 14:40 | |
| tomwardill | oh, look, a value! | 14:41 |
| tomwardill | <_< | 14:41 |
| tomwardill | >_> | 14:41 |
| SpecialK|Canon | :D | 14:42 |
| cjwatson | Can anyone review https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/384556 for me? | 14:44 |
| tomwardill | node-sass installation: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/384644 and dependencies: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/384614 | 15:04 |
| cjwatson | Looks very familiar, I suspect the lazy_eval stuff was originally me :) | 15:07 |
| tomwardill | it was :) | 15:07 |
| tomwardill | all of that preamble was yours | 15:07 |
| tomwardill | I forgot that you made it actually none-hardcoded after I just plonked a bunch of version numbers in there | 15:07 |
| cjwatson | Dependencies URL should be https://code.launchpad.net/~twom/lp-source-dependencies/+git/lp-source-dependencies/+merge/384643 | 15:08 |
| cjwatson | right? | 15:08 |
| tomwardill | main difference is that yarn uses the environment variable, where npm uses a cli switch | 15:08 |
| tomwardill | cjwatson: oh yes, copy paste fail | 15:08 |
| cjwatson | What a lot of dependencies, but that's node for you I guess | 15:09 |
| cjwatson | r=me | 15:09 |
| tomwardill | I haven't attempted to prune them or antyhing, it's just the result of `yarn add node-sass` | 15:09 |
| === mup_ is now known as mup | ||
| tomwardill | from the SCSS docs: "Prefer @use over @import as it is deprecated" | 16:41 |
| tomwardill | what they don't say: "only the dart-sass implementation actually has a working @use" | 16:41 |
| SpecialK|Canon | rargh | 16:41 |
| tomwardill | https://github.com/facebook/create-react-app/issues/8316 | 16:41 |
| * tomwardill just uses @import | 16:42 | |
| tomwardill | oh hey, it works now! | 16:43 |
| tomwardill | 17k of CSS, lovely | 16:58 |
| tomwardill | yet the old one is 86k | 17:01 |
| tomwardill | hmm, what have I missed | 17:02 |
| tomwardill | 130k now | 17:03 |
| tomwardill | that's... more believable | 17:03 |
| tomwardill | 92k in compressed mode, that's probably close enough | 17:04 |
| * tomwardill -> EOD | 17:04 | |
| cjwatson | tomwardill: diff -w I guess | 17:27 |
| cjwatson | Well, -bu maybe | 17:27 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!