[17:07] blackboxsw, ec2-f was supposed to be enabled: https://github.com/canonical/server-jenkins-jobs/pull/120 [17:08] paride: hahah, oops was mapping that to minutes incorrectly :. [17:08] thanks approved [17:09] paride: and landed [17:10] great [17:15] paride: two more back at you https://github.com/canonical/server-jenkins-jobs/pull/121 [17:18] merged [17:20] paride: last one from me: https://github.com/canonical/server-jenkins-jobs/pull/122 [17:22] blackboxsw, merged, thanks! [17:23] paride: it's probably past your EOD have time for me to put up another for adding curtin-g CI jobs and cloud-init kvm|lxd-g jobs too [17:23] we may load the CI machines to near breaking point [17:28] torkoal will explode :) blackboxsw I am going out, but I can review/merge tomorrow morning [17:28] ok one more cloud-init https://github.com/canonical/server-jenkins-jobs/pull/123 for lxd/kvm groovy [17:28] ok just in time [17:28] heh see ya paride tomorrow it is [17:28] :) [17:28] let me see [17:28] thanks again [17:28] if an issue, I'll blame the new guys :) [17:29] * blackboxsw is looking at falcojr there :) [17:29] falcojr: I may have a couple of minor CI branches for you to look at today [17:31] Heh, sounds good [17:33] blackboxsw, merged, thanks [17:33] thanks paride have a good one [17:33] * paride declares EOD for real :) [17:33] falcojr: on the hook from here on out ! :) [17:34] falcojr: as a note, our jenkins is behind a firewall at https://jenkins.ubuntu.com/server/ [17:34] so you'll need VPN up to access it [17:35] and any job changes we make are auto-syncd to jenkins every 15 mins, but we can manually pull with the job: https://jenkins.ubuntu.com/server/job/admin-jobs-update/ [17:35] so if we break something we can fix quickly if needed [17:44] falcojr: for you if you end up having time today https://github.com/canonical/server-jenkins-jobs/pull/124 [17:44] if not, no biggie [17:49] I should be able to today [17:59] thank you sir. [18:04] what does proposed mean in the context of these jenkins jobs? === tds0 is now known as tds [18:39] falcojr: sorry missed this, proposed for the jenkins jobs means to pull-lp-source curtin "$RELEASE"-proposed [18:39] it means we are testing the debian source bits that have been uploaded for curtin to the xenial-proposed bionic-proposed etc. deb pocket [18:40] gotcha, thanks [18:40] so it is testing what we plan to SRU, as those bits get queued in the $release-proposed pocket for testing and verification for an SRU until SRU verification is fixed [18:40] then when we pass verification the bits get published to $release-updates pocket [18:41] falcojr: https://people.canonical.com/~ubuntu-archive/pending-sru.html lists packages that are currently queued in the *-proposed pockets and haven't cleared SRU verification yet [18:41] generally there'll be links to a project bug (or multiple bugs) related to that SRU verification that needs completion [19:08] another minor ci branch if anyone wants to grab it https://github.com/canonical/cloud-init/pull/400 [19:08] our cloud_tests need to allow us to support groovy release [19:10] awesome falcojr https://github.com/canonical/server-jenkins-jobs/pull/124#discussion_r432033139 and thanks you are right [19:11] pushed fix [19:18] blackboxsw: I reviewed the ubuntu/bionic; I had a question in the review; I wasn't sure if what you've pushed to ubuntu/bionic is the *final* form (it looks like my local branch following your steps has a diff from yours) [19:46] ahh rharper I held off on my manual patches, will apply them now and push [19:46] blackboxsw: I see [19:46] lemme diff to my previous commit [19:46] +1 rharper I'll wait to push [19:46] \o/ [19:47] ok awesome sauce. pushing manual changes in 2 mins [19:47] ok, then I'll refresh [19:48] though I think your commit message will need more than "test patches" [19:48] for what you're pushing to ubuntu/$release right ? [19:50] rharper: fort pushed [19:50] force pushed rather [19:50] yeah rharper I manually did the following [19:51] git commit -m 'd/control: drop python3-nose and python3-unittest2' debian/control [19:51] git commit -am 'changelog: add content for dropping python3-nose and python3-unittest2' [19:51] +1 [19:51] OK, +1 on your update; we diff the same there as well [19:51] then I git rebase -i HEAD~5 and reordered the commits squashing the debian/changelog ones into 3703b789d3ad3a0495b204118a44a19ed8b31da1 the new-upstream-snapshot changelog entry [19:51] thanks rharper [19:52] eoan and focal are more straightforward [20:01] blackboxsw: ok, ping me when you've got them up, I'll review [20:01] rharper: their up [20:01] already [20:02] focal: https://github.com/canonical/cloud-init/pull/398 [20:02] eoan: https://github.com/canonical/cloud-init/pull/397 [20:02] nice [20:04] blackboxsw: in your eoan PR, you show applying the patch first, then new-upstream-snapshot ? any reason for that ? [20:04] shouldn't that go after the snapshot ? [20:05] rharper: if we apply it first, then new-upstream-snapshot takes care of it in the right order without a rebase afterward [20:05] hrm, ok [20:05] I end up manually rebasing after to make sure the commit is in the changelog before we tag it anyway [20:05] why did we not do that for xenial ? [20:05] rharper: we could have and should have landed it first, I only though about it after we got through bionic [20:06] but either way is reasonable. I can redo xenial and bionic if you like , but in xenial and bionic we have to rebase anyway because we re-order the debian/changelog content lines after new-upstream-snapshot is 'done' anyway [20:07] blackboxsw: ok [20:07] so I'll still need to rebase -i and squash the manual re-order of debian/changelog commits [20:07] bionic and xenial only [20:20] blackboxsw: ok, I'll review eoan and focal; we can re-review xenial/bionic if we want to re-do === tds6 is now known as tds === tds5 is now known as tds [21:41] hrm rharper so on eoan I forgot to push my changes. done now [21:47] and focal push fixed https://github.com/canonical/cloud-init/pull/398 [21:48] rharper: benefit of patching before new-upstream-snapshot is we can add the ~20.04.1 suffix so new-upstream-snapshot knows to redact bug #s and require an SRU_BUG_NUMBER [21:48] for focal specifically === tds6 is now known as tds [22:38] blackboxsw: ok, I'll re-review eoan/focal now [22:45] thanks powersj for jumping in on all the flake stuff [22:49] blackboxsw, no worries wanted a couple easy ones :) [22:54] blackboxsw: ok, eoan/focal good to go [23:07] thanks rharper [23:13] yw [23:20] rharper: thanks I think I missed a review on ubuntu/xenial [23:20] but otherwise all others are uploaded [23:21] if you get a chance to double check that'd be great