[09:32] use node-sass for (nearly) no-op CSS compilation: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/384706 [09:33] the output file isn't exactly the same as the current one, but it contains all the same rules afaics (and the site seems to work...) [09:33] the watch command has some slightly strange output due to mishandling of subdirectories and imports, but it works and I think just needs some layout tweaks that I'll hopefully get to next [09:44] tomwardill: Can we remove lib/lp/scripts/utilities/js/combo.py and lib/lp/scripts/utilities/js/tests/test_combo.py as well? [09:44] I guess all of lib/lp/scripts/utilities/js/tests/ in fact [09:44] cjwatson: I think that's still used for the JS files [09:45] Are you sure? It was at one point, but grep doesn't find any other references [09:45] Unless I'm misreading [09:45] Worth a bit of hunting around to see what else we can remove, anyway [09:46] I'll have another poke at it [09:46] * tomwardill randomly deletes things to see what breaks [10:18] somewhat randomly, is LP using pybars? There are forks of it adding python3 and newer handlebars.js features [10:19] I don't know if anyone reached out to the LP team about it, but it might be an idea to hand over the pypi project to one of the forks if not [10:19] * lifeless hands over whatever blessing might possibly be needed for that [10:19] lifeless: no [10:20] at least I don't think so [10:21] we use pystache in the buglisting tests [10:22] and a copy of mustache.js I think [10:27] cjwatson: removed those files: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/384706 dont' seem to be able to remove any further without a re-engineering of the jsbuild stuff [10:27] I'd like CSSComboFile to go away, but stuff breaks if I try [10:31] Should hopefully be possible to redo Builder.build_skin etc. using scss, but doesn't have to be in this MP [10:32] yeah, that's where I'd like to get it eventually [13:27] cjwatson: just as an FYI for the bug i filed about code review DMARC compliance, I'm still working on it, but some more major IT Security related things came up @ employers so i had to address that stuff heh [13:27] in case anyone was asking :) [13:28] (i'm still working on that branch heh) [13:28] Nobody has been asking, but thanks :) [13:28] No immediate rush, whenever you have time [13:34] yeh the status change on the bug is what caught my attention :) [13:34] (since i filed it xD) [13:37] cjwatson: i'm not subscribed to the bugs and questions list, has there been any flak from the Community At Large with the email change yet? Or edge cases and bugs and stuff? [13:37] teward: not a word [13:37] lucky us. [13:37] guess the vast majority of people don't care enough to keep an eye on it as long as it works heh [13:38] Oh, one blog comment [13:38] Basically asking for name mangling [13:39] name mangling how? (Comments are invisible heh) [13:40] Hm? No they're not, https://blog.launchpad.net/notifications/bug-emails-now-use-the-bugs-address-in-the-from-header [13:41] they are if you ain't logged in [13:41] I'm not logged in [13:41] * teward just logged in with SSO and can see it now [13:41] I checked in w3m [13:41] hmm [13:41] wonder if my system is being weird. [13:41] *goes to check it* [13:41] shift-reload [13:41] Same sort of thing we discussed as maybe a possibility, anyway. I don't think it's immediately urgent but we should probably have a bug report for it [13:42] i mean [13:42] that's pretty fixable [13:42] And TBH I'd rather avoid name mangling if we can [13:42] but that would require the level of complexity we had before [13:43] with special case exclusions, etc. [13:43] The fact that GitHub doesn't do it means we're not alone [13:43] yeah most places dno't [13:43] don't* [13:43] those that DO have mangling in line do that as a design decision in their systems / lists [13:43] Anyway, we don't need to discuss it in depth here IMO [13:44] yep [13:44] *goes to consume breakfast* [14:46] huh, css to scss converters exist [14:46] how badly can that go? [14:46] [14:47] weirdly, it's... not that bad? [14:47] tomwardill: I don't know... maybe it would change randomly the color of dropdowns? 👀 [14:47] ah, from 'grey' to 'slightly not that grey'? [14:47] * pappacena hahaha! [14:50] ;P [14:50] I dropped 'base.css' into https://css2sass.herokuapp.com/ [14:50] and the result is actually readable [14:51] (at least to me, as someone who wouldn't know good scss if it wrote me a letter) [15:00] hmm, actually going to go with that [15:01] One day I'll ship a tool like that and have it embed zalgo in 0.01% of responses or sth, see who notices ;) [15:02] * tomwardill pays careful attention to any SpecialK|Canon MP [15:02] lol [15:21] wow, we have some fun about overriding link colours [16:04] "ImportError: No module named PIL" [16:04] ...not an error I was expecting in this work, I must admit [16:07] That's linked using link-system-packages.py [16:07] Have you done 'make compile' in that tree recently? [16:17] yeah, think I messed up my env [16:17] make clean fixed it [16:17] found a bug, the combo code rewrites relative urls, so removing it... doesn't [16:18] so css declared icons now 404