| hpidcock | correct | 00:00 |
|---|---|---|
| hpidcock | also there are only 119 tests in that package | 00:00 |
| hpidcock | the 1 failed is a non test | 00:00 |
| wallyworld | could be teardown then | 00:01 |
| hpidcock | "applicationSuite.TestSetApplicationStatus" | 00:05 |
| hpidcock | some sort of race, calling with -check.vv causes it to not fail | 00:09 |
| wallyworld | hmmm, ok, i'll see if anything jumps out | 00:14 |
| hpidcock | wallyworld: found it | 00:16 |
| hpidcock | func (s *applicationSuite) SetUpTest(c *gc.C) { shouldn't be using c from the SetUpTest | 00:16 |
| hpidcock | for apiCaller | 00:17 |
| wallyworld | good catch, i can fix as a driveby. that gc.C scoping issue sucks | 00:26 |
| hpidcock | wallyworld: awesome thanks | 00:28 |
| hpidcock | wallyworld: prepping for 2.8 release, I think its time to release the juju-db snap | 04:52 |
| hpidcock | any objections? | 04:53 |
| hpidcock | wallyworld: https://github.com/juju/juju/commit/8d1435b9f241c23a33f81bc09d6683373910c9d9#r39571648 | 05:33 |
| wallyworld | hpidcock: oh ffs, can't belive i did that, sigh | 05:38 |
| wallyworld | no objections to releasing juju-db snap | 05:38 |
| hpidcock | not your fault, merge jobs doesn't run linters | 05:39 |
| hpidcock | adding linters to merge job so we can't land bad code | 05:39 |
| wallyworld | at least it's not fatal and it only for testing | 05:39 |
| wallyworld | wosrt that can happen is a developer won't see the testing they want | 05:40 |
| hpidcock | small pr https://github.com/juju/juju/pull/11649 | 06:06 |
| tlm | looking hpidcock | 06:29 |
| kelvinliu | wallyworld: could u take a look this PR for eks provider? https://github.com/juju/juju/pull/11624 | 07:00 |
| wallyworld | kelvinliu: looking | 07:04 |
| kelvinliu | ty | 07:04 |
| wallyworld | kelvinliu: seems ok to me, ty | 07:10 |
| kelvinliu | wallyworld: ty and the other 2 PRs, plz | 07:12 |
| wallyworld | oh, sorry, looking | 07:13 |
| kelvinliu | nws | 07:13 |
| wallyworld | kelvinliu: done | 07:17 |
| kelvinliu | ty | 07:19 |
| jamespage | o/ | 07:26 |
| manadart | stickupkid achilleasa: https://github.com/juju/juju/pull/11650 | 09:10 |
| stub | Has juju 2.8 stopped automatically invoking the config-changed hook after install ? | 10:52 |
| stub | nope, framework didn't create the hooks/config-changed stub :-/ | 10:54 |
| * stub updates for dispatch | 10:56 | |
| rick_h | stub: that happened in 2.7 I believe | 11:39 |
| rick_h | stub: oh nvm, not after install, after something else | 11:39 |
| rick_h | guild just a heads up giumaas should be all released and thanks for all the help and support last week | 13:23 |
| petevg | rick_h: cool cool. Thank you for all the work on the team's behalf last week :-) | 13:23 |
| * rick_h slips back into the shadows | 13:23 | |
| rick_h | petevg: same to you! | 13:24 |
| rick_h | petevg: only used that bundle about 12 different times in different ways, solid one. Useful functional test one ime | 13:24 |
| petevg | Nice! Glad it was useful :-) | 13:24 |
| petevg | Props to the OpenStack team for the bundle. I just stole on of their test bundles and modified it a bit. | 13:25 |
| === narindergupta is now known as narinderguptamac | ||
| stickupkid | sigh TLS issues | 14:58 |
| === ulidtko|k is now known as ulidtko | ||
| pmatulis | how do i see the available revisions of a charm? | 21:06 |
| hpidcock | re-review please https://github.com/juju/juju/pull/11649 | 22:19 |
| tlm | i can take a look | 22:20 |
| hpidcock | tlm its just manadart's changes verbatim | 22:20 |
| tlm | roger | 22:20 |
| tlm | approved hpidcock but may need mandart to approve as well by the look of the github interface | 22:22 |
| hpidcock | tlm: I just dismissed his review so shouldn't block landing | 22:23 |
| tlm | getting so many random test failures in CI hpidcock :| | 22:24 |
| wallyworld | hpidcock: https://github.com/juju/juju/pull/11653 | 23:48 |
| hpidcock | wallyworld: looking | 23:53 |
| hpidcock | wallyworld: one comment | 23:55 |
| wallyworld | ta | 23:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!