hpidcockalso there are only 119 tests in that package00:00
hpidcockthe 1 failed is a non test00:00
wallyworldcould be teardown then00:01
hpidcocksome sort of race, calling with -check.vv causes it to not fail00:09
wallyworldhmmm, ok, i'll see if anything jumps out00:14
hpidcockwallyworld: found it00:16
hpidcockfunc (s *applicationSuite) SetUpTest(c *gc.C) { shouldn't be using c from the SetUpTest00:16
hpidcockfor apiCaller00:17
wallyworldgood catch, i can fix as a driveby. that gc.C scoping issue sucks00:26
hpidcockwallyworld: awesome thanks00:28
hpidcockwallyworld: prepping for 2.8 release, I think its time to release the juju-db snap04:52
hpidcockany objections?04:53
hpidcockwallyworld: https://github.com/juju/juju/commit/8d1435b9f241c23a33f81bc09d6683373910c9d9#r3957164805:33
wallyworldhpidcock: oh ffs, can't belive i did that, sigh05:38
wallyworldno objections to releasing juju-db snap05:38
hpidcocknot your fault, merge jobs doesn't run linters05:39
hpidcockadding linters to merge job so we can't land bad code05:39
wallyworldat least it's not fatal and it only for testing05:39
wallyworldwosrt that can happen is a developer won't see the testing they want05:40
hpidcocksmall pr https://github.com/juju/juju/pull/1164906:06
tlmlooking hpidcock06:29
kelvinliuwallyworld: could u take a look this PR for eks provider? https://github.com/juju/juju/pull/1162407:00
wallyworldkelvinliu: looking07:04
wallyworldkelvinliu: seems ok to me, ty07:10
kelvinliuwallyworld: ty and the other 2 PRs, plz07:12
wallyworldoh, sorry, looking07:13
wallyworldkelvinliu: done07:17
manadartstickupkid achilleasa: https://github.com/juju/juju/pull/1165009:10
stubHas juju 2.8 stopped automatically invoking the config-changed hook after install ?10:52
stubnope, framework didn't create the hooks/config-changed stub :-/10:54
* stub updates for dispatch10:56
rick_hstub:  that happened in 2.7 I believe11:39
rick_hstub:  oh nvm, not after install, after something else11:39
rick_hguild just a heads up giumaas should be all released and thanks for all the help and support last week13:23
petevgrick_h: cool cool. Thank you for all the work on the team's behalf last week :-)13:23
* rick_h slips back into the shadows13:23
rick_hpetevg:  same to you!13:24
rick_hpetevg:  only used that bundle about 12 different times in different ways, solid one. Useful functional test one ime13:24
petevgNice! Glad it was useful :-)13:24
petevgProps to the OpenStack team for the bundle. I just stole on of their test bundles and modified it a bit.13:25
=== narindergupta is now known as narinderguptamac
stickupkidsigh TLS issues14:58
=== ulidtko|k is now known as ulidtko
pmatulishow do i see the available revisions of a charm?21:06
hpidcockre-review please https://github.com/juju/juju/pull/1164922:19
tlmi can take a look22:20
hpidcocktlm its just manadart's changes verbatim22:20
tlmapproved hpidcock but may need mandart to approve as well by the look of the github interface22:22
hpidcocktlm: I just dismissed his review so shouldn't block landing22:23
tlmgetting so many random test failures in CI hpidcock :|22:24
wallyworldhpidcock: https://github.com/juju/juju/pull/1165323:48
hpidcockwallyworld: looking23:53
hpidcockwallyworld: one comment23:55

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!