[00:00] <hpidcock> correct
[00:00] <hpidcock> also there are only 119 tests in that package
[00:00] <hpidcock> the 1 failed is a non test
[00:01] <wallyworld> could be teardown then
[00:05] <hpidcock> "applicationSuite.TestSetApplicationStatus"
[00:09] <hpidcock> some sort of race, calling with -check.vv causes it to not fail
[00:14] <wallyworld> hmmm, ok, i'll see if anything jumps out
[00:16] <hpidcock> wallyworld: found it
[00:16] <hpidcock> func (s *applicationSuite) SetUpTest(c *gc.C) { shouldn't be using c from the SetUpTest
[00:17] <hpidcock> for apiCaller
[00:26] <wallyworld> good catch, i can fix as a driveby. that gc.C scoping issue sucks
[00:28] <hpidcock> wallyworld: awesome thanks
[04:52] <hpidcock> wallyworld: prepping for 2.8 release, I think its time to release the juju-db snap
[04:53] <hpidcock> any objections?
[05:33] <hpidcock> wallyworld: https://github.com/juju/juju/commit/8d1435b9f241c23a33f81bc09d6683373910c9d9#r39571648
[05:38] <wallyworld> hpidcock: oh ffs, can't belive i did that, sigh
[05:38] <wallyworld> no objections to releasing juju-db snap
[05:39] <hpidcock> not your fault, merge jobs doesn't run linters
[05:39] <hpidcock> adding linters to merge job so we can't land bad code
[05:39] <wallyworld> at least it's not fatal and it only for testing
[05:40] <wallyworld> wosrt that can happen is a developer won't see the testing they want
[06:06] <hpidcock> small pr https://github.com/juju/juju/pull/11649
[06:29] <tlm> looking hpidcock
[07:00] <kelvinliu> wallyworld: could u take a look this PR for eks provider? https://github.com/juju/juju/pull/11624
[07:04] <wallyworld> kelvinliu: looking
[07:04] <kelvinliu> ty
[07:10] <wallyworld> kelvinliu: seems ok to me, ty
[07:12] <kelvinliu> wallyworld: ty and the other 2 PRs, plz
[07:13] <wallyworld> oh, sorry, looking
[07:13] <kelvinliu> nws
[07:17] <wallyworld> kelvinliu: done
[07:19] <kelvinliu> ty
[07:26] <jamespage> o/
[09:10] <manadart> stickupkid achilleasa: https://github.com/juju/juju/pull/11650
[10:52] <stub> Has juju 2.8 stopped automatically invoking the config-changed hook after install ?
[10:54] <stub> nope, framework didn't create the hooks/config-changed stub :-/
[10:56]  * stub updates for dispatch
[11:39] <rick_h> stub:  that happened in 2.7 I believe
[11:39] <rick_h> stub:  oh nvm, not after install, after something else
[13:23] <rick_h> guild just a heads up giumaas should be all released and thanks for all the help and support last week
[13:23] <petevg> rick_h: cool cool. Thank you for all the work on the team's behalf last week :-)
[13:23]  * rick_h slips back into the shadows
[13:24] <rick_h> petevg:  same to you!
[13:24] <rick_h> petevg:  only used that bundle about 12 different times in different ways, solid one. Useful functional test one ime
[13:24] <petevg> Nice! Glad it was useful :-)
[13:25] <petevg> Props to the OpenStack team for the bundle. I just stole on of their test bundles and modified it a bit.
=== narindergupta is now known as narinderguptamac
[14:58] <stickupkid> sigh TLS issues
=== ulidtko|k is now known as ulidtko
[21:06] <pmatulis> how do i see the available revisions of a charm?
[22:19] <hpidcock> re-review please https://github.com/juju/juju/pull/11649
[22:20] <tlm> i can take a look
[22:20] <hpidcock> tlm its just manadart's changes verbatim
[22:20] <tlm> roger
[22:22] <tlm> approved hpidcock but may need mandart to approve as well by the look of the github interface
[22:23] <hpidcock> tlm: I just dismissed his review so shouldn't block landing
[22:24] <tlm> getting so many random test failures in CI hpidcock :|
[23:48] <wallyworld> hpidcock: https://github.com/juju/juju/pull/11653
[23:53] <hpidcock> wallyworld: looking
[23:55] <hpidcock> wallyworld: one comment
[23:55] <wallyworld> ta