mup | Issue operator#317 opened: use charm state for Juju 2.8 <Created by jetpackdanger> <https://github.com/canonical/operator/issues/317> | 04:52 |
---|---|---|
Chipaca | morning all | 08:29 |
jam | morning Chipaca | 08:33 |
facubatista | Muy buenos días a todos! | 11:04 |
Chipaca | a wild facundo appears! | 11:12 |
* facubatista puts some clothes on | 11:14 | |
Chipaca | better | 11:25 |
Chipaca | facubatista: hola :) | 11:25 |
facubatista | hola :) | 11:25 |
Chipaca | i've just realised i spent all morning messing around with versioning :-( | 11:25 |
facubatista | Chipaca, and this is the 3.1.2nd time it happes to you! | 11:25 |
facubatista | *happens | 11:26 |
Chipaca | well, i did do a bit of reviewing and such before diving down this rabbithole | 11:26 |
facubatista | Chipaca, but at least you have a conclusion? | 11:26 |
Chipaca | facubatista: I have something I like, I just need to check one more thing | 11:26 |
Chipaca | hm, the files github gives us at https://github.com/canonical/operator/releases is already reasonably useless :-/ do we care about them? | 11:28 |
facubatista | Chipaca, for `fades`, the person doing the debian packaging takes those | 11:29 |
facubatista | Chipaca, anyway, I don't care about them, not even to take the action of removing them or something | 11:30 |
Chipaca | heh | 11:30 |
facubatista | Chipaca, re MANIFEST.in... "LICENSE": don't we need to package it? why do we have it in the first place? shall we remove it from the project? | 11:31 |
Chipaca | facubatista: in the wheel, it's already there | 11:32 |
Chipaca | facubatista: in the source dist, we reference it by name, isn't that enough? | 11:32 |
Chipaca | i'm asking :) | 11:33 |
facubatista | Chipaca, who put it in the wheel? | 11:33 |
Chipaca | facubatista: wheel :) | 11:36 |
Chipaca | facubatista: FWIW I don't object to it being there | 11:37 |
facubatista | Chipaca, even if we don't specify to put it in the tarball? | 11:37 |
Chipaca | facubatista: correct | 11:37 |
facubatista | wow | 11:37 |
Chipaca | facubatista: you can try it yourself :) | 11:37 |
facubatista | nah, I trust you | 11:37 |
Chipaca | facubatista: 'python setup.py bdist_wheel' | 11:37 |
Chipaca | shaaame | 11:37 |
Chipaca | oh dang lunch | 11:37 |
* Chipaca rushes | 11:38 | |
Chipaca | so, it *looks* like github doesn't auto-add assets if you add them manually, so that might be a good way out | 12:13 |
facubatista | Chipaca, what we do about LICENSE file, then? | 12:15 |
Chipaca | facubatista: give me a bit | 12:16 |
Chipaca | just digging into that :) | 12:16 |
Chipaca | bah. i should probably shelve the version stuff first :-D | 12:16 |
facubatista | ack, no rush | 12:16 |
Chipaca | facubatista: so one approach is to add a setup.cfg with [metadata] license_file = LICENSE.txt | 12:21 |
Chipaca | license_files* | 12:21 |
facubatista | Chipaca, jam, now I pushed the files to where they belong, so I won't confuse again my directories: https://github.com/facundobatista/blog/tree/master/charm | 12:26 |
Chipaca | i don't have a stick big enough to shake at how much i dislike the under-documentedness of setup.py and .cfg | 12:30 |
jam | Chipaca, simple enough :) | 13:08 |
Chipaca | grmbl | 13:10 |
Chipaca | (tm) | 13:10 |
facubatista | Chipaca, see, I created a clean venv, then `pip install -r requirements-dev.txt`, and I get: | 13:17 |
facubatista | Installing collected packages: pycodestyle, toml, autopep8, mccabe, zipp, importlib-metadata, pyflakes, flake8, PyYAML, ops | 13:17 |
facubatista | I don't like that "ops" at the end | 13:17 |
facubatista | oh, mmm | 13:18 |
facubatista | $ cat env/lib/python3.6/site-packages/ops.egg-link | 13:18 |
facubatista | /home/facundo/canonical/operator | 13:18 |
facubatista | probably not harmful, though | 13:18 |
Chipaca | yep, it's done a 'develop' | 13:19 |
* Chipaca links to https://xkcd.com/1987/ on the README.md | 14:03 | |
jam | Chipaca, :) | 14:05 |
jam | danger of using 'sudo' to install python packages, indeed | 14:06 |
mup | PR operator#318 opened: Simplified the CharmBase init signature <Created by facundobatista> <https://github.com/canonical/operator/pull/318> | 14:08 |
facubatista | never ever do "sudo pip" | 14:09 |
jam | facubatista, do "curl | sudo bash" right? | 14:09 |
facubatista | ja | 14:10 |
facubatista | oh, Trello is down :/ | 14:18 |
Chipaca | facubatista: if trello is down, are you even working | 14:57 |
facubatista | Chipaca, I'm not doing anything but pressing F5 every couple of minutes, staring at the empty browser page | 15:00 |
Chipaca | facubatista: let's have our 1:1 now then :) | 15:01 |
facubatista | je | 15:02 |
facubatista | Chipaca, bah, I'm ok for the 1:1 now if you prefer it | 15:03 |
Chipaca | facubatista: let's do it | 15:06 |
facubatista | ok, 1' | 15:06 |
facubatista | Chipaca, omw | 15:08 |
Chipaca | soft EOD from me. brain = ded | 16:43 |
Chipaca | migt bbl if it reactivates | 16:43 |
facubatista | Chipaca, should we distribute ops docs inside its package? | 17:10 |
=== facundo__ is now known as facubatista | ||
* facundo__ eods | 21:04 | |
* Chipaca eods | 22:24 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!