=== vrubiolo1 is now known as vrubiolo
lucasmouraHey everyone, do we have a script called "sbuild-it" ? I am reviewing https://github.com/canonical/cloud-init/pull/407 and one of the step is to run:13:18
lucasmoura sbuild-it ../out/cloud-init_20.2-45-g5f7825e2-0ubuntu1~18.04.1.dsc13:18
lucasmouraBuild I can't find this script in either uss-tableflip or qa-scripts13:19
Odd_BlokeI'm not familiar with it.14:06
lucasmouraAlso, a question for a different issue, if the bug that I am doing the manual testing is not related to a launchpad bug, is there a convention to name that file ?14:18
rharperlucasmoura: I think blackboxsw might have that;14:36
lucasmourarharper, ack14:38
rharperlucasmoura: there's no convention yet; I suspect git log line <commish> replacing spaces with -14:39
lucasmourarharper, okay14:39
rharperor, we can start using gh-<pr-number>14:39
rharperOdd_Bloke: blackboxsw ^ ?   for fixes without lp bugs to match in ubuntu-sru test-cases ?14:40
falcojris "cloud-init devel schema" supposed to work with jinja templates?14:44
falcojrI get a 'Cloud config schema errors: format-l1.c1: File jinja.yaml needs to begin with "#cloud-config"' but our docs say the first line should be the jinja comment14:45
Odd_BlokeThat sounds like a gap we'll need to address as part of the schema work this cycle.14:48
rharper falcojr you need both ##template: jinja\n#cloud-config\nruncmd: ['echo', 'Hi']14:48
rharperfalcojr: oh I see; you want to schema check a template ...14:49
falcojrthanks. I had another issue with my config so wanted to verify it with that before fully launching it14:49
rharperthat seems like a new use-case;  as it's not*yet* fully formed14:49
rharperuntil you render it14:49
rharperthe schema won't know what to do with {{ foo }} etc14:49
falcojrright, makes sense14:50
rharperlet's file a bug/new-feature for that use-case;14:50
falcojrI can do that (hopefully ;) )14:52
Odd_Blokerharper: falcojr: As for naming, I think we've used git-<abbreviated hash>.txt before, but I don't have a strong preference.14:54
falcojrOdd_Bloke: sorry, for naming what?14:56
falcojrbug here: https://bugs.launchpad.net/cloud-init/+bug/188192514:58
ubot5Ubuntu bug 1881925 in cloud-init "Schema validation fails on jinja template" [Undecided,New]14:58
Odd_BlokeOh sorry, that was lucasmoura not you.14:58
lucasmouraOdd_Bloke, I have opened a PR with rharper naming suggestion. But I can rename it if the proposed convention should not be followed14:59
lucasmouraAlso, if my manual test references two distinct PRs, should I include both of them in the file name or just one ? In my PR I included just one, but I don't know if that is right14:59
blackboxswlucasmoura: thanks for the ping, I've added a PR which adds the sbuild-it script I use for package build  and validation. it's smoser's script originally, but I think it makes sense in our uss-tableflip repo15:51
blackboxswlucasmoura: https://github.com/canonical/uss-tableflip/pull/5215:53
blackboxswfeel free to land and merge that into uss-tableflip if it looks good.15:53
Odd_Blokefalcojr: I feel like we haven't reached consensus on my comment in https://github.com/canonical/cloud-init/pull/367/files#r434689535, gimme a shout if you want to jump on a call to get on the same page.16:20
falcojrOdd_Bloke: now works for me. Standup room?16:22
Odd_BlokeSure, omw.16:23
blackboxswfalcojr: nice schema devel gap/bug. the CLI tools wasn't full wired to the jinja part handling. so it's rudimentary. a fix would be helpful16:57
blackboxswlanded https://github.com/canonical/uss-tableflip/pull/5217:00
blackboxswso an update of uss-tableflip will expose scripts/sbuilt-it for package upload verification17:00
blackboxswalso eoan, xenial and bionic upload PRs are all updated for review (so we can officially kickoff the SRU process with the 'final' bits). eoan: https://github.com/canonical/cloud-init/pull/409 bionic: https://github.com/canonical/cloud-init/pull/407 xenial: https://github.com/canonical/cloud-init/pull/40617:04
blackboxswI think lucasmoura is on #407 already and dan on #40917:04
=== hjensas is now known as hjensas|afk
blackboxswlucasmoura: sorry on the sbuild-it script, that should now be landed via the following merged pull request:  https://github.com/canonical/uss-tableflip/pull/5218:02
lucasmourablackboxsw, no worries. I have just used to build the bionic package and now I was able to build the package18:03
lucasmouraAlso, I just finished reviewing the bionic PR18:03
Odd_Blokeblackboxsw: One typo in the eoan changelog, then I think it's good. Thanks!18:21
blackboxswthanks Odd_Bloke, just pushed the changelog fix19:32
Odd_BlokeThanks, looking now.19:48
Odd_Blokeblackboxsw: What does sbuild-it do for us other than save you from substituting the correct dist in?19:51
blackboxswhrm, travis seems to have queued and  not run the ubuntu/<series> branches for a while.20:02
blackboxswOdd_Bloke: sbuild-it just limits the # of params you need to pass, making it a simple sbuild-it *dsc20:03
blackboxswjust helpful to cut down on the sbuild params. not really required  or necessary20:04
blackboxswmaybe unnecessary  'sugar' as this could nearly be solved with a simple bash alias20:05
blackboxswmomousta: in landing your branch can I ammend your squashed commit  message to the following: https://pastebin.ubuntu.com/p/7zRn9WpMqs/?20:39
blackboxswwanted to note that 410 is now being handle20:39
blackboxswwanted to note that 410 is now being handled20:39
momoustaSure, please go ahead.20:39
blackboxswexcellent, and done20:39
blackboxswthanks again20:39
blackboxswit'll be in our next upload to ubuntu groovy20:40
Odd_Blokeblackboxsw: +1 on eoan21:18
Odd_Blokefalcojr: So your PR is ready to merge, but I'm done for the day and don't have the time to write a good merge commit message (which I think is particularly important for this change).  Would you mind putting one together for me to copy/paste first thing tomorrow (or perhaps by blackboxsw later)?21:38
falcojrOdd_Bloke: Sure...I can do the squashing too21:38
blackboxswthanks Odd_Bloke uploaded that. and thanks lucasmoura uploaded bionic21:56
blackboxswjust xenial remains for SRU upload, then I can ping the vanguard in #ubutu-devel to accept the queued uploads21:57
blackboxswxenial is here https://github.com/canonical/cloud-init/pull/40622:01
blackboxswand I just uploaded 20.2-45 B, E and F to https://launchpad.net/~cloud-init-dev/+archive/ubuntu/proposed22:01
blackboxswso we should be able to test those bits directly in SRU validation22:01
lucasmourablackboxsw, I will review the xenial release right now22:16
lucasmourablackboxsw, we have a flake8 issue related to one of the existing patches in xenial22:39
lucasmouraI have commented the issue on the PR22:39
blackboxswugh thanks lucasmoura for both reviews22:39
blackboxswlucasmoura: for tomorrow I fixed and pushed the flake error22:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!