falcojrIf I compare http://archive.ubuntu.com/ubuntu/pool/main/c/cloud-init/ to https://launchpad.net/~cloud-init-dev/+archive/ubuntu/proposed, why is the PPA behind proposed? My understanding was that it took some time for the package to make it to proposed, and we also pushed it to the PPA and could use that in the mean time for testing. Am I13:04
falcojrmisunderstanding something?13:04
lucasmouraHey everyone, I just realized that for xenial, we are dropping the jsonschema requirement from the package. In that case, our schema tests for https://git.launchpad.net/cloud-init/commit/?id=8bcf1c06 are not properly applied, since xenial will not perform any verification on the schema file as can be see here: https://github.com/canonical/cloud-init/blob/4261ae538563d262bc76b8c55f7cc0c8abb14b00/cloudinit/config/schema.py#L9013:17
lucasmouraIs that something we are okay with for this release or should we change that behavior on xenial ?13:18
=== Odd_Bloke changed the topic of #cloud-init to: Migration to travis-ci.com in progress, expect some CI weirdness | pull-requests https://git.io/JeVed | Meeting minutes: https://goo.gl/mrHdaj | Next status meeting June 16 16:15 UTC | 20.1 (Feb 18) | 20.2 (Apr 28) | https://bugs.launchpad.net/cloud-init/+filebug
Odd_Blokepowersj: Thanks for the help on Friday!  Full disclosure, I'd forgotten I didn't have admin on the new cloud-init repo, which is why you get ping-and-run'd. :p13:33
Odd_Blokefalcojr: Hmm, looks to me like we didn't upload the most recent version to the PPA. :/13:35
Odd_Blokelucasmoura: We are happy for the schema behaviour to not be present on xenial.  (We don't introduce new dependencies in stable releases without substantial justification, and xenial released before the schema code landed in cloud-init.)13:40
lucasmouraOdd_Bloke, ack13:41
Odd_Blokerharper: You should probably sign the CLA too. :p13:41
Odd_Blokepowersj: GH/Travis are very confused about your README PR, I think we may need to throw that one away and start again.14:18
Odd_BlokeOK, I think it might have been confused because the commit you created had state attached to it in a weird way; I just `commit --amend`ed it locally, and it's now only showing a single in-progress Travis check.14:21
rharperOdd_Bloke: ack14:23
Odd_Blokeparide: I've just sent an email to the cloud-init ML to answer your "Mhh, how is it that Travis CI didn't run on this PR?" Q. :)14:31
Odd_Bloke(And have already applied the prescribed fix in this case. :)14:32
parideOdd_Bloke, great, thanks14:36
powersjOdd_Bloke, based on your email I assume we are in a happy state now?14:45
Odd_Blokepowersj: Yep, thanks!15:03
smoserI'd like to have someone take a look at https://github.com/canonical/cloud-init/pull/416 sooner than later.15:17
smoserfor obvious reasons, re-basing or merging is probably going to be a pain again.15:17
=== 5EXAAFRTG is now known as ober
blackboxswlucasmoura: thanks for the update on the SRU16:08
blackboxswsmoser: grabbing it now16:08
blackboxswlucasmoura: just a minor set of fixes on your PR #99, then we'll land it16:09
lucasmourablackboxsw, Thanks for the review. I have updated the code16:21
blackboxswsmoser: review posted. thanks!16:23
smoserblackboxsw: responded16:29
blackboxswlucasmoura: mergedhttps://github.com/cloud-init/ubuntu-sru/pull/9916:29
blackboxswchecking smoser16:29
blackboxsw+1 smoser16:30
blackboxswlaunching a container now to double check smoser and will merge16:30
blackboxswand we can follow up w/ separate pr for runparts16:30
smoseris_exe doesn't seem unreasonable as a method exposed from a 'subp' module.16:31
smoserbut since we have no other callers, your argument seems sane.16:31
blackboxswyeah I kinda figured the same. I was checking for any  other users of X_OK... hrm looks like cloud-init/cloudinit/config/cc_chef.py16:32
blackboxswcould use that too.16:32
blackboxswsmoser: ok maybe we leave it public16:32
blackboxswsmoser: sorry bout that. and we can fold in cc_chef  to use subp.is_exe?16:33
blackboxswor separate PR16:33
smoserso you're16:34
smoserum... i dont really feel strong.16:34
smoseri can do it. or not.16:35
blackboxswok let's leave it public, as I can imagine other callers using subp.is_exe in the future16:35
blackboxswand chef could be adapted to it with a separate pr16:35
blackboxswor this one if you want16:35
smoserok. back to public.16:36
blackboxswwoo hoo. and around we go16:36
blackboxswgoing through a deployment now16:36
smoserblackboxsw: can you land? thanks for review.  and very fast review of 148 files ;)16:46
blackboxswsmoser: just checking the a set of chef changes for temporary file handling that appears to be in your branch. I think it's just locally when I diff against master. but I'm double checking before merging (as I'm hovering over the merge button)_16:47
blackboxswyeah part of your PR. ok and documented. n/m16:48
blackboxswsmoser: merged thx16:49
smoseri moved subp_blob_in_tempfile into cc_chef16:49
smoseras it was the only caller of that16:49
smoserand that method used util.writefilei and subp16:49
smoserso which woudl have caused recursive import16:49
smoserthat was just the easiest way out since only one caller16:50
meenablackboxsw: https://github.com/canonical/cloud-init/pull/416#issuecomment-640032968 any comment on (my comment)?17:03
blackboxswmeena: heh, I saw that happy face on your comment and interpreted as a joke given the complexity of the cloudinit.distro.net refactor :/17:05
blackboxswmeena: specifically what do you see in that which would be significantly different on BSD*?17:06
blackboxswor rather, across each linux distro17:06
meenawell, right now, we my handle enabling and starting services on BSD, in modules, where we do it on Linux,it's all duplicated code17:07
meenai actually thought, for puppet, we could use puppet to do it for us platform independently :D17:08
meena(and probably the same for chef, but i don't know chef, so i can't speak for chef)17:09
blackboxswheh, right....   just get people to swallow the big puppet config mgmt solution pill.   There goes our boot time :/17:09
meenaall you'd do is puppet apply, not the full thing with server and agent and database17:10
meena(in fact, despite being a Big Puppet Cheer Girl, i don't use the server/agent setup at all)17:11
meenabut, yeah, running ruby from python just to execute service { puppet: ensure => running, enabled => true } is overkill,overly specialised to that one module,and implementing very basic service handling in cloud-init would benefit more services17:14
blackboxswmeena: yeah I'm a puppet fan too.  Thanks for more context. I was misreading your PR comment related to the move of subp and didn't realize you were actually talking about the init services. right, those *could/should* be distro-specialized as there is a very different approach on many distros17:17
blackboxsw sorry you were talking about a separate refactor. and I *think* that would make sense to generalize that service enable/chaining/start etc. right now the jinja templates for that and the config templates are getting a bit busy, which indicates that we may need to develop a  better way to deal with it17:19
* blackboxsw tries to wrap up all the discussion you good folks have been having on the cloudinit.(distro).net refactor per https://github.com/canonical/cloud-init/pull/391/files17:20
blackboxswOdd_Bloke: looks really good https://github.com/canonical/cloud-init/pull/391/files initial questions and I can followup18:06
blackboxswsmoser: cloudinit/subp.py:377:17: F821 undefined name 'logexc'  on https://github.com/canonical/cloud-init/pull/42018:26
smoserblackboxsw: i don tknow what to do about that18:31
smoserhttps://paste.ubuntu.com/p/37rbHM6XQq/ ?18:33
blackboxswyeah smoser that looks good18:34
blackboxswdon't want to pull in util.logexc18:35
blackboxswsmoser: have you seen this before? I now see two travis CI  builds queued for your PR and I can't trash the first one https://github.com/canonical/cloud-init/pull/41918:41
blackboxswit's preventing me from merging via github UX18:41
smoserblackboxsw: no18:44
smosernot seen nit18:44
meenay'all ever gone a day of using computers without reporting at least one bug?18:48
powersjblackboxsw, see Odd_Bloke's email18:55
powersjre: transition to travis-ci.com18:55
=== Odd_Bloke changed the topic of #cloud-init to: Migration to travis-ci.com in progress, see https://lists.launchpad.net/cloud-init/msg00284.html | pull-requests https://git.io/JeVed | Meeting minutes: https://goo.gl/mrHdaj | Next status meeting June 16 16:15 UTC | 20.1 (Feb 18) | 20.2 (Apr 28) | https://bugs.launchpad.net/cloud-init/+filebug
blackboxswahh oops right. I had triggered rebuild, but that didn't quite clear it up. though smoser just put that PR up within the last hour, so I don't that qualifies as a PR generated before the move18:58
Odd_Blokeblackboxsw: Huh, yeah, that is weird.19:01
Odd_BlokeParticularly as both checks are pointing at the same Travis build ID. :/19:01
blackboxswsmoser: is it worth, closing and reopening you RP?19:01
smosermeena: when i left Canonical, i looked at how many bugs i'd opened.  I think it was 1 every 3 days for 10  years (including weekends/holidays)19:01
blackboxswPR rather https://github.com/canonical/cloud-init/pull/41919:01
smoserblackboxsw: thats fine. i'll just re-submit19:01
blackboxswyeah something is amiss there as smoser's other PRs from today were running CI fine19:01
meenasmoser: you'd think it'd get better, eventually?? huh?19:02
smoseri dont recall the number that were still open ;)19:05
blackboxswgood a happy single CI run in progress on https://github.com/canonical/cloud-init/pull/42119:11
meenalet's not try to look too closely19:12
meenaI'm going to look very closely into sleep now19:12
blackboxswfalcojr: lucasmoura Odd_Bloke I uploaded 20.2.45 to https://launchpad.net/~cloud-init-dev/+archive/ubuntu/proposed/+packages I think the build finally completed in that PPA as I now see the right version present in apt policy20:50
blackboxswso we should be able to use that PPA for testing20:51
Odd_Blokehttps://github.com/canonical/cloud-init/pull/414 <-- this has two non-committer +1s, if a committer wants to take a quick look21:03
blackboxswlucasmoura: could nits on https://github.com/cloud-init/ubuntu-sru/pull/103/files21:05
Odd_Blokeblackboxsw: Thanks!  (And thanks to James and Paride for the earlier reviews!)21:09
lucasmourablackboxsw, Thanks for the review. I have updated the code21:12
blackboxswlucasmoura: a small response on renaming terminate_instance function. and +121:17
lucasmourablackboxsw, done21:19
blackboxswlucasmoura: merged. also with trello cards if you ctrl-c on the PR url and ctrl-v while highlighting the card, it attaches the PR link to the card top-level so that trello github automation will surface whether the PR is merged21:24
blackboxswlucasmoura: per this trello card https://trello.com/c/clHH7aDU/1680-add-code-to-terminate-ec2-instance  it looks like you attach links in a comment, which doesn't surface github PR status on the card21:25
blackboxswawesome looks fixed now21:25
blackboxswthen I can see a "1 merged" icon on the card without opening it (as well as21:25
blackboxswci results too)21:25
lucasmourablackboxsw, Cool feature :) I will use on my next cards. Thanks for pointing that out21:26
blackboxswlucasmoura: for tomorrow https://github.com/canonical/cloud-init/pull/390/files review done22:40
blackboxswfor ec2 mirror disabling22:41
lucasmourablackboxsw, ack22:41

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!