wallyworld | hpidcock: is the TestArrayArraysUnorderedWithExpected test, why diesn't jc.NewMultiChecker().Add("[1]", jc.SameContents) work? why does it need the additonal jc.ExpectedValue arg? To me we should just be able to specify jc.SameContext and job done | 00:11 |
---|---|---|
hpidcock | wallyworld: because some checkers don't take any arguments, some checkers take more than one | 00:12 |
hpidcock | so this way the syntax matches c.Check | 00:13 |
hpidcock | and it means you declare the compared value to be different than whats in the object you are comparing | 00:14 |
wallyworld | ok, that make sense | 00:15 |
wallyworld | looks nice | 00:16 |
hpidcock | wallyworld: yeah we can iterate on it to make sure its useful for all cases in the future | 00:17 |
wallyworld | yup, land and iterate :-) | 00:17 |
oyrogerg | Hi everyone, quite new to Juju. I am comparing two different bundle files for deploying the same final system, and would like to know about 'gui-x' and 'gui-y' settings. Do they do much of interest to a non-GUI user? | 00:19 |
oyrogerg | (Meanwhile, I see there's a Discourse. Searching there...) | 00:19 |
pmatulis | oyrogerg, they are a GUI-only thing | 00:20 |
oyrogerg | Thanks pmatulis, I wil ignore those differences then. | 00:20 |
pmatulis | https://juju.is/docs/bundle-reference | 00:21 |
pmatulis | oyrogerg, ^^^ | 00:21 |
oyrogerg | Even better, thank you. | 00:21 |
hpidcock | PR please https://github.com/juju/juju/pull/11676 | 02:16 |
thumper | landings seems to be faster and less buggy | 02:19 |
thumper | based on my sample size of one | 02:19 |
* thumper looks at PR | 02:19 | |
thumper | hpidcock: looks good | 02:26 |
hpidcock | thumper: awesome thanks | 02:26 |
thumper | hpidcock: looking at the 2.7 merge updating gorilla ws, did we have a fix for this yet? | 02:28 |
tlm | wallyworld: got 2 minute for HO ? | 04:11 |
wallyworld | tlm: in another meeting, can ping when done? | 04:11 |
tlm | no rush might see if hpidcock wants to assist ? | 04:12 |
manadart | hml or stickupkid_ or achilleasa: https://github.com/juju/juju/pull/11678 | 15:20 |
manadart | I'm EoD. If it's good, feel free to merge it. | 15:20 |
hml | manadart: i’ll take a look | 15:21 |
manadart | hml: I'll add a new test specifically for the port change life. | 15:47 |
hml | manadart: to the pr? | 15:47 |
manadart | hml: Yeah. | 15:47 |
hml | manadart: ack, working on qa now | 15:48 |
hml | manadart: that’s weird, wonder why everything started failing with build fail in the middle of the make-check-juju | 15:55 |
manadart | hml: Added that test. | 18:01 |
hml | manadart: k, kicked off !!build!! a bit ago, see how it ran | 18:02 |
manadart | hml: Great. See you tomorrow. | 18:02 |
hml | manadart: g'night | 18:02 |
tlm | 2.8 => develop PR https://github.com/juju/juju/pull/11679 | 23:07 |
tlm | another PR as well https://github.com/juju/juju/pull/11671 | 23:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!