[00:11] hpidcock: is the TestArrayArraysUnorderedWithExpected test, why diesn't jc.NewMultiChecker().Add("[1]", jc.SameContents) work? why does it need the additonal jc.ExpectedValue arg? To me we should just be able to specify jc.SameContext and job done [00:12] wallyworld: because some checkers don't take any arguments, some checkers take more than one [00:13] so this way the syntax matches c.Check [00:14] and it means you declare the compared value to be different than whats in the object you are comparing [00:15] ok, that make sense [00:16] looks nice [00:17] wallyworld: yeah we can iterate on it to make sure its useful for all cases in the future [00:17] yup, land and iterate :-) [00:19] Hi everyone, quite new to Juju. I am comparing two different bundle files for deploying the same final system, and would like to know about 'gui-x' and 'gui-y' settings. Do they do much of interest to a non-GUI user? [00:19] (Meanwhile, I see there's a Discourse. Searching there...) [00:20] oyrogerg, they are a GUI-only thing [00:20] Thanks pmatulis, I wil ignore those differences then. [00:21] https://juju.is/docs/bundle-reference [00:21] oyrogerg, ^^^ [00:21] Even better, thank you. [02:16] PR please https://github.com/juju/juju/pull/11676 [02:19] landings seems to be faster and less buggy [02:19] based on my sample size of one [02:19] * thumper looks at PR [02:26] hpidcock: looks good [02:26] thumper: awesome thanks [02:28] hpidcock: looking at the 2.7 merge updating gorilla ws, did we have a fix for this yet? [04:11] wallyworld: got 2 minute for HO ? [04:11] tlm: in another meeting, can ping when done? [04:12] no rush might see if hpidcock wants to assist ? [15:20] hml or stickupkid_ or achilleasa: https://github.com/juju/juju/pull/11678 [15:20] I'm EoD. If it's good, feel free to merge it. [15:21] manadart: i’ll take a look [15:47] hml: I'll add a new test specifically for the port change life. [15:47] manadart: to the pr? [15:47] hml: Yeah. [15:48] manadart: ack, working on qa now [15:55] manadart: that’s weird, wonder why everything started failing with build fail in the middle of the make-check-juju [18:01] hml: Added that test. [18:02] manadart: k, kicked off !!build!! a bit ago, see how it ran [18:02] hml: Great. See you tomorrow. [18:02] manadart: g'night [23:07] 2.8 => develop PR https://github.com/juju/juju/pull/11679 [23:31] another PR as well https://github.com/juju/juju/pull/11671