[01:34] i remember asking about that a year ago. iirc, they are provider-dependent [01:57] pmatulis: ty [01:57] that's the conclusion I have come to [02:28] thumper: https://github.com/juju/juju/pull/11703 [02:29] * thumper headdesks at 2.8 branch needing apiserver to test state package [02:29] * thumper looks at pr [02:29] igmores [02:30] 15 files? [02:30] small changes [02:32] * thumper nods [02:35] ah FFS [02:35] * thumper wonders about 2.7 all watcher bits [02:36] wallyworld: this isn't going to work [02:36] did you want to jump in a HO to discuss [02:36] sure [02:36] 1+1 [03:31] thumper: tweaked the cache lookup, just need to test with libjuju [03:32] and need to fix one unit test [04:12] wallyworld: is it ready for a rereview? [04:13] thumper: HO? [04:27] sure [04:48] hpidcock: did your new multichecker land in 2.7? [04:48] hpidcock: I have a perfect usecase for it [04:48] thumper: I don't think so [04:49] hpidcock: boo [04:49] Feel free to update the juju/testing dep [04:50] hpidcock: hmm... [04:50] hpidcock: may well do [04:50] hangon [04:50] I'm in 2.8 [04:50] yay [04:50] hpidcock: what is it called again [04:51] jc.NewMultiChecker() [04:51] there is an example of its use somewhere in 2.8 [04:52] found it [04:52] now I need to work out how to get it to ignore the right field [04:53] hpidcock: got 2 minutes to help out? [04:55] I'm not sure how to map this thing through [04:55] sure [04:55] standup? [04:56] thumper:^ [04:57] hpidcock: yeah [05:03] thumper: you good with the PR then? i wan tto land it so i can forward port [05:28] wallyworld: sorry, will do another quick pass over [05:28] all good [05:32] and you push while I'm looking? [05:32] thumper: sorry, there was a go fmt thing [05:33] an extra ' ' [05:34] approved with a questino [05:34] * thumper is done and heading off now [05:34] leaving with 15 failing tests in state package [05:34] get to them next week [05:34] later peeps [09:05] manadart: to fix the lingering port issue with ovs we could override the port name via the 'veth.pair' option to a known (based on the container id or similar) value so we can remove it when we destroy the container [09:05] achilleasa: Yep. [09:46] yay, managed to replicate the LXD bug, finally [10:20] now, we have deterministic iface naming for lxd veths ;-) https://pastebin.canonical.com/p/ysbqGHWJVV/ [10:21] manadart: stickupkid comments/concerns about format? ^^ (it's "machID-ifaceIdx" where machID has / converted to _ to distinguish from last dash) [10:22] achilleasa, i'm never sure if you even need _, but otherwise looks ok to me [10:23] achilleasa, i.e. 0lxd2-0 [10:23] achilleasa, lxd is the separator [10:23] achilleasa, like doing `1_,_2_,_3` for csv ;-) [10:24] achilleasa: Agree with stickupkid. This is cool BTW. [10:25] achilleasa: This will apply to all LXD veths created for Juju right? not just connected to OVS? [10:29] stickupkid: makes sense; I will just trim it off. manadart yes; I wanted to put a juju prefix but there is a 16 char limit so I tried to keep it shorter [10:31] achilleasa: I love that "ip a" will now give a less opaque picture of what's going on. [10:31] achilleasa: And in the state link-layer data for that matter. [15:20] stickupkid: pr review changes made to 11701. i’m finalizing k8s testing now [15:41] hml, been looking [15:41] stickupkid: testing my k8s myself [15:47] hml, approved again [15:48] stickupkid: cool, ty [15:49] stickupkid: ffs: https://pastebin.canonical.com/p/J3Tx9pF6Wc/. will have to fix this [15:52] stickupkid: and k8s is now failing to install *sigh [15:53] hml, weird [15:54] stickupkid actually no… the LXDProfileRequire doesn’t check machine for KVM or manual etc…. only if the charm has a profile in it [15:55] *facepalm* [15:55] not sure on the k8s change yet [16:23] hml, if you've got 5 minutes before my EOD around https://github.com/juju/juju/pull/11700 [16:24] stickupkid: had a question for you on there… forgot to click send. ho? === mpontillo_ is now known as mpontillo