| SpecialK|Canon | https://code.launchpad.net/~doismellburning/launchpad/+git/launchpad/+merge/385644 please | 10:26 |
|---|---|---|
| tomwardill | +1 | 10:29 |
| SpecialK|Canon | Thanks :) | 10:33 |
| SpecialK|Canon | And uh https://code.launchpad.net/~doismellburning/launchpad/+git/launchpad/+merge/385741 to fix the test I broke please...! | 12:04 |
| SpecialK|Canon | http://lpbuildbot.canonical.com/builders/lp-devel-xenial/builds/1334/steps/shell_9/logs/summary also shows TestRunMissingJobs.test_run_missing_ready_does_not_return_results failure but I can't reproduce it locally, can't see how my change would have impacted it, and have a suspicion that it's a transient timing issue? | 12:05 |
| tomwardill | yeah | 12:05 |
| tomwardill | that's a celery / rabbit failure manifestation | 12:05 |
| SpecialK|Canon | tomwardill: an actual proper persistent failure, it seems? http://lpbuildbot.canonical.com/builders/lp-devel-xenial/builds/1335/steps/shell_9/logs/summary | 13:16 |
| ilasc | SpecialK|Canon: nope, that's transient | 13:16 |
| tomwardill | you just have the fun of it happening multiple times :) | 13:16 |
| ilasc | that's one of "the usual" | 13:17 |
| ilasc | right, as tomwardill said :) | 13:17 |
| SpecialK|Canon | Ah ok I'm 2/2 so far - I recognise that's not a lot of data points but also figured safest to assume that I'd just broken stuff ;) | 13:17 |
| SpecialK|Canon | Cheers! | 13:17 |
| SpecialK|Canon | Can I kick off a restart somehow or do I just wait for someone else to merge something? | 13:17 |
| tomwardill | http://lpbuildbot.canonical.com/force | 13:18 |
| SpecialK|Canon | ...it's even right there on the front page isn't it - thanks | 13:18 |
| tomwardill | it's non-ovious terminology | 13:18 |
| tomwardill | also non-obvious place, you'd expect a 'retry' on the build page or something | 13:19 |
| tomwardill | (fwiw, our cancel also doesn't work) | 13:19 |
| pappacena | Did it fail again? I've retried right before the standup... | 13:19 |
| SpecialK|Canon | pappacena: ah then I might have double-retried, sorry | 13:19 |
| * pappacena not a problem :) | 13:19 | |
| tomwardill | iirc, if it's in a failed state, a merge won't cause a new build | 13:19 |
| tomwardill | you have to force it once the merge shows up on the left column | 13:20 |
| SpecialK|Canon | it definitely tried a new build of my merged test fixen | 13:20 |
| tomwardill | https://usercontent.irccloud-cdn.com/file/9jd2SNIX/image.png | 13:21 |
| tomwardill | not at that time difference it didn't, that was pappacena retrying it for you | 13:21 |
| * SpecialK|Canon retracts the "definitely" | 13:21 | |
| SpecialK|Canon | I assumed that there would be visible indication in the waterfall of someone doing that | 13:22 |
| tomwardill | nope | 13:22 |
| tomwardill | force is a bit of a weird hack in this version of buildbot, it's not natively implemented | 13:22 |
| tomwardill | but there was a standard 'recipe' for people to extend the web ui to create it | 13:22 |
| SpecialK|Canon | no pressure re your buildbot work, but uh.... ;) | 13:22 |
| tomwardill | hah | 13:22 |
| tomwardill | SpecialK|Canon: you can see it on http://lpbuildbot.canonical.com/builders/lp-devel-xenial/builds/1335 fwiw | 13:23 |
| tomwardill | under 'Reason' | 13:23 |
| tomwardill | but the waterfall doesn't show it | 13:24 |
| pappacena | ilasc, tomwardill these are the MPs for projects as pillar for OCI projects: | 13:24 |
| pappacena | - https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/384506 (create & edit page) | 13:24 |
| pappacena | - https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/384514 (search & list) | 13:24 |
| SpecialK|Canon | http://lpbuildbot.canonical.com/builders/lp-devel-xenial/builds/1336/steps/shell_9/logs/summary - TestJobRunner.test_runAll_mails_oopses also a known flaky? | 14:07 |
| pappacena | tomwardill: on https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/384514, you've mentioned a typo, but I cannot see your comment on the code :-( | 15:35 |
| tomwardill | pappacena: sigh, bet I forgotr to save it | 15:36 |
| tomwardill | I did | 15:36 |
| tomwardill | pappacena: L590 in the diff, s/contains/contain | 15:36 |
| tomwardill | (findByPillarAndName) | 15:36 |
| pappacena | Ah! Thanks! | 15:36 |
| tomwardill | pappacena: fairly sure it was my typo to start with :) | 15:38 |
| pappacena | hahaha. Maybe... I will fix it there anyway :) | 15:38 |
| tomwardill | ah poop, actual test failure | 15:54 |
| * tomwardill gets to fixing | 15:54 | |
| * pappacena :-( | 15:55 | |
| tomwardill | tricky as we don't actually have the git repository that has been created to check against it's IP | 16:01 |
| tomwardill | mgiht just have to swap it for an assert 'id' in repo.keys() | 16:02 |
| pappacena | Maybe using a matcher for the data type could do? | 16:04 |
| pappacena | Like `'id': IsInstance(int)` | 16:06 |
| tomwardill | yeah, that's probably better | 16:06 |
| * tomwardill does that | 16:06 | |
| tomwardill | fix my whoopsie: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/385759 | 16:09 |
| tomwardill | curious as to how it got to be 'not 1' though, that does imply a test isolation failure somewhere | 16:10 |
| * pappacena +1 | 16:10 | |
| pappacena | I guess the tests do not delete the database (or it depends on the layer, or whatever). And increasing a sequence has effect regardless on rolling back a transaction... | 16:11 |
| tomwardill | ta, landing | 16:11 |
| tomwardill | and then poking buildbot | 16:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
