| mup | PR snapd#8854 closed: sysconfig/cloudinit: make callers of DisableCloudInit use WritableDefaultsDir <Simple 😃> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8854> | 05:02 |
|---|---|---|
| mup | PR snapd#8850 closed: dirs: delete unused Cloud var, fix typo <Cleanup :broom:> <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8850> | 05:12 |
| mborzecki | morning | 05:24 |
| mvo | hey mborzecki | 05:25 |
| mborzecki | mvo: hey | 05:26 |
| mborzecki | https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1858636 is interesting | 05:36 |
| mup | Bug #1858636: snapd generates incomplete fontconfig caches, result in emoji rendering issue in chromium <apport-collected> <eoan> <focal> <rls-ff-incoming> <snap> <wayland-session> <chromium-browser (Ubuntu):Confirmed> <snapd (Ubuntu):Confirmed for anonymouse67> <https://launchpad.net/bugs/1858636> | 05:36 |
| mup | PR snapd#8837 closed: snap: add an activates-on property to apps for D-Bus activation <Needs Samuele review> <Created by jhenstridge> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8837> | 05:42 |
| zyga | Hey guys | 06:25 |
| zyga | Unclear if I will work today, depending on ability | 06:25 |
| mborzecki | zyga: hey | 06:27 |
| zyga | Hey :-) | 06:28 |
| mvo | zyga: good morning | 06:32 |
| zyga | Hey mvo | 06:43 |
| zyga | I will file time of for Friday | 06:44 |
| mvo | zyga: yeah, please do | 06:48 |
| pstolowski | morning | 07:02 |
| mborzecki | pstolowski:hey | 07:03 |
| mborzecki | heh, even without font cache, spotify snap still segfaults on my host | 07:17 |
| pedronis | hello | 07:21 |
| pedronis | pstolowski: hi, I left some comments/questions in #8812 | 07:24 |
| mup | PR #8812: o/snapstate: service-control task handler (4/N) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8812> | 07:24 |
| pedronis | pstolowski: on a different note: is/can be #8532 useful or should we just close it? | 07:25 |
| mup | PR #8532: tests: install new snapd deb into preseed image <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8532> | 07:25 |
| pstolowski | pedronis: saw your comments, thanks for looking at it! | 07:26 |
| pstolowski | pedronis: 8532 might be useful, i need to think | 07:27 |
| pedronis | pstolowski: ok, on a 3rd note: do you want to look at #8823 more ? | 07:28 |
| mup | PR #8823: asserts/internal: limit Grouping size switching to a bitset representation <Bulk assert refresh :scroll::scroll::scroll:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8823> | 07:28 |
| pstolowski | pedronis: yes, i'll conclude this review today | 07:29 |
| pedronis | mvo: mborzecki: hi, we were having issues with centos on Fri, are we looking into it? | 07:30 |
| mborzecki | pedronis: what kind of issues? | 07:30 |
| mborzecki | let me check the most recent prs | 07:31 |
| pedronis | mborzecki: https://github.com/snapcore/snapd/pull/8855/checks?check_run_id=766170841 selinux/package related | 07:31 |
| mup | PR #8855: cmd,many: move Version and bits related to snapd tools to snapdtool, merge cmdutil <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8855> | 07:31 |
| mborzecki | pedronis: yeah, it's the same as https://forum.snapcraft.io/t/snapd-updates-in-fedora-epel-for-enterprise-linux/8310/28?u=mborzecki | 07:32 |
| pedronis | mborzecki: do we need to mark them unstable? | 07:33 |
| pedronis | 7 is also failing and marked required | 07:34 |
| mborzecki | pedronis: maybe, i need to poke around a bit more, had some trouble refreshing rhel vms in the morning | 07:34 |
| mup | PR snapd#8858 opened: asserts,daemon: add support for "serials" field in system-user assertion <Created by mvo5> <https://github.com/snapcore/snapd/pull/8858> | 07:38 |
| === alazred_ is now known as alazred | ||
| mborzecki | heh, so centos is lagging behind again | 07:49 |
| mborzecki | and snapd 2.45 installs fine on rhel8 | 07:50 |
| mborzecki | hm a build of selinux-policy for centos in a sufficient version was done a couple of days ago https://koji.mbox.centos.org/koji/buildinfo?buildID=11412 but no clue where to find it | 08:01 |
| mup | PR snapd#8859 opened: tests: enable snap-auto-mount test on core20 <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8859> | 08:08 |
| mborzecki | pedronis: mvo: yeah, so with some info from folks in #centos it is lagging behind, 8.2 is in the oven so no updates are being pushed, and in general there is no clear solution for the latency of updates from rhel (which is used for epel builds) appearing in centos | 08:19 |
| pedronis | mborzecki: mvo: so short term we shoul mark both centos unstable? | 08:20 |
| mborzecki | perhaps we should make that test smarter, rather than dumping whole centos to unstable | 08:20 |
| pedronis | mborzecki: that sounds ok, but if is not trivial we should first unblock landings | 08:21 |
| pedronis | mborzecki: also it's a bit unclear is a good use of time, I don't know. I agree that the fact that we have fully unsable systems, instead of unstable tests is a bit of a problem | 08:22 |
| mborzecki | otoh, how do we mark the system unstable right now? | 08:23 |
| mvo | mborzecki: I can mark it unstable (I uncheck "required test" in the settings box for this) | 08:26 |
| mborzecki | mvo: please do | 08:26 |
| mvo | mborzecki: done, centos-7 is no longer required | 08:30 |
| mborzecki | mvo: centos-8 :) | 08:30 |
| mvo | mborzecki: that is already not-required | 08:31 |
| mvo | mborzecki: should I make -7 required again? | 08:31 |
| mborzecki | mvo: yeah, sorry, centos-7 is good, only 8 needs to be non-mandatory | 08:31 |
| mvo | mborzecki: updated again, thank you :) | 08:32 |
| mborzecki | sil2100: hey, can you take a look at https://github.com/CanonicalLtd/ubuntu-image/pull/189 ? | 08:45 |
| mup | PR CanonicalLtd/ubuntu-image#189: ubuntu_image: do not overwrite the files that snap prepare-image has created <Created by bboozzoo> <https://github.com/CanonicalLtd/ubuntu-image/pull/189> | 08:45 |
| mup | PR snapd#8823 closed: asserts/internal: limit Grouping size switching to a bitset representation <Bulk assert refresh :scroll::scroll::scroll:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8823> | 08:48 |
| mup | PR snapd#8860 opened: overlord: refuse to install snaps whose activatable D-Bus services conflict with installed snaps <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8860> | 08:53 |
| mborzecki | quick errand | 08:59 |
| zyga | starting work | 08:59 |
| zyga | pedronis: thank you for the changes to https://github.com/snapcore/snapd/pull/8829 - they look good | 09:01 |
| mup | PR #8829: sandbox/cgroup: add tracking helpers <Created by zyga> <https://github.com/snapcore/snapd/pull/8829> | 09:01 |
| zyga | pedronis: I will prepare the next chunk in a moment | 09:01 |
| zyga | mborzecki: what is up with centos-8? | 09:02 |
| zyga | Problem: package snapd-2.45-1.el8.x86_64 requires snapd-selinux = 2.45-1.el8, but none of the providers can be installed | 09:02 |
| * zyga reads backlog | 09:04 | |
| pedronis | pstolowski: thanks, I expanded a bit my considerations: https://github.com/snapcore/snapd/pull/8812#discussion_r440038759 | 09:15 |
| mup | PR #8812: o/snapstate: service-control task handler (4/N) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8812> | 09:15 |
| pstolowski | pedronis: thank you | 09:17 |
| zyga | mborzecki: do you think you could do a 2nd review for 8829? | 09:21 |
| zyga | it's the same code, just split out and polished a little | 09:21 |
| mborzecki | re | 09:35 |
| mborzecki | pstolowski: which snap did you try to debug with --gdbserver? | 09:36 |
| pstolowski | mborzecki: hello-world | 09:36 |
| mborzecki | ok, let me try that | 09:37 |
| mborzecki | meh, python 3.5 vs 3.8 | 09:38 |
| mup | PR snapd#8861 opened: data,packaging,wrappers: extend D-Bus service activation search path <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8861> | 09:38 |
| mborzecki | zyga: centos-8 should be marked as unstable, even if it fails it should be possible to merge a PR | 09:40 |
| zyga | I see | 09:40 |
| zyga | are we waiting for something to migrate? | 09:40 |
| mborzecki | zyga: and i'll be adding some details about centos-8 and epel to the standup docs | 09:40 |
| zyga | ok | 09:40 |
| pedronis | mborzecki: hi, I updated https://github.com/snapcore/snapd/pull/8844 to keep only the benchmarks as we discussed previously | 09:44 |
| mup | PR #8844: asserts/internal: add some iteration benchmarks <Created by pedronis> <https://github.com/snapcore/snapd/pull/8844> | 09:44 |
| mborzecki | pedronis: thanks! | 09:48 |
| pedronis | mvo: I reviewed #8858, missing some bits (format is a bit complicated) | 09:54 |
| mup | PR #8858: asserts,daemon: add support for "serials" field in system-user assertion <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8858> | 09:54 |
| mvo | pedronis: thank you, looking | 09:55 |
| pstolowski | mborzecki: are you checking my remark about seond 'continue'? | 10:00 |
| mborzecki | pstolowski: yeah, that was my intention, but got into a fight with py35 in ubuntu-image :/ | 10:01 |
| pstolowski | haha | 10:01 |
| === pedronis_ is now known as pedronis | ||
| mup | PR snapd#8784 closed: snap: add new `snap run --experimental-gdbserver` option <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8784> | 10:44 |
| jamesh | mborzecki: would you have any idea of what sort of changes I'd need to fix this error? https://github.com/snapcore/snapd/pull/8861#issuecomment-644048833 | 10:55 |
| mup | PR #8861: data,packaging,wrappers: extend D-Bus service activation search path <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8861> | 10:55 |
| mborzecki | jamesh: looking | 10:55 |
| jamesh | mborzecki: in short, I need to make a couple of directories under /var/lib/snapd readable by dbus-daemon | 10:56 |
| jamesh | while being writable by snapd | 10:56 |
| mborzecki | jamesh: should be fairly simple, i can push a patch there | 10:57 |
| jamesh | mborzecki: thanks. That seemed like the only legitimate failure in the logs so far. | 10:58 |
| jamesh | good thing you added that regression test :-) | 10:58 |
| mborzecki | jamesh: mhm, yeah we need to updae the policy, system_dbusd_t (used dbus-daemon) does not have read access to /var/lib/snapd | 10:59 |
| jamesh | mborzecki: I suppose we can't just label /var/lib/snapd/dbus in a way to give it access if it can't read /var/lib/snapd :( | 11:00 |
| jamesh | or traverse it at least | 11:00 |
| popey | I have updated a snap (atom) which now complains that "- Mount snap "atom" (256) (cannot find required base "core")" - but i have core installed. https://paste.ubuntu.com/p/kMNzw3Jj8v/ any ideas? | 11:01 |
| popey | you can "snap install atom --edge --classic" to try for yourself. | 11:01 |
| mborzecki | jamesh: we could use the same label as /usr/share/dbus/services.d but then quite likely we'd need to update the snapd policy to allow snapd write access there | 11:02 |
| mborzecki | jamesh: either way, a change is needed | 11:02 |
| mborzecki | i wonder why there was no error on fedora though | 11:02 |
| zyga | jamesh: hi | 11:04 |
| zyga | sorrym I'm not around during the calls much | 11:04 |
| zyga | not the best moment in my life | 11:04 |
| jamesh | mborzecki: it should be similar label to /usr/share/dbus-1/{services,system-services} -- not sure if that differs to session.d/system.d | 11:04 |
| zyga | I left a pair of small comments on https://github.com/snapcore/snapd/pull/8861 | 11:04 |
| mup | PR #8861: data,packaging,wrappers: extend D-Bus service activation search path <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8861> | 11:04 |
| jamesh | zyga: no problem | 11:04 |
| zyga | jamesh: sorry to nickpick about the name but I really wonder why we use "services" and not "session-services" | 11:05 |
| jamesh | zyga: I followed the naming scheme that D-Bus uses, as mentioned in the comment. I'm not sure it is worth being different | 11:06 |
| zyga | I see, I missed that when jumping through the diff | 11:07 |
| jamesh | zyga: and as always, thanks for the review feedback :-) | 11:11 |
| mborzecki | jamesh: do we need to reload dbus-daemon to have it pick up those extra conf files? | 11:15 |
| mborzecki | i would guess that system dbus got reloaded/restarted on centos 7 and that triggered the denial | 11:15 |
| zyga | Interesting, I recall a bug where it would only work if a directory was present to start with | 11:17 |
| zyga | as otherwise dbus would not establish some inotify watch | 11:17 |
| zyga | I don't recall the details | 11:17 |
| jamesh | mborzecki: there is a restart method you can send, but I think it generally picks things up via inotify these days | 11:18 |
| jamesh | mborzecki: we don't currently do it when adding/removing system bus policy, but probably should. | 11:19 |
| jamesh | perhaps that should be a new PR | 11:19 |
| mborzecki | jamesh: isn't inotify only for service.d system.d directories? | 11:19 |
| jamesh | mborzecki: once it reads the new config file from /usr/share/dbus-1/system.d or session.d, it should start monitoring the new directory for service activation files | 11:22 |
| zyga | core20 prepare fails, has anyone looked at that? | 11:34 |
| pedronis | that's recent | 11:44 |
| mborzecki | jamesh: heh, the test is fine in isolation as suspected | 11:56 |
| clmsy | hi everyone, quick question, were there any known changes to gadget structure for core20 builds? my ubuntu-image cli fails on the last step of building a core20 based image with "cant find boot config". | 12:09 |
| clmsy | in the gadget's stage folder i can see all the grub related files | 12:09 |
| clmsy | ooh one sec i realized something... snapcraft clean actually never removes gadget and parts folder somehow, i manually deleted them, did another build and the gadget snap is created but there is no stage or parts folder hmm | 12:16 |
| zyga | mborzecki: o/ | 12:18 |
| zyga | mborzecki: I opened a small tweak and another chunk carved out of the refresh tracking logic | 12:18 |
| zyga | mborzecki: the tweak is https://github.com/snapcore/snapd/pull/8862 and is really small apart from mv'ing some code around - I did this to allow the diff in cgroup.go (in subsequent branches) to be readable | 12:19 |
| mborzecki | zyga: trading PR for PR https://github.com/snapcore/snapd/pull/8864 :) | 12:19 |
| mup | PR #8862: sandbox/cgroup: improve pid parsing code <Created by zyga> <https://github.com/snapcore/snapd/pull/8862> | 12:19 |
| mup | PR #8864: cmd/snap: do not show $PATH warning when executing under sudo on a known distro <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8864> | 12:19 |
| zyga | mborzecki: and to make sure I didn't break anything in conflict resolution | 12:19 |
| mup | PR snapd#8862 opened: sandbox/cgroup: improve pid parsing code <Created by zyga> <https://github.com/snapcore/snapd/pull/8862> | 12:19 |
| mup | PR snapd#8863 opened: sandbox/cgroup: allow discovering PIDs of given snap <Created by zyga> <https://github.com/snapcore/snapd/pull/8863> | 12:19 |
| zyga | mborzecki: gladly :) | 12:19 |
| mup | PR snapd#8864 opened: cmd/snap: do not show $PATH warning when executing under sudo on a known distro <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8864> | 12:19 |
| zyga | mborzecki: the only new change is that I simplified PidsInGroup | 12:19 |
| zyga | compare https://github.com/snapcore/snapd/pull/8862/files#diff-a44752c174bd4af51ccc892ed5bc15b4L212 and https://github.com/snapcore/snapd/pull/8862/files#diff-a5c0640204de19f988a6d5446e6108e6R32 | 12:20 |
| zyga | it was a simple code reuse as everything was exactly the same | 12:20 |
| zyga | the https://github.com/snapcore/snapd/pull/8863 is a bigger PR that involves one main new function in the form taken verbatim out of refresh app awareness v2 branch - again split to a new file for readability | 12:20 |
| mup | PR #8863: sandbox/cgroup: allow discovering PIDs of given snap <Created by zyga> <https://github.com/snapcore/snapd/pull/8863> | 12:20 |
| mborzecki | mhm | 12:21 |
| zyga | comments there probably need tweaking but the logic is what I wanted it to be | 12:21 |
| zyga | the comment on the PR is more accurate than than the comments inside | 12:21 |
| zyga | ok, that's that | 12:21 |
| zyga | going to look at your PR :) | 12:21 |
| zyga | mborzecki: is there a spread test that shows this warning? | 12:23 |
| mborzecki | zyga: afaik there isn't one | 12:24 |
| zyga | ok | 12:25 |
| zyga | btw, I found one thing over weekend | 12:25 |
| zyga | grep -x | 12:25 |
| zyga | very useful for line matches | 12:25 |
| zyga | especially as grep -qFx | 12:25 |
| zyga | quiet, literal, whole line matches | 12:25 |
| zyga | it's essentially a line in open("fname").splitlines() in shell | 12:25 |
| zyga | mborzecki: could you add a test, I think it's going to be useful to let us know the list is stale | 12:26 |
| zyga | apart from that and the nitpick inline +1 | 12:26 |
| * zyga reviews services changes from pawel | 12:47 | |
| mup | PR snapcraft#3170 closed: repo: decouple fetch and unpack stage-packages <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3170> | 12:50 |
| pedronis | clmsy: yes, gadget look different/have different details in UC20 (and some details are still in flux), I recommend ATM looking at the 20 branches of https://github.com/snapcore/pi-gadget and https://github.com/snapcore/pc-amd64-gadget for an idea | 12:55 |
| * zyga lunch break (ha ha, in bed :() | 13:28 | |
| roadmr | zyga!!! hope you get better! I'm too far to help but let me know if I can in any way | 13:35 |
| zyga | thanks Daniel, being here and working keeps me sane | 13:39 |
| roadmr | 👍 | 13:41 |
| roadmr | just don't work too much :) | 13:41 |
| Saviq | ijohnson: confirmed the classic → strict refresh issue https://bugs.launchpad.net/snapd/+bug/1883538 | 13:41 |
| mup | Bug #1883538: Classic to strict refresh requires manual intervention <snapd:New> <https://launchpad.net/bugs/1883538> | 13:41 |
| Saviq | almost looks like staged refresh… | 13:42 |
| Saviq | we only have about 10% of the people tracking stable on the most recent revision (that's out for a week now) | 13:43 |
| Saviq | mvo: FYI ↑ | 13:43 |
| mvo | Saviq: oh, interessting. thank you, will look after my current meeting | 13:45 |
| ijohnson | thanks Saviq | 14:00 |
| ijohnson | we will look in a bit, I too have a meeting now :-) | 14:00 |
| zyga | pstolowski: https://github.com/snapcore/snapd/pull/8812#pullrequestreview-430673354 | 14:02 |
| mup | PR #8812: o/snapstate: service-control task handler (4/N) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8812> | 14:02 |
| pstolowski | zyga: thank you | 14:02 |
| * zyga debugs the core 20 prepare failure | 14:06 | |
| abeato | has anybody tried running UC20 on kvm + TPM (simulated or passthrough) for disk encryption? | 14:12 |
| ijohnson | abeato: yes not passthrough, but simulated | 14:12 |
| abeato | ijohnson, cool - any special issue with that or things just work? | 14:12 |
| ijohnson | abeato: yes it should just work, what issues are you running into? | 14:13 |
| abeato | ijohnson, none, just double checking before I enter a rabbit hole :) | 14:13 |
| ijohnson | abeato: for now, I use the swtpm-mvo snap + socket to provide to qemu | 14:13 |
| abeato | ijohnson, will try that, thanks | 14:13 |
| ijohnson | abeato: this is my qemu cmdline I use with a copy of the OVMF_VARS.ms.fd from the ovmf package: | 14:14 |
| ijohnson | https://www.irccloud.com/pastebin/I4HPR8u9/ | 14:14 |
| mborzecki | zyga: should probbaly land https://github.com/snapcore/snapd/pull/8863 first | 14:53 |
| mup | PR #8863: sandbox/cgroup: allow discovering PIDs of given snap <Created by zyga> <https://github.com/snapcore/snapd/pull/8863> | 14:53 |
| mborzecki | zyga: w8, not this one, this one: #8862 | 14:54 |
| mup | PR #8862: sandbox/cgroup: improve pid parsing code <Created by zyga> <https://github.com/snapcore/snapd/pull/8862> | 14:54 |
| zyga | looking | 14:55 |
| zyga | yeah | 14:55 |
| zyga | with one review? | 14:55 |
| zyga | maybe pawel can do a quick one | 14:55 |
| zyga | it's just moving a few lines around | 14:55 |
| zyga | mborzecki: thanks for this! | 14:55 |
| mborzecki | zyga: or ijohnson/cmatsuoka maybe? | 14:56 |
| zyga | yeah | 14:56 |
| zyga | anyone who's around | 14:56 |
| zyga | sorry, I'm kind of out of touch | 14:56 |
| zyga | ah I see ijohnson is around | 14:56 |
| ijohnson | whats up | 14:56 |
| cmatsuoka | which PR? | 14:56 |
| zyga | https://github.com/snapcore/snapd/pull/8862 | 14:56 |
| mup | PR #8862: sandbox/cgroup: improve pid parsing code <Created by zyga> <https://github.com/snapcore/snapd/pull/8862> | 14:56 |
| zyga | 2nd review, just moving code around _and_ simplifying the main function since it had a common implementation with a private function already present | 14:57 |
| zyga | it's good to chat to you guys btw | 14:57 |
| zyga | I'm sorry for not joining the standups now | 14:57 |
| zyga | I really want to get over this part of my life | 14:57 |
| mborzecki | ijohnson: zyga: if https://github.com/snapcore/snapd/pull/8864 is green, i'll merge it and add a test in a follow up | 14:57 |
| mup | PR #8864: cmd/snap: do not show $PATH warning when executing under sudo on a known distro <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8864> | 14:57 |
| ijohnson | k, sounds good to me | 14:58 |
| zyga | mborzecki: that's okay | 14:58 |
| zyga | mborzecki: the test is mainly to see it break over time | 14:58 |
| zyga | :) | 14:58 |
| zyga | kind of distro-sensors | 14:58 |
| pedronis | is spread on core 20 working now? | 15:00 |
| ijohnson | pedronis: it seems that preparing it intermittently fails because there are snaps in the classic 20.04 image we use to prepare it | 15:00 |
| zyga | yeah | 15:00 |
| ijohnson | I saw some reds preparing on Friday, some greens preapring on Friday | 15:00 |
| zyga | I'm running a loop to get a shell and look around | 15:00 |
| pedronis | is this the issue that we seem not to get the same image all the time? | 15:01 |
| ijohnson | I think it's really the problem that mvo described is that we don't get the same image all the time | 15:01 |
| ijohnson | pedronis: yes | 15:01 |
| ijohnson | at least afaict | 15:01 |
| pedronis | :/ | 15:01 |
| ijohnson | maybe it's something else too | 15:01 |
| zyga | woah | 15:02 |
| zyga | interesting | 15:02 |
| zyga | do we have hard proof that this happens? | 15:03 |
| zyga | (!same image) | 15:03 |
| ijohnson | zyga: the hard proof is that we sometimes get an image with snaps installed in it, and sometimes we get an image without snaps installed in it | 15:03 |
| zyga | hmm | 15:04 |
| zyga | maybe we always get an image with a seed inside | 15:04 |
| ijohnson | iirc mvo added a check to make preparing fail if it detects snaps installed in the image | 15:04 |
| zyga | and we sometimes manage to seed | 15:04 |
| zyga | and sometimes dont | 15:04 |
| ijohnson | zyga: you approved the PR :-) | 15:05 |
| ijohnson | https://github.com/snapcore/snapd/pull/8849 | 15:05 |
| mup | PR #8849: tests: fail in setup_reflash_magic() if there is snapd state left <Test Robustness> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8849> | 15:05 |
| zyga | yeah but I didn't know it turned something up | 15:05 |
| cmatsuoka | zyga: so from what I see 8862 is just reorganization, without any feature changes? | 15:07 |
| zyga | cmatsuoka: yes | 15:07 |
| zyga | cmatsuoka: one tiny code change, if you look at the public function | 15:07 |
| zyga | but it's 100% identical after, just calls a helper that happens to do the common tail | 15:07 |
| cmatsuoka | zyga: yes, I noticed that, and it looks better this way | 15:08 |
| zyga | yeah, it's easy to follow top to bottom | 15:08 |
| zyga | thanks guys! | 15:10 |
| cmatsuoka | zyga: how are you feeling? getting better? | 15:12 |
| zyga | cmatsuoka: not actually | 15:12 |
| zyga | cmatsuoka: more news on Wednesday after doc visit | 15:12 |
| cmatsuoka | zyga: I hope you get well soon | 15:16 |
| zyga | thanks, I really want to | 15:16 |
| mup | PR snapd#8865 opened: workflow <missing-colon> test PR title as part of the static checks again <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8865> | 15:50 |
| zyga | https://github.com/snapcore/snapd/pull/8863 is now ready for review | 16:10 |
| mup | PR #8863: sandbox/cgroup: allow discovering PIDs of given snap <Created by zyga> <https://github.com/snapcore/snapd/pull/8863> | 16:10 |
| zyga | broken out of the refresh-app-awareness-v2 branch | 16:10 |
| mup | PR snapd#8862 closed: sandbox/cgroup: improve pid parsing code <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/8862> | 16:10 |
| ijohnson | hey folks, could I get reviews on https://github.com/snapcore/snapd/pull/8519, it is green now after I debugged it more and fixed the test | 16:59 |
| mup | PR #8519: tests/special-home-can-run-classic-snaps: re-enable <Test Robustness> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8519> | 16:59 |
| === ijohnson is now known as ijohnson|lunch | ||
| === ijohnson|lunch is now known as ijohnson | ||
| mup | PR snapd#8844 closed: asserts/internal: add some iteration benchmarks <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8844> | 18:31 |
| mup | PR snapd#8864 closed: cmd/snap: do not show $PATH warning when executing under sudo on a known distro <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8864> | 19:01 |
| mup | PR snapd#8866 opened: tests/main: add spread test for running svc from install hook <Services ⚙️> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8866> | 19:06 |
| mup | PR snapd#8867 opened: interfaces: add uinput interface <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8867> | 19:41 |
| mup | PR snapd#8868 opened: interfaces: add system-source-code for access to /usr/src <Needs Samuele review> <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8868> | 20:06 |
| mup | PR snapd#8869 opened: asserts/internal: expand errors about invalid serialized grouping labels <Bulk assert refresh :scroll::scroll::scroll:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8869> | 20:46 |
| mup | PR snapd#8317 closed: many: make sure ephemeral failover snapd does not open sockets <Created by pedronis> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8317> | 20:51 |
| mup | PR snapd#8870 opened: interfaces: add gconf interface <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8870> | 21:27 |
| mup | PR snapd#8871 opened: tests/prepare-restore.sh: reset-failed systemd-journald before restarting <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8871> | 21:32 |
| mup | PR snapd#8872 opened: tests/lib/prepare-restore.sh: if we failed to purge snapd deb, ls /var/lib/snapd <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8872> | 21:42 |
| mup | PR snapd#8873 opened: interfaces: misc small interface updates <Created by jdstrand> <https://github.com/snapcore/snapd/pull/8873> | 22:02 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!