| mborzecki | morning | 05:21 |
|---|---|---|
| mvo | hey mborzecki | 05:31 |
| mborzecki | mvo: hey | 05:32 |
| mborzecki | 56 prs, nice | 05:35 |
| mvo | sweet | 05:36 |
| mvo | and 3 easy wins once samuele had a chance to look at the interface prs from jamie | 05:37 |
| mup | PR snapd#8882 opened: tests: use the "jq" snap from the edge channel <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8882> | 06:05 |
| pedronis | mborzecki: hi, #8340 needs a 2nd review, and if possible also to look at #8813 again | 06:23 |
| mup | PR #8340: boot, snap-bootstrap: move initramfs-mounts logic to boot pkg <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8340> | 06:23 |
| mup | PR #8813: gadget,cmd/snap-bootstrap: move partitioning to gadget <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8813> | 06:23 |
| mborzecki | pedronis: hi, yes, i'll be looking at those in the morning | 06:28 |
| pedronis | thank you | 06:28 |
| pstolowski | morning | 07:03 |
| mup | PR snapd#8882 closed: tests: use the "jq" snap from the edge channel <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8882> | 07:40 |
| abeato | hey, I'm having some problems when connecting an interface: | 07:45 |
| abeato | $ snap connect mysnap:network-control | 07:45 |
| abeato | error: cannot perform the following tasks: | 07:45 |
| abeato | - Conectar mysnap:network-control a snapd:network-control (cannot update mount namespace of snap "mysnap": cannot update preserved namespace of snap "mysnap": cannot update snap namespace: device or resource busy) | 07:45 |
| abeato | any idea on what might be going wrong? | 07:45 |
| mup | PR snapd#8724 closed: interfaces/block_devices: add NVMe subsystem devices, support multipath paths <Needs security review> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8724> | 07:45 |
| mborzecki | pedronis: heh, that isTrySnapErr does not work indeed, perhaps that's why the tests were not hitting that code path | 07:49 |
| pedronis | I don't think we use new* either from the tests | 07:50 |
| mborzecki | pedronis: i've added a test case for that, and it wasn't handled in the right if branch | 07:50 |
| mborzecki | pedronis: anyways i'll push a patch there | 07:51 |
| pedronis | thx | 07:51 |
| mborzecki | pedronis: pushed now | 08:06 |
| mborzecki | btw. we used to have something added to the snapd repo that showed test coverage of go code | 08:06 |
| mborzecki | was that codecov? | 08:11 |
| mborzecki | mvo: pedronis: do you think we could try enabling https://github.com/marketplace/codecov/plan/MDIyOk1hcmtldHBsYWNlTGlzdGluZ1BsYW4xNg== on snapd repo? | 08:12 |
| mborzecki | there's also https://github.com/marketplace/coveralls | 08:13 |
| mvo | mborzecki: we had coveralls a while ago, I would love to have coverage reports again | 08:14 |
| mvo | mborzecki: it was a bit cumbersome to setup in the past | 08:14 |
| mborzecki | it'd be nice to build & test the C bits too, even if the coverage is orders lower than the go code | 08:16 |
| pedronis | mvo: I re-reviewed #8858, some things to tweak | 08:22 |
| mup | PR #8858: asserts,daemon: add support for "serials" field in system-user assertion <Needs Samuele review> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8858> | 08:22 |
| mup | PR snapd#8802 closed: spread.yaml: update secure boot attribute name <Simple 😃> <⛔ Blocked> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8802> | 08:25 |
| * Chipaca peers in | 08:26 | |
| mup | PR snapd#8883 opened: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 08:45 |
| Saviq | mvo: bump on https://bugs.launchpad.net/snapd/+bug/1883538 :) | 09:09 |
| mup | Bug #1883538: Classic to strict refresh requires manual intervention <snapd:New> <https://launchpad.net/bugs/1883538> | 09:09 |
| mvo | Saviq: meh! sorry, put it on my list again | 09:11 |
| mborzecki | pedronis: #8813 probably needs a pass from you regarding the naming of things | 09:36 |
| mup | PR #8813: gadget,cmd/snap-bootstrap: move partitioning to gadget <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8813> | 09:36 |
| mborzecki | otherwise, it looks quite ok to me | 09:37 |
| pedronis | mborzecki: anything in particular, the new structures? | 09:39 |
| mup | PR snapcraft#3174 opened: link_or_copy: do not try to create hardlinks to symlinks <Created by hpoul> <https://github.com/snapcore/snapcraft/pull/3174> | 09:40 |
| mborzecki | pedronis: yes, the new structures, OnDisk* | 09:40 |
| pedronis | mborzecki: I'm not completely a fan of those tbh | 09:45 |
| mborzecki | mvo: https://github.com/snapcore/snapd/pull/8883#discussion_r441422472 | 09:47 |
| mup | PR #8883: packaging: stop snapd early on purge <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8883> | 09:47 |
| mvo | mborzecki: right, I can go a different route, i.e. stop just snapd right before we remove the snapd dirs | 09:49 |
| mvo | mborzecki: but I think this is the reason we see the 20.04 failures, we remove the dirs while snapd is running so it will just re-addd stuff there | 09:50 |
| mvo | mborzecki: but yeah, I guess it's safer to keep it running until late | 09:50 |
| * mvo changes the PR | 09:50 | |
| mborzecki | mvo: yeah, a middle ground is probaly the safest bet | 09:51 |
| mborzecki | mvo: otoh, once we start stopping the mount units and removing directories snapd could get confused, but it's a part of purge anyway | 09:52 |
| mvo | mborzecki: should I also snapd in snap-mgr or is that not needed there because snpad will not run at this point when snap-mgr purge is used? | 10:02 |
| mborzecki | mvo: hmm, snap-mgmt is run after snapd is stopped, so if that does not leave anything behind, maybe we could go with your initial version? | 10:04 |
| mborzecki | mvo: the fedora and arch packaging stops snapd (and sockets) before the purge | 10:05 |
| mvo | mborzecki: cool, I updated the PR now | 10:06 |
| pedronis | mborzecki: basically I'm a bit unhappy that we need to have Structure LaidOutStructure and OnDiskStructure | 10:06 |
| pedronis | I know why they each exist but is a bit much | 10:07 |
| mborzecki | pedronis: perhaps we can address that once we're done with snap-bootstrap -> gadget/install move | 10:10 |
| mborzecki | then the change should be fairly mechanical | 10:10 |
| mup | PR snapd#8884 opened: cmd/snap: Debian does not allow $SNAP_MOUNT_DIR/bin in sudo secure_path <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8884> | 10:11 |
| ijohnson | morning folks | 10:13 |
| pstolowski | hi ijohnson ! | 10:13 |
| ijohnson | hey pstolowski | 10:13 |
| ijohnson | thanks mborzecki for the patches to those PR's | 10:13 |
| * ijohnson looks at his only 3 open PR's :-D | 10:14 | |
| pedronis | mborzecki: if I see it correctly #8813 is mostly mechanical right? | 10:15 |
| mup | PR #8813: gadget,cmd/snap-bootstrap: move partitioning to gadget <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8813> | 10:15 |
| pedronis | mborzecki: I mean I'm lookin at it, there is not subtle changes in it? | 10:15 |
| mborzecki | pedronis: there are some tweaks in the few recent commits | 10:16 |
| mborzecki | pedronis: i mean, we could very well do a single pr with renames (provided it's renames only) | 10:17 |
| pedronis | in which sense? | 10:17 |
| pedronis | my plan is not renames only | 10:17 |
| pedronis | mborzecki: my question was really more is this simple enough that we should just try to get it in quickly, or does it need careful looking over anyway? | 10:18 |
| pedronis | my plan to avoid some many struct involve more than renames | 10:19 |
| mborzecki | pedronis: maybe let's have a chat with cmatsuoka then? | 10:19 |
| pedronis | anyway reducing the structs is not a priority | 10:20 |
| pedronis | but you asked me if I had opinions about names | 10:20 |
| pedronis | and it's complicated :) | 10:20 |
| mborzecki | haha | 10:22 |
| mvo | Saviq: can you please "snapcraft release multipass 2114 edge/snap-test-classic" for me? this way I can actually try to test your exact scenario | 10:25 |
| Saviq | mvo: done, and invited you as collaborator | 10:32 |
| mvo | Saviq: thank you I think I can reproduce, let me dig into this | 10:44 |
| mvo | 8858 needs a second review, should be simple | 10:44 |
| mvo | well, not that simple but I should not say this or it won't get reviewed :P | 10:44 |
| mup | PR snapd#8885 opened: data/sudo: drop a failed sudo secure_path workaround <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8885> | 10:46 |
| popey | ogra your mjpg streamer snap, how do you control the webcam resolution? mine is only grabbing at 640x480 | 11:05 |
| popey | ah, there's an option for the .so | 11:06 |
| ogra | its in the config file | 11:07 |
| ogra | i have a half done branch that uses snapctl but that has been sitting for a while (it has many users, switching over the config without breaking them is a little work) | 11:08 |
| popey | found https://community.octoprint.org/t/available-mjpg-streamer-configuration-options/1106 | 11:09 |
| pedronis | mborzecki: I think zyga asked you to review #8829 ? | 11:09 |
| mup | PR #8829: sandbox/cgroup: add tracking helpers <Created by zyga> <https://github.com/snapcore/snapd/pull/8829> | 11:09 |
| ogra | popey, mjpg-streamer --help ... and mjpg-streamer -i "input_uvc.so --help" | 11:12 |
| ogra | it comes with documentation builtin too 😉 | 11:12 |
| ogra | (not all controls work with all webcams though ... watch journalctl output) | 11:12 |
| ijohnson | pedronis: so can I merge #8340 ? | 11:19 |
| mup | PR #8340: boot, snap-bootstrap: move initramfs-mounts logic to boot pkg <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8340> | 11:19 |
| ijohnson | it's green now | 11:19 |
| pedronis | ijohnson: yes, any concerns? | 11:21 |
| ijohnson | nope, just wanted to be extra suer | 11:21 |
| ijohnson | *sure | 11:21 |
| * ijohnson clicks the button | 11:21 | |
| mborzecki | and boom | 11:23 |
| mup | PR snapd#8340 closed: boot, snap-bootstrap: move initramfs-mounts logic to boot pkg <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8340> | 11:26 |
| mvo | Saviq: found the issue, WIP in https://github.com/snapcore/snapd/compare/master...mvo5:classic-to-strict-is-fine?expand=1 but need to write a proper test after lunch | 11:28 |
| mvo | Saviq: but with your testcase it seems to work | 11:28 |
| pedronis | pstolowski: is #8812 ready for re-review? | 11:28 |
| mup | PR #8812: o/snapstate: service-control task handler (4/N) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8812> | 11:28 |
| pstolowski | pedronis: yes, thank you | 11:30 |
| pedronis | pstolowski: ok, thx, putting it back in the queue | 11:32 |
| === msalvatore_ is now known as msalvatore | ||
| ijohnson | pedronis: remind me, can *util packages import other *util packages ? | 12:11 |
| ijohnson | i.e. can I import strutil from osutil/disks ? | 12:11 |
| pedronis | ijohnson: usually yes | 12:12 |
| pedronis | I mean we should be reasonable and avoid circular deps, but there is no sense to a general rule | 12:12 |
| pedronis | that they can't | 12:12 |
| pedronis | pstolowski: I finally got to #8395, I didn't something is missing but maybe I'm confused (could be) | 12:13 |
| mup | PR #8395: o/ifacestate: handle interface hooks when preseeding <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8395> | 12:13 |
| ijohnson | pedronis: ack sounds good | 12:13 |
| ijohnson | thanks for the clarification | 12:13 |
| pedronis | pstolowski: s/I didn't/I think/ | 12:13 |
| pstolowski | pedronis: thanks, will need to refresh my memory, it's been a while | 12:13 |
| pedronis | pstolowski: it's not urgent for you to go back to it, don't context switch for me, but I wanted to reduce my own queue a bit more | 12:16 |
| mup | PR snapd#8886 opened: gadget: mv encodeLabel to strutil.EncodeHexBlkIDFormat <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8886> | 12:16 |
| pedronis | ijohnson: ^ why strutil and not osutil itself though? | 12:18 |
| pedronis | or even osutil/disks | 12:18 |
| ijohnson | pedronis: it seems like a string function ? | 12:18 |
| ijohnson | pedronis: I mean sure it can live in osutil/disks if you want that's fine | 12:18 |
| pedronis | ijohnson: it's a very very specific string function | 12:19 |
| ijohnson | true... | 12:19 |
| pstolowski | pedronis: ok, thanks, i've read your comment, i'll definitely need to think deeper, so will get back to it later | 12:20 |
| ijohnson | pedronis: mmm ok I'll move it to osutil/disks, but it will make more messy git history in my existing PR | 12:20 |
| pedronis | ijohnson: heh | 12:20 |
| pedronis | ijohnson: that is not a good reason in particular | 12:21 |
| pedronis | ijohnson: anyway except for Version stuff most of strutil is quite quite generic | 12:21 |
| pedronis | is not a meant to be a repository of any sort of side-effect free things that produce strings | 12:22 |
| pedronis | PathIterator is also a bit borderline there | 12:22 |
| ijohnson | apparently you can't change branch names in a PR on github which also is maybe a bit expected | 12:27 |
| pedronis | names are hard (in more than one sense) | 12:28 |
| ijohnson | alright re-opened as 8888 | 12:29 |
| pedronis | mborzecki: does #8887 supersede #8775 ? | 12:30 |
| mup | PR #8887: bootloader: pull recovery grub config from internal assets <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8887> | 12:30 |
| mup | PR #8775: [RFC] bootloader, boot: boot scripts, edition <Needs Samuele review> <UC20> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8775> | 12:30 |
| mup | PR snapd#7570 closed: [RFC] snap-mount-dir: add mount unit for snap-mount-dir <⛔ Blocked> <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/7570> | 12:31 |
| mup | PR snapd#8886 closed: gadget: mv encodeLabel to strutil.EncodeHexBlkIDFormat <Simple 😃> <UC20> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/8886> | 12:31 |
| mup | PR snapd#8887 opened: bootloader: pull recovery grub config from internal assets <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8887> | 12:31 |
| mup | PR snapd#8888 opened: gadget: mv encodeLabel to osutil/disks.EncodeHexBlkIDFormat <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8888> | 12:31 |
| mborzecki | pedronis: i think i'll close 8875 and will be open smaller bits as we go (always one less PR to remember) | 12:32 |
| pedronis | mborzecki: sounds good | 12:32 |
| mup | PR snapd#8775 closed: [RFC] bootloader, boot: boot scripts, edition <Needs Samuele review> <UC20> <⛔ Blocked> <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/8775> | 12:36 |
| === alan_g is now known as alan_g_ | ||
| cjp256 | anyone have a suggestion for what to do when kswap0 and snapd (and in this instance canonical-livepatch) lock up CPU? i've been using the default 1GB swap and have run into this a fair bit again recently. it locks up hard enough the only recourse is usually to hard power-off unless you wait long enough for OOM killer to do something, if it even does (laptop was unusable for at least 10-15 minutes in my case). | 13:26 |
| mvo | cjp256: do you have the output of "journalctl -u snapd" when this happens? and snap changes ideally? would love to know how to reproduce | 13:27 |
| * mvo is actually in a meeting | 13:28 | |
| cjp256 | mvo: the journal https://pastebin.ubuntu.com/p/NqtJryXrwc/ shows a trace. last `change` was a few hours beforehand, not canonical-livepatch fwiw | 13:35 |
| pstolowski | cachio: have you seen my comment re early core20 config test? | 13:45 |
| cachio | pstolowski, no, I didnt, sorry | 13:46 |
| cachio | just got disconnected | 13:46 |
| pstolowski | cachio: in standup notes | 13:47 |
| mvo | cjp256: thanks, do you have a timestamp for me when the OOM happend? | 13:48 |
| mvo | cjp256: also - how many snaps are installed there? anything special about the machine this run on? | 13:51 |
| cjp256 | mvo: relevant journal log chunk https://pastebin.ubuntu.com/p/ynj57trvfg/ | 13:55 |
| mvo | cjp256: cool, thanks | 13:55 |
| cjp256 | interesting that the logs seem to be out of order :D | 13:55 |
| cachio | pstolowski, ok, I'll take a look again | 13:59 |
| cachio | ijohnson, if you make a try with uc20-recovery test please tell me | 14:25 |
| ijohnson | cachio: yes sorry got distracted with doing reviews, but will try that real soon | 14:26 |
| pedronis | ijohnson: nitpick on #8888, feel free to apply it on a follow up or something | 14:26 |
| mup | PR #8888: gadget: mv encodeLabel to osutil/disks.EncodeHexBlkIDFormat <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8888> | 14:26 |
| ijohnson | pedronis: ack I think I'll take it in a followup | 14:27 |
| pstolowski | pedronis: small nitpicks under #8852 | 14:31 |
| mup | PR #8852: asserts: introduce new assertion validation-set <validation-sets :white_check_mark:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8852> | 14:31 |
| ijohnson | pstolowski: reviewed 8812 for you | 14:33 |
| pedronis | pstolowski: thank you | 14:34 |
| pstolowski | ijohnson: thanks! | 14:34 |
| pstolowski | ijohnson: updated | 14:55 |
| cachio | pstolowski, I run twice and both times saw the same error https://paste.ubuntu.com/p/5wfwC7kNbc/ | 14:56 |
| ijohnson | pstolowski: re-approved | 15:00 |
| pstolowski | ijohnson: thank you! | 15:01 |
| mup | PR snapd#8888 closed: gadget: mv encodeLabel to osutil/disks.EncodeHexBlkIDFormat <Simple 😃> <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/8888> | 15:02 |
| pstolowski | cachio: i'll take a look. wasn't something like this happening when things were changing in core20 and it wouldn't boot? i saw similiar problems before when i worked on this and it would automagically work again another day after things landed | 15:04 |
| cachio | pstolowski, ahh, because it is the only test on which it fails to sdo shpass | 15:05 |
| pstolowski | cachio: yes, it fails in prepare already, cannot ssh into the nested system | 15:07 |
| mup | PR snapd#8858 closed: asserts,daemon: add support for "serials" field in system-user assertion <Needs Samuele review> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8858> | 15:07 |
| mup | PR snapd#8885 closed: data/sudo: drop a failed sudo secure_path workaround <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8885> | 15:07 |
| cachio | in my case it could ssh | 15:07 |
| cachio | but fails trygin to create the test user | 15:07 |
| cachio | it is weird bacause all the other uc20 tests are passing | 15:08 |
| pstolowski | cachio: ah, wait, i think i misread the log (too many ssh attempts), indeed it seems it's test user password issue | 15:10 |
| pstolowski | why would it start failing, did we change something? | 15:10 |
| pstolowski | cachio: did it start failing last night? | 15:11 |
| cachio | pstolowski, let me check | 15:11 |
| cachio | pstolowski, 2020-06-15 passed | 15:13 |
| cachio | 2020-06-16 failed | 15:13 |
| cachio | with the same error | 15:14 |
| cachio | so, yesterday was the first fail | 15:14 |
| pstolowski | cachio: ok, thanks, i'll try to find out what/if something changed | 15:17 |
| cachio | pstolowski, nice, thanks | 15:22 |
| mvo | fwiw I pushed a new "test-snapd-classic-confined" to candidate, please let me know if that causes any issues, I will revert in this case (but should be fine) | 15:26 |
| ijohnson | cachio: mmm I see a potential issue with uc20 and self signed models, need to investigate more but it would explain your issue | 15:30 |
| ijohnson | cachio: can you show your model assertion you used to build the external image ? | 15:30 |
| * ijohnson needs to step out for few minutes | 15:30 | |
| cachio | ijohnson, https://github.com/sergiocazzolato/validator/blob/master/images/models/pc-amd64-20.model | 15:31 |
| cachio | this is for amd64 | 15:31 |
| pedronis | I'm not sure what Ian meant | 15:32 |
| cachio | ijohnson, it is hte same we use for nested tests on snapd projecy | 15:33 |
| cachio | project | 15:33 |
| cachio | ijohnson, what I see is that after reboot /home/gopath does not exist anymore | 15:39 |
| ijohnson | cachio I thought the issue was that you couldn't login to the device via ssh? | 15:46 |
| cachio | ijohnson, I can login | 15:47 |
| mup | PR snapd#8889 opened: snapstate: fix autorefresh from classic->strict <Bug> <Created by mvo5> <https://github.com/snapcore/snapd/pull/8889> | 15:47 |
| cachio | ijohnson, is that the spread path is not there anymore after the reboot | 15:48 |
| cachio | ijohnson, then I see this https://paste.ubuntu.com/p/VNbk5hjCXf/ | 15:49 |
| pedronis | as we said in the standup, I think the issue is that the system comes up | 15:49 |
| pedronis | in recovery mode | 15:49 |
| pedronis | not run mode | 15:49 |
| pedronis | after the test | 15:49 |
| pedronis | cachio: can you see what's in /var/lib/snapd/modeenv in the system without the path? | 15:50 |
| cachio | pedronis, mode=recover | 15:51 |
| pedronis | yea, so what I said | 15:51 |
| cachio | so, why it fails here and is not failing on each PR? | 15:52 |
| pedronis | something is different | 15:52 |
| pedronis | but I don't know the test well | 15:52 |
| cachio | here I am testing with secboot and tpm enabled | 15:52 |
| pedronis | just making sure we understand the problem the same way | 15:52 |
| ijohnson | Ah sorry well the issue I'm seeing is a different one then | 15:52 |
| cachio | pedronis, ok, thnaks, I'll compare the systems with the one running on gce after lunch | 15:55 |
| * cachio lunch | 15:57 | |
| ijohnson | ah sorry I actually need to step out now for longer | 15:59 |
| === ijohnson is now known as ijohnson|afk | ||
| pstolowski | cachio: i just run that test two times and it passed on second run. something is wonky | 16:03 |
| pedronis | cmatsuoka: I did a pass on #8813 | 16:12 |
| mup | PR #8813: gadget,cmd/snap-bootstrap: move partitioning to gadget <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8813> | 16:12 |
| pedronis | cmatsuoka: I marked it changes requested mostly because of the not glued up tests | 16:26 |
| cmatsuoka | pedronis: thanks, looking | 16:53 |
| mup | PR snapcraft#3172 closed: cli: restore --target-arch with warning for LXD and Multipass <bug> <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3172> | 17:01 |
| mup | PR snapcraft#3175 opened: cli: restore --target-arch with warning for LXD and Multipass <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3175> | 17:01 |
| mup | PR snapcraft#3176 opened: tools: fix environment-setup to work on aarch64 <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3176> | 17:11 |
| mup | PR snapd#8852 closed: asserts: introduce new assertion validation-set <Skip spread> <validation-sets :white_check_mark:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8852> | 17:18 |
| cmatsuoka | pedronis: added missing glue and todo notes, left some of the changes to follow-ups | 17:20 |
| pedronis | cmatsuoka: thanks, probably deploy.go => install.go and other things still called deploy should be called install, like deployMountpoint | 17:35 |
| cmatsuoka | pedronis: yes, adjusting that | 17:36 |
| pedronis | some test names as well | 17:37 |
| cmatsuoka | pedronis: the mountpoint itself looks a bit strange, do you have a suggestion for a better name? | 17:37 |
| cmatsuoka | hmm, renaming to install.go now could be a problem because there's a file with the same name in the next PR | 17:39 |
| pedronis | cmatsuoka: then call it content.go I suppose | 17:39 |
| cmatsuoka | pedronis: content.go is good, thanks | 17:39 |
| pedronis | cmatsuoka: about the mountpoint, maybe /run/snapd/gadget-install | 17:45 |
| pedronis | /run/snapd is dirs.SnapRunDir | 17:45 |
| cmatsuoka | yes, good, I'll use it, thanks | 17:45 |
| * cachio at kinesiologist | 17:48 | |
| pedronis | cmatsuoka: if you do something like what with do for FreezerCgroupDir in sandbox/cgroup/freezer.go, maybe you don't need the Mock but dirs.SetRootDir is enough, you'll have to see | 17:48 |
| pedronis | ah, it's only local anyway | 17:49 |
| pedronis | so doesn't matter | 17:49 |
| cmatsuoka | pedronis: so can I just declare an uninitialized var and initialize it on init() to use dirs.SnapRunDir? | 17:51 |
| pedronis | yes, and if you setup a callback you can also have if follow to root in dirs.go | 17:51 |
| cmatsuoka | interesting solution | 17:52 |
| pedronis | as I said, you might not need it here | 17:53 |
| pedronis | I thought you were exporting the Mock but is only in export_test.go | 17:53 |
| cmatsuoka | yes. well, I'll use a simple initialization and then if need arises we can use the callback | 17:54 |
| pedronis | cmatsuoka: you lost deploy_test.go somehow instead of it getting commited as content_test.go now | 17:56 |
| pedronis | https://github.com/snapcore/snapd/pull/8813/commits/6245b309270ee00b818ccfea45a84522c3f11499 | 17:56 |
| mup | PR #8813: gadget,cmd/snap-bootstrap: move partitioning to gadget <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8813> | 17:56 |
| cmatsuoka | that's... strange, let me see here what's happening and I'll push a fix along with the content mountpoint change | 17:57 |
| mup | PR snapd#8884 closed: cmd/snap: Debian does not allow $SNAP_MOUNT_DIR/bin in sudo secure_path <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8884> | 17:58 |
| cmatsuoka | pedronis: pushed. I think the missing test was caused by mistakingly using mv instead of git mv | 18:03 |
| pedronis | cmatsuoka: reviewed | 18:11 |
| cmatsuoka | pedronis: thank you! | 18:11 |
| pedronis | cmatsuoka: a TestWriteFilesystemContent like the TestWriteRawContent would be good | 18:12 |
| pedronis | if possible | 18:12 |
| cmatsuoka | pedronis: ok, will do | 18:12 |
| pedronis | thx | 18:12 |
| mup | PR core18#156 opened: Add motd and issue to writable /etc files <Created by WillNilges> <https://github.com/snapcore/core18/pull/156> | 18:36 |
| mup | PR snapcraft#3177 opened: repo: consider virtual pkgs for cache invalidation <bug> <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3177> | 18:36 |
| === ijohnson|afk is now known as ijohnson | ||
| cachio | ijohnson, cmatsuoka hey | 19:50 |
| ijohnson | hey cachio | 19:50 |
| cachio | https://paste.ubuntu.com/p/NKNc4SQB8q/ | 19:50 |
| cachio | I see this | 19:50 |
| ijohnson | cachio: this is on uc20 yah ? | 19:50 |
| cachio | in the uc20-recovery test | 19:50 |
| cmatsuoka | cachio: let's see... | 19:50 |
| ijohnson | cachio: snap-repair is known to be broken on uc20 | 19:50 |
| ijohnson | it needs to be fixed but is somewhat non-trivial to fix | 19:51 |
| cmatsuoka | well I don't know what snap-repair is | 19:51 |
| MrSassyPants | Whats the current version of this command: snap set system.service.rsyslog disable=true | 20:04 |
| MrSassyPants | snap + discord is ddosing kernel log | 20:04 |
| ijohnson | MrSassyPants: do you mean how to silence denials AppArmor denials in the system journal ? | 20:17 |
| MrSassyPants | snap connect discord:system-observe :system-observe ; snap connect discord:unity7 :unity7 | 20:17 |
| MrSassyPants | did it | 20:17 |
| ijohnson | cool | 20:17 |
| MrSassyPants | I googled more | 20:17 |
| ijohnson | there's also some AppArmor config to turn denied messages off entirely | 20:18 |
| MrSassyPants | idk about such things | 20:18 |
| MrSassyPants | I tried the first cli thing that google spat out | 20:18 |
| MrSassyPants | the system.service.rsyslog thing | 20:18 |
| MrSassyPants | and then proceeded to ask | 20:18 |
| === bloodearnest_ is now known as bloodearnest | ||
| ijohnson | MrSassyPants: that command is only applicable to Ubuntu core, not classic Ubuntu systems like desktop or server | 20:23 |
| mup | PR snapd#8890 opened: seed: fix LoadEssentialMeta when gadget is not loaded <Created by pedronis> <https://github.com/snapcore/snapd/pull/8890> | 20:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!