| mup | PR snapcraft#3175 closed: cli: restore --target-arch with warning for LXD and Multipass <bug> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3175> | 00:22 |
|---|---|---|
| mup | PR snapcraft#3178 opened: extensions: add gcc to GNOME 3.28 extension part <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3178> | 02:32 |
| guiverc | chromium snap: a post on askubu (https://askubuntu.com/questions/1184357/why-cant-chromium-suddenly-access-any-partition-except-for-home/1251289#1251289) claims they can bypass what I suspect is intended security; should it be reported, if so where? snapcraft.io (it maybe nothing; a quick look and I didn't re-create but didn't really try) | 03:47 |
| * guiverc adds it's the new added answer by Dan Dasc. | 03:48 | |
| jamesh | guiverc: it's true that running random binaries from within a snap rather than the public entry points will not be sandboxed. There's no guarantee that such an invocation will work though. | 04:07 |
| guiverc | so not an issue, or known issue... I'll ignore. thanks jamesh | 04:08 |
| mborzecki | morning | 05:27 |
| mborzecki | hm weird failure in google:ubuntu-core-20-64:tests/core/snap-auto-mount | 05:53 |
| mborzecki | and debug section is buggy in that test too | 05:53 |
| mborzecki | mvo: hey | 06:23 |
| mvo | hey mborzecki | 06:23 |
| mup | PR snapd#8890 closed: seed: fix LoadEssentialMeta when gadget is not loaded <Bug> <UC20> <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8890> | 06:41 |
| pstolowski | morning | 06:59 |
| mvo | good morning pstolowski | 07:03 |
| mup | PR snapd#8813 closed: gadget,cmd/snap-bootstrap: move partitioning to gadget <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8813> | 07:06 |
| zyga | Good morning | 07:14 |
| zyga | I’m back home | 07:14 |
| zyga | Tired but okay | 07:14 |
| zyga | I just dropped in to say hi | 07:14 |
| zyga | And tell you all I will take today and tomorrow off to rest | 07:15 |
| zyga | Surgery cannot be done yet, and I need to wait for a few weeks on new | 07:15 |
| zyga | Meds that decrease the problem | 07:15 |
| zyga | I will resume work next week | 07:15 |
| zyga | And will work mostly normally for the next two to four weeks | 07:16 |
| zyga | I may have the surgery after that, when my condition improves | 07:17 |
| zyga | So that is that | 07:17 |
| zyga | I’m really tired today, had a very painful and long day and night | 07:17 |
| zyga | mvo: I will file yesterday today and tomorrow into the system | 07:18 |
| mvo | zyga: thank you, get well | 07:19 |
| zyga | Thank you, good luck with apparmor and secure boot and everything :) | 07:20 |
| mvo | zyga: yeah, slowely working my way forward there, almost no progress yesterday because of other things but I'm somewhat hopeful for today :) | 07:24 |
| mvo | mborzecki, pedronis any concerns to merge 8675? it has two +1 now | 07:25 |
| pedronis | mvo: I think mborzecki should look at it again | 07:26 |
| mborzecki | pedronis: mvo: finishign with some tweaks to u-i, will that a look at that pr next | 07:27 |
| mvo | mborzecki: ta | 07:29 |
| mwhudson | does something in snapd set LC_ALL to C? | 08:23 |
| mwhudson | hm doesn't look like it | 08:24 |
| mvo | mwhudson: hey, I don't think so - thanks for updating go/edge ! | 08:28 |
| mvo | pstolowski: I added an idea to your comment in https://github.com/snapcore/snapd/pull/8881/files#r441360886 - please let me know what you think, zyga is out so I want to push this forward a bit | 09:32 |
| mup | PR #8881: interfaces: optimize rules of multiple connected iio and spi plugs <Bug> <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8881> | 09:32 |
| pstolowski | looking | 09:32 |
| * zyga needs to disable phone notifications | 09:33 | |
| zyga | mvo: I would not drift away from ###PARAM###, just handle it without panic | 09:33 |
| mvo | zyga: haha - sorry | 09:33 |
| zyga | as it makes use of map nicer | 09:33 |
| zyga | mvo: no worries, I really feel better already | 09:33 |
| mvo | zyga: if you want and feel good have a look at my comment, it still uses ###PARM### internally just make the interface for the caller slightly different | 09:34 |
| zyga | mvo: yeah I like the interface a lot | 09:34 |
| zyga | I misunderstood that it also changes the backend | 09:34 |
| zyga | if that's the same backend that's a brilliant way out | 09:34 |
| zyga | nice work! | 09:34 |
| mvo | zyga: no worries, just comment there if you prefer the []string or "prefix,postfix" either way is fine, you know more about this than me (I slightly prfer []string) | 09:35 |
| zyga | I prefer [] as it may be needed to insert this many times | 09:35 |
| mvo | zyga: +1 | 09:35 |
| mvo | thank you zyga | 09:35 |
| zyga | really sweet way out of this :) | 09:35 |
| zyga | thank You :) | 09:35 |
| mvo | :) my pleasure | 09:35 |
| zyga | if you park it ping me on irc/tg and I will iterate some more and add tests/i2c support | 09:36 |
| zyga | my family is helping me to adjust the bed to a better workspace | 09:36 |
| zyga | with "floating" laptop so that I don't need to strain my neck | 09:36 |
| zyga | and a split keyboard so that my hands don't have to be in the air while typing | 09:37 |
| zyga | I just ordered https://ultimatehackingkeyboard.com/ | 09:37 |
| mvo | zyga: I did some of the cosmetic changes that jamie asked for, 1.5 unit tests and can push the diff and then it's all yours if you want :) , I have code-review and meetings today | 09:37 |
| mvo | zyga: I wonder if a bed breakfast tray would help? | 09:37 |
| zyga | mvo: we tried but I really want something that's more less at 45 angle | 09:38 |
| zyga | above my head | 09:38 |
| * mvo nods | 09:38 | |
| zyga | some wood and duck tape will work as a prototype | 09:38 |
| zyga | I'll send pics when it works :) | 09:39 |
| zyga | mvo: I'm afk again, ping me when you are done with the PR | 09:40 |
| mborzecki | pedronis_: https://github.com/snapcore/snapd/pull/8887#discussion_r442077693 i was wondering whether there should be any fallback, but i gues when you're generating an image with some version of snapd, the asset must exist | 09:44 |
| mup | PR #8887: bootloader: pull recovery grub config from internal assets <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8887> | 09:44 |
| === pedronis_ is now known as pedronis | ||
| pedronis | mvo: so it seems there was an almost fix of 8889 in the codebase | 09:45 |
| pedronis | mvo: there's probably more code to cleanup there | 09:46 |
| mvo | pedronis: yeah, it was 2 steps forward, one step back. I did not dig super deep but my feeling is the same, there is more hidding there | 09:50 |
| mvo | zyga: pushed the tweak to the signature, feel free to tweak further or change as needed, I'm done with the PR for a couple of hours now (meeting, code-review, lunch etc). keep me updated please and fwiw, really nice job there | 09:51 |
| zyga | thanks! | 09:52 |
| pedronis | mvo: I left comments there | 09:55 |
| pedronis | mvo: I think the issue with the original fix is that we didn't write an UpdateMany tests perhaps? | 09:56 |
| pedronis | if don't have many of those, or maybe we did but is not quite right? | 09:56 |
| pedronis | s/if don't/we don't/ | 09:56 |
| pstolowski | mvo: i like your idea, i meant to comment under the PR but it seems this comment is gone | 09:58 |
| mvo | pedronis: thanks, I have a look | 09:59 |
| mvo | pedronis: but yeah, missing test(s) seems very likely | 09:59 |
| mvo | pstolowski: sorry, my fault probably, I resolved it (but it should still be there, just collapsed) | 09:59 |
| mvo | pstolowski: anyway, "like it" is enough :) | 09:59 |
| pstolowski | mvo: ah indeed it's there, i got confused, sorry | 10:01 |
| mborzecki | quick errand, back in a bit | 10:08 |
| zyga | mborzecki: woah | 10:19 |
| zyga | snap just broke a non-snap app fonts | 10:19 |
| zyga | that was *open* | 10:19 |
| zyga | surreal | 10:19 |
| zyga | I opened telegram | 10:19 |
| zyga | and the ebook reader app got messed up | 10:19 |
| mborzecki | re | 10:33 |
| pedronis | mvo: I made a remark in #8881 that that method needs a doc comment | 10:37 |
| mup | PR #8881: interfaces: optimize rules of multiple connected iio and spi plugs <Bug> <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8881> | 10:37 |
| mvo | pedronis: thank you! | 10:40 |
| mvo | pedronis: also thanks for your comment in 8889, I had no idea we look at flags in so many place, +100 for the unit test(s) | 10:40 |
| mvo | s/comment/comments/ | 10:41 |
| clmsy | did anyone experience "no such device: ubuntu-boot" from trying to boot this: https://github.com/snapcore/pc-amd64-gadget (20 branch) | 10:44 |
| mvo | clmsy: I don't remember this but if you used qemu, did you boot it in UEFI mode? | 10:52 |
| === facundo__ is now known as facubatista | ||
| clmsy | I will double check and comeback mvo, thx | 10:58 |
| mvo | ijohnson: I merged 8675 but there is a small suggestion for a followup that is worth checking | 11:15 |
| ijohnson | mvo: sure I will take a look in a bit, trying to wrap up my presentation this morning :-) | 11:16 |
| mup | PR snapd#8675 closed: osutil: add disks pkg for associating mountpoints with disks/partitions <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8675> | 11:17 |
| mvo | ijohnson: no worries | 11:17 |
| mvo | ijohnson: it's not urgent, just wanted to mention it :) | 11:17 |
| mvo | pstolowski: 8812 looks ready, if you get unrelated failures just ping me and I can sudo merge | 11:18 |
| pstolowski | mvo: yes i'm super keen to land it and have been monitoring it; failed on project- on core20 and i restarted the tests | 11:19 |
| mvo | pstolowski: ok | 11:20 |
| mvo | pstolowski: thanks for being on top of this! | 11:20 |
| pstolowski | mvo: let's wait a little bit for current run | 11:20 |
| mvo | sure | 11:20 |
| mvo | in related news: down to 50 PRs again! | 11:20 |
| pstolowski | mvo: failed on centos 8 only, on selinux-clean. cannot be related because this functionality is not yet hooked anywhere | 11:34 |
| pstolowski | mvo: so i'd say go ahead an merge | 11:34 |
| pstolowski | cachio: hi, #8558 still has unaddressed comments, do you plan to add the doc? | 11:46 |
| mup | PR #8558: tests: make the nested library usable independently of spread <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8558> | 11:46 |
| cachio | pstolowski, hi, yes, but still applying some improvements to that one | 11:46 |
| cachio | pstolowski, I'll push today the update | 11:47 |
| pstolowski | cachio: ah, sure | 11:47 |
| cachio | pstolowski, there were many changes in nested recently :) | 11:48 |
| pstolowski | cachio: yes.. btw, is the core20 early config still failing? | 11:48 |
| cachio | pschecking | 11:58 |
| cachio | pstolowski, today I see the nested/core20 suite failed with that error https://paste.ubuntu.com/p/fqVwCSZDGf/ | 12:00 |
| cachio | seems to be a race I think | 12:00 |
| mup | PR snapd#8891 opened: o/servicestate: add updateSnapstateServices helper (5/6) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8891> | 12:27 |
| mborzecki | https://github.com/snapcore/snapd/pull/8455 could use some reviews | 12:27 |
| mup | PR #8455: tests/lib/cla_check: expect explicit commit range <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8455> | 12:27 |
| pedronis | pstolowski: should we merge #8812 ? | 12:30 |
| mup | PR #8812: o/snapstate: service-control task handler (4/N) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8812> | 12:30 |
| pstolowski | pedronis: yes, i pinged mvo earlier but he seems busy. unrelated failure on centos | 12:30 |
| cachio | pstolowski, added the sectino to HACKING file | 12:31 |
| pedronis | pstolowski: you can merge, centos is marked not required | 12:32 |
| cachio | still testing hte lib with different variables | 12:32 |
| pstolowski | cachio: would it be possible to add it as --help ? | 12:32 |
| pedronis | pstolowski: you don't need mvo | 12:32 |
| pstolowski | pedronis: ah, indeed | 12:32 |
| cachio | pstolowski, yes let me add that | 12:33 |
| pstolowski | the grey merge button is confusing | 12:33 |
| pstolowski | done | 12:33 |
| pstolowski | that's great. i pushing the last PR then | 12:33 |
| mup | PR snapd#8812 closed: o/snapstate: service-control task handler (4/N) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/8812> | 12:37 |
| pedronis | pstolowski: yes, the button can be green, grey, or greyed out | 12:42 |
| pedronis | something like that afair | 12:42 |
| mvo | yeah, centos-8 is no longer required because it's a bit unstable right now | 12:44 |
| pedronis | pstolowski: great, not sure I'll get to them immediately though | 12:46 |
| mup | PR snapd#8892 opened: o/snapstate,servicestate: use service-control task for service actions (6/6) <Complex> <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8892> | 12:47 |
| pstolowski | pedronis: np, i'll probably push some tests to #8892 still | 12:48 |
| mup | PR #8892: o/snapstate,servicestate: use service-control task for service actions (6/6) <Complex> <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8892> | 12:48 |
| pedronis | pstolowski: is still fairly large? | 12:48 |
| pstolowski | pedronis: yes, the 5th one will reduce it a bit | 12:49 |
| pstolowski | pedronis: +1,082 −573 | 12:50 |
| pstolowski | pedronis: maybe I can find some small bits to extract into separate PR(s), but it got really hard at this point | 12:51 |
| pedronis | pstolowski: we'll need to see it might get hard to get in one go | 12:52 |
| pedronis | it seems to touch a lot of places | 12:52 |
| pedronis | pstolowski: there might be things we can do | 12:55 |
| pedronis | some things are also inherited messiness | 12:57 |
| pstolowski | pedronis: i'll look at the entire diff again and try to find something to propose separately. the main problem was change in semantics of wrappers, it affects a lot | 12:57 |
| pedronis | pstolowski: yea, I think we should discuss a bit | 12:57 |
| pstolowski | pedronis: and at some point when i was trying to split this i was lost and managing conflicts was nightmare | 12:58 |
| pstolowski | because i was trying to do some things "dummy" in preparation for something upcoming, but that just diverged too much | 12:59 |
| pstolowski | pedronis: i see a few smaller things that i can extract and propose independently without extra work, so i can prep them to start with | 13:23 |
| cachio | mvo, this is the log https://paste.ubuntu.com/p/6jmQQRkpCD/ | 13:47 |
| cachio | there is another similar | 13:47 |
| cachio | do you want it? | 13:47 |
| mvo | cachio: looking, one is probably fine for now | 13:53 |
| mvo | cachio: I noticed test-snapd-sh-coe20 is missing, building that now | 13:59 |
| cachio | mvo, yes, thnaks | 14:02 |
| cachio | in most cases we build it | 14:03 |
| cachio | in the test | 14:03 |
| pstolowski | pedronis: do you have a moment now? | 14:23 |
| pedronis | pstolowski: I'm available in the standup HO | 14:23 |
| pstolowski | coming | 14:24 |
| === alan_g is now known as alan_g_ | ||
| zyga | mvo: I'm less sleepy now, I will pick up that branch in an hour or two | 15:15 |
| mvo | zyga: \o/ thanks! | 15:18 |
| mup | PR snapcraft#3178 closed: extensions: add gcc to GNOME 3.28 extension part <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3178> | 15:24 |
| ogra | xnox, so we got UC20 demo from ian today ... systemd in initrd is seriously shiny, you rock !!! | 15:47 |
| xnox | ogra: it's held by duct-tape and lots of hacks from everyone ian maciej michael etc. | 15:52 |
| === alan_g_ is now known as alan_g | ||
| xnox | ogra: i'm glad that it _appears_ rock solid =) | 15:52 |
| ogra | still super shiny and long overdue ... duct tape or not ... kudos ! | 15:53 |
| abeato | jdstrand, hey, is primed-staged-packages already used to find CVEs for snaps in the store? | 16:18 |
| * cachio lunch | 16:29 | |
| mup | PR snapcraft#3179 opened: Maven plugin: improve error message when target libs are not found <Created by edumucelli> <https://github.com/snapcore/snapcraft/pull/3179> | 17:34 |
| jdstrand | abeato: not yet. emitorino got assigned to do that but then some urgent stuff came up. it'll happen 'soonish' | 17:49 |
| jdstrand | 'ish' since I'm not quite sure when, but it is the first review-tools item she'll pick up when she gets back to the review-tools :) | 17:50 |
| emitorino | abeato, yes, it's on my list as jdstrand mentioned. I plan to work on that feature next week. Let me know if you need it earlier and we can coordinate | 18:10 |
| abeato | jdstrand, emitorino great, thanks for the update - no, not in a hurry, I was just wondering if it was already there | 18:16 |
| emitorino | abeato, cool, I will let you know as soon as it is ready | 18:16 |
| abeato | awesome, thanks | 18:16 |
| pstolowski | ijohnson: hey, i've updated services PR | 18:57 |
| pstolowski | ijohnson: and i think the loop is correct, please take a look | 18:58 |
| ijohnson | Okay, thanks pstolowski | 18:58 |
| mup | PR snapd#8893 opened: osutil/disks: refactor diskFromMountPointImpl a bit <Cleanup :broom:> <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8893> | 19:23 |
| zyga | jdstrand: I've updated https://github.com/snapcore/snapd/pull/8881 | 21:25 |
| mup | PR #8881: interfaces: optimize rules of multiple connected iio and spi plugs <Bug> <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8881> | 21:25 |
| zyga | jdstrand: I think everything is addressed now, with one important exception | 21:26 |
| zyga | jdstrand: if you review it today it can be cherry picked into the release branch by mvo tomorrow | 21:26 |
| zyga | jdstrand: I'm officially off today and tomorrow | 21:26 |
| zyga | but I may show up for a moment | 21:26 |
| mup | PR snapcraft#3177 closed: repo: consider virtual pkgs for cache invalidation <bug> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3177> | 22:35 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!