mupPR snapcraft#3175 closed: cli: restore --target-arch with warning for LXD and Multipass <bug> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3175>00:22
mupPR snapcraft#3178 opened: extensions: add gcc to GNOME 3.28 extension part <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3178>02:32
guivercchromium snap:  a post on askubu (https://askubuntu.com/questions/1184357/why-cant-chromium-suddenly-access-any-partition-except-for-home/1251289#1251289) claims they can bypass what I suspect is intended security; should it be reported, if so where?  snapcraft.io  (it maybe nothing; a quick look and I didn't re-create but didn't really try)03:47
* guiverc adds it's the new added answer by Dan Dasc.03:48
jameshguiverc: it's true that running random binaries from within a snap rather than the public entry points will not be sandboxed.  There's no guarantee that such an invocation will work though.04:07
guivercso not an issue, or known issue... I'll ignore.  thanks jamesh04:08
mborzeckihm weird failure in google:ubuntu-core-20-64:tests/core/snap-auto-mount05:53
mborzeckiand debug section is buggy in that test too05:53
mborzeckimvo: hey06:23
mvohey mborzecki06:23
mupPR snapd#8890 closed: seed: fix LoadEssentialMeta when gadget is not loaded <Bug> <UC20> <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8890>06:41
mvogood morning pstolowski07:03
mupPR snapd#8813 closed: gadget,cmd/snap-bootstrap: move partitioning to gadget <UC20> <Created by cmatsuoka> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8813>07:06
zygaGood morning07:14
zygaI’m back home07:14
zygaTired but okay07:14
zygaI just dropped in to say hi07:14
zygaAnd tell you all I will take today and tomorrow off to rest07:15
zygaSurgery cannot be done yet, and I need to wait for a few weeks on new07:15
zygaMeds that decrease the problem07:15
zygaI will resume work next week07:15
zygaAnd will work mostly normally for the next two to four weeks07:16
zygaI may have the surgery after that, when my condition improves07:17
zygaSo that is that07:17
zygaI’m really tired today, had a very painful and long day and night07:17
zygamvo: I will file yesterday today and tomorrow into the system07:18
mvozyga: thank you, get well07:19
zygaThank you, good luck with apparmor and secure boot and everything :)07:20
mvozyga: yeah, slowely working my way forward there, almost no progress yesterday because of other things but I'm somewhat hopeful for today :)07:24
mvomborzecki, pedronis any concerns to merge 8675? it has two +1 now07:25
pedronismvo: I think mborzecki should look at it again07:26
mborzeckipedronis: mvo: finishign with some tweaks to u-i, will that a look at that pr next07:27
mvomborzecki: ta07:29
mwhudsondoes something in snapd set LC_ALL to C?08:23
mwhudsonhm doesn't look like it08:24
mvomwhudson: hey, I don't think so - thanks for updating go/edge !08:28
mvopstolowski: I added an idea to your comment in https://github.com/snapcore/snapd/pull/8881/files#r441360886 - please let me know what you think, zyga is out so I want to push this forward a bit09:32
mupPR #8881: interfaces: optimize rules of multiple connected iio and spi plugs <Bug> <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8881>09:32
* zyga needs to disable phone notifications09:33
zygamvo: I would not drift away from ###PARAM###, just handle it without panic09:33
mvozyga: haha - sorry09:33
zygaas it makes use of map nicer09:33
zygamvo: no worries, I really feel better already09:33
mvozyga: if you want and feel good have a look at my comment, it still uses ###PARM### internally just make the interface for the caller slightly different09:34
zygamvo: yeah I like the interface a lot09:34
zygaI misunderstood that it also changes the backend09:34
zygaif that's the same backend that's a brilliant way out09:34
zyganice work!09:34
mvozyga: no worries, just comment there if you prefer the []string or "prefix,postfix" either way is fine, you know more about this than me (I slightly prfer []string)09:35
zygaI prefer [] as it may be needed to insert this many times09:35
mvozyga: +109:35
mvothank you zyga09:35
zygareally sweet way out of this :)09:35
zygathank You :)09:35
mvo:) my pleasure09:35
zygaif you park it ping me on irc/tg and I will iterate some more and add tests/i2c support09:36
zygamy family is helping me to adjust the bed to a better workspace09:36
zygawith "floating" laptop so that I don't need to strain my neck09:36
zygaand a split keyboard so that my hands don't have to be in the air while typing09:37
zygaI just ordered https://ultimatehackingkeyboard.com/09:37
mvozyga: I did some of the cosmetic changes that jamie asked for, 1.5 unit tests and can push the diff and then it's all yours if you want :) , I have code-review and meetings today09:37
mvozyga: I wonder if a bed breakfast tray would help?09:37
zygamvo: we tried but I really want something that's more less at 45 angle09:38
zygaabove my head09:38
* mvo nods09:38
zygasome wood and duck tape will work as a prototype09:38
zygaI'll send pics when it works :)09:39
zygamvo: I'm afk again, ping me when you are done with the PR09:40
mborzeckipedronis_: https://github.com/snapcore/snapd/pull/8887#discussion_r442077693 i was wondering whether there should be any fallback, but i gues when you're generating an image with some version of snapd, the asset must exist09:44
mupPR #8887: bootloader: pull recovery grub config from internal assets <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8887>09:44
=== pedronis_ is now known as pedronis
pedronismvo: so it seems there was an almost fix of 8889 in the codebase09:45
pedronismvo: there's probably more code to cleanup there09:46
mvopedronis: yeah, it was 2 steps forward, one step back. I did not dig super deep but my feeling is the same, there is more hidding there09:50
mvozyga: pushed the tweak to the signature, feel free to tweak further or change as needed, I'm done with the PR for a couple of hours now (meeting, code-review, lunch etc). keep me updated please and fwiw, really nice job there09:51
pedronismvo: I left comments there09:55
pedronismvo: I think the issue with the original fix is that we didn't write an UpdateMany tests perhaps?09:56
pedronisif don't have many of those, or maybe we did but is not quite right?09:56
pedroniss/if don't/we don't/09:56
pstolowskimvo: i like your idea, i meant to comment under the PR but it seems this comment is gone09:58
mvopedronis: thanks, I have a look09:59
mvopedronis: but yeah, missing test(s) seems very likely09:59
mvopstolowski: sorry, my fault probably, I resolved it (but it should still be there, just collapsed)09:59
mvopstolowski: anyway, "like it" is enough :)09:59
pstolowskimvo: ah indeed it's there, i got confused, sorry10:01
mborzeckiquick errand, back in a bit10:08
zygamborzecki: woah10:19
zygasnap just broke a non-snap app fonts10:19
zygathat was *open*10:19
zygaI opened telegram10:19
zygaand the ebook reader app got messed up10:19
pedronismvo: I made a remark in #8881 that that method needs a doc comment10:37
mupPR #8881: interfaces: optimize rules of multiple connected iio and spi plugs <Bug> <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8881>10:37
mvopedronis: thank you!10:40
mvopedronis: also thanks for your comment in 8889, I had no idea we look at flags in so many place, +100 for the unit test(s)10:40
clmsydid anyone experience "no such device: ubuntu-boot" from trying to boot this: https://github.com/snapcore/pc-amd64-gadget (20 branch)10:44
mvoclmsy: I don't remember this but if you used qemu, did you boot it in UEFI mode?10:52
=== facundo__ is now known as facubatista
clmsyI will double check and comeback mvo, thx10:58
mvoijohnson: I merged 8675 but there is a small suggestion for a followup that is worth checking11:15
ijohnsonmvo: sure I will take a look in a bit, trying to wrap up my presentation this morning :-)11:16
mupPR snapd#8675 closed: osutil: add disks pkg for associating mountpoints with disks/partitions <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8675>11:17
mvoijohnson: no worries11:17
mvoijohnson: it's not urgent, just wanted to mention it :)11:17
mvopstolowski: 8812 looks ready, if you get unrelated failures just ping me and I can sudo merge11:18
pstolowskimvo: yes i'm super keen to land it and have been monitoring it; failed on project- on core20 and i restarted the tests11:19
mvopstolowski: ok11:20
mvopstolowski: thanks for being on top of this!11:20
pstolowskimvo: let's wait a little bit for current run11:20
mvoin related news: down to 50 PRs again!11:20
pstolowskimvo: failed on centos 8 only, on selinux-clean. cannot be related because this functionality is not yet hooked anywhere11:34
pstolowskimvo: so i'd say go ahead an merge11:34
pstolowskicachio: hi, #8558 still has unaddressed comments, do you plan to add the doc?11:46
mupPR #8558: tests: make the nested library usable independently of spread <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8558>11:46
cachiopstolowski, hi, yes, but still applying some improvements to that one11:46
cachiopstolowski, I'll push today the update11:47
pstolowskicachio: ah, sure11:47
cachiopstolowski, there were many changes in nested recently :)11:48
pstolowskicachio: yes.. btw, is the core20 early config still failing?11:48
cachiopstolowski, today I see the nested/core20 suite failed with that error https://paste.ubuntu.com/p/fqVwCSZDGf/12:00
cachioseems to be a race I think12:00
mupPR snapd#8891 opened: o/servicestate: add updateSnapstateServices helper (5/6) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8891>12:27
mborzeckihttps://github.com/snapcore/snapd/pull/8455 could use some reviews12:27
mupPR #8455: tests/lib/cla_check: expect explicit commit range <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8455>12:27
pedronispstolowski: should we merge #8812 ?12:30
mupPR #8812: o/snapstate: service-control task handler (4/N) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8812>12:30
pstolowskipedronis: yes, i pinged mvo earlier but he seems busy. unrelated failure on centos12:30
cachiopstolowski, added the sectino to HACKING file12:31
pedronispstolowski: you can merge, centos is marked not required12:32
cachiostill testing hte lib with different variables12:32
pstolowskicachio: would it be possible to add it as --help ?12:32
pedronispstolowski: you don't need mvo12:32
pstolowskipedronis: ah, indeed12:32
cachiopstolowski, yes let me add that12:33
pstolowskithe grey merge button is confusing12:33
pstolowskithat's great. i pushing the last PR then12:33
mupPR snapd#8812 closed: o/snapstate: service-control task handler (4/N) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/8812>12:37
pedronispstolowski: yes, the button can be green, grey, or greyed out12:42
pedronissomething like that afair12:42
mvoyeah, centos-8 is no longer required because it's a bit unstable right now12:44
pedronispstolowski: great, not sure I'll get to them immediately though12:46
mupPR snapd#8892 opened: o/snapstate,servicestate: use service-control task for service actions (6/6) <Complex> <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8892>12:47
pstolowskipedronis: np, i'll probably push some tests to #8892 still12:48
mupPR #8892: o/snapstate,servicestate: use service-control task for service actions (6/6) <Complex> <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8892>12:48
pedronispstolowski: is still fairly large?12:48
pstolowskipedronis: yes, the 5th one will reduce it a bit12:49
pstolowskipedronis: +1,082 −57312:50
pstolowskipedronis: maybe I can find some small bits to extract into separate PR(s), but it got really hard at this point12:51
pedronispstolowski: we'll need to see it might get hard to get in one go12:52
pedronisit seems to touch a lot of places12:52
pedronispstolowski: there might be things we can do12:55
pedronissome things are also inherited messiness12:57
pstolowskipedronis: i'll look at the entire diff again and try to find something to propose separately. the main problem was change in semantics of wrappers, it affects a lot12:57
pedronispstolowski: yea, I think we should discuss a bit12:57
pstolowskipedronis: and at some point when i was trying to split this i was lost and managing conflicts was nightmare12:58
pstolowskibecause i was trying to do some things "dummy" in preparation for something upcoming, but that just diverged too much12:59
pstolowskipedronis: i see a few smaller things that i can extract and propose independently without extra work, so i can prep them to start with13:23
cachiomvo, this is the log https://paste.ubuntu.com/p/6jmQQRkpCD/13:47
cachiothere is another similar13:47
cachiodo you want it?13:47
mvocachio: looking, one is probably fine for now13:53
mvocachio: I noticed test-snapd-sh-coe20 is missing, building that now13:59
cachiomvo, yes, thnaks14:02
cachioin most cases we build it14:03
cachioin the test14:03
pstolowskipedronis: do you have a moment now?14:23
pedronispstolowski: I'm available in the standup HO14:23
=== alan_g is now known as alan_g_
zygamvo: I'm less sleepy now, I will pick up that branch in an hour or two15:15
mvozyga: \o/ thanks!15:18
mupPR snapcraft#3178 closed: extensions: add gcc to GNOME 3.28 extension part <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3178>15:24
ograxnox, so we got  UC20 demo from ian today ... systemd in initrd is seriously shiny, you rock !!!15:47
xnoxogra:  it's held by duct-tape and lots of hacks from everyone ian maciej michael etc.15:52
=== alan_g_ is now known as alan_g
xnoxogra:  i'm glad that it _appears_ rock solid =)15:52
ograstill super shiny and long overdue ... duct tape or not ... kudos !15:53
abeatojdstrand, hey, is primed-staged-packages already used to find CVEs for snaps in the store?16:18
* cachio lunch16:29
mupPR snapcraft#3179 opened: Maven plugin: improve error message when target libs are not found <Created by edumucelli> <https://github.com/snapcore/snapcraft/pull/3179>17:34
jdstrandabeato: not yet. emitorino got assigned to do that but then some urgent stuff came up. it'll happen 'soonish'17:49
jdstrand'ish' since I'm not quite sure when, but it is the first review-tools item she'll pick up when she gets back to the review-tools :)17:50
emitorinoabeato, yes, it's on my list as jdstrand mentioned. I plan to work on that feature next week. Let me know if you need it earlier and we can coordinate18:10
abeatojdstrand, emitorino great, thanks for the update - no, not in a hurry, I was just wondering if it was already there18:16
emitorinoabeato, cool, I will let you know as soon as it is ready18:16
abeatoawesome, thanks18:16
pstolowskiijohnson: hey, i've updated services PR18:57
pstolowskiijohnson: and i think the loop is correct, please take a look18:58
ijohnsonOkay, thanks pstolowski18:58
mupPR snapd#8893 opened: osutil/disks: refactor diskFromMountPointImpl a bit <Cleanup :broom:> <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8893>19:23
zygajdstrand: I've updated https://github.com/snapcore/snapd/pull/888121:25
mupPR #8881: interfaces: optimize rules of multiple connected iio and spi plugs <Bug> <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8881>21:25
zygajdstrand: I think everything is addressed now, with one important exception21:26
zygajdstrand: if you review it today it can be cherry picked into the release branch by mvo tomorrow21:26
zygajdstrand: I'm officially off today and tomorrow21:26
zygabut I may show up for a moment21:26
mupPR snapcraft#3177 closed: repo: consider virtual pkgs for cache invalidation <bug> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3177>22:35

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!