tomwardill | okay, I broke buildbot, working on it | 08:25 |
---|---|---|
* tomwardill shakes fist at doctests | 08:27 | |
ilasc | 🙂 | 08:30 |
tomwardill | https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/386081 | 08:31 |
tomwardill | ilasc: you still have the 'findByRecipe' method in your oci-registry-credentials MP. Is that used anywhere? | 08:32 |
tomwardill | ta for the review :) | 08:34 |
ilasc | tomwardill: well spotted! it will be used only in the next MPs for Push Rule viewing & editing - this is the result of splitting the big MP into smaller ones, I'll remove it now | 08:35 |
ilasc | done | 08:46 |
tomwardill | ilasc: +1 | 08:51 |
ilasc | thanks tomwardill , I'll obviously wait until later today or at some point next week to land, give buildbot a chance to recover 🙂 | 08:53 |
tomwardill | well, at least it's gone back to 'normal' errors now | 08:54 |
ilasc | lol | 08:58 |
tomwardill | storm.exceptions.PropertyPathError: Path 'QuestionMessage.<primary key>' matches no known property. | 10:56 |
* tomwardill has no idea what that means (and yes, it's similar to the one I got yesterday,b ut that one went away) | 10:56 | |
ilasc | hmmm | 10:58 |
ilasc | tomwardill: this buildbot or local dev env ? | 10:59 |
tomwardill | local instance | 10:59 |
ilasc | ok | 10:59 |
tomwardill | trying to convert QuestionMessage to Storm | 10:59 |
tomwardill | there is a primary key on that model | 10:59 |
ilasc | yes, ok, used to get similar with the stom -> sqlalchemy but on the FK | 11:01 |
ilasc | this one sounds like it doesn't know what 'primary key' is for QuestionMessage | 11:02 |
tomwardill | `id = Int(primary=True)` | 11:03 |
ilasc | yep, that should be sufficient | 11:05 |
ilasc | is QuestionMessage declared StormBased or SQLBased ? | 11:11 |
tomwardill | aha, progress | 11:11 |
tomwardill | I've changed QuestionMessage to be StormBase, but Question still had a SQLBase style ForeignKey declaration | 11:12 |
tomwardill | changing that to a Reference has solved that particular problem | 11:12 |
ilasc | 🙂 good! | 11:12 |
* tomwardill gets lunch before any more | 11:12 | |
tomwardill | something something, DOC TESTS ARRGGHHH | 15:14 |
pappacena | There is no love in something that breaks even the editor's syntax highlighting... | 15:31 |
tomwardill | no | 15:33 |
tomwardill | this set is somewhat annoyiong | 15:33 |
SpecialK|Canon | is this the file that crashes your ide? | 15:35 |
tomwardill | no, that's factory.py | 15:36 |
tomwardill | although it's a lot better now | 15:36 |
tomwardill | this doctest is failing, but i cna't tell why, because all it will tell me is that the transaction has been aborted | 15:38 |
tomwardill | repeatededly | 15:38 |
pappacena | Can you send stacktrace here? | 15:39 |
tomwardill | oh, found it | 15:43 |
tomwardill | First exception had the relevenat stack trace | 15:43 |
tomwardill | but I had to turn on 'infinite scrollback' in my terminal to be able to see it | 15:43 |
* pappacena laughing, but worried 😂 | 15:45 | |
tomwardill | anyone tried using lazr Snapshot with Storm ReferenceSet? | 16:44 |
tomwardill | looks like it's failing to snapshot it, my referenceset for the 'old' is the same as the 'new' | 16:44 |
tomwardill | hmm, doesn't appear to work | 16:54 |
* tomwardill replaces it with a list() property instead | 16:54 | |
* tomwardill undoes all the replaceing of [-1] with .last() | 16:54 | |
tomwardill | "Total: 226 tests, 0 failures, 0 errors, 0 skipped in 4 minutes 20.402 seconds." | 17:05 |
tomwardill | I think that'll do for the day | 17:05 |
* tomwardill -> EOD | 17:05 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!