Chipaca | hmm, github 500ing | 08:37 |
---|---|---|
Chipaca | good morning all! | 08:37 |
MarkMaglana | i think it has something to do with that second octocat overtightening that nut: https://www.githubstatus.com/ | 09:00 |
MarkMaglana | i could be wrong though | 09:00 |
Chipaca | MarkMaglana: possibly related to a small github project being on frontpage of newsie | 09:18 |
facubatista | Muy buenos días a todos! | 11:09 |
facubatista | Chipaca, which project? | 11:11 |
Chipaca | facubatista: https://github.com/dabeaz-course/practical-python | 11:11 |
facubatista | gracias | 11:12 |
* facubatista brb | 11:27 | |
MarkMaglana | Chipaca: I'm going to go with that second octocat. | 12:16 |
* Chipaca sets the octocat on fire | 12:16 | |
Chipaca | MarkMaglana: and now? | 12:16 |
* Chipaca forgot to not be evil | 12:16 | |
MarkMaglana | See. Now Github is OK for me again. | 12:16 |
Chipaca | now you know their secret | 12:16 |
facubatista | Chipaca, may you take a look (as in "initial light review") at https://github.com/canonical/charmcraft/pull/43 before our standup today? thanks! | 12:39 |
mup | PR charmcraft#43: First draft of interaction to the store <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/43> | 12:39 |
Chipaca | facubatista: i may :) | 12:39 |
facubatista | i june! | 12:39 |
facubatista | thanks | 12:39 |
facubatista | Chipaca, LWP crashed when trying to save the credentials :/ | 14:12 |
facubatista | File "/usr/lib/python3.6/http/cookiejar.py", line 1846, in lwp_cookie_str | 14:12 |
facubatista | keys = sorted(cookie._rest.keys()) | 14:12 |
facubatista | AttributeError: 'NoneType' object has no attribute 'keys' | 14:12 |
Chipaca | welp :) | 14:13 |
Chipaca | that answers that question i guess | 14:13 |
Chipaca | uff, that thing pulls in protobuf :-( | 14:15 |
Chipaca | and pynacl | 14:16 |
facubatista | Chipaca, nice things to know to avoid taking the "let's rewrite this" path | 14:22 |
Chipaca | gah, why am i looking at macaroonbakery code instead of at yours :-( | 14:53 |
Chipaca | facubatista: fwiw, wrt cookie jars, do you have the full traceback? i'm curious | 15:03 |
facubatista | Chipaca, https://paste.ubuntu.com/p/YKvgpzftsm/ | 15:04 |
Chipaca | facubatista: charmcraft#33 needs a master merge and then it can land | 15:09 |
mup | PR charmcraft#33: Refactored all the message sending to the user, including storing everything in a file <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/33> | 15:09 |
facubatista | Chipaca, thanks! | 15:09 |
Chipaca | facubatista: a reminder that I'd really like you to not use branches on the project itself for development | 15:09 |
facubatista | Chipaca, ah, we forgot to talk about it | 15:09 |
facubatista | Chipaca, I mean, why? it's simpler | 15:10 |
Chipaca | facubatista: it's untidy, and it dirties the project itself, meaning anybody cloning the project also pulls 'your' branches | 15:10 |
facubatista | Chipaca, we could delete those old branches... | 15:11 |
Chipaca | facubatista: and when we start having release branches it'll make them harder to find | 15:11 |
Chipaca | ('release branches' here i mean 'we need to cut 0.8.3 but just for this cherry-picked thing, not all of 0.9') | 15:12 |
facubatista | yeap | 15:12 |
Chipaca | for now we've been lucky in that all releases have just been master, but that'll not last :) | 15:12 |
facubatista | ok | 15:13 |
Chipaca | facubatista: i'd be interested to know what aspect of your workflow is harder because of this though, as locally it's no harder | 15:13 |
Chipaca | maybe there's some extra configuration i do without thinking at this point? | 15:14 |
facubatista | Chipaca, I always considered "forks" to be something to be done when you didn't own the project | 15:14 |
facubatista | Chipaca, if the 99.9% of the branches come from a 2-4 people, just use the project's repository | 15:15 |
Chipaca | facubatista: that seems like an arbitrary us-vs-them thing to me | 15:21 |
Chipaca | anyhoo, i need to step out for a bit, need to get the boys over to their mum's | 15:21 |
Chipaca | facubatista: also having it in branches fires a lot more traviseses | 16:25 |
Chipaca | (that one we can fix -- but we haven't) | 16:25 |
Chipaca | facubatista: i merged master into 33 and it's good to go, but i'll let you merge it | 16:45 |
facubatista | Chipaca, landed, thanks | 16:46 |
Chipaca | i'm going for a run | 16:57 |
Chipaca | facubatista: have a great weekend! | 16:57 |
facubatista | Chipaca, thanks! same for you | 16:58 |
facubatista | Chipaca, ajá! it looks some stuff from private internal modules are also exposed in the main module, publicly | 17:57 |
facubatista | Chipaca, this doesn't look so bad, now | 17:57 |
facubatista | and this is why documentation is important :p | 18:00 |
* facubatista eods and eows! | 20:55 | |
facubatista | see you all on Monday | 20:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!