mupPR snapd#8893 closed: osutil/disks: refactor diskFromMountPointImpl a bit <Cleanup :broom:> <Simple 😃> <UC20> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8893>06:01
zygaNot going to be around today06:20
zygaPlease relay to mvo that the fix is ready06:20
zygaAnd needs reviews06:20
zygaThat is 888106:20
mborzeckizyga: mvo is off today and on monday06:46
zygaI see06:46
zygaI think jamie will +1 it06:46
zygaso it needs 2nd review06:46
mborzeckizyga: jdstrand already did, i can apply the little tweaks he suggested06:46
zygaoh, super06:47
zygaI didn't check06:47
mborzeckipstolowski: hey07:13
mborzeckipstolowski: can you take a look at https://github.com/snapcore/snapd/pull/8455 ?07:14
mupPR #8455: tests/lib/cla_check: expect explicit commit range <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8455>07:14
pstolowskimborzecki: hi! sure07:14
pstolowskihi pedronis07:24
pedronispstolowski: mborzecki: when you have a moment a re-review of #8702 would be great, I pushed some changes and added a spread test to it07:28
mupPR #8702: overlord/configstate: add system.kernel.printk.console-loglevel option <Created by EthanHsieh> <https://github.com/snapcore/snapd/pull/8702>07:28
pstolowskipedronis: sure07:29
mupPR snapd#8455 closed: tests/lib/cla_check: expect explicit commit range <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8455>07:51
pedronispstolowski: you remember at some point we had to snap.Info.Type -> snap.Info.GetType ?07:57
pedronisto make a change safely07:58
pstolowskipedronis: yes.. we wanted to avoid surprises with go silently accepting function instead of struct member07:59
pedronispstolowski: yes, now that we are down to 50 PRs it might be time to finally undo that, I'll work on this, super mechanical PR but need to land a bit quickly08:00
pstolowskipedronis: ok, shouldn't be too annoying hopefully08:02
mborzeckipstolowski: any of your servies PRs need a 2nd review?08:02
pstolowskimborzecki: #8991 only atm, thanks08:03
mupPR snapd#8894 opened: many: rename back snap.Info.GetType to Type <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/8894>08:26
pedronispstolowski: mborzecki ^08:26
pstolowskithank you08:27
mborzeckibtw. has anyone switched to the new github ui?08:33
pstolowskiyeah, it's surprising go is happy with "func (s *Info) Type() Type {.." ;)08:33
pedronismborzecki: I get 500s if I try08:38
pedronisor maybe I'm just getting 500s right now08:39
pedronisnow thery status says there are issues08:49
pedronismborzecki: pstolowski: is github working for you atm?08:49
pstolowskipedronis: yes. got 500 once, then work08:50
pedronisok, it 500s quite consistenly here08:51
mupPR snapd#8895 opened: tests: mock servicestate in api tests to avoid systemctl checks  (6/8) <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8895>09:51
pstolowskipedronis: ^09:52
pstolowskihmm got FAIL: cmd_sign_build_test.go:108: SnapSignBuildSuite.TestSignBuildWorksDevelGrade10:04
pstolowski"cannot sign assertion: cannot sign assertion: bad GPG produced signature: it does not verify:10:04
pedronispstolowski: we are getting those sometimes, I haven't had a chance to dig, or anybody else afaik so far10:09
pstolowskii see. couldn't repro locally10:09
mborzeckiand another thunderstorm10:24
mborzeckiheh, summer weather10:24
pstolowskimborzecki: #8895 needs a 2nd review if you have a moment10:26
mupPR #8895: tests: mock servicestate in api tests to avoid systemctl checks  (6/8) <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8895>10:26
mborzeckipstolowski: looking at 8702, then 8891, after that 8895 :)10:27
* pstolowski lunch10:36
mborzeckipedronis: have you tried systemd-sysctl --prefix .. --prefix .. on xenial?11:03
mborzeckiafaic the spread test executes the call with just one --prefix11:04
* mborzecki spins up a xenial node11:05
pedronismborzecki: no,  I straced it only on 2011:05
mborzeckipedronis: and it works there too11:11
pedronismborzecki: good, thanks for thinking about this11:11
pedronisI suppose we could have done multiple calls if it didn't work11:11
mborzeckiyeah, but we're good so meh, one call is fine11:13
mborzeckiyet another thunderstorm, 2nd today, looking at weather radars there's 2 more coming :/11:13
pedronismborzecki: seems we have archive issues with fedora ?11:25
mborzeckithat's unfortunate11:26
mborzeckimaybe dl.fedoraproject.org is hosted on some of the hosts that are being moved11:27
pedronismborzecki: see https://github.com/snapcore/snapd/pull/8895/checks?check_run_id=78774541711:27
mupPR #8895: tests: mock servicestate in api tests to avoid systemctl checks  (6/8) <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8895>11:27
mborzeckipedronis: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org/message/MAGJJTVR777ARZ4TVMBQQ3YK6RC7ODE6/11:29
mborzeckipedronis: can you switch fedora-* to unstable for now?11:30
mborzeckii know mvo can, but i'm not sure anyone else has the permissions to do that11:30
pedronisI don't think I can11:36
pedronismborzecki: we can turn them manual as suppose11:59
pedronisor ping him on tg11:59
mborzecki3rd thunderstorm12:03
mborzeckipstolowski: left a comment in #889112:48
mupPR #8891: o/servicestate: add updateSnapstateServices helper (5/8) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8891>12:48
mupPR snapd#8894 closed: many: rename back snap.Info.GetType to Type <Cleanup :broom:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/8894>14:12
* cachio lunch15:10
sergiusensany ideas about disconnect failing "- Disconnect gtk3-hello:gnome-3-28-1804 from gnome-3-28-1804:gnome-3-28-1804 (cannot update mount namespace of snap "gtk3-hello": cannot update preserved namespace of snap "gtk3-hello": cannot update snap namespace: cannot create writable mimic over "/usr/share": no such file or directory)"15:55
sergiusensthat is on https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic-snappy-dev-snapcraft-daily/bionic/amd64/s/snapcraft/20200619_061338_41454@/log.gz15:55
jdstrandsergiusens: otoh no. I recommend filing a bug with steps to reproduce. it looks a bit curious since a) /usr/share should be in the snap's base runtime and b) not sure why in the snap disconnect it is *creating* a writable mimic (I would think that would happen during connect, not disconnect; but this may not be an error depending on how it is unraveling the mount namespace as part of disconnect)16:25
sergiusensjdstrand: this only happens on autopkgtest infra16:28
jdstrandsergiusens: this is a normal snap install, not snap try?16:38
jdstrand(it shouldn't matter, but curious)16:38
sergiusensjdstrand: yes, normal install it is17:58
sergiusensjdstrand: this is what we do https://github.com/snapcore/snapcraft/blob/master/tests/spread/extensions/gnome-3-28/task.yaml and this works just fine on spread/google18:00
cmatsuokacachio: hi, are you aware of this error? https://github.com/snapcore/snapd/pull/8824/checks?check_run_id=78899609818:23
mupPR #8824: many: move encryption and installer from snap-boostrap to gadget <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8824>18:23
ijohnsoncmatsuoka: that looks like a result of mborzecki's CLA fix from this morning18:24
ijohnsoncmatsuoka: have you merged master to this PR ?18:24
cachiocmatsuoka, checking18:24
cmatsuokaijohnson: hummm I think I didn't, let's do it18:24
cmatsuokaijohnson, cachio: hmm, I have a different cla error now, but that one is gone at least :)18:28
ijohnsoncmatsuoka: what's the new one :-) ?18:28
cmatsuokanow it's verifying the CLA for all email addresses in my launchpad account, it seems18:28
cmatsuokaI'm doing it again just be sure it's deterministic18:29
cmatsuokaso this is what I'm getting now: https://github.com/snapcore/snapd/pull/8824/checks?check_run_id=78910968018:30
mupPR #8824: many: move encryption and installer from snap-boostrap to gadget <UC20> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8824>18:30
ijohnsoncmatsuoka: which email is configured as your contact address?18:32
cmatsuokathe canonical one18:32
ijohnsonhmm yeah me too18:32
ijohnsonlet me see if the CLA check fails for me now too18:32
cmatsuokaI think, /me double checks18:33
ijohnsoncmatsuoka: ahh seems I can't test it because both of my email addresses are already on master18:35
cmatsuokahmm, git shortlog -se only lists my canonical email18:35
ijohnsonwhich also implies I may have been a bit sloppy with some previous commits using my personal email ...18:35
* cmatsuoka investigates how cla_check.py works18:35
ijohnsoncmatsuoka: for reference this is what happened for me https://github.com/snapcore/snapd/pull/8896/checks?check_run_id=78912362518:35
mupPR #8896: README.md: make changes to test CLA checker <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8896>18:35
mupPR snapd#8896 opened: README.md: make changes to test CLA checker <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8896>18:38
mupPR snapcraft#3180 opened: build providers: nice message on bad base <bug> <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3180>18:52
ijohnsoncmatsuoka: did you ever figure anything out ?18:52
cmatsuokaijohnson, cachio: this is interesting: if I run it locally, I get:18:53
ijohnsoncmatsuoka: if it's not working anymore I can submit a PR reverting mborzecki's PR so that you can land things18:53
cmatsuokaNeed to check 1 emails:18:53
cmatsuoka✓ claudio.matsuoka@canonical.com already on master18:53
cmatsuokabut in the tests it lists 2 addresses, for some reason18:53
cmatsuokalet me check what that PR changed...18:53
cmatsuokahumm, unless a regular expression is failing there...18:54
cmatsuokano, it can't be a regexp failure :|18:56
cmatsuokaI'll check the PR18:56
cmatsuokaijohnson: well it's not urgent, I'll check that with maciek on Monday19:02
ijohnsoncmatsuoka: ok19:02
mupPR snapcraft#3181 opened: cli: don't warn about --target-arch if target_arch is None <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3181>19:02
cmatsuokacachio: it seems that git shortlog -se master..HEAD in the test machine is listing more email addresses than it used to do, and more than what I see locally in the same branch. Does it make any sense to you?19:21
cmatsuokacachio: Did we change anything in the repository clone process, or the git version, or something like that?19:22
ijohnsoncmatsuoka: I see the same as you, 5 commits by your canonical email19:23
ijohnsonon my machine locally with your branch that is19:23
cmatsuokathat's very odd19:23
cmatsuokaI mean, not what you're seeing, but what the test is seeing19:23
cachiocmatsuoka, checking19:25
mupPR snapd#8896 closed: README.md: make changes to test CLA checker <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/8896>19:44
cachiocmatsuoka, dont see any change, not sure why it is failing19:46
mupPR snapcraft#3181 closed: cli: don't warn about --target-arch if target_arch is None <bug> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3181>20:32
mupPR snapcraft#3182 opened: build providers: improve warning for unknown base <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3182>20:32
cachiocmatsuoka, hi20:36
cachiocmatsuoka, testing the nested lib I see secboot_tpm.go:392: TPM provisioning error: the TPM is in DA lockout mode20:36
cachioany idea why it could be happening?20:36
mupPR snapcraft#3180 closed: build providers: nice message on bad base <bug> <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3180>21:13
cmatsuokacachio: no idea, it seems very weird21:41
cmatsuokacachio: Re: TPM error message: let me see here what could be happening21:45
cmatsuokacachio:  is it happening in a normal test that used to work before, or is it a new test?21:45
cmatsuokacachio: our number of tries for DA is set to 32, it shouldn't lock that easily21:50
cachioI am starting a vm using the swtpm-mvo snap21:53
cachioin my machine21:53
cmatsuokacachio: so is it a new installation?21:54
cachiocmatsuoka, yes21:54
cmatsuokacachio: are you clearing the tpm?21:54
cachiocmatsuoka, no21:54
cachioshould I ?21:54
cmatsuokacachio: in a new installation yes, but if you're rebooting an existing system, no21:55
cmatsuokacachio: to clear it delete /var/snap/swtpm-mvo/current/tpm2-00.permall21:55
mupPR snapcraft#3183 opened: static: prepare for update to black 19.10b0 <tooling> <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3183>21:58
cachiocmatsuoka, I'll try that21:58
cmatsuokacachio: yaw, if the problem persists we can investigate more21:59
cachiocmatsuoka, sure, thanks22:02
mupPR snapcraft#3182 closed: build providers: improve warning for unknown base <bug> <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3182>22:03
mupPR snapd#8897 opened: tests: trying to debug the weird cla problem <⛔ Blocked> <Created by cmatsuoka> <https://github.com/snapcore/snapd/pull/8897>23:09

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!