mborzeckiquick errand, brb06:19
zygaGood morning06:29
zygaLet’s catch up on email06:29
zygaAnd administrative tasks06:29
zygahttps://github.com/snapcore/snapd/pull/8881 needs a 2nd review06:51
mupPR #8881: interfaces: optimize rules of multiple connected iio/i2c/spi plugs <Bug> <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8881>06:51
zygahey :)07:02
mborzeckizyga: hey, how are you feeling?07:06
mborzeckipstolowski: hey07:06
zygahey pawel!07:07
zygamborzecki: without pain killers, pretty bad07:07
zygawith them, passable07:07
zygatwo weeks of bed now07:07
zygabut hey, special bed desk arrives today07:07
zygaso no more cramped legs :)07:10
mupPR snapd#8895 closed: tests: mock servicestate in api tests to avoid systemctl checks  (6/8) <Services ⚙️> <Created by stolowski> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8895>07:41
mborzeckipedronis: hey08:02
mborzeckido we have a helper that checks wheher snapd reexec'ed?08:31
mborzeckizyga: ^^08:34
zygamborzecki: I think we have some logic like that in cmd/* somewhere08:35
mborzeckii see there's some code in snapdtool, but it derives the location of the internal tooling08:35
zygabut there was some change recently08:35
mborzeckizyga: i was hoping for something like `IsReexeced() (boot, error)` ;)08:35
zygaright :)08:36
zygadon't we have a env variable for thaT?08:36
pedroniszyga: is https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1871652 fixed released now?08:37
mupBug #1871652: snap run hangs on system-key mismatch due to reexec and shutdown <champagne> <snapd:Fix Committed by zyga> <snapd (Ubuntu):Confirmed for zyga> <https://launchpad.net/bugs/1871652>08:37
zygapedronis: I think so08:37
zyga2.44.3 was released as .5 IIRC08:37
mupBug #1870201 changed: lxd-support interface doesn't appear to get properly connected/ready <snapd:Triaged> <https://launchpad.net/bugs/1870201>08:39
mupBug #1871827 changed: git ubuntu submit fails on focal <snap> <submit> <usd-importer:New> <https://launchpad.net/bugs/1871827>08:39
mupBug #1882957 changed: Snapd `internal error: connection "[slot] [plug]" not found in state` <snapd:Triaged> <https://launchpad.net/bugs/1882957>08:39
mborzeckizyga: hmm, we don't?09:09
mborzeckizyga: looks like we're jut passing os.Environ() to exec09:10
pedronismborzecki: snapdtool is just what was in cmd  and cmdutil move to one place, didn't change or add much09:15
mborzeckipedronis: zyga: in the context of #8861, i'm not sure we should be writing out the conf fies to /usr/share/dbus-1 unless snapd is reexeced09:15
mupPR #8861: data,packaging,wrappers: extend D-Bus service activation search path <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8861>09:15
zygaI agree09:16
mborzeckihence the question whether there's any helpers that can tell us that09:16
zygait's not our place to write probably09:16
mborzeckimhm, leaving a comment there for jamesh09:16
jameshmborzecki: if there are better places to do this stuff, I'm open to changing it.  But at the moment, that's where similar work is being done.09:31
pedronispstolowski: you are still working on #8891, right?09:32
mupPR #8891: o/servicestate: add updateSnapstateServices helper (5/8) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8891>09:32
pstolowskipedronis: yes, i'd like to play a bit and refactor this helper09:32
pedronisjamesh: hi, Jamie asked a question for you here: https://bugs.launchpad.net/snapd/+bug/188123209:33
mupBug #1881232: AppArmor blocks ibus input when IBUS_USE_PORTAL=1 <snapd:Confirmed for pedronis> <snapd (Ubuntu):Confirmed> <https://launchpad.net/bugs/1881232>09:33
mborzeckijamesh: do you recall those other bits that write out system locations were? iirc there's some code for snapd on core and core->snapd remodels doing that09:34
mborzeckimaybe we should wrap those locations with an if{} too09:35
jameshmborzecki: it's writing out D-Bus activation files for "snap userd"09:35
jameshpedronis: looking09:35
mborzeckijamesh: thanks i will take a look, but it soulds like we could address this in a follow up09:35
jameshpedronis: responded to the bug report.  Looks reasonable to add to the desktop interface (no need for desktop-legacy)09:55
mupPR snapd#8898 opened:  snapdtool: helper to check whether the current binary is reexeced from a snap <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8898>10:01
mborzeckijamesh: pedronis: ^^10:02
mborzeckipedronis: i've tentatively put the helper in snapdtool10:03
pedronisit's the right place10:03
mupPR snapd#8899 opened: tests: add servicestate.Control tests (7/9) <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8899>10:31
mborzeckizyga: yay, like there weren't enough for the last few days11:35
zygahaha, right? :D11:35
zygatropical banana republic of polandia11:36
zygaI need to reboot to fix my system11:48
zygareally heavy rain now11:54
* zyga small break for tea12:13
zygaand larger break for lunch too12:30
mupPR snapd#8900 opened: tests: extra worker for google-nested backend to avoid timeout error on uc20 <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8900>12:32
mborzeckicmatsuoka: hi, i looked a bit why the cla check came up with your @gmail.com email address12:34
cmatsuokamborzecki: yeah, I found the merge node there12:34
mborzeckicmatsuoka: it's probably the merge that happens automatically when the branch is not on top of current master12:34
cmatsuokamborzecki: but this is something that started happening on friday, I wonder if github changed something there12:35
cmatsuokamborzecki: I worked around it by changing my primary email address in github12:35
mborzeckicmatsuoka: hm i could tweak the call to git shortlog -s -e --no-merges, though i'm thinking that there could be a merge that ahs some actual code changes due to conflicts12:35
cmatsuokamborzecki: the primary address change shouldn't be a problem (and now it will allow me to accept modiciation suggestions in reviews)12:37
cmatsuokait's interesting however that it never happened before, even in the same PR, and now it happens in all of them12:38
mborzeckicmatsuoka: it's becase we landed some tweaks to cla_check12:38
mborzeckicmatsuoka: https://github.com/snapcore/snapd/pull/8455 landed on friday12:38
mupPR #8455: tests/lib/cla_check: expect explicit commit range <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8455>12:38
cmatsuokamborzecki: mm ok, well, it's not causing problems for me anymore but if someone else complains we already know what's causing it and a potential workaround12:40
mborzeckicmatsuoka: btw. thhere's a way to select differnt email address on per organization basis, but afaict it only affects notifiactions :/12:43
cmatsuokamborzecki: ah interesting, I didn't find that settings on gh12:47
mborzeckicmatsuoka: it's in notifications -> custom routing, but apparently does not affect commits12:48
cmatsuokaah, under notifications, ok, I didn't look there12:48
mborzeckicmatsuoka: perhaps you can add your other email address to lp too12:49
mborzecki(it's probably more convenient)12:49
cmatsuokayep, it's already on LP but it seems that I didn't sign the CLA using it12:49
mborzeckicachio:  when did that problem on centos start appearing?13:35
cachiolast week13:43
cachiomborzecki, I thought that was going to be fixed with the last update but didn't happen13:44
cachiomborzecki, we use a base image which is provided by centos cloud project13:46
cachiolast week I updated the image manually13:46
cachioI can do it again13:46
cachioand it will start failing on snapd tests so then we can fix snapd tests13:47
cachiomborzecki, what do you suggest?13:47
mborzeckicachio: you can try updating, maybe ausearch will be consistent, but it may as well be a bug in the tool itself13:50
cachiomborzecki, ok13:50
cachioI'll manually update again13:50
cachiomborzecki, thanks13:50
mborzeckicachio: it used to show 'no matches' but i don't understand why it's not doing tghat anymore, do you have more of the log, or just the tiny snippet?13:51
cachiomborzecki, just that13:52
jdstrandpedronis: I'm happy to take bug #1881232 off your hands14:07
mupBug #1881232: AppArmor blocks ibus input when IBUS_USE_PORTAL=1 <snapd:Confirmed for pedronis> <snapd (Ubuntu):Confirmed> <https://launchpad.net/bugs/1881232>14:07
pedronisjdstrand: thanks14:08
* jdstrand assigns himself14:08
mborzeckizyga: do you recall whether https://github.com/systemd/systemd/issues/12401 was introduced in 242?14:14
mborzeckizyga: the linger workaround14:15
zygahmm hmm hmm14:15
zygaI don't recall for sure, let me look if I left a comment14:15
mborzeckizyga: there's a comment indicating when the fix was done14:15
zygaso you are asking about when the bug was introduced?14:16
zygaIIRC it was always broken before that :)14:16
mborzeckizyga: well, it must have worked before, otherwise they would not keep recommenting loginctl enable-linger in rhbz for rhel814:18
mborzeckihm must/should14:18
zygait may have been fixed in distros14:18
cachiomborzecki, centos 8 updated14:18
zygabut if you look, the required line to logind conf was only added in 24314:18
zygait probably worked with some distro config before that but master was broken14:19
mborzeckizyga: do you recall which distros were broken?14:20
zygaall that we tested14:20
zygaI don't recall this being okay before 243 on any distro14:20
zygabut I may be wrong14:20
mupPR core18#152 closed: Make .disk/info visible on the root partition <Created by sil2100> <Merged by sil2100> <https://github.com/snapcore/core18/pull/152>14:21
mborzeckizyga: hmm so the effect was that the director would not be created?14:28
mborzeckizyga: i mean /var/lib/systemd/linger ?14:28
zygalinger wouldn't do anything because logind could not create it14:28
zygalogind itself worked okay14:29
zygajust this part was impacted14:29
mborzeckizyga: tried centos-8 and fedora-31/32, loginctl enable-linger seems to work fine, /var/lib/systemd/linger is already there even before i run the command, and then it creates the right file underneath14:30
zygahow about centos-7?14:30
mborzeckizyga: we don't do user sessions there anyway14:31
mborzeckizyga: i'll try wrapping that workaround with if ! test -d /var/lib/systemd/linger and see what happens14:31
* zyga will resume work later, need a break for painkillers to work again15:08
mborzeckizyga: cachio: i've tried a couple of workaroudns for linger, but i need to run some errands now, opened #8901 to see if this one is sufficient15:25
mupPR #8901:  tests/lib/tools: apply linger workaround when needed  <Precious Logs> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8901>15:25
cachiomborzecki, thanks15:26
cachioI'll take a look15:26
mborzeckiand wth tests.session is formatted with tabs15:26
mborzeckii don't think any other scripts use tabs15:27
mupPR snapd#8901 opened:  tests/lib/tools: apply linger workaround when needed  <Precious Logs> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8901>15:27
mborzeckianyways, bbl15:27
mupIssue pc-amd64-gadget#49 opened: Please provide dual-signed shim for UC20 1.0 <Created by xnox> <https://github.com/snapcore/pc-amd64-gadget/issues/49>15:50
* cachio lunch16:25
jdstrandpedronis: hey, you assigned bug #1884444 to me, but it is working as expected. what did you want me to do with it?16:52
mupBug #1884444: SECURITY ISSUE: Snaps unconfined on CentOS and Fedora <snapd:New for jdstrand> <https://launchpad.net/bugs/1884444>16:52
=== ijohnson is now known as ijohnson|lunch
=== ijohnson|lunch is now known as ijohnson
pedronisjdstrand: answer with the official stance on that18:04
ijohnsontianon: do you know if this is the right docker repo to file an issue for the registry against ?19:41
tianonijohnson: for the registry in general, yes, but the specific issue you've filed is an issue with the registry image, which would be https://github.com/docker/distribution-library-image -- see also https://github.com/docker/distribution-library-image/issues/106 and https://github.com/docker/distribution-library-image/issues/107 (https://github.com/docker/distribution-library-image/pull/92)19:44
mupPR docker/distribution-library-image#92: Fix security issues: bump alpine to 3.11, remove apache2-utils <Created by andriisoldatenko> <Merged by dmcgowan> <https://github.com/docker/distribution-library-image/pull/92>19:44
ijohnsonthanks tianon, I think I will close my issue and comment on the existing issues that if htpasswd is meant to not be in the image anymore, they need to adjust the docs too19:47
jdstrandroadmr: hey, can you sync 20200622-2009UTC ?20:22
roadmrjdstrand: certainly!20:23
jdstrandmsalvatore: ^ that has the cvescan override20:23
jdstrandroadmr: thanks!20:23
msalvatorejdstrand: thanks :)20:26
ijohnsoncachio: in order to run nested tests via qemu, I need to increase the amount of memory allocated to spread systems otherwise the nested QEMU allocation fails due to not being able to allocate all the memory for the nextedVM21:25
ijohnsoncachio: , is `memory: 4G` ok, or should I use `memory: 3G`?21:26
ijohnsoncachio: the other thing I could do is define a qemu-nested which uses `memory: 4G` and leave qemu at `memory: 2G`21:26
cachioijohnson, hi21:30
cachioyou are talking about memory of the host vm right?21:30
ijohnsoncachio: yes21:30
cachionot the nested vm21:30
ijohnsoncachio: yes I want to increase the memory of the host VM in the qemu backend21:31
cachiowell, I think 4gb21:31
cachioand then 2 for the host21:31
cachiofor the nested21:31
cachioif you run nested suite of snapd then the default size for the nested is PARAM_MEM="-m 4096"21:32
cachioand the host has 8gb21:32
cachioso, you will need to update nested.sh to upate that21:33
ijohnsoncachio: ah I forgot actually that I had already decreased the nested VM memory in my local git tree to 2G, you're right it's 4G, so it would need to be at least 5G in the host21:34
cachioijohnson, yes21:35
cachio5GB should work21:35
cachioor more21:35
ijohnsoncachio: since the current default is 2G, I think increasing to 5G is a bit much and may be unexpected to folks trying to run qemu spread tests locally as they will run out of memory very easily with even 3 spread workers, so I think I will just define a new qemu-nested backend which uses 8G21:36
cachioijohnson, yes21:36
cachioit is easier21:37
cachioijohnson, if you need any help I am going to buy some stuff, please leave a note I'll read it once I am back21:38
ijohnsoncachio: I will open the PR for you to look at, but I will be EOD within the hour, but please take a look tomorrow21:39
ijohnsoncachio: it's not urgent so it can wait til tomorrow21:39
cachioijohnson, sure, I'll take a look once I'm back21:40
* cachio afk21:40
mupPR snapcraft#3184 opened: build providers: check revision before switching <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3184>21:51
mupPR snapd#8902 opened: tests: fix assertion disk handling for nested UC systems <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8902>22:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!