| mborzecki | morning | 05:24 |
|---|---|---|
| mborzecki | quick errand, brb | 06:19 |
| zyga | Good morning | 06:29 |
| zyga | Let’s catch up on email | 06:29 |
| zyga | And administrative tasks | 06:29 |
| zyga | https://github.com/snapcore/snapd/pull/8881 needs a 2nd review | 06:51 |
| mup | PR #8881: interfaces: optimize rules of multiple connected iio/i2c/spi plugs <Bug> <Needs security review> <Created by zyga> <https://github.com/snapcore/snapd/pull/8881> | 06:51 |
| mborzecki | re | 07:00 |
| zyga | hey :) | 07:02 |
| pstolowski | morning | 07:06 |
| mborzecki | zyga: hey, how are you feeling? | 07:06 |
| mborzecki | pstolowski: hey | 07:06 |
| zyga | hey pawel! | 07:07 |
| zyga | mborzecki: without pain killers, pretty bad | 07:07 |
| zyga | with them, passable | 07:07 |
| zyga | two weeks of bed now | 07:07 |
| zyga | but hey, special bed desk arrives today | 07:07 |
| zyga | so no more cramped legs :) | 07:10 |
| mup | PR snapd#8895 closed: tests: mock servicestate in api tests to avoid systemctl checks (6/8) <Services ⚙️> <Created by stolowski> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8895> | 07:41 |
| pedronis | hello | 07:44 |
| mborzecki | pedronis: hey | 08:02 |
| mborzecki | do we have a helper that checks wheher snapd reexec'ed? | 08:31 |
| mborzecki | zyga: ^^ | 08:34 |
| zyga | mborzecki: I think we have some logic like that in cmd/* somewhere | 08:35 |
| mborzecki | i see there's some code in snapdtool, but it derives the location of the internal tooling | 08:35 |
| zyga | but there was some change recently | 08:35 |
| mborzecki | zyga: i was hoping for something like `IsReexeced() (boot, error)` ;) | 08:35 |
| zyga | right :) | 08:36 |
| zyga | don't we have a env variable for thaT? | 08:36 |
| pedronis | zyga: is https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1871652 fixed released now? | 08:37 |
| mup | Bug #1871652: snap run hangs on system-key mismatch due to reexec and shutdown <champagne> <snapd:Fix Committed by zyga> <snapd (Ubuntu):Confirmed for zyga> <https://launchpad.net/bugs/1871652> | 08:37 |
| zyga | pedronis: I think so | 08:37 |
| zyga | 2.44.3 was released as .5 IIRC | 08:37 |
| mup | Bug #1870201 changed: lxd-support interface doesn't appear to get properly connected/ready <snapd:Triaged> <https://launchpad.net/bugs/1870201> | 08:39 |
| mup | Bug #1871827 changed: git ubuntu submit fails on focal <snap> <submit> <usd-importer:New> <https://launchpad.net/bugs/1871827> | 08:39 |
| mup | Bug #1882957 changed: Snapd `internal error: connection "[slot] [plug]" not found in state` <snapd:Triaged> <https://launchpad.net/bugs/1882957> | 08:39 |
| mborzecki | zyga: hmm, we don't? | 09:09 |
| mborzecki | zyga: looks like we're jut passing os.Environ() to exec | 09:10 |
| pedronis | mborzecki: snapdtool is just what was in cmd and cmdutil move to one place, didn't change or add much | 09:15 |
| pedronis | *moved | 09:15 |
| mborzecki | pedronis: zyga: in the context of #8861, i'm not sure we should be writing out the conf fies to /usr/share/dbus-1 unless snapd is reexeced | 09:15 |
| mup | PR #8861: data,packaging,wrappers: extend D-Bus service activation search path <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/8861> | 09:15 |
| zyga | I agree | 09:16 |
| mborzecki | hence the question whether there's any helpers that can tell us that | 09:16 |
| zyga | it's not our place to write probably | 09:16 |
| mborzecki | mhm, leaving a comment there for jamesh | 09:16 |
| jamesh | mborzecki: if there are better places to do this stuff, I'm open to changing it. But at the moment, that's where similar work is being done. | 09:31 |
| pedronis | pstolowski: you are still working on #8891, right? | 09:32 |
| mup | PR #8891: o/servicestate: add updateSnapstateServices helper (5/8) <Needs Samuele review> <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8891> | 09:32 |
| pstolowski | pedronis: yes, i'd like to play a bit and refactor this helper | 09:32 |
| pedronis | ok | 09:33 |
| pedronis | jamesh: hi, Jamie asked a question for you here: https://bugs.launchpad.net/snapd/+bug/1881232 | 09:33 |
| mup | Bug #1881232: AppArmor blocks ibus input when IBUS_USE_PORTAL=1 <snapd:Confirmed for pedronis> <snapd (Ubuntu):Confirmed> <https://launchpad.net/bugs/1881232> | 09:33 |
| mborzecki | jamesh: do you recall those other bits that write out system locations were? iirc there's some code for snapd on core and core->snapd remodels doing that | 09:34 |
| mborzecki | maybe we should wrap those locations with an if{} too | 09:35 |
| jamesh | mborzecki: it's writing out D-Bus activation files for "snap userd" | 09:35 |
| jamesh | pedronis: looking | 09:35 |
| pedronis | thx | 09:35 |
| mborzecki | jamesh: thanks i will take a look, but it soulds like we could address this in a follow up | 09:35 |
| zyga | brb | 09:41 |
| zyga | re | 09:50 |
| jamesh | pedronis: responded to the bug report. Looks reasonable to add to the desktop interface (no need for desktop-legacy) | 09:55 |
| mup | PR snapd#8898 opened: snapdtool: helper to check whether the current binary is reexeced from a snap <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8898> | 10:01 |
| mborzecki | jamesh: pedronis: ^^ | 10:02 |
| mborzecki | pedronis: i've tentatively put the helper in snapdtool | 10:03 |
| pedronis | it's the right place | 10:03 |
| mup | PR snapd#8899 opened: tests: add servicestate.Control tests (7/9) <Services ⚙️> <Created by stolowski> <https://github.com/snapcore/snapd/pull/8899> | 10:31 |
| zyga | thunderstorms! | 11:35 |
| mborzecki | zyga: yay, like there weren't enough for the last few days | 11:35 |
| zyga | haha, right? :D | 11:35 |
| zyga | tropical banana republic of polandia | 11:36 |
| mborzecki | hahah | 11:36 |
| zyga | I need to reboot to fix my system | 11:48 |
| zyga | really heavy rain now | 11:54 |
| * zyga small break for tea | 12:13 | |
| zyga | and larger break for lunch too | 12:30 |
| mup | PR snapd#8900 opened: tests: extra worker for google-nested backend to avoid timeout error on uc20 <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/8900> | 12:32 |
| mborzecki | cmatsuoka: hi, i looked a bit why the cla check came up with your @gmail.com email address | 12:34 |
| cmatsuoka | mborzecki: yeah, I found the merge node there | 12:34 |
| mborzecki | cmatsuoka: it's probably the merge that happens automatically when the branch is not on top of current master | 12:34 |
| cmatsuoka | mborzecki: but this is something that started happening on friday, I wonder if github changed something there | 12:35 |
| cmatsuoka | mborzecki: I worked around it by changing my primary email address in github | 12:35 |
| mborzecki | cmatsuoka: hm i could tweak the call to git shortlog -s -e --no-merges, though i'm thinking that there could be a merge that ahs some actual code changes due to conflicts | 12:35 |
| cmatsuoka | mborzecki: the primary address change shouldn't be a problem (and now it will allow me to accept modiciation suggestions in reviews) | 12:37 |
| cmatsuoka | it's interesting however that it never happened before, even in the same PR, and now it happens in all of them | 12:38 |
| mborzecki | cmatsuoka: it's becase we landed some tweaks to cla_check | 12:38 |
| mborzecki | cmatsuoka: https://github.com/snapcore/snapd/pull/8455 landed on friday | 12:38 |
| mup | PR #8455: tests/lib/cla_check: expect explicit commit range <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/8455> | 12:38 |
| cmatsuoka | mborzecki: mm ok, well, it's not causing problems for me anymore but if someone else complains we already know what's causing it and a potential workaround | 12:40 |
| mborzecki | cmatsuoka: btw. thhere's a way to select differnt email address on per organization basis, but afaict it only affects notifiactions :/ | 12:43 |
| zyga | re | 12:47 |
| cmatsuoka | mborzecki: ah interesting, I didn't find that settings on gh | 12:47 |
| mborzecki | cmatsuoka: it's in notifications -> custom routing, but apparently does not affect commits | 12:48 |
| cmatsuoka | ah, under notifications, ok, I didn't look there | 12:48 |
| mborzecki | cmatsuoka: perhaps you can add your other email address to lp too | 12:49 |
| mborzecki | (it's probably more convenient) | 12:49 |
| cmatsuoka | yep, it's already on LP but it seems that I didn't sign the CLA using it | 12:49 |
| mborzecki | cachio: when did that problem on centos start appearing? | 13:35 |
| cachio | last week | 13:43 |
| cachio | mborzecki, I thought that was going to be fixed with the last update but didn't happen | 13:44 |
| cachio | mborzecki, we use a base image which is provided by centos cloud project | 13:46 |
| cachio | last week I updated the image manually | 13:46 |
| cachio | I can do it again | 13:46 |
| cachio | and it will start failing on snapd tests so then we can fix snapd tests | 13:47 |
| cachio | mborzecki, what do you suggest? | 13:47 |
| mborzecki | cachio: you can try updating, maybe ausearch will be consistent, but it may as well be a bug in the tool itself | 13:50 |
| cachio | mborzecki, ok | 13:50 |
| cachio | I'll manually update again | 13:50 |
| cachio | mborzecki, thanks | 13:50 |
| mborzecki | cachio: it used to show 'no matches' but i don't understand why it's not doing tghat anymore, do you have more of the log, or just the tiny snippet? | 13:51 |
| cachio | mborzecki, just that | 13:52 |
| jdstrand | pedronis: I'm happy to take bug #1881232 off your hands | 14:07 |
| mup | Bug #1881232: AppArmor blocks ibus input when IBUS_USE_PORTAL=1 <snapd:Confirmed for pedronis> <snapd (Ubuntu):Confirmed> <https://launchpad.net/bugs/1881232> | 14:07 |
| pedronis | jdstrand: thanks | 14:08 |
| * jdstrand assigns himself | 14:08 | |
| mborzecki | zyga: do you recall whether https://github.com/systemd/systemd/issues/12401 was introduced in 242? | 14:14 |
| zyga | looking | 14:14 |
| mborzecki | zyga: the linger workaround | 14:15 |
| zyga | ah | 14:15 |
| zyga | hmm hmm hmm | 14:15 |
| zyga | numbers | 14:15 |
| zyga | I don't recall for sure, let me look if I left a comment | 14:15 |
| mborzecki | zyga: there's a comment indicating when the fix was done | 14:15 |
| zyga | so you are asking about when the bug was introduced? | 14:16 |
| zyga | IIRC it was always broken before that :) | 14:16 |
| mborzecki | zyga: well, it must have worked before, otherwise they would not keep recommenting loginctl enable-linger in rhbz for rhel8 | 14:18 |
| mborzecki | hm must/should | 14:18 |
| zyga | it may have been fixed in distros | 14:18 |
| cachio | mborzecki, centos 8 updated | 14:18 |
| zyga | but if you look, the required line to logind conf was only added in 243 | 14:18 |
| zyga | it probably worked with some distro config before that but master was broken | 14:19 |
| mborzecki | zyga: do you recall which distros were broken? | 14:20 |
| zyga | all that we tested | 14:20 |
| zyga | I don't recall this being okay before 243 on any distro | 14:20 |
| zyga | but I may be wrong | 14:20 |
| mup | PR core18#152 closed: Make .disk/info visible on the root partition <Created by sil2100> <Merged by sil2100> <https://github.com/snapcore/core18/pull/152> | 14:21 |
| mborzecki | zyga: hmm so the effect was that the director would not be created? | 14:28 |
| mborzecki | zyga: i mean /var/lib/systemd/linger ? | 14:28 |
| zyga | linger wouldn't do anything because logind could not create it | 14:28 |
| zyga | logind itself worked okay | 14:29 |
| zyga | just this part was impacted | 14:29 |
| mborzecki | zyga: tried centos-8 and fedora-31/32, loginctl enable-linger seems to work fine, /var/lib/systemd/linger is already there even before i run the command, and then it creates the right file underneath | 14:30 |
| zyga | how about centos-7? | 14:30 |
| mborzecki | zyga: we don't do user sessions there anyway | 14:31 |
| zyga | ah | 14:31 |
| zyga | right | 14:31 |
| mborzecki | zyga: i'll try wrapping that workaround with if ! test -d /var/lib/systemd/linger and see what happens | 14:31 |
| zyga | sure | 14:31 |
| * zyga will resume work later, need a break for painkillers to work again | 15:08 | |
| mborzecki | zyga: cachio: i've tried a couple of workaroudns for linger, but i need to run some errands now, opened #8901 to see if this one is sufficient | 15:25 |
| mup | PR #8901: tests/lib/tools: apply linger workaround when needed <Precious Logs> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8901> | 15:25 |
| cachio | mborzecki, thanks | 15:26 |
| zyga | ok | 15:26 |
| cachio | I'll take a look | 15:26 |
| mborzecki | and wth tests.session is formatted with tabs | 15:26 |
| mborzecki | i don't think any other scripts use tabs | 15:27 |
| mup | PR snapd#8901 opened: tests/lib/tools: apply linger workaround when needed <Precious Logs> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/8901> | 15:27 |
| mborzecki | anyways, bbl | 15:27 |
| mup | Issue pc-amd64-gadget#49 opened: Please provide dual-signed shim for UC20 1.0 <Created by xnox> <https://github.com/snapcore/pc-amd64-gadget/issues/49> | 15:50 |
| * cachio lunch | 16:25 | |
| jdstrand | pedronis: hey, you assigned bug #1884444 to me, but it is working as expected. what did you want me to do with it? | 16:52 |
| mup | Bug #1884444: SECURITY ISSUE: Snaps unconfined on CentOS and Fedora <snapd:New for jdstrand> <https://launchpad.net/bugs/1884444> | 16:52 |
| === ijohnson is now known as ijohnson|lunch | ||
| === ijohnson|lunch is now known as ijohnson | ||
| pedronis | jdstrand: answer with the official stance on that | 18:04 |
| ijohnson | tianon: do you know if this is the right docker repo to file an issue for the registry against ? | 19:41 |
| ijohnson | https://github.com/docker/distribution/issues/3185 | 19:41 |
| tianon | ijohnson: for the registry in general, yes, but the specific issue you've filed is an issue with the registry image, which would be https://github.com/docker/distribution-library-image -- see also https://github.com/docker/distribution-library-image/issues/106 and https://github.com/docker/distribution-library-image/issues/107 (https://github.com/docker/distribution-library-image/pull/92) | 19:44 |
| mup | PR docker/distribution-library-image#92: Fix security issues: bump alpine to 3.11, remove apache2-utils <Created by andriisoldatenko> <Merged by dmcgowan> <https://github.com/docker/distribution-library-image/pull/92> | 19:44 |
| ijohnson | thanks tianon, I think I will close my issue and comment on the existing issues that if htpasswd is meant to not be in the image anymore, they need to adjust the docs too | 19:47 |
| jdstrand | roadmr: hey, can you sync 20200622-2009UTC ? | 20:22 |
| roadmr | jdstrand: certainly! | 20:23 |
| jdstrand | msalvatore: ^ that has the cvescan override | 20:23 |
| jdstrand | roadmr: thanks! | 20:23 |
| msalvatore | jdstrand: thanks :) | 20:26 |
| ijohnson | cachio: in order to run nested tests via qemu, I need to increase the amount of memory allocated to spread systems otherwise the nested QEMU allocation fails due to not being able to allocate all the memory for the nextedVM | 21:25 |
| ijohnson | cachio: , is `memory: 4G` ok, or should I use `memory: 3G`? | 21:26 |
| ijohnson | cachio: the other thing I could do is define a qemu-nested which uses `memory: 4G` and leave qemu at `memory: 2G` | 21:26 |
| cachio | ijohnson, hi | 21:30 |
| cachio | you are talking about memory of the host vm right? | 21:30 |
| ijohnson | cachio: yes | 21:30 |
| cachio | not the nested vm | 21:30 |
| ijohnson | cachio: yes I want to increase the memory of the host VM in the qemu backend | 21:31 |
| cachio | well, I think 4gb | 21:31 |
| cachio | and then 2 for the host | 21:31 |
| cachio | for the nested | 21:31 |
| cachio | if you run nested suite of snapd then the default size for the nested is PARAM_MEM="-m 4096" | 21:32 |
| cachio | and the host has 8gb | 21:32 |
| cachio | so, you will need to update nested.sh to upate that | 21:33 |
| ijohnson | cachio: ah I forgot actually that I had already decreased the nested VM memory in my local git tree to 2G, you're right it's 4G, so it would need to be at least 5G in the host | 21:34 |
| cachio | ijohnson, yes | 21:35 |
| cachio | 5GB should work | 21:35 |
| cachio | or more | 21:35 |
| ijohnson | cachio: since the current default is 2G, I think increasing to 5G is a bit much and may be unexpected to folks trying to run qemu spread tests locally as they will run out of memory very easily with even 3 spread workers, so I think I will just define a new qemu-nested backend which uses 8G | 21:36 |
| cachio | ijohnson, yes | 21:36 |
| cachio | it is easier | 21:37 |
| cachio | ijohnson, if you need any help I am going to buy some stuff, please leave a note I'll read it once I am back | 21:38 |
| ijohnson | cachio: I will open the PR for you to look at, but I will be EOD within the hour, but please take a look tomorrow | 21:39 |
| ijohnson | cachio: it's not urgent so it can wait til tomorrow | 21:39 |
| cachio | ijohnson, sure, I'll take a look once I'm back | 21:40 |
| ijohnson | thanks | 21:40 |
| cachio | np | 21:40 |
| * cachio afk | 21:40 | |
| mup | PR snapcraft#3184 opened: build providers: check revision before switching <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3184> | 21:51 |
| mup | PR snapd#8902 opened: tests: fix assertion disk handling for nested UC systems <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/8902> | 22:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!