=== apollo13_ is now known as apollo13
otuboOdd_Bloke, quick question on PR 428: Would you like a unittest for kernel_version() function? We already have tests for swap file.12:28
otuboOdd_Bloke, oh I see you specified you want both :-) Nevermind.12:31
otuboOdd_Bloke, but I'm not sure I can test the kernel_version function without issuing os.uname() again. I would have to hard-code a kernel version assuming I know the actual kernel version in where the test will run.12:40
Odd_Blokeotubo: I noticed this when reviewing your generator PR: https://github.com/canonical/cloud-init/pull/45212:43
otuboOdd_Bloke, Oh, didn't see you already had this PR! Apologies :-)12:45
Odd_Blokeotubo: Oh, no, I noticed that one of the other systemd files was incorrect when I was grepping around to confirm that your change matched the rest of the templates.  Your fix already landed, this is a different file. :)12:46
Odd_Blokeotubo: Regarding testing kernel_version(), I was thinking that you'd mock out os.uname() and test that if you return a few different valid kernel versions (ideally formatted how we would find across a few different distros) it produces the expected tuple.12:47
otuboOdd_Bloke, oh nice one, indeed.12:48
Odd_BlokeThanks for the review!12:54
Odd_BlokeOh, huh, I thought I had a committer +1 on https://github.com/canonical/cloud-init/pull/391 but I don't; could someone give me a +1 so I can hit the green button?12:59
meenaOdd_Bloke: i could but its not worth much13:10
Odd_BlokeSimilarly, just looking for a committer +1 here: https://github.com/canonical/cloud-init/pull/45213:25
otuboOdd_Bloke, I don't think I'm a committer, am I?13:27
Odd_BlokeNope, that's Chad, Ryan, Scott and myself.13:29
powersjOdd_Bloke, +1 on 45213:37
Odd_Blokepowersj: Thanks!13:40
powersj+1 on 39113:43
meenaotubo: Odd_Bloke tried to give me reviewer permissions before, and it didn't pan out14:51
meenamy ✅ is still grey14:52
Odd_Blokemeena: I gave you enough permissions that we can _request_ reviews from you, we still want to have a committer's +1 even on BSD-specific changes.14:52
blackboxswsorry lucasmoura just pushed that missing release -> UBUNTU_RELEASE commit to the sru test refactor https://github.com/cloud-init/ubuntu-sru/pull/128 and merged your RandomPassword validatrion15:59
blackboxswvalidation rather15:59
falcojrwhats the point of these "ssh "${SSHOPTS[@]}" ubuntu@$VM_IP -- grep Trace /var/log/cloud-init.log" lines in the manual verification?17:12
falcojrthere's no trace in the logs so the script is failing17:13
blackboxswfalcojr: generally with set -ex in the script we should have made that line whats the point of these "ssh "${SSHOPTS[@]}" ubuntu@$VM_IP -- ! grep Trace /var/log/cloud-init.log"17:13
blackboxswsorry if I switched the script to set -ex, I should have adapted those lines to expect no matches17:13
blackboxswor fail quickly if they hit it17:13
blackboxswnote the bang "!" above17:14
falcojrgotcha. I saw some with a bang and some without, so was wondering17:14
* blackboxsw looks over the refactor cloud tests and fixes that throughout17:14
blackboxswgce and azure scripts it seems17:15
rharperblackboxsw: btw, this swap: auto for swapfile is a PITA, all of my lxd deployments use ZFS and ZFS does not support swapfiles ... so having to go VM route;  lxd vms IIRC don't have cloud-images for Xenial (right? ) so that'll have to be a one-off  to get a xenial cloud-image up; should ahve a PR up for that today17:15
blackboxswgce/softlayer I mean , though I ffixed softlayer in the PR https://github.com/cloud-init/ubuntu-sru/pull/13017:16
Odd_BlokeI think we've figured out that you can launch xenial VMs but the lxd agent won't work without the HWE kernel so you can't use any of the `lxc` commands to interact with it.17:16
Odd_BlokeSomeone else please confirm though, we've been learning a lot over the past couple of days so I might have got mixed up. :p17:17
blackboxswrharper: sorry, right so falcojr was using ssh into the xenial lxc container instead of lxc exec specifically for xenial https://github.com/cloud-init/ubuntu-sru/pull/12917:17
blackboxswstrange thing rharper is that paride was still able to lxc launch ubuntu-daily:xenial --vm  --profile <vm_profile> yesterday I thought (and I know I was able to do the same last week, but can no longer do that today)17:19
rharperwell, I think I'm going to add an ext4 loop device as a storage pool to lxd17:19
blackboxswrharper: trusty via lxc launch --vm is an official "not gonna do it" as far as images. Xenial has some support, and bionic+ is good to go17:19
rharperthen file-based swaps will work and I can just use the normal lxc path17:19
falcojr@rharper I tested some other swap srus17:19
falcojrI can take this one too if that's easier17:19
rharperI've got the test written; just a matter of running  it on all of the releases17:20
blackboxswfalcojr: pushed the "! grep Trace" commit  into sru/refactor-manual-clouds17:25
blackboxswo/  sparkiegeek17:31
sparkiegeek\o blackboxsw17:31
sparkiegeekI'm trying to understand how MAAS needs to send user-data to cloud-init for the machines it boots. AFAICT MAAS is currently base64 encoding a script, and sending it as application/octet-stream but I might be misunderstanding17:34
* blackboxsw is peeking through maas code again to see how cloud-config userdata is specified directly to cloud-init. Generally I believe providing any cloud-init userdata types should be acceptable and interpreted correctly by cloud-init https://cloudinit.readthedocs.io/en/latest/topics/format.html17:40
blackboxswIn maas case, I know that cloud-init gets some user-data/ or at least vendors data through a curtin config passthrough that maas provides (in order to make sure curtin and cloud-init knows how to talk back to the maas proper log/event endpoints). But I don't recall exactly how maas passes cloud-init user-data specifically (whether through curtin config or the maas datasource).17:42
blackboxswahh user-data for maas comes from the maas seed url. to the instance.17:43
blackboxswso generally, if that user-data exposed to the instance is a supported cloud-init user-data format  (link above). Cloud-init should be able to properly interpret it. I see in the MAAS datasource, that cloud-init will attempt to decode the content of user-data url if present. It does expect user-data to be binary encoded content.17:47
blackboxswsparkiegeek: not sure if that is what you were looking for as far as context17:48
sparkiegeekblackboxsw: thanks, that's plenty to chew over17:50
blackboxsw-/me merged ubuntSRU verification  branch https://github.com/cloud-init/ubuntu-sru/pull/128 will adapt/iterate on the softlayer results.17:58
blackboxswfalcojr: I think I handled your initial review comments (and probably expect there may be a couple of extra things you run across in your GCE test run)17:58
rharpersparkiegeek: you may also be interested in the curtin handling of maas provided cloud-config, https://git.launchpad.net/curtin/tree/curtin/commands/curthooks.py#n134418:06
rharperfun fact:  eoan, bionic, and xenial  never had the bug around swap: {size: auto};  as it was an regression introduced with the fix for fallocate, on Jan 23; 6603706eec1c39d9d591c8ffa0ef7171b74d84d6 ; it only regress focal;  blackboxsw  so, for SRU verification is it OK to only verify focal ?19:29
blackboxswgood pt. rharper yes focal only19:36
blackboxswgiven we never introduced the bug in the first place.... thank goooodness for not SRUing for 6 months ;)19:37
blackboxswohh wait carry that cost forward :/19:37
rharperI spent too long trying to figure out why I couldn't recreate on eoan, thinking it was lxd vm related; turns out not a bug in 19.4-3319:39
rharperblackboxsw: https://github.com/cloud-init/ubuntu-sru/pull/132/files20:18
blackboxswon it rharper20:19
rharperyou also mentioned, https://git.launchpad.net/cloud-init/commit/?id=723e2bc1  (nfs style paths) ;  is that still open/needed ?20:19
blackboxswrharper: yep in the hidden trello board, still has your gravatar on it :)20:19
blackboxswfalcojr: you didn't grab the above commit for verification did you? ^20:20
falcojrblackboxsw rharper , no I have not grabbed that one20:21
rharperblackboxsw: falcojr: ok, I'll take that one next20:31
blackboxswlucasmoura: a followup change request on https://github.com/cloud-init/ubuntu-sru/pull/122#pullrequestreview-43613629120:37
blackboxswfalcojr: you are on gce next for SRU verification right? and you don't plan on oracle?20:38
blackboxswif not oracle , then I'll grab it (and re-find my credentials)20:38
lucasmourablackboxsw, ack20:39
falcojrblackboxsw yes, I'm doing GCE (should have it done soon)...I could jump or Oracle too20:39
blackboxswfalcojr: I'll wrap up SRU reviews and ping you to when I'm done to see where we are both at.20:40
falcojrsounds good20:41
meenaOdd_Bloke: how do i take on one of those cloudinit/net refactor bugs?20:52
meenanever mind, i'm too tired. lol21:04
blackboxswheh meena, just assign yourself when intererested21:35
blackboxswmeena: Odd_Bloke was planning on filing bugs for each aspect of the net refactor and we can have devs assign themselves to each bug and mark it in progress21:38
blackboxswas they carve out the items21:38
blackboxswI'm on https://github.com/cloud-init/ubuntu-sru/pull/133 falcojr for gce verification. minor request for comment on https://github.com/cloud-init/ubuntu-sru/pull/129 to resolve and we can land that22:26
falcojrSounds good22:34
blackboxswlucasmoura: https://github.com/cloud-init/ubuntu-sru/pull/131#discussion_r444497107 I'm not sure what you are asking. should I add the content of sru-vars.template to the verification output for softlayer ?22:40
blackboxswor something else22:40
lucasmourablackboxsw, no no. It is just that in the other cloud providers tests we have the shellscript that generated the output on the report as well, like this for example https://github.com/cloud-init/ubuntu-sru/blob/master/manual/ec2-sru-20.2.45.txt#L122:44
blackboxswahh ahh, I see. yes I will put that in there. an oversight thanks22:45
blackboxswI thought you were specifically asking about including sru-vars.template content alone22:45
blackboxswdidn't realize I left it out22:45
blackboxswall of it22:45

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!