[07:56] hmm, there's some doc test fallout from the code import changes, unsure as to correct way to fix [08:00] yep, saw that [08:01] and can't seem to reproduce locally [08:02] ok, got it locally [08:02] meaning reproduced [08:02] The diff on that MP is very weird [08:02] tomwardill: do you want me to look at it or are you ? [08:02] `bin/test -vvct lib/lp/code/doc/codeimport.txt` on master will do it [08:02] + permission="launchpad.Edit" [08:03] + set_attributes="url"/> [08:03] url has a separate setter method AFAIK which performs extra checks [08:04] wgrant: the doctests imply it does, but I can't find any reference to it actuallye xisting [08:04] Oh, interesting. [08:05] there is `updateFromData`, but there's no setters for the attributes [08:05] Oh, yeah, that's what I mean [08:05] And what it means. [08:05] Not as in a property.setter, but a general accessor. [08:06] The fix here is to remove that extra security declaration and fix any test fallout from that. [08:24] poking now [09:05] wgrant, ilasc: Doing this seemed a sensible way forward: https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/386241 [09:06] otherwise updateFromData grows a bunch of 'if' checks for permissions on certain attributes. [09:23] thanks ilasc :) wgrant, can you just check we've not missed something easier with the zcml? I get suspicious of xml, it's sneaky. [09:41] Needs more gaml [09:41] tomwardill: Looks fine I think [09:41] ta, landing [09:42] Only objection is that updateFromData could use updateURL, but that's hard with how the former is currently implemented [09:42] So this way around is good [09:42] yeah, it's a little too wrapped up in the notification checks to extract easily [09:48] I bet me landing the QuestionMessage changes breaks a bunch too [09:52] 🙂 [09:52] I guess we'll find out [10:12] sigh, yep [10:15] Easy ones, at least. [10:18] yeah, got a branch to fix, just waiting to see if there's any more [10:28] https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/386248 counting is hard [10:28] lol [13:06] Thanks for fixing the doctest, folks. Sorry about that! I didn't see the build bot failure. [13:09] no worries :) [14:23] hmm, this LXD transcription is going to have some 'interesting' features here... [14:25] Obligatory reminder to please signpost all the known dragons... [14:25] it's okay, I've named them all Errol [14:26] I really must read Discworld some day [14:26] start at Guard Guards. [14:26] (this is a semi-controversial opinion) [15:43] pylxd does not make things easy [15:44] to the point where actually just shelling out and using bash is a lot easier [16:08] * tomwardill -> EOD for bicycle club [16:09] That's disappointing :( [16:09] Er, the pylxd thing not the bicycle club! [16:09] Happy cycling!