jammorning all04:10
Chipacahuh, the redirect from #charmcraft has broken again08:41
* Chipaca bbiab09:31
* Chipaca really bbiab now09:39
mupIssue operator#333 closed: Events with no observers never get deleted <Created by jameinel> <Closed by jameinel> <https://github.com/canonical/operator/issues/333>10:23
mupPR operator#334 closed: Unobserved events <Created by jameinel> <Merged by jameinel> <https://github.com/canonical/operator/pull/334>10:23
facubatistaMuy buenos días a todos!10:50
Chipacafacubatista: eyy 👉😎👉10:56
facubatistahola Chipaca10:56
Chipacajam, facubatista, i think we should bite the bullet and use black on all our projects. It'll avoid a lot of discussion with the charms we review (and i don't feel we should tell people to use it if we aren't ourselves)10:58
jamChipaca, autopep8 is a reasonable middle solution10:59
facubatistaChipaca, at least we should tell them to use flake8 (and it shouldn't complain, of course)10:59
facubatistaChipaca, black is a little too authorative, they will hate it, and they will hate us because of forcing them11:00
Chipacaor violet11:00
Chipacathat's ok, people have hated me for my work since i started doing free software ¯\_(ツ)_/¯11:00
facubatistaChipaca, every weird decission by black, they won't blame black, they will blame us11:00
jamfacubatista, Chipaca coming ?11:01
Chipacai'm already there11:01
* Chipaca looks11:01
jamChipaca, you're not in the room I'm in with them11:01
Chipacaof course google logs me out on the hour11:01
mupIssue operator#306 closed: Add [ops:<version>] to operator log lines <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/issues/306>11:29
mupPR operator#336 closed: main: log ops version on startup <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/336>11:29
Chipacajam: ceph call?12:02
davigar15jam: For testing the relation-set issue I need juju 2.8/edge, right?12:08
jamdavigar15, stable should be sufficient12:08
davigar15But the bug wasn't commited in 2.8.1? may be I'm wrong, sorry12:09
davigar15Oh no, it was rc1 :P12:10
Chipacai get to have lunch! \o/12:11
* Chipaca brb12:11
facubatistaChipaca, jam, this is what I promised for today :) https://github.com/canonical/charmcraft/pull/4312:28
mupPR charmcraft#43: First draft of interaction to the store <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/43>12:28
Chipacajam: stand up!13:34
Chipacajam: and dance!13:34
jamsorry the other standup is going long13:40
* facubatista -> errands14:19
Chipacafacubatista: we're using retcode=-1 when it should be retcode=114:22
Chipaca-1 is syscalls, not sys.exit()14:22
Chipacai'll fix14:22
facubatistaChipaca, I can include the fix in my branch for charmcraft#314:23
mupIssue charmcraft#3: Support for long help texts from each command <Created by facundobatista> <https://github.com/canonical/charmcraft/issues/3>14:23
facubatistabut as you wish14:23
Chipacafacubatista: as you wish14:23
facubatistaChipaca, I'll do it14:23
* facubatista -> really errands14:23
Chipacafacubatista: should i file an issue?14:23
Chipacafacubatista: "Unix programs generally use 2 for command line syntax errors and 1 for all other kind of errors." (from sys.exit.__doc__)14:26
Chipacafacubatista: i'm touching this code anyway,might as well fix it myself14:31
Chipacafacubatista: charmcraft#46 fwiw14:45
mupPR charmcraft#46: handle ^C better. Also exit with 1 on error, not -1 <Created by chipaca> <https://github.com/canonical/charmcraft/pull/46>14:45
Chipacafacubatista: https://github.com/canonical/charmcraft/pull/46/files#diff-3e5146a0bd380b51a3c6f1307f045616R29415:26
mupPR charmcraft#46: handle ^C better. Also exit with 1 on error, not -1 <Created by chipaca> <https://github.com/canonical/charmcraft/pull/46>15:26
Chipacaoh, of the test itself :-)15:26
facubatistaChipaca, mmm... what?15:26
Chipacafacubatista: nothing :)15:27
Chipacai was all 'but it has a test!'15:27
facubatistabut it doesn't, right?15:27
Chipacaprobably half asleep15:27
Chipacafacubatista: it does not15:27
Chipacafacubatista: there is a test that checks that the function is called when ^C is hit :)15:27
Chipacawhich is almost the same :-p15:27
facubatistabut I want to test that it logs properly, and it removes the file15:28
facubatistaChipaca, btw, can the log file NOT be there?15:28
Chipacafacubatista: come again?15:29
facubatistaChipaca, what if you do ctrl-c really quick15:29
facubatistamaybe even before the command is executed?15:29
facubatistano, even before the first log line is sent to the file15:30
facubatistaChipaca, one of the first things we do is log the startup with version and everything, so we'll surely always have a log file15:30
Chipacafacubatista: well, maybe15:30
Chipacafacubatista: if your disk is being slow then that'll fail15:31
Chipacafacubatista: I can try/catch the removal15:31
facubatistaChipaca, two tests are missing, then :p15:31
Chipacafacubatista: wait, isnt' the logfile created in init itself?15:32
facubatistaChipaca, ah, let's see how mkstemp behaves15:32
* Chipaca looks15:32
Chipacafacubatista: yeah, that's already created the file15:32
facubatistawe can keep it simple15:33
Chipacafacubatista: but15:34
Chipacafacubatista: but, but15:34
Chipacafacubatista: we're leaking a file descriptor :-/15:34
Chipaca        _, self._log_filepath = tempfile.mkstemp(prefix='charmcraft-log-')15:34
Chipacatempfile.mkstemp's first arg is an open fd15:34
facubatistaChipaca, yeap, but it's *one* (not inside a loop or whatever)15:36
Chipacafacubatista: right. it'll blow up in windows though :)15:36
Chipaca(you can't unlink an open file, in windows)15:36
facubatistaChipaca, why?15:36
facubatistaah, oh15:36
Chipacafacubatista: tricky to fix properly though15:37
Chipacaopen takes a fd as well as a string,  wonder if logging.FileHandler does too?15:38
* Chipaca tries15:38
Chipacafacubatista: i think it should work15:38
Chipacapassing the open fd into logging.FileHandler15:38
Chipacaoh, boo, no :-/15:39
facubatistaChipaca, I think we can support it, inheriting FileHandler and overloading it's `open` method15:41
Chipacaanyway, not for now :) should i file an issue with this?15:41
facubatistaChipaca, file an issue, yes; it will break the tests when we run them in windows, anyway15:42
facubatistaChipaca, I can't create conversations on specific details if you use "regular comments" (not a proper review)15:50
Chipacafacubatista: ?15:50
facubatistaChipaca, in https://github.com/canonical/charmcraft/pull/4315:51
mupPR charmcraft#43: Store authentication related commands <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/43>15:51
Chipacaah :)15:51
Chipacasorry, some of those were very fly-by15:51
Chipacafacubatista: on the comment, tap '...', "quote reply"15:51
Chipacafacubatista: (or 'reference in new issue' if it's that bad :-) )15:52
facubatistaChipaca, yes, yes, but three responses will get all mixed; in a real review we have threads15:52
facubatistaI wanted to "resolve" the conversation, anyway15:53
facubatistaChipaca, don't worry for *these* ones15:53
Chipacafacubatista: would you mind if i pushed a pr to change 'whoami' as i describe? (or is that one of the things you're already looking at?)16:55
facubatistaChipaca, I'm already doing that16:55
Chipacafacubatista: ah, perfect16:55
facubatistaChipaca,     expected = [16:55
facubatista        'name:     John Doe',16:55
facubatista        'username: jdoe',16:55
facubatista        'id:       -1',16:55
facubatista    ]16:55
* Chipaca EODs (mostly)17:06
facubatistaChipaca, pushed17:10
* facubatista eods20:05

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!