| jam | morning all | 04:10 |
|---|---|---|
| Chipaca | huh, the redirect from #charmcraft has broken again | 08:41 |
| Chipaca | sigh | 08:41 |
| Chipaca | fixed | 08:42 |
| * Chipaca bbiab | 09:31 | |
| * Chipaca really bbiab now | 09:39 | |
| mup | Issue operator#333 closed: Events with no observers never get deleted <Created by jameinel> <Closed by jameinel> <https://github.com/canonical/operator/issues/333> | 10:23 |
| mup | PR operator#334 closed: Unobserved events <Created by jameinel> <Merged by jameinel> <https://github.com/canonical/operator/pull/334> | 10:23 |
| facubatista | Muy buenos dÃas a todos! | 10:50 |
| Chipaca | facubatista: eyy 👉😎👉 | 10:56 |
| facubatista | hola Chipaca | 10:56 |
| Chipaca | jam, facubatista, i think we should bite the bullet and use black on all our projects. It'll avoid a lot of discussion with the charms we review (and i don't feel we should tell people to use it if we aren't ourselves) | 10:58 |
| jam | Chipaca, autopep8 is a reasonable middle solution | 10:59 |
| facubatista | Chipaca, at least we should tell them to use flake8 (and it shouldn't complain, of course) | 10:59 |
| facubatista | Chipaca, black is a little too authorative, they will hate it, and they will hate us because of forcing them | 11:00 |
| Chipaca | or violet | 11:00 |
| Chipaca | that's ok, people have hated me for my work since i started doing free software ¯\_(ツ)_/¯ | 11:00 |
| facubatista | Chipaca, every weird decission by black, they won't blame black, they will blame us | 11:00 |
| jam | facubatista, Chipaca coming ? | 11:01 |
| facubatista | oops | 11:01 |
| Chipaca | i'm already there | 11:01 |
| * Chipaca looks | 11:01 | |
| jam | Chipaca, you're not in the room I'm in with them | 11:01 |
| Chipaca | of course google logs me out on the hour | 11:01 |
| mup | Issue operator#306 closed: Add [ops:<version>] to operator log lines <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/issues/306> | 11:29 |
| mup | PR operator#336 closed: main: log ops version on startup <Created by chipaca> <Merged by chipaca> <https://github.com/canonical/operator/pull/336> | 11:29 |
| Chipaca | jam: ceph call? | 12:02 |
| davigar15 | jam: For testing the relation-set issue I need juju 2.8/edge, right? | 12:08 |
| jam | davigar15, stable should be sufficient | 12:08 |
| davigar15 | But the bug wasn't commited in 2.8.1? may be I'm wrong, sorry | 12:09 |
| davigar15 | Oh no, it was rc1 :P | 12:10 |
| Chipaca | i get to have lunch! \o/ | 12:11 |
| * Chipaca brb | 12:11 | |
| facubatista | Chipaca, jam, this is what I promised for today :) https://github.com/canonical/charmcraft/pull/43 | 12:28 |
| mup | PR charmcraft#43: First draft of interaction to the store <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/43> | 12:28 |
| Chipaca | jam: stand up! | 13:34 |
| Chipaca | jam: and dance! | 13:34 |
| jam | sorry the other standup is going long | 13:40 |
| * facubatista -> errands | 14:19 | |
| Chipaca | hmm | 14:21 |
| Chipaca | facubatista: we're using retcode=-1 when it should be retcode=1 | 14:22 |
| Chipaca | -1 is syscalls, not sys.exit() | 14:22 |
| Chipaca | i'll fix | 14:22 |
| facubatista | Chipaca, I can include the fix in my branch for charmcraft#3 | 14:23 |
| mup | Issue charmcraft#3: Support for long help texts from each command <Created by facundobatista> <https://github.com/canonical/charmcraft/issues/3> | 14:23 |
| facubatista | but as you wish | 14:23 |
| Chipaca | facubatista: as you wish | 14:23 |
| Chipaca | heheh | 14:23 |
| facubatista | Chipaca, I'll do it | 14:23 |
| * facubatista -> really errands | 14:23 | |
| Chipaca | facubatista: should i file an issue? | 14:23 |
| facubatista | nah | 14:23 |
| Chipaca | facubatista: "Unix programs generally use 2 for command line syntax errors and 1 for all other kind of errors." (from sys.exit.__doc__) | 14:26 |
| Chipaca | facubatista: i'm touching this code anyway,might as well fix it myself | 14:31 |
| Chipaca | facubatista: charmcraft#46 fwiw | 14:45 |
| mup | PR charmcraft#46: handle ^C better. Also exit with 1 on error, not -1 <Created by chipaca> <https://github.com/canonical/charmcraft/pull/46> | 14:45 |
| Chipaca | facubatista: https://github.com/canonical/charmcraft/pull/46/files#diff-3e5146a0bd380b51a3c6f1307f045616R294 | 15:26 |
| mup | PR charmcraft#46: handle ^C better. Also exit with 1 on error, not -1 <Created by chipaca> <https://github.com/canonical/charmcraft/pull/46> | 15:26 |
| Chipaca | oh, of the test itself :-) | 15:26 |
| facubatista | Chipaca, mmm... what? | 15:26 |
| Chipaca | facubatista: nothing :) | 15:27 |
| Chipaca | i was all 'but it has a test!' | 15:27 |
| facubatista | but it doesn't, right? | 15:27 |
| Chipaca | probably half asleep | 15:27 |
| Chipaca | facubatista: it does not | 15:27 |
| facubatista | ack | 15:27 |
| Chipaca | facubatista: there is a test that checks that the function is called when ^C is hit :) | 15:27 |
| Chipaca | which is almost the same :-p | 15:27 |
| facubatista | but I want to test that it logs properly, and it removes the file | 15:28 |
| facubatista | Chipaca, btw, can the log file NOT be there? | 15:28 |
| Chipaca | facubatista: come again? | 15:29 |
| facubatista | Chipaca, what if you do ctrl-c really quick | 15:29 |
| facubatista | maybe even before the command is executed? | 15:29 |
| facubatista | no, even before the first log line is sent to the file | 15:30 |
| facubatista | Chipaca, one of the first things we do is log the startup with version and everything, so we'll surely always have a log file | 15:30 |
| Chipaca | facubatista: well, maybe | 15:30 |
| Chipaca | facubatista: if your disk is being slow then that'll fail | 15:31 |
| Chipaca | facubatista: I can try/catch the removal | 15:31 |
| facubatista | Chipaca, two tests are missing, then :p | 15:31 |
| Chipaca | facubatista: wait, isnt' the logfile created in init itself? | 15:32 |
| facubatista | Chipaca, ah, let's see how mkstemp behaves | 15:32 |
| * Chipaca looks | 15:32 | |
| Chipaca | facubatista: yeah, that's already created the file | 15:32 |
| facubatista | yes | 15:33 |
| facubatista | great! | 15:33 |
| facubatista | we can keep it simple | 15:33 |
| Chipaca | facubatista: but | 15:34 |
| Chipaca | facubatista: but, but | 15:34 |
| Chipaca | facubatista: we're leaking a file descriptor :-/ | 15:34 |
| Chipaca | _, self._log_filepath = tempfile.mkstemp(prefix='charmcraft-log-') | 15:34 |
| Chipaca | tempfile.mkstemp's first arg is an open fd | 15:34 |
| facubatista | Chipaca, yeap, but it's *one* (not inside a loop or whatever) | 15:36 |
| Chipaca | facubatista: right. it'll blow up in windows though :) | 15:36 |
| Chipaca | (you can't unlink an open file, in windows) | 15:36 |
| facubatista | Chipaca, why? | 15:36 |
| facubatista | ah, oh | 15:36 |
| Chipaca | facubatista: tricky to fix properly though | 15:37 |
| Chipaca | thinking | 15:37 |
| Chipaca | open takes a fd as well as a string, wonder if logging.FileHandler does too? | 15:38 |
| * Chipaca tries | 15:38 | |
| Chipaca | facubatista: i think it should work | 15:38 |
| Chipaca | passing the open fd into logging.FileHandler | 15:38 |
| Chipaca | oh, boo, no :-/ | 15:39 |
| facubatista | Chipaca, I think we can support it, inheriting FileHandler and overloading it's `open` method | 15:41 |
| Chipaca | anyway, not for now :) should i file an issue with this? | 15:41 |
| facubatista | Chipaca, file an issue, yes; it will break the tests when we run them in windows, anyway | 15:42 |
| facubatista | Chipaca, I can't create conversations on specific details if you use "regular comments" (not a proper review) | 15:50 |
| Chipaca | facubatista: ? | 15:50 |
| facubatista | Chipaca, in https://github.com/canonical/charmcraft/pull/43 | 15:51 |
| mup | PR charmcraft#43: Store authentication related commands <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/43> | 15:51 |
| Chipaca | ah :) | 15:51 |
| Chipaca | sorry, some of those were very fly-by | 15:51 |
| Chipaca | facubatista: on the comment, tap '...', "quote reply" | 15:51 |
| Chipaca | facubatista: (or 'reference in new issue' if it's that bad :-) ) | 15:52 |
| facubatista | Chipaca, yes, yes, but three responses will get all mixed; in a real review we have threads | 15:52 |
| facubatista | I wanted to "resolve" the conversation, anyway | 15:53 |
| Chipaca | :'( | 15:53 |
| facubatista | Chipaca, don't worry for *these* ones | 15:53 |
| Chipaca | :') | 15:53 |
| Chipaca | facubatista: would you mind if i pushed a pr to change 'whoami' as i describe? (or is that one of the things you're already looking at?) | 16:55 |
| facubatista | Chipaca, I'm already doing that | 16:55 |
| Chipaca | facubatista: ah, perfect | 16:55 |
| facubatista | Chipaca, expected = [ | 16:55 |
| facubatista | 'name: John Doe', | 16:55 |
| facubatista | 'username: jdoe', | 16:55 |
| facubatista | 'id: -1', | 16:55 |
| facubatista | ] | 16:55 |
| * Chipaca EODs (mostly) | 17:06 | |
| facubatista | Chipaca, pushed | 17:10 |
| * facubatista eods | 20:05 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!