[04:10] morning all [08:41] huh, the redirect from #charmcraft has broken again [08:41] sigh [08:42] fixed [09:31] * Chipaca bbiab [09:39] * Chipaca really bbiab now [10:23] Issue operator#333 closed: Events with no observers never get deleted [10:23] PR operator#334 closed: Unobserved events [10:50] Muy buenos días a todos! [10:56] facubatista: eyy 👉😎👉 [10:56] hola Chipaca [10:58] jam, facubatista, i think we should bite the bullet and use black on all our projects. It'll avoid a lot of discussion with the charms we review (and i don't feel we should tell people to use it if we aren't ourselves) [10:59] Chipaca, autopep8 is a reasonable middle solution [10:59] Chipaca, at least we should tell them to use flake8 (and it shouldn't complain, of course) [11:00] Chipaca, black is a little too authorative, they will hate it, and they will hate us because of forcing them [11:00] or violet [11:00] that's ok, people have hated me for my work since i started doing free software ¯\_(ツ)_/¯ [11:00] Chipaca, every weird decission by black, they won't blame black, they will blame us [11:01] facubatista, Chipaca coming ? [11:01] oops [11:01] i'm already there [11:01] * Chipaca looks [11:01] Chipaca, you're not in the room I'm in with them [11:01] of course google logs me out on the hour [11:29] Issue operator#306 closed: Add [ops:] to operator log lines [11:29] PR operator#336 closed: main: log ops version on startup [12:02] jam: ceph call? [12:08] jam: For testing the relation-set issue I need juju 2.8/edge, right? [12:08] davigar15, stable should be sufficient [12:09] But the bug wasn't commited in 2.8.1? may be I'm wrong, sorry [12:10] Oh no, it was rc1 :P [12:11] i get to have lunch! \o/ [12:11] * Chipaca brb [12:28] Chipaca, jam, this is what I promised for today :) https://github.com/canonical/charmcraft/pull/43 [12:28] PR charmcraft#43: First draft of interaction to the store [13:34] jam: stand up! [13:34] jam: and dance! [13:40] sorry the other standup is going long [14:19] * facubatista -> errands [14:21] hmm [14:22] facubatista: we're using retcode=-1 when it should be retcode=1 [14:22] -1 is syscalls, not sys.exit() [14:22] i'll fix [14:23] Chipaca, I can include the fix in my branch for charmcraft#3 [14:23] Issue charmcraft#3: Support for long help texts from each command [14:23] but as you wish [14:23] facubatista: as you wish [14:23] heheh [14:23] Chipaca, I'll do it [14:23] * facubatista -> really errands [14:23] facubatista: should i file an issue? [14:23] nah [14:26] facubatista: "Unix programs generally use 2 for command line syntax errors and 1 for all other kind of errors." (from sys.exit.__doc__) [14:31] facubatista: i'm touching this code anyway,might as well fix it myself [14:45] facubatista: charmcraft#46 fwiw [14:45] PR charmcraft#46: handle ^C better. Also exit with 1 on error, not -1 [15:26] facubatista: https://github.com/canonical/charmcraft/pull/46/files#diff-3e5146a0bd380b51a3c6f1307f045616R294 [15:26] PR charmcraft#46: handle ^C better. Also exit with 1 on error, not -1 [15:26] oh, of the test itself :-) [15:26] Chipaca, mmm... what? [15:27] facubatista: nothing :) [15:27] i was all 'but it has a test!' [15:27] but it doesn't, right? [15:27] probably half asleep [15:27] facubatista: it does not [15:27] ack [15:27] facubatista: there is a test that checks that the function is called when ^C is hit :) [15:27] which is almost the same :-p [15:28] but I want to test that it logs properly, and it removes the file [15:28] Chipaca, btw, can the log file NOT be there? [15:29] facubatista: come again? [15:29] Chipaca, what if you do ctrl-c really quick [15:29] maybe even before the command is executed? [15:30] no, even before the first log line is sent to the file [15:30] Chipaca, one of the first things we do is log the startup with version and everything, so we'll surely always have a log file [15:30] facubatista: well, maybe [15:31] facubatista: if your disk is being slow then that'll fail [15:31] facubatista: I can try/catch the removal [15:31] Chipaca, two tests are missing, then :p [15:32] facubatista: wait, isnt' the logfile created in init itself? [15:32] Chipaca, ah, let's see how mkstemp behaves [15:32] * Chipaca looks [15:32] facubatista: yeah, that's already created the file [15:33] yes [15:33] great! [15:33] we can keep it simple [15:34] facubatista: but [15:34] facubatista: but, but [15:34] facubatista: we're leaking a file descriptor :-/ [15:34] _, self._log_filepath = tempfile.mkstemp(prefix='charmcraft-log-') [15:34] tempfile.mkstemp's first arg is an open fd [15:36] Chipaca, yeap, but it's *one* (not inside a loop or whatever) [15:36] facubatista: right. it'll blow up in windows though :) [15:36] (you can't unlink an open file, in windows) [15:36] Chipaca, why? [15:36] ah, oh [15:37] facubatista: tricky to fix properly though [15:37] thinking [15:38] open takes a fd as well as a string, wonder if logging.FileHandler does too? [15:38] * Chipaca tries [15:38] facubatista: i think it should work [15:38] passing the open fd into logging.FileHandler [15:39] oh, boo, no :-/ [15:41] Chipaca, I think we can support it, inheriting FileHandler and overloading it's `open` method [15:41] anyway, not for now :) should i file an issue with this? [15:42] Chipaca, file an issue, yes; it will break the tests when we run them in windows, anyway [15:50] Chipaca, I can't create conversations on specific details if you use "regular comments" (not a proper review) [15:50] facubatista: ? [15:51] Chipaca, in https://github.com/canonical/charmcraft/pull/43 [15:51] PR charmcraft#43: Store authentication related commands [15:51] ah :) [15:51] sorry, some of those were very fly-by [15:51] facubatista: on the comment, tap '...', "quote reply" [15:52] facubatista: (or 'reference in new issue' if it's that bad :-) ) [15:52] Chipaca, yes, yes, but three responses will get all mixed; in a real review we have threads [15:53] I wanted to "resolve" the conversation, anyway [15:53] :'( [15:53] Chipaca, don't worry for *these* ones [15:53] :') [16:55] facubatista: would you mind if i pushed a pr to change 'whoami' as i describe? (or is that one of the things you're already looking at?) [16:55] Chipaca, I'm already doing that [16:55] facubatista: ah, perfect [16:55] Chipaca, expected = [ [16:55] 'name: John Doe', [16:55] 'username: jdoe', [16:55] 'id: -1', [16:55] ] [17:06] * Chipaca EODs (mostly) [17:10] Chipaca, pushed [20:05] * facubatista eods