| Odd_Bloke | rharper: Did you see my reply to your comment: https://github.com/canonical/cloud-init/pull/453/files#r444872750 ? | 18:06 |
|---|---|---|
| Odd_Bloke | (That's going to conflict with the next networking PR I want to put up, so I'd like to resolve it sooner rather than later, if possible. :) | 18:08 |
| rharper | Odd_Bloke: sorry, not yet; today's crazy at the house; I'll look at it shortly | 18:08 |
| meena | Odd_Bloke: i think i'll need to see a sample PR doing one of the functions before i can sensibly contribute… | 18:50 |
| meena | i expect that startig mid-august when my daughter's in child-care, so i hope i'll have more… brain left | 18:52 |
| Odd_Bloke | meena: I'm not proposing it yet (because it conflicts with the PR I'm discussing with Ryan), but I've pushed up an example that you can take a look at: https://github.com/OddBloke/cloud-init/compare/net...net3 | 18:58 |
| Odd_Bloke | meena: Obviously that hasn't been reviewed at all, so I would still hold off on using it as a template for now. | 18:58 |
| meena | Odd_Bloke: i'm surprised that is_physical isn't used anywhere in cloudinit/net/__init__.py https://github.com/OddBloke/cloud-init/compare/net...net3#diff-ce643f3a459f3fe8a4a910905190bf77 | 19:00 |
| meena | also, wow, this is… https://github.com/OddBloke/cloud-init/compare/net...net3#diff-a708ab28fe2a7127c07c0800289b6bd4R68-R76 wow. | 19:02 |
| meena | Odd_Bloke: so, basically, after the first thing goes thru, most consumers will have a distro parameter where it's needed and for those that don't, we can use that first PR as example. | 19:05 |
| rharper | Odd_Bloke: commented on the PR and the bug | 19:05 |
| meena | rharper: which ones? | 19:07 |
| rharper | https://github.com/canonical/cloud-init/pull/453/files#r444872750 | 19:11 |
| meena | ah yeah, i keep thinking that all important PRs / issues are the ones in which i'm "participating" in on github | 19:14 |
| rharper | hehe, it doesn't help that there are a lot of threads on this refactor; thank you for working on it | 19:18 |
| Odd_Bloke | rharper: Thanks! Would you be able to give me a +1 there too? | 19:18 |
| rharper | oh, right, | 19:21 |
| rharper | yes | 19:21 |
| Odd_Bloke | Thanks! | 19:22 |
| meena | rharper: if by working on it, make Odd_Bloke work on it, then, yes, you're perfectly welcome. | 19:26 |
| meena | if i had managed to make him do this a year or two ago, we could've been long done already | 19:29 |
| blackboxsw | falcojr: or lucasmoura for SRU review if you get a chance https://github.com/cloud-init/ubuntu-sru/pull/134. either one of you | 19:30 |
| blackboxsw | it's netplan vs eni prioritization on x b e f | 19:30 |
| blackboxsw | and I'm hitting SRU review queue | 19:31 |
| blackboxsw | falcojr: and lucasmoura and if you approve any of the PRs in ubuntu-sru or qa-scripts or uss-tableflip repos, I think you have commit rights, so feel free to squash merge that stuff in github UI if you want. | 19:32 |
| blackboxsw | thanks for all the reviews | 19:32 |
| blackboxsw | man all those merges feel good though | 19:34 |
| Odd_Bloke | meena: OK, you can do some work and review https://github.com/canonical/cloud-init/pull/457 ;) | 19:43 |
| Odd_Bloke | (If you have time, ofc!) | 19:43 |
| meena | i have time, i'll checkout your pr, and see if i can cotribute a BSD function too ;) | 19:44 |
| Odd_Bloke | Thanks! :) | 19:47 |
| meena | Odd_Bloke: somebody in #freebsd helped me come up with a way to list all the physical interfaces: http://ix.io/2q5e | 20:39 |
| meena | if you're thinking, isn't this the worst thing i've ever seen, well, yeah, this is unix, baby! | 20:40 |
| chillysurfer | i remember last year somebody from upstream showing me scripts that are used for sru validation on cloud providers? i think it was on github | 20:59 |
| chillysurfer | anybody know where that could be? | 20:59 |
| meena | chillysurfer: sru validation is happening rn | 21:04 |
| meena | chillysurfer: https://github.com/cloud-init/ubuntu-sru/ ? | 21:06 |
| blackboxsw | thnk meena , and that's the right repo | 21:07 |
| blackboxsw | I think we are wrapping up the last cloud SRU validtions now. expectation is to finally publish tomorrow | 21:07 |
| rharper | blackboxsw: I didn't yet get to the nfs mount spec verification; did that get covered? | 21:17 |
| blackboxsw | rharper: not yet, but if need be we can grab it. | 21:18 |
| blackboxsw | I think the last remaining issue is oracle SRU, an email ping to VMware, and the nfs | 21:18 |
| rharper | blackboxsw: I can work on it but I don't want to hold you up if you needed it done by tonight for tomorrow release | 21:21 |
| chillysurfer | awesome thanks! | 21:22 |
| * meena ➡️ 🛌 | 21:24 | |
| blackboxsw | ok lucasmoura done https://github.com/cloud-init/ubuntu-sru/pull/134 with re-run of netplan vs eni test | 21:27 |
| lucasmoura | blackboxsw, approved | 21:32 |
| blackboxsw | rharper: we are still waitingon a CDO qa run to compete. job is queued, but that and Oracle SRU verification are last remaining bits | 21:38 |
| blackboxsw | complete even | 21:38 |
| rharper | ok | 21:42 |
| rharper | blackboxsw: hrm; a quick test with nfs and the default cloud images don't have an nfs client installed, so mounting something with a colon for remote system is complicated locally; what do we want to do? THe original bug mentions EC2 nfs (which is type efs or something and maybe the ec2 image has correct client package support in it) | 21:55 |
| * blackboxsw is reading up on efs setup | 21:59 | |
| blackboxsw | in aws | 21:59 |
| * blackboxsw is looking at https://docs.aws.amazon.com/efs/latest/ug/wt1-create-efs-resources.html | 22:01 | |
| blackboxsw | looks like their docs are for non-ubuntu (yum install nfs-utils) etc. so image doesn't have utils baked in | 22:03 |
| rharper | *sigh* | 22:04 |
| rharper | ok, so looks like it's reboots and cloud-init clean | 22:04 |
| rharper | I can do that | 22:04 |
| rharper | what a PITA | 22:04 |
| blackboxsw | yeah, pita. rharper we are going to talk about and float new SRU verification process to the mailinglist I think after a retrospective on this round of fun. | 22:05 |
| blackboxsw | so watch for that email/proposal folks because we want to reduce the cost of this effort if we can without sacrificing quality. | 22:05 |
| rharper | indeed | 22:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!