[09:09] <Chipaca> belated good morning, all :)
[09:36] <Chipaca> hmm
[09:37] <Chipaca> facubatista: playing with charmcraft master+43+46, with --verbose, i think we need a couple more log lines :)
[09:37] <Chipaca> i'll propose something in a bit
[09:58] <Chipaca> facubatista: boo, it's more work than i wanted it to be; filed charmcraft#48 and charmcraft#49 so we don't forget
[09:58] <mup> Issue charmcraft#48: initialization order means early log lines can be lost <bug> <Created by chipaca> <https://github.com/canonical/charmcraft/issues/48>
[09:58] <mup> Issue charmcraft#49: charmcraft should log where it's logging to, and when the logfile is removed <Created by chipaca> <https://github.com/canonical/charmcraft/issues/49>
[10:00] <Chipaca> facubatista: unrelatedly, i'm concerned the store ops are slow. I'll be asking about this in the meeting today...
[10:05] <Chipaca> facubatista: OTOH 'slow' is 50ms from it being a snap, 150ms from all the extra imports for store things, 250ms from the actual store request
[10:05] <Chipaca> but it does but it at 500ms which is definitely slow
[10:06] <Chipaca> *put it
[10:19]  * Chipaca breaks a take
[11:02] <facubatista> Muy buenos días a todos!
[11:10] <Chipaca> facubatista: [citation needed] :-p
[11:10] <Chipaca> facubatista: hola :)
[11:10] <facubatista> hola :)
[11:13] <Chipaca> facubatista: i'm concerned that 'charmcraft whoami' easily takes over 500ms
[11:14] <Chipaca> facubatista: just fyi; it's not actionable yet
[11:14] <Chipaca> mostly raising a bit of stink over in https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/76
[11:14] <facubatista> Chipaca, I can move the httbakery/etc imports to when the first time any store related thing is used
[11:15] <Chipaca> facubatista: that won't stop whoami taking over 500ms :)
[11:15] <facubatista> ah, right, jaja
[11:15] <Chipaca> at some point, yes, we want to make things import just what's needed
[11:15] <Chipaca> but not yet, not this early
[11:15] <facubatista> Chipaca, I don't like the 500ms either
[11:16] <Chipaca> facubatista: at least part of it is the server being slow, fwiw
[11:16] <Chipaca> facubatista: I'm *also* going to raise that
[11:16] <Chipaca> (in its defense, it is staging)
[11:17] <Chipaca> /v2/whoami takes between 100 and 250ms
[11:17] <Chipaca> *both* of those are two big
[11:17] <Chipaca> too*
[11:17] <Chipaca> 10 times too big in fact :)
[11:17] <Chipaca> but, we'll see
[11:17] <facubatista> Chipaca, that is when credentials are valid, right?
[11:17] <Chipaca> yes
[11:17] <facubatista> ack
[11:18] <Chipaca> i haven't even looked at slow paths here :)
[11:18] <Chipaca> anyway
[11:18] <Chipaca> back to reviewing john's code
[11:24] <facubatista> Chipaca, https://github.com/canonical/charmcraft/issues/50
[11:25] <facubatista> Chipaca, what do you feel about renaming `_save_credentials` to `_check_save_credentials`?
[11:25] <Chipaca> _save_credentiarola
[11:27] <Chipaca> facubatista: _save_credentials_if_changed ?
[11:27] <jam> Chipaca, facubatista /wave
[11:27] <Chipaca> jam: 👋
[11:27] <facubatista> hola jam
[11:27] <jam> I'm certainly flexible on the naming, and we can stick with save, but it did feel a bit like one of those places that you would start digging in "why didn't it get updated", etc.
[11:30] <Chipaca> yeah, i agree with that :)
[11:30] <Chipaca> facubatista: do you see this method growing any other checks before actually saving?
[11:32] <jam> "_maybe_save_credentials"
[11:32] <Chipaca> _save_credentials_or_dont_yolo
[11:32] <Chipaca> :-)
[11:33] <jam> I like ensure for that sort of thing, but it doesn't feel great here
[11:34] <Chipaca> i need to get lunch done, bbiab
[11:35] <facubatista> Chipaca, I don't think it would also test other thing; its backend may change (file -> wallet), but it will essentially remain like this
[11:43] <Chipaca> facubatista: then i'll stick with my suggestion above
 facubatista: _save_credentials_if_changed ? ← this one i mean
[11:45] <facubatista> Chipaca, ok
[11:49]  * facubatista likes _save_credentials_if_changed because it's exactly what the docstring says 
[11:53] <facubatista> Chipaca, jam, all comments addressed; also annotated open issues to correspondant XXXs
[11:53] <facubatista> and pushed!
[12:28] <Chipaca> jam: i'm canceling the standup fyi
[12:54] <Chipaca> facubatista: WRT building the snap to edge, yes but version should probably be generated from git for that
[12:55] <Chipaca> facubatista: otherwise everything on edge will always have <previous released version> which is a lie :)
[12:55] <Chipaca> facubatista: would you mind if we did the same thing we do in ops?
[13:05] <facubatista> Chipaca, +1
[13:12] <Chipaca> facubatista: post-release tho
[13:22] <facubatista> ack
[13:24] <Chipaca> d'oh, i merged something i should not have
[13:24]  * Chipaca ← bad person
[13:32] <facubatista> Chipaca, btw, missing your review here: https://github.com/canonical/charmcraft/pull/43
[13:32] <mup> PR charmcraft#43: Store authentication related commands <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/43>
[15:05] <Chipaca> facubatista: https://github.com/canonical/charmcraft/pull/54 plz
[15:05] <mup> PR charmcraft#54: address issues raised in review of #46 that i merged too fast <Created by chipaca> <https://github.com/canonical/charmcraft/pull/54>
[15:56] <Chipaca> facubatista: is charmcraft#43 needing anything more from your end?
[15:56] <mup> PR charmcraft#43: Store authentication related commands <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/43>
[16:22] <mup> PR operator#337 opened: trivial change to test something <Created by chipaca> <https://github.com/canonical/operator/pull/337>
[16:24] <facubatista> Chipaca, I need travis to end
[16:24] <facubatista> ja, I summoned the response (?)
[16:24] <facubatista> Chipaca, landed!
[16:24] <Chipaca> aww
[16:25] <Chipaca> rtd could give us docs for pull requests
[16:25] <Chipaca> but i need to be able to authorize the organization
[16:31] <mup> PR operator#337 closed: trivial change to test something <Created by chipaca> <Closed by chipaca> <https://github.com/canonical/operator/pull/337>
[19:11] <facubatista> 2020-06-24 16:11:10,768  charmcraft.commands.build DEBUG    :: ERROR: Cannot find command 'git' - do you have 'git' installed and in your PATH?
[19:12] <facubatista> Chipaca, maybe we need to put git and other VCs
[19:12] <facubatista> *VCSs tools inside the snap?
[20:34] <Chipaca> facubatista: how did you get that one?
[20:34] <Chipaca> facubatista: (and yes i was expecting to have to do that, it's fine)
[20:34] <Chipaca> facubatista: (just not yet; i hadn't notied we were using git yet -- where are we?)
[20:35] <Chipaca> hm
[20:35] <Chipaca> i guess if you have a git url in your requires?
[21:10] <facubatista> Chipaca, xactly
[21:10] <Chipaca> drat :)
[21:10] <Chipaca> facubatista: something you were trying, or a user reported this?
[21:11] <facubatista> Chipaca, a user reported something similar, I'm not sure if exactly the same thing (need to see the logs they passed later)
[21:11] <facubatista> Chipaca, we need also to "see" which `pip` they have
[21:11] <Chipaca> facubatista: we're shipping pip in the snap already
[21:11] <Chipaca> that much i did test :)
[21:12] <facubatista> Chipaca, yes, but what if you run from tarball or whatever? seeing that the user has a different pip from "us" helps to understand a possible different behaviour
[21:13] <facubatista> even from snap: we may have different pips in edge than stable, etc, so have that explicitly in the logs I think it worths having an extra system call when building
[21:14] <Chipaca> facubatista: you can start the build with 'pip list'
[21:15] <facubatista> oh, that's probably better than `pip --version`
[21:15] <Chipaca> i think so :)
[21:16] <facubatista> great
[21:19] <Chipaca> facubatista: hadn't the change to create the tempdir landed?
[21:20] <Chipaca> maybe i misremember
[21:36] <facubatista> Chipaca, the tempdir? nop, I don't think we did that
[21:36] <facubatista> Chipaca, I landed the creation of the config directory, for the credentials
[21:41] <facubatista> Chipaca, `list` gives much juicy information that just the pip version
[21:41] <Chipaca> facubatista: ok i'll include creating the tempdir in my snap changes
[21:42] <Chipaca> facubatista: yes, useful information
[21:42] <Chipaca> facubatista: look at what travis prints out for example
[21:42] <Chipaca> facubatista: that's a good war log
[21:49] <facubatista> Chipaca, having a simple "pip list" first is an awesome way to see if there's *any* problem with pip, before the quite more complex install itself
[21:50] <facubatista> Chipaca, https://github.com/canonical/charmcraft/pull/56
[21:50] <mup> PR charmcraft#56: Make pip list current packages before proceeding with the install <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/56>
[21:56] <facubatista> Chipaca, remember we removed the `--system` parameter in the install call? I think the lack of it is creating the failure here: https://github.com/canonical/charmcraft/issues/55
[21:59] <Chipaca> facubatista: let me ask one other thing there
[21:59] <facubatista> Chipaca, I would let you ask even three things
[21:59] <Chipaca> qué compromiso /o\
[22:00] <facubatista> it's a max, not a hard number :p
[22:00] <facubatista> like when the genius gives you UP TO three desires
[22:01] <Chipaca> wishes*
[22:01] <Chipaca> genie*
[22:01] <Chipaca> first wish: infinite genies
[22:03] <Chipaca> facubatista: strange that in spanish genie (djinn) and genius, are the same word (very different etymologies afaict)
[22:04] <Chipaca> facubatista: ('genio' in the djinn sense is not from latin)
[22:04] <facubatista> "wishes": I should have known; "genie": didn't know
[22:05] <facubatista> "Según parece, la palabra española «genio» proviene del árabe «djinn» cuyo significado describe a un tipo muy preciso de ser."
[22:06] <facubatista> ah, genius comes from Latin
[22:07] <Chipaca> facubatista: as does genio in the genius sense :)
[22:07] <facubatista> ah, "genio" from djinn is about "mood"?
[22:08] <Chipaca> facubatista: hmm... i hadn't thought about that, but probably
[22:08] <Chipaca> that's a weird one :)
[22:08] <Chipaca> facubatista: another one that spanish mashes together is scatology and escatology
[22:08] <Chipaca> but that one i love :-D
[22:09] <facubatista> oh, that one is awesome
[22:10] <facubatista> it totally mutates the meaning of "chistes escatológicos"
[22:12] <Chipaca> facubatista: good news on that bug
[22:14] <facubatista> Chipaca, yes, but I suspected, "from snap" would be the main method of running snap, that's why I wanted for *us* to be always testing really-really-edge
[22:14] <facubatista> s/running snap/running charmcraft/
[22:14] <Chipaca> facubatista: yep
[22:14] <Chipaca> facubatista: also we'll need spread tests for the snap soon
[22:15] <Chipaca> anyway, tagged, assigned, and milestoned
[22:15] <Chipaca> and unblocked the user
[22:15] <facubatista> rock
[22:15] <Chipaca> i declare this a great success
[22:15] <Chipaca> and go to bed
[22:18] <Chipaca> facubatista: 👋 eod for me
[22:19]  * facubatista eods too