| timClicks | Docs review available for anyone with a rubber stamp https://github.com/juju/docs/pull/3507 | 03:03 |
|---|---|---|
| timClicks | Actually, I'm just going to merge it in as it only brings the repo up-to-date with what's already there | 03:04 |
| timClicks | thumper: do you have any thoughts on the use cases for LXD should be described? with LXD clustering, I feel like saying that it's only for local development is selling it short | 04:03 |
| thumper | yes local development only would be selling it short | 04:13 |
| thumper | one use case I had thought about was using LXD cluseter to install maas | 04:14 |
| thumper | using LXD clusters, you have a very lightweight cloudish thing | 04:14 |
| stickupkid | manadart_, achilleasa : CR https://github.com/juju/juju/pull/11762 | 09:02 |
| manadart_ | stickupkid: I'm looking. | 09:10 |
| stickupkid | manadart_, quick HO? | 09:44 |
| stickupkid | manadart_, hopefully that'll fix everything in that PR | 10:03 |
| manadart_ | stickupkid: I already approved it. | 10:03 |
| achilleasa | manadart_: where was that code that you were showing me? My grep-fu only seems to match a call to Subnets() in client/subnets/cache.go with an UnknownId arg | 10:13 |
| manadart_ | achilleasa: environes/networking, environs/space ? | 10:14 |
| manadart_ | `ReloadSpaces` is in environs/space/spaces.go. That's where the fallback to subnet discovery is. | 10:15 |
| achilleasa | ah just found it :D | 10:15 |
| achilleasa | so the thing is that I can't seem to be able to get all CIDRs from the lxd api | 10:16 |
| flxfoo | hi all, | 10:47 |
| flxfoo | I would like to add some little things in `cloudinit-userdata` model config, but I have this error in return: The update path 'settings.' contains an empty field name, which is not allowed. | 10:48 |
| achilleasa | stickupkid: or manadart_ simple PR for a bug https://github.com/juju/juju/pull/11763 | 11:35 |
| manadart_ | achilleasa: Will do it in a sec. | 11:41 |
| achilleasa | manadart_: not in a rush. If you have a few min later let's jump back into the HO to chat subnet discovery again bec I think I'm stuck | 11:43 |
| manadart_ | achilleasa: Swap you: https://github.com/juju/juju/pull/11764 | 11:56 |
| === arif-ali_ is now known as arif-ali | ||
| stickupkid | hml, i'm unsure we would want a mutex in the firewaller that gates every openstack call | 14:52 |
| achilleasa | manadart_: clear to land 11764 | 14:53 |
| stickupkid | hml, esp. when ensureGroups could take forever depending on the api calls | 14:53 |
| achilleasa | can I get a CR on https://github.com/juju/juju/pull/11765? | 14:54 |
| stickupkid | hml, we should be resilent against things not being there imo | 14:54 |
| hml | stickupkid: rgr. in that case. is it appropriate for us to be removing security group rules like this? that aren’t in our list or egress rules? | 14:55 |
| stickupkid | let me check that next | 14:55 |
| stickupkid | hml, this worries me though https://github.com/juju/juju/pull/11756/files#diff-cc8fa9cbee78e4f349622a6a1d6d9f24R570 | 14:55 |
| hml | hahahaha | 14:58 |
| manadart_ | achilleasa: Ta. | 14:59 |
| achilleasa | status tests seem to be flaky | 15:35 |
| stickupkid | hml, I think what the code is doing is fine, we just need to handle the issue that we may end up deleting a sg that's already gone | 15:46 |
| stickupkid | https://github.com/juju/juju/pull/11756 | 15:46 |
| hml | stickupkid: k, i’ll review shortly | 15:52 |
| achilleasa | hml: can you also add https://github.com/juju/juju/pull/11765 to the review queue? it's a really small patch | 16:26 |
| hml | achilleasa: sure | 16:27 |
| achilleasa | petevg: you might also want to QA this before we land it ^^^ | 16:27 |
| petevg | achilleasa: roger that. | 16:31 |
| bdx | hit this just now https://bugs.launchpad.net/juju/+bug/1885339 | 22:30 |
| mup | Bug #1885339: unit not removed from relation <juju:New> <https://launchpad.net/bugs/1885339> | 22:30 |
| bdx | I remove a unit, but it never leaves the relation | 22:31 |
| bdx | I'm thinking this can't be intended | 22:31 |
| bdx | is it? | 22:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!