[00:20] Hi! I've been seeing huge memory leaks in gnome-shell-calendar-server, like several GBs in a couple days. I finally tracked it down and I think I plugged them. I'm going to submit the changes to gnome, but what do I do from Ubuntu's end? Wait for those changes to trickle down, or submit a patch to the ubuntu package? [00:28] heewa: please file a bug with ubuntu-bug -- waiting for trickle-down probably means it wouldn't be fixed until 20.10 is released, and previous releases wouldn't be fixed until someone notices the problem, backports and tests fixes, etc [00:30] probably best to do both, and link the upstream GNOME bug into the Ubuntu bug :) [00:33] oh yes most definitely :) [00:33] thanks JanC [00:33] good thing it's friday afternoon... [00:33] it *is*, right? [00:33] What'll happen when the commit hits downstream while a duplicate patch is there? [00:35] sarnold: it's already Saturday here ;) [00:35] the groovy version will either import the new version from upstream before your patch is accepted into focal, or if groovy is patched, the patch will be dropped on a future sync from debian by whoever does the merge [00:35] JanC: yay :D [00:36] that's why you want both upstream & downstream to be aware also... [00:37] @sarnold, Oh I fixed it for the version ubuntu 20.04 (focal-devel, so almost released). Should I try to fix it in other versions? [00:38] heewa: focal was released two months ago [00:39] heewa: "best" in my opionion would be providing ubuntu with a fix for focal and providing upstream gnome with a fix for whatever is tip of their development process [00:40] Oh, lol, I thought focal-devel was used for updates to focal. This is my first ubuntu (and gnome) contribution. Where should I put my patch? [00:40] aha! :) focal-updates gets regular bug fixes, focal-security gets security-relavant bug fixes [00:41] you should start with whatever version in -release, -security, or -updates is the newest [00:41] Also, ubuntu-bug collects diagnostic info, right? Does that mean I should revert to the version that has the leak, wait a few days, then submit a bug report so that it has the leak as part of the info? [00:42] if you've got a patch in hand, the collected diagnostics probably aren't super-useful [00:43] they're an incredible lifesaver for most bug reports, I'm really glad we collect them, it's great to quickly skim through a few files and say "oh this computer looks like its hard drive is dying" or "wow these other errors are far more important", etc [00:44] ah, that does sound super useful === JanC_ is now known as JanC