Chipacagood morning peeps!08:03
jammorning Chipaca08:05
facubatistaMuy buenos días a todos!10:56
Chipacafacubatista: I just lied to stub!11:20
Chipacafacubatista: src is *not* in our dispatch's pythonpatgh11:20
Chipacafacubatista: i thought we'd agreed to that :-|11:20
jamChipaca, i think we should if we don't right now11:20
jamunless python always includes siblings.11:21
facubatistawe talked about mod, and then we said that all charms were symlinking from lib to that anyway11:21
facubatistaabout 'mod' dir, I mean11:21
facubatistadon't remember about 'src'11:22
jamI wouldn't include mod, because you generally want a subdir of that anyway11:22
mupIssue operator#339 opened: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339>11:23
jamChipaca, you already set my pr as non draft? Or it just accepted our earlier attempts11:24
Chipacajam: i did it11:24
mupIssue operator#339 closed: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339>11:32
mupIssue operator#339 opened: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339>11:33
mupIssue operator#339 closed: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339>11:41
mupIssue operator#339 opened: debug-code silently fails if src/charm.py is not executable <Created by stub42> <https://github.com/canonical/operator/issues/339>11:42
facubatistaChipaca, jam, added 'src' to PYTHONPATH - https://github.com/canonical/charmcraft/pull/6311:43
mupPR charmcraft#63: Added 'src' to PYTHONPATH <Created by facundobatista> <https://github.com/canonical/charmcraft/pull/63>11:43
jamfacubatista, Chipaca : isn't it automatically part of PYTHONPATH if you exec src/charm.py ?11:44
facubatistaah, wait, we don't want 'src' hardcoded11:46
facubatistathat PR is wrong11:46
Chipacajam: not part of pythonpath, but effectively the same thing11:48
Chipacabut i thought it wouldn't work when going via the symlinks11:48
Chipacamaybe i was wrong?11:48
Chipacatrying to get it to break here :)11:49
Chipacaso, there's something the site thing is doing11:49
Chipacaif you run it in isolated mode, it fails11:49
facubatistaChipaca, what do you mean?11:50
Chipacafacubatista: I mean: if you have src/charm.py importing potato, and you have src/potato.py11:50
Chipacafacubatista: and you do 'python3 src/charm.py'11:50
facubatistait works11:50
Chipacait will find potato, at least on ubuntu focal11:50
Chipacabut now try with python3 -I src/charm.py11:50
Chipacaand it no longer finds potato.py11:50
Chipacaso the site configuration is doing something11:51
Chipacai'd have to dig to figure it out11:51
Chipacathis means we probably want src/ on the pythonpath so it works in pythons weirder than just plain ubuntu11:51
Chipacabut i need more data to be confident :)11:51
facubatistaChipaca, -I: "In isolated mode sys.path contains neither the script’s directory..."11:54
facubatistaChipaca, so, the -I is removing the script dir11:54
facubatistanot that something else is adding it11:54
facubatista"All PYTHON* environment variables are ignored, too. "11:55
facubatistaChipaca, so, if you run it isolated, it would not respect our path fixings either, so...11:55
Chipacafacubatista: ah :-) thanks12:29
Chipacafacubatista: yeah i knew it ignored pythonpath, i wasn't suggesting to run it with that12:29
Chipacafacubatista: I just wanted -S, i guess12:29
Chipacafacubatista: jam: https://discourse.juju.is/t/charmcraft-bi-weekly-dev-summary-2020w25-26/328912:41
Chipacafacubatista: jam: can you give it a quick read in case i forgot anything, before sending it out to the non-editable things?12:42
jamChipaca, I just remembered we need to confirm whether collect-metrics is going to cause problems. I'll start working on that tomorrow after all my meetings.12:44
facubatistaChipaca, the "snap" part looks too detailed, I wonder if we should have a tl;dr part12:44
mupPR operator#323 closed: 317 state get <Created by jameinel> <Merged by jameinel> <https://github.com/canonical/operator/pull/323>12:44
jam(meetings today)12:44
Chipacajam: congrats on landing that12:44
jamChipaca, is it worth holding the summary for tomorrow and be able to just announce 0.7 ?12:45
Chipacajam: i'm happy to do a smaller we-got-0.7-up one on wednesday12:46
facubatistacan't we release 0.7 today?12:46
jamIt seems like we could12:47
Chipacashould I do those changes to ops.lib.use before that?12:47
jamChipaca, autoimport ?12:50
jamI'd happily review it for you12:50
jamChipaca, meeting?13:01
jamChipaca, I noted that it did include PyYAML but no .so extensions13:41
Chipacai think it including pyyaml is a bug :) but that's just me13:42
jamChipaca, I'd rather not, but that is a side effect if people prefer "include system packages = false"13:42
Chipacai wonder which yaml you get when you import it tho13:43
jamall of them simultaneously13:47
Chipacajam: maybe then it'll be fastest!13:48
facubatistaChipaca, jam, as a conclusion from the debugging some minutes ago... shall we fix dispatch execution bits or not?14:06
Chipacafacubatista: i think we should, but not zomg-release-this14:21
facubatistaChipaca, https://github.com/canonical/charmcraft/issues/6414:24
* facubatista -> lunch15:05
Chipacajam, facubatista, if you're still around jay responded16:16
Chipacajam, facubatista, never mind then :)16:20
* facubatista is back16:42
Chipacaand I'm EOD :-)16:59
Chipacafacubatista: 👋 ttfn16:59
mupPR operator#340 opened: make ops.lib.autoimport use optional <Created by chipaca> <https://github.com/canonical/operator/pull/340>16:59
facubatistaChipaca, bye17:00
* facubatista eods21:16

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!